37838 2010-04-19 18:40:26 -0700 new-run-webkit-tests: add a --no-retry-failures flag 2010-04-23 13:03:04 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 dpranke dpranke abarth cjerdonek eric ojan tony webkit.review.bot oldest_to_newest 214422 0 dpranke 2010-04-19 18:40:26 -0700 We should add a --no-retry-failures flag in case we want to check something but don't want to retry things. 214424 1 53760 dpranke 2010-04-19 18:41:58 -0700 Created attachment 53760 Patch 214431 2 53760 eric 2010-04-19 18:46:44 -0700 Comment on attachment 53760 Patch Why do we want more options? I'm trying to cut down on the number of options the user sees so we can make --help less intimidating. These seem unlikely for a user to use. 214438 3 dpranke 2010-04-19 18:49:28 -0700 (In reply to comment #2) > (From update of attachment 53760 [details]) > Why do we want more options? I'm trying to cut down on the number of options > the user sees so we can make --help less intimidating. These seem unlikely for > a user to use. Certainly --retry-failures is unlikely to be used, since it's the default. I would be fine if --no-retry-failures was hidden, but I'd like for it to be there, especially to help w/ unit testing coverage. 216033 4 53760 abarth 2010-04-22 12:54:36 -0700 Comment on attachment 53760 Patch WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:1768 + optparse.make_option("--no-retry-failures", action="store_false", I thought we had magic to generate the [no-] versions. 216042 5 eric 2010-04-22 13:00:29 -0700 I've not written the --no- magic yet. 216514 6 dpranke 2010-04-23 12:43:25 -0700 Committed r58183: <http://trac.webkit.org/changeset/58183> 216523 7 webkit.review.bot 2010-04-23 13:03:04 -0700 http://trac.webkit.org/changeset/58183 might have broken Qt Linux Release 53760 2010-04-19 18:41:58 -0700 2010-04-22 12:54:36 -0700 Patch bug-37838-20100419184157.patch text/plain 5253 dpranke ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBlMTBhZmNiLi5mZDdjYmJkIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDQgKzEsMTkgQEAKIDIwMTAtMDQt MTkgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgbmV3LXJ1bi13ZWJraXQtdGVzdHM6IGFk ZCBhICItLXJldHJ5LWZhaWx1cmVzIiBmbGFnIGFuZCBhCisgICAgICAgICItLW5vLXJldHJ5LWZh aWx1cmVzIiBmbGFnICh0aGUgZm9ybWVyIGlzIHRoZSBkZWZhdWx0KS4gQWxzbywgcmVuYW1lCisg ICAgICAgICItLXByaW50LXVuZXhwZWN0ZWQtcmVzdWx0cyIgYW5kICItLXJldHJ5LXVuZXhwZWN0 ZWQtcmVzdWx0cyIgdG8KKyAgICAgICAgIi0tcHJpbnQtbGFzdC1mYWlsdXJlcyIgYW5kICItLXJl dHJ5LWxhc3QtZmFpbHVyZXMiIGJlY2F1c2UgdGhlCisgICAgICAgIHJldHJ5IGZsYWcgd2FzIGNv bmZ1c2luZy4gVGhlIG5ldyBmbGFnIG5hbWVzIGFyZW4ndCBncmVhdCwgYnV0CisgICAgICAgIGhv cGVmdWxseSB0aGV5J3JlIGxlc3MgY29uZnVzaW5nLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNzgzOAorCisgICAgICAgICogU2NyaXB0cy93ZWJr aXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0cy5weToKKworMjAxMC0wNC0xOSAgRGly ayBQcmFua2UgIDxkcHJhbmtlQGNocm9taXVtLm9yZz4KICAKICAgICAgICAgIFJldmlld2VkIGJ5 IEFkYW0gQmFydGguCiAgCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5 L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzLnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93 ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0cy5weQppbmRleCA3NjU4MjliLi4x YzNjZDIwIDEwMDc1NQotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90 ZXN0cy9ydW5fd2Via2l0X3Rlc3RzLnB5CisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0 cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHMucHkKQEAgLTE4Nyw4ICsxODcsNiBAQCBj bGFzcyBUZXN0UnVubmVyOgogICAgICMgaW4gRHVtcFJlbmRlclRyZWUuCiAgICAgREVGQVVMVF9U RVNUX1RJTUVPVVRfTVMgPSA2ICogMTAwMAogCi0gICAgTlVNX1JFVFJZX09OX1VORVhQRUNURURf RkFJTFVSRSA9IDEKLQogICAgIGRlZiBfX2luaXRfXyhzZWxmLCBwb3J0LCBvcHRpb25zLCBtZXRl cik6CiAgICAgICAgICIiIkluaXRpYWxpemUgdGVzdCBydW5uZXIgZGF0YSBzdHJ1Y3R1cmVzLgog CkBAIC0yMTksNyArMjE3LDcgQEAgY2xhc3MgVGVzdFJ1bm5lcjoKICAgICAgICAgc2VsZi5fY3Vy cmVudF9wcm9ncmVzc19zdHIgPSAiIgogICAgICAgICBzZWxmLl9jdXJyZW50X3Rlc3RfbnVtYmVy ID0gMAogCi0gICAgICAgIHNlbGYuX3JldHJpZXMgPSAwCisgICAgICAgIHNlbGYuX3JldHJ5aW5n ID0gRmFsc2UKIAogICAgIGRlZiBfX2RlbF9fKHNlbGYpOgogICAgICAgICBfbG9nLmRlYnVnKCJm bHVzaGluZyBzdGRvdXQiKQpAQCAtNjU3LDEyICs2NTUsMTIgQEAgY2xhc3MgVGVzdFJ1bm5lcjoK ICAgICAgICAgIyB3ZSB3YW50IHRvIHRyZWF0IGV2ZW4gYSBwb3RlbnRpYWxseSBmbGFreSBjcmFz aCBhcyBhbiBlcnJvci4KICAgICAgICAgZmFpbHVyZXMgPSBzZWxmLl9nZXRfZmFpbHVyZXMocmVz dWx0X3N1bW1hcnksIGluY2x1ZGVfY3Jhc2hlcz1GYWxzZSkKICAgICAgICAgcmV0cnlfc3VtbWFy eSA9IHJlc3VsdF9zdW1tYXJ5Ci0gICAgICAgIHdoaWxlIChzZWxmLl9yZXRyaWVzIDwgc2VsZi5O VU1fUkVUUllfT05fVU5FWFBFQ1RFRF9GQUlMVVJFIGFuZAotICAgICAgICAgICAgICAgbGVuKGZh aWx1cmVzKSk6CisgICAgICAgIHdoaWxlIChsZW4oZmFpbHVyZXMpIGFuZCBzZWxmLl9vcHRpb25z LnJldHJ5X2ZhaWx1cmVzIGFuZAorICAgICAgICAgICAgbm90IHNlbGYuX3JldHJ5aW5nKToKICAg ICAgICAgICAgIF9sb2cuaW5mbygnJykKLSAgICAgICAgICAgIF9sb2cuaW5mbygiUmV0cnlpbmcg JWQgdW5leHBlY3RlZCBmYWlsdXJlKHMpIiAlIGxlbihmYWlsdXJlcykpCisgICAgICAgICAgICBf bG9nLmluZm8oIlJldHJ5aW5nICVkIHVuZXhwZWN0ZWQgZmFpbHVyZShzKSAuLi4iICUgbGVuKGZh aWx1cmVzKSkKICAgICAgICAgICAgIF9sb2cuaW5mbygnJykKLSAgICAgICAgICAgIHNlbGYuX3Jl dHJpZXMgKz0gMQorICAgICAgICAgICAgc2VsZi5fcmV0cnlpbmcgPSBUcnVlCiAgICAgICAgICAg ICByZXRyeV9zdW1tYXJ5ID0gUmVzdWx0U3VtbWFyeShzZWxmLl9leHBlY3RhdGlvbnMsIGZhaWx1 cmVzLmtleXMoKSkKICAgICAgICAgICAgIHNlbGYuX3J1bl90ZXN0cyhmYWlsdXJlcy5rZXlzKCks IHJldHJ5X3N1bW1hcnkpCiAgICAgICAgICAgICBmYWlsdXJlcyA9IHNlbGYuX2dldF9mYWlsdXJl cyhyZXRyeV9zdW1tYXJ5LCBpbmNsdWRlX2NyYXNoZXM9VHJ1ZSkKQEAgLTc0NCw3ICs3NDIsNyBA QCBjbGFzcyBUZXN0UnVubmVyOgogICAgICAgICBwZXJjZW50X2NvbXBsZXRlID0gMTAwICogKHJl c3VsdF9zdW1tYXJ5LmV4cGVjdGVkICsKICAgICAgICAgICAgIHJlc3VsdF9zdW1tYXJ5LnVuZXhw ZWN0ZWQpIC8gcmVzdWx0X3N1bW1hcnkudG90YWwKICAgICAgICAgYWN0aW9uID0gIlRlc3Rpbmci Ci0gICAgICAgIGlmIHNlbGYuX3JldHJpZXMgPiAwOgorICAgICAgICBpZiBzZWxmLl9yZXRyeWlu ZzoKICAgICAgICAgICAgIGFjdGlvbiA9ICJSZXRyeWluZyIKICAgICAgICAgc2VsZi5fbWV0ZXIu cHJvZ3Jlc3MoIiVzICglZCUlKTogJWQgcmFuIGFzIGV4cGVjdGVkLCAlZCBkaWRuJ3QsIgogICAg ICAgICAgICAgIiAlZCBsZWZ0IiAlIChhY3Rpb24sIHBlcmNlbnRfY29tcGxldGUsIHJlc3VsdF9z dW1tYXJ5LmV4cGVjdGVkLApAQCAtMTQ0NywxNCArMTQ0NSwxNCBAQCBkZWYgbWFpbihvcHRpb25z LCBhcmdzLCBwcmludF9yZXN1bHRzPVRydWUpOgogICAgICAgICBvcHRpb25zLnJlc3VsdHNfZGly ZWN0b3J5ID0gcG9ydF9vYmoucmVzdWx0c19kaXJlY3RvcnkoKQogCiAgICAgbGFzdF91bmV4cGVj dGVkX3Jlc3VsdHMgPSBbXQotICAgIGlmIG9wdGlvbnMucHJpbnRfdW5leHBlY3RlZF9yZXN1bHRz IG9yIG9wdGlvbnMucmV0cnlfdW5leHBlY3RlZF9yZXN1bHRzOgorICAgIGlmIG9wdGlvbnMucHJp bnRfbGFzdF9mYWlsdXJlcyBvciBvcHRpb25zLnJldGVzdF9sYXN0X2ZhaWx1cmVzOgogICAgICAg ICB1bmV4cGVjdGVkX3Jlc3VsdHNfZmlsZW5hbWUgPSBvcy5wYXRoLmpvaW4oCiAgICAgICAgICAg IG9wdGlvbnMucmVzdWx0c19kaXJlY3RvcnksICJ1bmV4cGVjdGVkX3Jlc3VsdHMuanNvbiIpCiAg ICAgICAgIGYgPSBmaWxlKHVuZXhwZWN0ZWRfcmVzdWx0c19maWxlbmFtZSkKICAgICAgICAgcmVz dWx0cyA9IHNpbXBsZWpzb24ubG9hZChmKQogICAgICAgICBmLmNsb3NlKCkKICAgICAgICAgbGFz dF91bmV4cGVjdGVkX3Jlc3VsdHMgPSByZXN1bHRzWyd0ZXN0cyddLmtleXMoKQotICAgICAgICBp ZiBvcHRpb25zLnByaW50X3VuZXhwZWN0ZWRfcmVzdWx0czoKKyAgICAgICAgaWYgb3B0aW9ucy5w cmludF9sYXN0X2ZhaWx1cmVzOgogICAgICAgICAgICAgcHJpbnQgIlxuIi5qb2luKGxhc3RfdW5l eHBlY3RlZF9yZXN1bHRzKSArICJcbiIKICAgICAgICAgICAgIHJldHVybiAwCiAKQEAgLTE3NTgs MTIgKzE3NTYsMTggQEAgZGVmIHBhcnNlX2FyZ3MoYXJncz1Ob25lKToKICAgICAgICAgIyAgICAg IEV4aXQgYWZ0ZXIgdGhlIGZpcnN0IE4gZmFpbHVyZXMgaW5zdGVhZCBvZiBydW5uaW5nIGFsbCB0 ZXN0cwogICAgICAgICAjIEZJWE1FOiBjb25zaWRlcjogLS1pdGVyYXRpb25zIG4KICAgICAgICAg IyAgICAgIE51bWJlciBvZiB0aW1lcyB0byBydW4gdGhlIHNldCBvZiB0ZXN0cyAoZS5nLiBBQkNB QkNBQkMpCi0gICAgICAgIG9wdHBhcnNlLm1ha2Vfb3B0aW9uKCItLXByaW50LXVuZXhwZWN0ZWQt cmVzdWx0cyIsIGFjdGlvbj0ic3RvcmVfdHJ1ZSIsCi0gICAgICAgICAgICBkZWZhdWx0PUZhbHNl LCBoZWxwPSJwcmludCB0aGUgdGVzdHMgaW4gdGhlIGxhc3QgcnVuIHRoYXQgIgotICAgICAgICAg ICAgImhhZCB1bmV4cGVjdGVkIHJlc3VsdHMuIiksCi0gICAgICAgIG9wdHBhcnNlLm1ha2Vfb3B0 aW9uKCItLXJldHJ5LXVuZXhwZWN0ZWQtcmVzdWx0cyIsIGFjdGlvbj0ic3RvcmVfdHJ1ZSIsCi0g ICAgICAgICAgICBkZWZhdWx0PUZhbHNlLCBoZWxwPSJyZS10cnkgdGhlIHRlc3RzIGluIHRoZSBs YXN0IHJ1biB0aGF0ICIKLSAgICAgICAgICAgICJoYWQgdW5leHBlY3RlZCByZXN1bHRzLiIpLAor ICAgICAgICBvcHRwYXJzZS5tYWtlX29wdGlvbigiLS1wcmludC1sYXN0LWZhaWx1cmVzIiwgYWN0 aW9uPSJzdG9yZV90cnVlIiwKKyAgICAgICAgICAgIGRlZmF1bHQ9RmFsc2UsIGhlbHA9IlByaW50 IHRoZSB0ZXN0cyBpbiB0aGUgbGFzdCBydW4gdGhhdCAiCisgICAgICAgICAgICAiaGFkIHVuZXhw ZWN0ZWQgZmFpbHVyZXMgKG9yIHBhc3NlcykuIiksCisgICAgICAgIG9wdHBhcnNlLm1ha2Vfb3B0 aW9uKCItLXJldGVzdC1sYXN0LWZhaWx1cmVzIiwgYWN0aW9uPSJzdG9yZV90cnVlIiwKKyAgICAg ICAgICAgIGRlZmF1bHQ9RmFsc2UsIGhlbHA9InJlLXRlc3QgdGhlIHRlc3RzIGluIHRoZSBsYXN0 IHJ1biB0aGF0ICIKKyAgICAgICAgICAgICJoYWQgdW5leHBlY3RlZCBmYWlsdXJlcyAob3IgcGFz c2VzKS4iKSwKKyAgICAgICAgb3B0cGFyc2UubWFrZV9vcHRpb24oIi0tcmV0cnktZmFpbHVyZXMi LCBhY3Rpb249InN0b3JlX3RydWUiLAorICAgICAgICAgICAgZGVmYXVsdD1UcnVlLAorICAgICAg ICAgICAgaGVscD0iUmUtdHJ5IGFueSB0ZXN0cyB0aGF0IHByb2R1Y2UgdW5leHBlY3RlZCByZXN1 bHRzIChkZWZhdWx0KSIpLAorICAgICAgICBvcHRwYXJzZS5tYWtlX29wdGlvbigiLS1uby1yZXRy eS1mYWlsdXJlcyIsIGFjdGlvbj0ic3RvcmVfZmFsc2UiLAorICAgICAgICAgICAgZGVzdD0icmV0 cnlfZmFpbHVyZXMiLAorICAgICAgICAgICAgaGVscD0iRG9uJ3QgcmUtdHJ5IGFueSB0ZXN0cyB0 aGF0IHByb2R1Y2UgdW5leHBlY3RlZCByZXN1bHRzLiIpLAogICAgIF0KIAogICAgIG1pc2Nfb3B0 aW9ucyA9IFsK