37837 2010-04-19 18:30:23 -0700 [chromium] Select popups should be closed when the browser window is moved/resized. 2010-04-27 19:08:47 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 jcivelli webkit-unassigned commit-queue oldest_to_newest 214412 0 jcivelli 2010-04-19 18:30:23 -0700 In Chromium, open a select popup. Move the browser window while the popup is showing. Expected: The popup is closed. Actual: The popup still shows. 214419 1 53758 jcivelli 2010-04-19 18:37:20 -0700 Created attachment 53758 Make a unique method to close all popups. 215521 2 53758 fishd 2010-04-21 14:58:57 -0700 Comment on attachment 53758 Make a unique method to close all popups. > Index: WebKit/chromium/public/WebView.h > - // DEPRECATED: WebView::hideSuggestionsPopup is the new way to access this. > - virtual void hideAutofillPopup() = 0; > - > - // Hides the suggestions popup if any are showing. > - virtual void hideSuggestionsPopup() = 0; > + // Hides any popup (suggestions, selects...) that might be showing. > + virtual void hidePopups() = 0; Won't this break Chromium when it is committed? Can you preserve the old method(s) until Chromium is switched over to only calling hidePopups? Then circle back with a cleanup patch to remove the DEPRECATED methods. Otherwise, LGTM 216177 3 54113 jcivelli 2010-04-22 17:26:59 -0700 Created attachment 54113 Preserve the old API so it does not break the Chromium build 218139 4 54113 commit-queue 2010-04-27 19:08:43 -0700 Comment on attachment 54113 Preserve the old API so it does not break the Chromium build Clearing flags on attachment: 54113 Committed r58369: <http://trac.webkit.org/changeset/58369> 218140 5 commit-queue 2010-04-27 19:08:47 -0700 All reviewed patches have been landed. Closing bug. 53758 2010-04-19 18:37:20 -0700 2010-04-22 17:26:59 -0700 Make a unique method to close all popups. select_move.patch text/plain 3729 jcivelli SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cNCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBXZWJLaXQv Y2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA1Nzg2MSkKKysrIFdlYktpdC9jaHJvbWl1bS9D aGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxOSBAQAorMjAxMC0wNC0xOSAgSmF5 IENpdmVsbGkgIDxqY2l2ZWxsaUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW2Nocm9taXVtXSBNZXJnZWQgdGhlIFdlYlZpZXcg cHVibGljIG1ldGhvZCB0byBjbG9zZSBzdWdnZXN0aW9uIHBvcHVwcworICAgICAgICBpbnRvIGEg c2luZ2xlIG1ldGhvZCB0byBjbG9zZSBhbGwgcG9wdXBzIChzZWxlY3QgYW5kIHN1Z2dlc3Rpb25z KS4KKyAgICAgICAgVGhhdCBlbnN1cmVzIHNlbGVjdCBwb3B1cHMgYXJlIGNsb3NlZCB3aGVuIHRo ZSBicm93c2VyIHdpbmRvdyBpcyBtb3ZlZAorICAgICAgICBvciByZXNpemVkLgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzc4MzcKKworICAgICAgICAq IHB1YmxpYy9XZWJWaWV3Lmg6CisgICAgICAgICogc3JjL1dlYlZpZXdJbXBsLmNwcDoKKyAgICAg ICAgKFdlYktpdDo6V2ViVmlld0ltcGw6OmhpZGVQb3B1cHMpOgorICAgICAgICAoV2ViS2l0OjpX ZWJWaWV3SW1wbDo6aGlkZVN1Z2dlc3Rpb25zUG9wdXApOgorICAgICAgICAqIHNyYy9XZWJWaWV3 SW1wbC5oOgorCiAyMDEwLTA0LTE5ICBBZGEgQ2hhbiAgPGFkYWNoYW5AYXBwbGUuY29tPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IEplcmVteSBPcmxvdy4KSW5kZXg6IFdlYktpdC9jaHJvbWl1bS9w dWJsaWMvV2ViVmlldy5oDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9X ZWJWaWV3LmgJKHJldmlzaW9uIDU3ODYxKQorKysgV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJW aWV3LmgJKHdvcmtpbmcgY29weSkKQEAgLTI0NiwxMSArMjQ2LDggQEAgcHVibGljOgogICAgICAg ICBjb25zdCBXZWJWZWN0b3I8V2ViU3RyaW5nPiYgc3VnZ2VzdGlvbnMsCiAgICAgICAgIGludCBk ZWZhdWx0U3VnZ2VzdGlvbkluZGV4KSA9IDA7CiAKLSAgICAvLyBERVBSRUNBVEVEOiBXZWJWaWV3 OjpoaWRlU3VnZ2VzdGlvbnNQb3B1cCBpcyB0aGUgbmV3IHdheSB0byBhY2Nlc3MgdGhpcy4KLSAg ICB2aXJ0dWFsIHZvaWQgaGlkZUF1dG9maWxsUG9wdXAoKSA9IDA7Ci0KLSAgICAvLyBIaWRlcyB0 aGUgc3VnZ2VzdGlvbnMgcG9wdXAgaWYgYW55IGFyZSBzaG93aW5nLgotICAgIHZpcnR1YWwgdm9p ZCBoaWRlU3VnZ2VzdGlvbnNQb3B1cCgpID0gMDsKKyAgICAvLyBIaWRlcyBhbnkgcG9wdXAgKHN1 Z2dlc3Rpb25zLCBzZWxlY3RzLi4uKSB0aGF0IG1pZ2h0IGJlIHNob3dpbmcuCisgICAgdmlydHVh bCB2b2lkIGhpZGVQb3B1cHMoKSA9IDA7CiAKIAogICAgIC8vIENvbnRleHQgbWVudSAtLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQpJbmRleDog V2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHANCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBXZWJL aXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcAkocmV2aXNpb24gNTc4NjEpCisrKyBXZWJL aXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTc4OSwx OSArMTc4OSwxMiBAQCB2b2lkIFdlYlZpZXdJbXBsOjphcHBseUF1dG9jb21wbGV0ZVN1Z2dlCiAg ICAgfQogfQogCi12b2lkIFdlYlZpZXdJbXBsOjpoaWRlQXV0b2ZpbGxQb3B1cCgpCit2b2lkIFdl YlZpZXdJbXBsOjpoaWRlUG9wdXBzKCkKIHsKKyAgICBoaWRlU2VsZWN0UG9wdXAoKTsKICAgICBo aWRlU3VnZ2VzdGlvbnNQb3B1cCgpOwogfQogCi12b2lkIFdlYlZpZXdJbXBsOjpoaWRlU3VnZ2Vz dGlvbnNQb3B1cCgpCi17Ci0gICAgaWYgKG1fc3VnZ2VzdGlvbnNQb3B1cFNob3dpbmcpIHsKLSAg ICAgICAgbV9zdWdnZXN0aW9uc1BvcHVwLT5oaWRlUG9wdXAoKTsKLSAgICAgICAgbV9zdWdnZXN0 aW9uc1BvcHVwU2hvd2luZyA9IGZhbHNlOwotICAgIH0KLX0KLQogdm9pZCBXZWJWaWV3SW1wbDo6 cGVyZm9ybUN1c3RvbUNvbnRleHRNZW51QWN0aW9uKHVuc2lnbmVkIGFjdGlvbikKIHsKICAgICBp ZiAoIW1fcGFnZSkKQEAgLTIwMzUsNiArMjAyOCwxNCBAQCBib29sIFdlYlZpZXdJbXBsOjp0YWJz VG9MaW5rcygpIGNvbnN0CiAgICAgcmV0dXJuIG1fdGFic1RvTGlua3M7CiB9CiAKK3ZvaWQgV2Vi Vmlld0ltcGw6OmhpZGVTdWdnZXN0aW9uc1BvcHVwKCkKK3sKKyAgICBpZiAobV9zdWdnZXN0aW9u c1BvcHVwU2hvd2luZykgeworICAgICAgICBtX3N1Z2dlc3Rpb25zUG9wdXAtPmhpZGVQb3B1cCgp OworICAgICAgICBtX3N1Z2dlc3Rpb25zUG9wdXBTaG93aW5nID0gZmFsc2U7CisgICAgfQorfQor CiAjaWYgVVNFKEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HKQogdm9pZCBXZWJWaWV3SW1wbDo6c2V0 Um9vdEdyYXBoaWNzTGF5ZXIoV2ViQ29yZTo6UGxhdGZvcm1MYXllciogbGF5ZXIpCiB7CkluZGV4 OiBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmgNCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBXZWJL aXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmgJKHJldmlzaW9uIDU3ODYxKQorKysgV2ViS2l0 L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5oCSh3b3JraW5nIGNvcHkpCkBAIC0xNjksOCArMTY5 LDcgQEAgcHVibGljOgogICAgICAgICBjb25zdCBXZWJOb2RlJiwKICAgICAgICAgY29uc3QgV2Vi VmVjdG9yPFdlYlN0cmluZz4mIHN1Z2dlc3Rpb25zLAogICAgICAgICBpbnQgZGVmYXVsdFN1Z2dl c3Rpb25JbmRleCk7Ci0gICAgdmlydHVhbCB2b2lkIGhpZGVBdXRvZmlsbFBvcHVwKCk7Ci0gICAg dmlydHVhbCB2b2lkIGhpZGVTdWdnZXN0aW9uc1BvcHVwKCk7CisgICAgdmlydHVhbCB2b2lkIGhp ZGVQb3B1cHMoKTsKICAgICB2aXJ0dWFsIHZvaWQgc2V0U2Nyb2xsYmFyQ29sb3JzKHVuc2lnbmVk IGluYWN0aXZlQ29sb3IsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1bnNp Z25lZCBhY3RpdmVDb2xvciwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVu c2lnbmVkIHRyYWNrQ29sb3IpOwpAQCAtMzE0LDYgKzMxMyw5IEBAIHB1YmxpYzoKIAogICAgIFdl YkNvcmU6OlBvcHVwQ29udGFpbmVyKiBzZWxlY3RQb3B1cCgpIGNvbnN0IHsgcmV0dXJuIG1fc2Vs ZWN0UG9wdXAuZ2V0KCk7IH0KIAorICAgIC8vIEhpZGVzIGFueSBzdWdnZXN0aW9uL2F1dG9maWxs IHBvcHVwIGlmIGFueSBpcyBzaG93aW5nLgorICAgIHZvaWQgaGlkZVN1Z2dlc3Rpb25zUG9wdXAo KTsKKwogcHJpdmF0ZToKICAgICBmcmllbmQgY2xhc3MgV2ViVmlldzsgIC8vIFNvIFdlYlZpZXc6 OkNyZWF0ZSBjYW4gY2FsbCBvdXIgY29uc3RydWN0b3IKICAgICBmcmllbmQgY2xhc3MgV1RGOjpS ZWZDb3VudGVkPFdlYlZpZXdJbXBsPjsK 54113 2010-04-22 17:26:59 -0700 2010-04-27 19:08:42 -0700 Preserve the old API so it does not break the Chromium build hide-popup.patch text/plain 2667 jcivelli SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cNCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBXZWJLaXQv Y2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA1Nzg5NSkKKysrIFdlYktpdC9jaHJvbWl1bS9D aGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxOSBAQAorMjAxMC0wNC0xOSAgSmF5 IENpdmVsbGkgIDxqY2l2ZWxsaUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW2Nocm9taXVtXSBNZXJnZWQgdGhlIFdlYlZpZXcg cHVibGljIG1ldGhvZCB0byBjbG9zZSBzdWdnZXN0aW9uIHBvcHVwcworICAgICAgICBpbnRvIGEg c2luZ2xlIG1ldGhvZCB0byBjbG9zZSBhbGwgcG9wdXBzIChzZWxlY3QgYW5kIHN1Z2dlc3Rpb25z KS4KKyAgICAgICAgVGhhdCBlbnN1cmVzIHNlbGVjdCBwb3B1cHMgYXJlIGNsb3NlZCB3aGVuIHRo ZSBicm93c2VyIHdpbmRvdyBpcyBtb3ZlZAorICAgICAgICBvciByZXNpemVkLgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzc4MzcKKworICAgICAgICAq IHB1YmxpYy9XZWJWaWV3Lmg6CisgICAgICAgICogc3JjL1dlYlZpZXdJbXBsLmNwcDoKKyAgICAg ICAgKFdlYktpdDo6V2ViVmlld0ltcGw6OmhpZGVQb3B1cHMpOgorICAgICAgICAoV2ViS2l0OjpX ZWJWaWV3SW1wbDo6aGlkZVN1Z2dlc3Rpb25zUG9wdXApOgorICAgICAgICAqIHNyYy9XZWJWaWV3 SW1wbC5oOgorCiAyMDEwLTA0LTIwICBKYXkgQ2l2ZWxsaSAgPGpjaXZlbGxpQGNocm9taXVtLm9y Zz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEaW1pdHJpIEdsYXprb3YuCkluZGV4OiBXZWJLaXQv Y2hyb21pdW0vcHVibGljL1dlYlZpZXcuaA0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIFdlYktpdC9jaHJvbWl1 bS9wdWJsaWMvV2ViVmlldy5oCShyZXZpc2lvbiA1Nzg5NSkKKysrIFdlYktpdC9jaHJvbWl1bS9w dWJsaWMvV2ViVmlldy5oCSh3b3JraW5nIGNvcHkpCkBAIC0yNDYsMTAgKzI0NiwxMiBAQCBwdWJs aWM6CiAgICAgICAgIGNvbnN0IFdlYlZlY3RvcjxXZWJTdHJpbmc+JiBzdWdnZXN0aW9ucywKICAg ICAgICAgaW50IGRlZmF1bHRTdWdnZXN0aW9uSW5kZXgpID0gMDsKIAotICAgIC8vIERFUFJFQ0FU RUQ6IFdlYlZpZXc6OmhpZGVTdWdnZXN0aW9uc1BvcHVwIGlzIHRoZSBuZXcgd2F5IHRvIGFjY2Vz cyB0aGlzLgotICAgIHZpcnR1YWwgdm9pZCBoaWRlQXV0b2ZpbGxQb3B1cCgpID0gMDsKKyAgICAv LyBIaWRlcyBhbnkgcG9wdXAgKHN1Z2dlc3Rpb25zLCBzZWxlY3RzLi4uKSB0aGF0IG1pZ2h0IGJl IHNob3dpbmcuCisgICAgdmlydHVhbCB2b2lkIGhpZGVQb3B1cHMoKSA9IDA7CiAKICAgICAvLyBI aWRlcyB0aGUgc3VnZ2VzdGlvbnMgcG9wdXAgaWYgYW55IGFyZSBzaG93aW5nLgorICAgIC8vIERF UFJFQ0FURUQ6IHVzZSBoaWRlUG9wdXBzKCkgaW5zdGVhZC4KKyAgICB2aXJ0dWFsIHZvaWQgaGlk ZUF1dG9maWxsUG9wdXAoKSA9IDA7CiAgICAgdmlydHVhbCB2b2lkIGhpZGVTdWdnZXN0aW9uc1Bv cHVwKCkgPSAwOwogCiAKSW5kZXg6IFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3Bw DQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09DQotLS0gV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAJKHJl dmlzaW9uIDU3ODk1KQorKysgV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTE3ODksNiArMTc4OSwxMiBAQCB2b2lkIFdlYlZpZXdJbXBsOjphcHBs eUF1dG9jb21wbGV0ZVN1Z2dlCiAgICAgfQogfQogCit2b2lkIFdlYlZpZXdJbXBsOjpoaWRlUG9w dXBzKCkKK3sKKyAgICBoaWRlU2VsZWN0UG9wdXAoKTsKKyAgICBoaWRlU3VnZ2VzdGlvbnNQb3B1 cCgpOworfQorCiB2b2lkIFdlYlZpZXdJbXBsOjpoaWRlQXV0b2ZpbGxQb3B1cCgpCiB7CiAgICAg aGlkZVN1Z2dlc3Rpb25zUG9wdXAoKTsKSW5kZXg6IFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmll d0ltcGwuaA0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQ0KLS0tIFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwu aAkocmV2aXNpb24gNTc4OTUpCisrKyBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmgJ KHdvcmtpbmcgY29weSkKQEAgLTE2OSw2ICsxNjksNyBAQCBwdWJsaWM6CiAgICAgICAgIGNvbnN0 IFdlYk5vZGUmLAogICAgICAgICBjb25zdCBXZWJWZWN0b3I8V2ViU3RyaW5nPiYgc3VnZ2VzdGlv bnMsCiAgICAgICAgIGludCBkZWZhdWx0U3VnZ2VzdGlvbkluZGV4KTsKKyAgICB2aXJ0dWFsIHZv aWQgaGlkZVBvcHVwcygpOwogICAgIHZpcnR1YWwgdm9pZCBoaWRlQXV0b2ZpbGxQb3B1cCgpOwog ICAgIHZpcnR1YWwgdm9pZCBoaWRlU3VnZ2VzdGlvbnNQb3B1cCgpOwogICAgIHZpcnR1YWwgdm9p ZCBzZXRTY3JvbGxiYXJDb2xvcnModW5zaWduZWQgaW5hY3RpdmVDb2xvciwK