37829 2010-04-19 16:01:05 -0700 Wrong header being included in FontPlatformDataCairo.cpp 2010-04-21 08:18:57 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Minor --- 0 lfelipe webkit-unassigned commit-queue lfelipe oldest_to_newest 214300 0 53733 lfelipe 2010-04-19 16:01:05 -0700 Created attachment 53733 Proposed patch The file WebCore/platform/graphics/cairo/FontPlatformDataCairo.cpp includes the gtk header when in fact it only uses gdk. A simple s/gtk/gdk/ fixes it (attached). 214636 1 53812 barbieri 2010-04-20 07:11:42 -0700 Created attachment 53812 Include just gdk instead of gtk for FontPlatformDataCairo.cpp WebCore/platform/graphics/cairo/FontPlatformDataCairo.cpp just use GDK to discover if there are X settings on some screen to adjust its parameters. So no need to include gtk.h there. 214644 2 53812 xan.lopez 2010-04-20 07:16:42 -0700 Comment on attachment 53812 Include just gdk instead of gtk for FontPlatformDataCairo.cpp r=me 215332 3 53812 commit-queue 2010-04-21 08:18:52 -0700 Comment on attachment 53812 Include just gdk instead of gtk for FontPlatformDataCairo.cpp Clearing flags on attachment: 53812 Committed r57984: <http://trac.webkit.org/changeset/57984> 215333 4 commit-queue 2010-04-21 08:18:57 -0700 All reviewed patches have been landed. Closing bug. 53733 2010-04-19 16:01:05 -0700 2010-04-20 07:35:29 -0700 Proposed patch replace_gtk_with_gdk_header.patch text/plain 455 lfelipe SW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vRm9udFBsYXRmb3JtRGF0YUNh aXJvLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0Zv bnRQbGF0Zm9ybURhdGFDYWlyby5jcHAJKHJldmlzaW9uIDU3ODQ4KQorKysgV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9jYWlyby9Gb250UGxhdGZvcm1EYXRhQ2Fpcm8uY3BwCSh3b3JraW5nIGNv cHkpCkBAIC0zMiw3ICszMiw3IEBACiAjaW5jbHVkZSA8Y2Fpcm8tZnQuaD4KICNpbmNsdWRlIDxj YWlyby5oPgogI2luY2x1ZGUgPGZvbnRjb25maWcvZmNmcmVldHlwZS5oPgotI2luY2x1ZGUgPGd0 ay9ndGsuaD4KKyNpbmNsdWRlIDxnZGsvZ2RrLmg+CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAo= 53812 2010-04-20 07:11:42 -0700 2010-04-21 08:18:52 -0700 Include just gdk instead of gtk for FontPlatformDataCairo.cpp FontPlatformDataCairo-include-gdk-not-gtk.patch text/plain 1077 barbieri SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1Nzg4OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTAtMDQtMjAgIEd1c3Rhdm8gU3Zlcnp1dCBCYXJiaWVyaSAgPGJh cmJpZXJpQHByb2Z1c2lvbi5tb2JpPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFdyb25nIGhlYWRlciBiZWluZyBpbmNsdWRlZCBpbiBGb250UGxhdGZv cm1EYXRhQ2Fpcm8uY3BwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0zNzgyOQorCisgICAgICAgIE5vIGJlaGF2aW9yIGNoYW5nZXMsIHNvIG5vIG5ldyB0 ZXN0cyB3ZXJlIGFkZGVkLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vRm9u dFBsYXRmb3JtRGF0YUNhaXJvLmNwcDoKKwogMjAxMC0wNC0yMCAgRXZhbiBTdGFkZSAgPGVzdGFk ZUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2aWQgTGV2aW4uCkluZGV4 OiBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0ZvbnRQbGF0Zm9ybURhdGFDYWlyby5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9Gb250UGxh dGZvcm1EYXRhQ2Fpcm8uY3BwCShyZXZpc2lvbiA1Nzg4NCkKKysrIFdlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvY2Fpcm8vRm9udFBsYXRmb3JtRGF0YUNhaXJvLmNwcAkod29ya2luZyBjb3B5KQpA QCAtMzIsNyArMzIsNyBAQAogI2luY2x1ZGUgPGNhaXJvLWZ0Lmg+CiAjaW5jbHVkZSA8Y2Fpcm8u aD4KICNpbmNsdWRlIDxmb250Y29uZmlnL2ZjZnJlZXR5cGUuaD4KLSNpbmNsdWRlIDxndGsvZ3Rr Lmg+CisjaW5jbHVkZSA8Z2RrL2dkay5oPgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAK