37825 2010-04-19 15:03:47 -0700 [chromium] select popup asserts on Mac 2010-04-21 20:22:27 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 jcivelli webkit-unassigned commit-queue webkit.review.bot oldest_to_newest 214272 0 jcivelli 2010-04-19 15:03:47 -0700 - In Chromium Mac, open a page with a select (ex: http://www.google.com/preferences?hl=en) - Open the select popup, select an item so the popup is closed. - Open the select popup again. Expected: The popup shows again. Actual: The tab crashes (because an ASSERT is triggered) 214283 1 53728 jcivelli 2010-04-19 15:22:11 -0700 Created attachment 53728 Fix for an ASSERT with select popups on Mac 214285 2 webkit.review.bot 2010-04-19 15:23:45 -0700 Attachment 53728 did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKit/chromium/src/ChromeClientImpl.cpp:633: Tab found; better to use spaces [whitespace/tab] [1] WebKit/chromium/src/ChromeClientImpl.cpp:634: Tab found; better to use spaces [whitespace/tab] [1] WebKit/chromium/src/ChromeClientImpl.cpp:635: Tab found; better to use spaces [whitespace/tab] [1] Total errors found: 3 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 214286 3 53729 jcivelli 2010-04-19 15:24:43 -0700 Created attachment 53729 Fixing style 214522 4 53729 hamaji 2010-04-20 01:17:24 -0700 Comment on attachment 53729 Fixing style > + * WebKit.gyp: It seems you didn't modify this file actually. 214715 5 53832 jcivelli 2010-04-20 10:00:31 -0700 Created attachment 53832 Fixing ChangeLog 215668 6 53832 commit-queue 2010-04-21 20:22:23 -0700 Comment on attachment 53832 Fixing ChangeLog Clearing flags on attachment: 53832 Committed r58046: <http://trac.webkit.org/changeset/58046> 215669 7 commit-queue 2010-04-21 20:22:27 -0700 All reviewed patches have been landed. Closing bug. 53728 2010-04-19 15:22:11 -0700 2010-04-19 15:24:43 -0700 Fix for an ASSERT with select popups on Mac select.patch text/plain 1737 jcivelli SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNTc4NDYpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTAtMDQtMTkgIEpheSBD aXZlbGxpICA8amNpdmVsbGlAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFtDaHJvbWl1bV0gRG9uJ3Qgbm90aWZ5IHRoZSBXZWJW aWV3IHRoYXQgYSBwb3B1cCB3YXMKKyAgICAgICAgb3BlbmVkIHdoZW4gdGhlIHBvcHVwIGlzIGhh bmRsZWQgZXh0ZXJuYWxseSwgYXMgdGhlIHBvcHVwCisgICAgICAgIGlzIGluIHRoYXQgY2FzZSB0 cmFuc3BhcmVudCB0byB0aGUgV2ViVmlldy4KKyAgICAgICAgVGhlIG5vdGlmaWNhdGlvbiB3YXMg Y2F1c2luZyBhbiBBU1NFUlQgb24gTWFjICh3aGVyZQorICAgICAgICB0aGUgcG9wdXAgaXMgaGFu bGRlZCBleHRlcm5hbGx5KSBhcyB0aGVyZSB3b3VsZCBiZSBubworICAgICAgICBub3RpZmljYXRp b24gdGhhdCB0aGUgcG9wdXAgd2FzIGNsb3NlZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTM3ODI1CisKKyAgICAgICAgKiBXZWJLaXQuZ3lwOgorICAg ICAgICAqIHNyYy9DaHJvbWVDbGllbnRJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6Q2hyb21l Q2xpZW50SW1wbDo6cG9wdXBPcGVuZWQpOgorCiAyMDEwLTA0LTE5ICBEYXZlIE1vb3JlICA8ZGF2 ZW1vb3JlQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEaW1pdHJpIEdsYXpr b3YuCkluZGV4OiBXZWJLaXQvY2hyb21pdW0vc3JjL0Nocm9tZUNsaWVudEltcGwuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFdlYktpdC9jaHJvbWl1bS9zcmMvQ2hyb21lQ2xpZW50SW1wbC5jcHAJKHJldmlz aW9uIDU3ODQwKQorKysgV2ViS2l0L2Nocm9taXVtL3NyYy9DaHJvbWVDbGllbnRJbXBsLmNwcAko d29ya2luZyBjb3B5KQpAQCAtNjMwLDggKzYzMCwxMSBAQCB2b2lkIENocm9tZUNsaWVudEltcGw6 OnBvcHVwT3BlbmVkKFBvcHVwCiAgICAgICAgICAgICB3ZWJ3aWRnZXQgPSBtX3dlYlZpZXctPmNs aWVudCgpLT5jcmVhdGVQb3B1cE1lbnUoKTsKICAgICAgICAgaWYgKCF3ZWJ3aWRnZXQpCiAgICAg ICAgICAgICB3ZWJ3aWRnZXQgPSBtX3dlYlZpZXctPmNsaWVudCgpLT5jcmVhdGVQb3B1cE1lbnUo ZmFsc2UpOworCS8vIFdlIG9ubHkgbm90aWZ5IHdoZW4gdGhlIFdlYlZpZXcgaGFzIHRvIGhhbmRs ZSB0aGUgcG9wdXAsIGFzIHdoZW4KKwkvLyB0aGUgcG9wdXAgaXMgaGFuZGxlZCBleHRlcm5hbGx5 LCB0aGUgZmFjdCB0aGF0IGEgcG9wdXAgaXMgc2hvd2luZyBpcworCS8vIHRyYW5zcGFyZW50IHRv IHRoZSBXZWJWaWV3LgorICAgICAgICBtX3dlYlZpZXctPnBvcHVwT3BlbmVkKHBvcHVwQ29udGFp bmVyKTsKICAgICB9Ci0gICAgbV93ZWJWaWV3LT5wb3B1cE9wZW5lZChwb3B1cENvbnRhaW5lcik7 CiAgICAgc3RhdGljX2Nhc3Q8V2ViUG9wdXBNZW51SW1wbCo+KHdlYndpZGdldCktPkluaXQocG9w dXBDb250YWluZXIsIGJvdW5kcyk7CiB9CiAK 53729 2010-04-19 15:24:43 -0700 2010-04-20 10:00:31 -0700 Fixing style select.patch text/plain 1758 jcivelli SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNTc4NDYpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTAtMDQtMTkgIEpheSBD aXZlbGxpICA8amNpdmVsbGlAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFtDaHJvbWl1bV0gRG9uJ3Qgbm90aWZ5IHRoZSBXZWJW aWV3IHRoYXQgYSBwb3B1cCB3YXMKKyAgICAgICAgb3BlbmVkIHdoZW4gdGhlIHBvcHVwIGlzIGhh bmRsZWQgZXh0ZXJuYWxseSwgYXMgdGhlIHBvcHVwCisgICAgICAgIGlzIGluIHRoYXQgY2FzZSB0 cmFuc3BhcmVudCB0byB0aGUgV2ViVmlldy4KKyAgICAgICAgVGhlIG5vdGlmaWNhdGlvbiB3YXMg Y2F1c2luZyBhbiBBU1NFUlQgb24gTWFjICh3aGVyZQorICAgICAgICB0aGUgcG9wdXAgaXMgaGFu ZGxlZCBleHRlcm5hbGx5KSBhcyB0aGVyZSB3b3VsZCBiZSBubworICAgICAgICBub3RpZmljYXRp b24gdGhhdCB0aGUgcG9wdXAgd2FzIGNsb3NlZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTM3ODI1CisKKyAgICAgICAgKiBXZWJLaXQuZ3lwOgorICAg ICAgICAqIHNyYy9DaHJvbWVDbGllbnRJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6Q2hyb21l Q2xpZW50SW1wbDo6cG9wdXBPcGVuZWQpOgorCiAyMDEwLTA0LTE5ICBEYXZlIE1vb3JlICA8ZGF2 ZW1vb3JlQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEaW1pdHJpIEdsYXpr b3YuCkluZGV4OiBXZWJLaXQvY2hyb21pdW0vc3JjL0Nocm9tZUNsaWVudEltcGwuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFdlYktpdC9jaHJvbWl1bS9zcmMvQ2hyb21lQ2xpZW50SW1wbC5jcHAJKHJldmlz aW9uIDU3ODQwKQorKysgV2ViS2l0L2Nocm9taXVtL3NyYy9DaHJvbWVDbGllbnRJbXBsLmNwcAko d29ya2luZyBjb3B5KQpAQCAtNjMwLDggKzYzMCwxMSBAQCB2b2lkIENocm9tZUNsaWVudEltcGw6 OnBvcHVwT3BlbmVkKFBvcHVwCiAgICAgICAgICAgICB3ZWJ3aWRnZXQgPSBtX3dlYlZpZXctPmNs aWVudCgpLT5jcmVhdGVQb3B1cE1lbnUoKTsKICAgICAgICAgaWYgKCF3ZWJ3aWRnZXQpCiAgICAg ICAgICAgICB3ZWJ3aWRnZXQgPSBtX3dlYlZpZXctPmNsaWVudCgpLT5jcmVhdGVQb3B1cE1lbnUo ZmFsc2UpOworICAgICAgICAvLyBXZSBvbmx5IG5vdGlmeSB3aGVuIHRoZSBXZWJWaWV3IGhhcyB0 byBoYW5kbGUgdGhlIHBvcHVwLCBhcyB3aGVuCisgICAgICAgIC8vIHRoZSBwb3B1cCBpcyBoYW5k bGVkIGV4dGVybmFsbHksIHRoZSBmYWN0IHRoYXQgYSBwb3B1cCBpcyBzaG93aW5nIGlzCisgICAg ICAgIC8vIHRyYW5zcGFyZW50IHRvIHRoZSBXZWJWaWV3LgorICAgICAgICBtX3dlYlZpZXctPnBv cHVwT3BlbmVkKHBvcHVwQ29udGFpbmVyKTsKICAgICB9Ci0gICAgbV93ZWJWaWV3LT5wb3B1cE9w ZW5lZChwb3B1cENvbnRhaW5lcik7CiAgICAgc3RhdGljX2Nhc3Q8V2ViUG9wdXBNZW51SW1wbCo+ KHdlYndpZGdldCktPkluaXQocG9wdXBDb250YWluZXIsIGJvdW5kcyk7CiB9CiAK 53832 2010-04-20 10:00:31 -0700 2010-04-21 20:22:22 -0700 Fixing ChangeLog select.patch text/plain 1735 jcivelli SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNTc4NDYpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTAtMDQtMTkgIEpheSBD aXZlbGxpICA8amNpdmVsbGlAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFtDaHJvbWl1bV0gRG9uJ3Qgbm90aWZ5IHRoZSBXZWJW aWV3IHRoYXQgYSBwb3B1cCB3YXMKKyAgICAgICAgb3BlbmVkIHdoZW4gdGhlIHBvcHVwIGlzIGhh bmRsZWQgZXh0ZXJuYWxseSwgYXMgdGhlIHBvcHVwCisgICAgICAgIGlzIGluIHRoYXQgY2FzZSB0 cmFuc3BhcmVudCB0byB0aGUgV2ViVmlldy4KKyAgICAgICAgVGhlIG5vdGlmaWNhdGlvbiB3YXMg Y2F1c2luZyBhbiBBU1NFUlQgb24gTWFjICh3aGVyZQorICAgICAgICB0aGUgcG9wdXAgaXMgaGFu ZGxlZCBleHRlcm5hbGx5KSBhcyB0aGVyZSB3b3VsZCBiZSBubworICAgICAgICBub3RpZmljYXRp b24gdGhhdCB0aGUgcG9wdXAgd2FzIGNsb3NlZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTM3ODI1CisKKyAgICAgICAgKiBzcmMvQ2hyb21lQ2xpZW50 SW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OkNocm9tZUNsaWVudEltcGw6OnBvcHVwT3BlbmVk KToKKwogMjAxMC0wNC0xOSAgRGF2ZSBNb29yZSAgPGRhdmVtb29yZUBjaHJvbWl1bS5vcmc+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgRGltaXRyaSBHbGF6a292LgpJbmRleDogV2ViS2l0L2Nocm9t aXVtL3NyYy9DaHJvbWVDbGllbnRJbXBsLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvY2hyb21p dW0vc3JjL0Nocm9tZUNsaWVudEltcGwuY3BwCShyZXZpc2lvbiA1Nzg0MCkKKysrIFdlYktpdC9j aHJvbWl1bS9zcmMvQ2hyb21lQ2xpZW50SW1wbC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTYzMCw4 ICs2MzAsMTEgQEAgdm9pZCBDaHJvbWVDbGllbnRJbXBsOjpwb3B1cE9wZW5lZChQb3B1cAogICAg ICAgICAgICAgd2Vid2lkZ2V0ID0gbV93ZWJWaWV3LT5jbGllbnQoKS0+Y3JlYXRlUG9wdXBNZW51 KCk7CiAgICAgICAgIGlmICghd2Vid2lkZ2V0KQogICAgICAgICAgICAgd2Vid2lkZ2V0ID0gbV93 ZWJWaWV3LT5jbGllbnQoKS0+Y3JlYXRlUG9wdXBNZW51KGZhbHNlKTsKKyAgICAgICAgLy8gV2Ug b25seSBub3RpZnkgd2hlbiB0aGUgV2ViVmlldyBoYXMgdG8gaGFuZGxlIHRoZSBwb3B1cCwgYXMg d2hlbgorICAgICAgICAvLyB0aGUgcG9wdXAgaXMgaGFuZGxlZCBleHRlcm5hbGx5LCB0aGUgZmFj dCB0aGF0IGEgcG9wdXAgaXMgc2hvd2luZyBpcworICAgICAgICAvLyB0cmFuc3BhcmVudCB0byB0 aGUgV2ViVmlldy4KKyAgICAgICAgbV93ZWJWaWV3LT5wb3B1cE9wZW5lZChwb3B1cENvbnRhaW5l cik7CiAgICAgfQotICAgIG1fd2ViVmlldy0+cG9wdXBPcGVuZWQocG9wdXBDb250YWluZXIpOwog ICAgIHN0YXRpY19jYXN0PFdlYlBvcHVwTWVudUltcGwqPih3ZWJ3aWRnZXQpLT5Jbml0KHBvcHVw Q29udGFpbmVyLCBib3VuZHMpOwogfQogCg==