37822 2010-04-19 14:07:02 -0700 new-run-webkit-tests: disable --use-drt on windows 2010-04-19 15:09:47 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 dpranke dpranke eric jamesr tkent tony oldest_to_newest 214236 0 dpranke 2010-04-19 14:07:02 -0700 AFAIK, --use-drt shouldn't be supported on Windows yet, so we should test this case and error out if necessary. 214241 1 53720 dpranke 2010-04-19 14:12:45 -0700 Created attachment 53720 Patch 214265 2 53720 eric 2010-04-19 14:57:50 -0700 Comment on attachment 53720 Patch Why not early-return False? 214273 3 dpranke 2010-04-19 15:05:11 -0700 (In reply to comment #2) > (From update of attachment 53720 [details]) > Why not early-return False? Because this way you actually check what else is also wrong and get all the errors at once. 214275 4 53720 eric 2010-04-19 15:06:43 -0700 Comment on attachment 53720 Patch The "continue-after-error" behavior seems like unnecessary complexity. But the code looks right. :) 214277 5 53720 dpranke 2010-04-19 15:09:42 -0700 Comment on attachment 53720 Patch Clearing flags on attachment: 53720 Committed r57847: <http://trac.webkit.org/changeset/57847> 214278 6 dpranke 2010-04-19 15:09:47 -0700 All reviewed patches have been landed. Closing bug. 53720 2010-04-19 14:12:45 -0700 2010-04-19 15:09:42 -0700 Patch bug-37822-20100419141244.patch text/plain 2260 dpranke ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCAxOGExZTEyLi40ODZmYWQxIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDQt MTkgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU3VibWl0IGEgYmV0dGVyIHdvcmthcm91 bmQgZm9yIHI1NzgwNiB0aGFuIHRoZSBvbmUgaW4gcjU3ODMxIC0gbG9nCisgICAgICAgIGFuIGVy cm9yIGFuZCBleGl0IGlmIHlvdSB0cnkgdG8gcnVuIG5ldy1ydW4td2Via2l0LXRlc3RzIHdpdGgg LS11c2UtZHJ0CisgICAgICAgIG9uIFdpbmRvd3MuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM3ODIyCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtp dHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtLnB5OgorCiAyMDEwLTA0LTE5ICBLZW5uZXRo IFJvaGRlIENocmlzdGlhbnNlbiAgPGtlbm5ldGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZp ZXdlZCBieSBTaW1vbiBIYXVzbWFubi4KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMv d2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW0ucHkgYi9XZWJLaXRUb29scy9TY3Jp cHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtLnB5CmluZGV4IDU2MjE2YTYu LjU5OWM2ODIgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0 X3Rlc3RzL3BvcnQvY2hyb21pdW0ucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRw eS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bS5weQpAQCAtODEsMjEgKzgxLDI1IEBAIGNsYXNz IENocm9taXVtUG9ydChiYXNlLlBvcnQpOgogICAgICAgICBiYXNlLlBvcnQuX19pbml0X18oc2Vs ZiwgcG9ydF9uYW1lLCBvcHRpb25zKQogICAgICAgICBzZWxmLl9jaHJvbWl1bV9iYXNlX2RpciA9 IE5vbmUKIAotICAgICAgICAjIEZJWE1FOiBzZWUgY29tbWVudCBhYm92ZSByZTogaW1wb3J0IHdl YmtpdAotICAgICAgICBpZiBzeXMucGxhdGZvcm0gaW4gKCd3aW4zMicsICdjeWd3aW4nKSBhbmQg b3B0aW9uczoKLSAgICAgICAgICAgIG9wdGlvbnMudXNlX2RydCA9IEZhbHNlCi0KICAgICBkZWYg YmFzZWxpbmVfcGF0aChzZWxmKToKICAgICAgICAgcmV0dXJuIHNlbGYuX3dlYmtpdF9iYXNlbGlu ZV9wYXRoKHNlbGYuX25hbWUpCiAKICAgICBkZWYgY2hlY2tfYnVpbGQoc2VsZiwgbmVlZHNfaHR0 cCk6CiAgICAgICAgIHJlc3VsdCA9IFRydWUKKworICAgICAgICAjIEZJWE1FOiBzZWUgY29tbWVu dCBhYm92ZSByZTogaW1wb3J0IHdlYmtpdAorICAgICAgICBpZiAoc3lzLnBsYXRmb3JtIGluICgn d2luMzInLCAnY3lnd2luJykgYW5kIHNlbGYuX29wdGlvbnMgYW5kCisgICAgICAgICAgICBoYXNh dHRyKHNlbGYuX29wdGlvbnMsICd1c2VfZHJ0JykgYW5kIHNlbGYuX29wdGlvbnMudXNlX2RydCk6 CisgICAgICAgICAgICBfbG9nLmVycm9yKCctLXVzZS1kcnQgaXMgbm90IHN1cHBvcnRlZCBvbiBX aW5kb3dzIHlldCcpCisgICAgICAgICAgICBfbG9nLmVycm9yKCcnKQorICAgICAgICAgICAgcmVz dWx0ID0gRmFsc2UKKwogICAgICAgICBkdW1wX3JlbmRlcl90cmVlX2JpbmFyeV9wYXRoID0gc2Vs Zi5fcGF0aF90b19kcml2ZXIoKQogICAgICAgICByZXN1bHQgPSBjaGVja19maWxlX2V4aXN0cyhk dW1wX3JlbmRlcl90cmVlX2JpbmFyeV9wYXRoLAotICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAndGVzdCBkcml2ZXInKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgJ3Rlc3QgZHJpdmVyJykgYW5kIHJlc3VsdAogICAgICAgICBpZiByZXN1bHQ6Ci0gICAgICAg ICAgICByZXN1bHQgPSAoc2VsZi5fY2hlY2tfZHJpdmVyX2J1aWxkX3VwX3RvX2RhdGUoc2VsZi5f b3B0aW9ucy5jb25maWd1cmF0aW9uKQotICAgICAgICAgICAgICAgICAgICAgIGFuZCByZXN1bHQp CisgICAgICAgICAgICByZXN1bHQgPSBzZWxmLl9jaGVja19kcml2ZXJfYnVpbGRfdXBfdG9fZGF0 ZSgKKyAgICAgICAgICAgICAgICBzZWxmLl9vcHRpb25zLmNvbmZpZ3VyYXRpb24pCiAgICAgICAg IGVsc2U6CiAgICAgICAgICAgICBfbG9nLmVycm9yKCcnKQogCg==