37821 2010-04-19 14:04:15 -0700 [Qt] loads APP directory when calling "window.open" 2010-04-26 03:43:46 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC Linux CLOSED FIXED Qt P2 Normal --- 35784 0 max.hong.shen webkit-unassigned commit-queue hausmann oldest_to_newest 214233 0 max.hong.shen 2010-04-19 14:04:15 -0700 When creating a new window by calling "window.open('http://www.cnn.com')", it loads the "file://$${applicationpath}" because the ChromeClientQt::createWindow() never check the request whether is empty or not, and it loads the app directory when the request is empty. When calling window.open('http://www.cnn.com'), the WebCore::createWindow() first 1) call client to create a new window 2) load cnn.com by calling changeLocation(); While in step 1), qt's chrome client always tries to load an empty request. I think we should check the request because 1)it helps the performance 2)I found the gtk's createWindow checks the request every time. e.g. In ChromeClientGtk.cpp:129 Page* ChromeClient::createWindow(...) { ... if (!frameLoadRequest.isEmpty()) webkit_web_view_open(....); } 214238 1 53718 max.hong.shen 2010-04-19 14:08:18 -0700 Created attachment 53718 proposed patch 214309 2 53718 hausmann 2010-04-19 16:07:40 -0700 Comment on attachment 53718 proposed patch Good catch! 215326 3 53718 commit-queue 2010-04-21 08:08:46 -0700 Comment on attachment 53718 proposed patch Clearing flags on attachment: 53718 Committed r57982: <http://trac.webkit.org/changeset/57982> 215327 4 commit-queue 2010-04-21 08:08:51 -0700 All reviewed patches have been landed. Closing bug. 216975 5 hausmann 2010-04-26 03:43:37 -0700 Revision r57982 cherry-picked into qtwebkit-2.0 with commit 624d8662f88895a1a25212ee088d6443c0e8e736 53718 2010-04-19 14:08:18 -0700 2010-04-21 08:08:46 -0700 proposed patch bug37821.patch text/plain 1272 max.hong.shen SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n ZUxvZwkocmV2aXNpb24gNTc4MzUpCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDQtMTkgIFlpIFNoZW4gIDx5aS40LnNoZW5Abm9r aWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFtRdF0gQ2hlY2sgdGhlIHJlcXVlc3QgZW1wdHkgb3Igbm90IGluIENocm9tZUNsaWVudFF0Ojpj cmVhdGVXaW5kb3coKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9Mzc4MjEKKworICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVudFF0LmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OkNocm9tZUNsaWVudFF0OjpjcmVhdGVXaW5kb3cpOgorCiAy MDEwLTA0LTE5ICBEYXZlIE1vb3JlICA8ZGF2ZW1vb3JlQGNocm9taXVtLm9yZz4KIAogICAgICAg ICBSZXZpZXdlZCBieSBEaW1pdHJpIEdsYXprb3YuCkluZGV4OiBXZWJLaXQvcXQvV2ViQ29yZVN1 cHBvcnQvQ2hyb21lQ2xpZW50UXQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9xdC9XZWJDb3Jl U3VwcG9ydC9DaHJvbWVDbGllbnRRdC5jcHAJKHJldmlzaW9uIDU3ODI2KQorKysgV2ViS2l0L3F0 L1dlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVudFF0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTY2 LDcgKzE2Niw5IEBAIFBhZ2UqIENocm9tZUNsaWVudFF0OjpjcmVhdGVXaW5kb3coRnJhbWUKICAg ICBRV2ViUGFnZSAqbmV3UGFnZSA9IG1fd2ViUGFnZS0+Y3JlYXRlV2luZG93KGZlYXR1cmVzLmRp YWxvZyA/IFFXZWJQYWdlOjpXZWJNb2RhbERpYWxvZyA6IFFXZWJQYWdlOjpXZWJCcm93c2VyV2lu ZG93KTsKICAgICBpZiAoIW5ld1BhZ2UpCiAgICAgICAgIHJldHVybiAwOwotICAgIG5ld1BhZ2Ut Pm1haW5GcmFtZSgpLT5sb2FkKHJlcXVlc3QucmVzb3VyY2VSZXF1ZXN0KCkudXJsKCkpOworCisg ICAgaWYgKCFyZXF1ZXN0LmlzRW1wdHkoKSkKKyAgICAgICAgbmV3UGFnZS0+bWFpbkZyYW1lKCkt PmxvYWQocmVxdWVzdC5yZXNvdXJjZVJlcXVlc3QoKS51cmwoKSk7CiAgICAgcmV0dXJuIG5ld1Bh Z2UtPmQtPnBhZ2U7CiB9CiAK