37816 2010-04-19 13:11:24 -0700 [Qt] Multitouch mocking in QtLauncher doesn't work with QGraphicsView 2010-04-21 04:20:16 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC Linux CLOSED FIXED P2 Normal --- 35784 0 kim.1.gronholm webkit-unassigned commit-queue eric hausmann ossy oldest_to_newest 214188 0 kim.1.gronholm 2010-04-19 13:11:24 -0700 Currently multi-touch mocking in QtLauncher works only with QWebView. Test page: https://bug-32434-attachments.webkit.org/attachment.cgi?id=44955. 214197 1 53713 kim.1.gronholm 2010-04-19 13:19:10 -0700 Created attachment 53713 Fix multi-touch mocking in QtLauncher when using QGraphicsView. 214587 2 53713 commit-queue 2010-04-20 05:37:27 -0700 Comment on attachment 53713 Fix multi-touch mocking in QtLauncher when using QGraphicsView. Rejecting patch 53713 from commit-queue. Unexpected failure when landing patch! Please file a bug against webkit-patch. Failed to run "['WebKitTools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', 'land-attachment', '--force-clean', '--build', '--test', '--non-interactive', '--ignore-builders', '--build-style=both', '--quiet', '53713', '--parent-command=commit-queue', '--no-update']" exit_code: 1 Last 500 characters of output: ', 'commit', '--all', '-F', '-'], input=message) File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/webkitpy/common/system/executive.py", line 85, in run_command return Executive().run_command(*args, **kwargs) File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/webkitpy/common/system/executive.py", line 186, in run_command string_to_communicate = str(input) UnicodeEncodeError: 'ascii' codec can't encode character u'\xf6' in position 18: ordinal not in range(128) 214759 3 hausmann 2010-04-20 10:42:17 -0700 Committed r57897: <http://trac.webkit.org/changeset/57897> 214885 4 hausmann 2010-04-20 12:49:56 -0700 Revision r57897 cherry-picked into qtwebkit-2.0 with commit 98e5667203fbe3366c3758d4da000ad5943ae32f 215144 5 eric 2010-04-20 22:49:45 -0700 The Qt windows builder is busted. This appears to be the only possibly related change. In file included from ..\..\..\..\WebKitTools\QtLauncher\/webview.h:38, from ..\..\..\..\WebKitTools\QtLauncher\webview.cpp:33: ..\..\include\QtWebKit/qgraphicswebview.h:1:95: error: T:/WindowsDebug/buildslave/windows-qt-debug/build/WebKit/qt/Api/qgraphicswebview.h: No such file or directory In file included from ..\..\..\..\WebKitTools\QtLauncher\webview.cpp:33: ..\..\..\..\WebKitTools\QtLauncher\/webview.h:55: error: expected class-name before '{' token ..\..\..\..\WebKitTools\QtLauncher\/webview.h: In constructor 'GraphicsWebView::GraphicsWebView(QGraphicsItem*)': 215148 6 hausmann 2010-04-20 22:59:37 -0700 Could be that it was broken for a while but that the incremental rebuilds didn't rebuild QtLauncher 215154 7 eric 2010-04-20 23:05:12 -0700 I suspect that's exactly the case. I suspect that QtLauncher's dependencies are not properly expressed in the build system. 215156 8 eric 2010-04-20 23:05:27 -0700 Should we roll this out Simon, or is there an easy fix? 215177 9 eric 2010-04-20 23:53:11 -0700 Waiting for the Qt bot to finish rolling. If it fails I'll start a rollout of this. 215242 10 eric 2010-04-21 04:20:16 -0700 The bot rolled green. Sorry for the trouble with the commit-queue and webkit-patch. You ran into bug 37765, which hopefully will be fixed tomorrow. 53713 2010-04-19 13:19:10 -0700 2010-04-20 05:37:27 -0700 Fix multi-touch mocking in QtLauncher when using QGraphicsView. patch-37816.diff text/plain 1773 kim.1.gronholm ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBmMTAyMDYzLi42ZTc4MDY0IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTAtMDQt MTkgIEtpbSBHcsO2bmhvbG0gIDxraW0uZ3JvbmhvbG1Abm9tb3Zvay5jb20+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBNdWx0aXRvdWNoIG1v Y2tpbmcgaW4gUXRMYXVuY2hlciBkb2Vzbid0IHdvcmsgd2l0aCBRR3JhcGhpY3NWaWV3CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNzgxNgorICAgICAg ICAKKyAgICAgICAgRml4IG11bHRpLXRvdWNoIG1vY2tpbmcgaW4gUXRMYXVuY2hlciB3aGVuIHVz aW5nIFFHcmFwaGljc1ZpZXcuCisgICAgICAgIFRlc3Q6IGh0dHBzOi8vYnVnLTMyNDM0LWF0dGFj aG1lbnRzLndlYmtpdC5vcmcvYXR0YWNobWVudC5jZ2k/aWQ9NDQ5NTUKKworICAgICAgICAqIFF0 TGF1bmNoZXIvbWFpbi5jcHA6CisgICAgICAgIChMYXVuY2hlcldpbmRvdzo6ZXZlbnRGaWx0ZXIp OgorICAgICAgICAoTGF1bmNoZXJXaW5kb3c6OmluaXRpYWxpemVWaWV3KToKKwogMjAxMC0wNC0x NiAgU2FtIFdlaW5pZyAgPHNhbUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFu ZGVycyBDYXJsc3Nvbi4KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1F0TGF1bmNoZXIvbWFpbi5j cHAgYi9XZWJLaXRUb29scy9RdExhdW5jaGVyL21haW4uY3BwCmluZGV4IDE1OWI4MDAuLmNjMTBi YzggMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1F0TGF1bmNoZXIvbWFpbi5jcHAKKysrIGIvV2Vi S2l0VG9vbHMvUXRMYXVuY2hlci9tYWluLmNwcApAQCAtMzY0LDcgKzM2NCw3IEBAIGJvb2wgTGF1 bmNoZXJXaW5kb3c6OmV2ZW50RmlsdGVyKFFPYmplY3QqIG9iaiwgUUV2ZW50KiBldmVudCkKICAg ICB9CiAKICNpZiBRVF9WRVJTSU9OID49IFFUX1ZFUlNJT05fQ0hFQ0soNCwgNiwgMCkKLSAgICBp ZiAoIW1fdG91Y2hNb2NraW5nIHx8IG9iaiAhPSBtX3ZpZXcpCisgICAgaWYgKCFtX3RvdWNoTW9j a2luZykKICAgICAgICAgcmV0dXJuIFFPYmplY3Q6OmV2ZW50RmlsdGVyKG9iaiwgZXZlbnQpOwog CiAgICAgaWYgKGV2ZW50LT50eXBlKCkgPT0gUUV2ZW50OjpNb3VzZUJ1dHRvblByZXNzCkBAIC02 MzQsOCArNjM0LDkgQEAgdm9pZCBMYXVuY2hlcldpbmRvdzo6aW5pdGlhbGl6ZVZpZXcoYm9vbCB1 c2VHcmFwaGljc1ZpZXcpCiAKICAgICAgICAgY29ubmVjdCh2aWV3LCBTSUdOQUwoY3VycmVudEZQ U1VwZGF0ZWQoaW50KSksIHRoaXMsIFNMT1QodXBkYXRlRlBTKGludCkpKTsKIAorICAgICAgICB2 aWV3LT5pbnN0YWxsRXZlbnRGaWx0ZXIodGhpcyk7CiAgICAgICAgIC8vIFRoZSBpbXBsZW1lbnRh dGlvbiBvZiBRQWJzdHJhY3RTY3JvbGxBcmVhOjpldmVudEZpbHRlciBtYWtlcyB1cyBuZWVkCi0g ICAgICAgIC8vIHRvIGluc3RhbGwgdGhlIGV2ZW50IGZpbHRlciBvbiB0aGUgdmlld3BvcnQgb2Yg YSBRR3JhcGhpY3NWaWV3LgorICAgICAgICAvLyB0byBpbnN0YWxsIHRoZSBldmVudCBmaWx0ZXIg YWxzbyBvbiB0aGUgdmlld3BvcnQgb2YgYSBRR3JhcGhpY3NWaWV3LgogICAgICAgICB2aWV3LT52 aWV3cG9ydCgpLT5pbnN0YWxsRXZlbnRGaWx0ZXIodGhpcyk7CiAKICAgICAgICAgbV92aWV3ID0g dmlldzsK