37811 2010-04-19 11:20:45 -0700 [Chromium] Windowless plugins can't set the cursor any more 2010-04-20 06:23:23 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 stuartmorgan stuartmorgan commit-queue oldest_to_newest 214116 0 stuartmorgan 2010-04-19 11:20:45 -0700 ChromeClientImpl.cpp has a variable, m_ignoreNextSetCursor, which was used to prevent a WebKit-triggered call to setCursor from overriding what the plugin does. In bug 35132 that call was removed, so now the workaround is not necessary, and is actually preventing windowless plugins from setting cursors (since all the calls are now coming from the plugin, so it's constantly being set to true). 214119 1 53692 stuartmorgan 2010-04-19 11:27:32 -0700 Created attachment 53692 Remove obsolete workaround 214605 2 53692 commit-queue 2010-04-20 06:23:19 -0700 Comment on attachment 53692 Remove obsolete workaround Clearing flags on attachment: 53692 Committed r57887: <http://trac.webkit.org/changeset/57887> 214606 3 commit-queue 2010-04-20 06:23:23 -0700 All reviewed patches have been landed. Closing bug. 53692 2010-04-19 11:27:32 -0700 2010-04-20 06:23:18 -0700 Remove obsolete workaround 37811.patch text/plain 2528 stuartmorgan SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNTc4MTkpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTAtMDQtMTkgIFN0dWFy dCBNb3JnYW4gIDxzdHVhcnRtb3JnYW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSBhIHdvcmthcm91bmQgaW4gcGx1 Z2luIGN1cnNvciBzZXR0aW5nIHRoYXQgd2FzIG9ic29sZXRlZCBieQorICAgICAgICB0aGUgY2hh bmdlIGluIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNTEzMgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzc4MTEKKworICAg ICAgICAqIHNyYy9DaHJvbWVDbGllbnRJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6Q2hyb21l Q2xpZW50SW1wbDo6Q2hyb21lQ2xpZW50SW1wbCk6CisgICAgICAgIChXZWJLaXQ6OkNocm9tZUNs aWVudEltcGw6OnNldEN1cnNvcik6CisgICAgICAgIChXZWJLaXQ6OkNocm9tZUNsaWVudEltcGw6 OnNldEN1cnNvckZvclBsdWdpbik6CisgICAgICAgICogc3JjL0Nocm9tZUNsaWVudEltcGwuaDoK KwogMjAxMC0wNC0xNyAgVmFuZ2VsaXMgS29ra2V2aXMgIDx2YW5nZWxpc0BjaHJvbWl1bS5vcmc+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGltaXRyaSBHbGF6a292LgpJbmRleDogV2ViS2l0L2No cm9taXVtL3NyYy9DaHJvbWVDbGllbnRJbXBsLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvY2hy b21pdW0vc3JjL0Nocm9tZUNsaWVudEltcGwuY3BwCShyZXZpc2lvbiA1NzgxMykKKysrIFdlYktp dC9jaHJvbWl1bS9zcmMvQ2hyb21lQ2xpZW50SW1wbC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEw Miw3ICsxMDIsNiBAQCBDaHJvbWVDbGllbnRJbXBsOjpDaHJvbWVDbGllbnRJbXBsKFdlYlZpCiAg ICAgLCBtX3Njcm9sbGJhcnNWaXNpYmxlKHRydWUpCiAgICAgLCBtX21lbnViYXJWaXNpYmxlKHRy dWUpCiAgICAgLCBtX3Jlc2l6YWJsZSh0cnVlKQotICAgICwgbV9pZ25vcmVOZXh0U2V0Q3Vyc29y KGZhbHNlKQogewogfQogCkBAIC02NDIsMTEgKzY0MSw2IEBAIHZvaWQgQ2hyb21lQ2xpZW50SW1w bDo6cG9wdXBDbG9zZWQoV2ViQ28KIAogdm9pZCBDaHJvbWVDbGllbnRJbXBsOjpzZXRDdXJzb3Io Y29uc3QgV2ViQ3Vyc29ySW5mbyYgY3Vyc29yKQogewotICAgIGlmIChtX2lnbm9yZU5leHRTZXRD dXJzb3IpIHsKLSAgICAgICAgbV9pZ25vcmVOZXh0U2V0Q3Vyc29yID0gZmFsc2U7Ci0gICAgICAg IHJldHVybjsKLSAgICB9Ci0KICAgICBpZiAobV93ZWJWaWV3LT5jbGllbnQoKSkKICAgICAgICAg bV93ZWJWaWV3LT5jbGllbnQoKS0+ZGlkQ2hhbmdlQ3Vyc29yKGN1cnNvcik7CiB9CkBAIC02NTQs MTEgKzY0OCw2IEBAIHZvaWQgQ2hyb21lQ2xpZW50SW1wbDo6c2V0Q3Vyc29yKGNvbnN0IFcKIHZv aWQgQ2hyb21lQ2xpZW50SW1wbDo6c2V0Q3Vyc29yRm9yUGx1Z2luKGNvbnN0IFdlYkN1cnNvcklu Zm8mIGN1cnNvcikKIHsKICAgICBzZXRDdXJzb3IoY3Vyc29yKTsKLQotICAgIC8vIEN1cnJlbnRs eSwgV2lkZ2V0OjpzZXRDdXJzb3IgaXMgYWx3YXlzIGNhbGxlZCBhZnRlciB0aGlzIGZ1bmN0aW9u IGluCi0gICAgLy8gRXZlbnRIYW5kbGVyLmNwcCBhbmQgc2luY2Ugd2UgZG9uJ3Qgd2FudCB0aGF0 IHdlIHNldCBhIGZsYWcgaW5kaWNhdGluZwotICAgIC8vIHRoYXQgdGhlIG5leHQgU2V0Q3Vyc29y IGNhbGwgaXMgdG8gYmUgaWdub3JlZC4KLSAgICBtX2lnbm9yZU5leHRTZXRDdXJzb3IgPSB0cnVl OwogfQogCiB2b2lkIENocm9tZUNsaWVudEltcGw6OmZvcm1TdGF0ZURpZENoYW5nZShjb25zdCBO b2RlKiBub2RlKQpJbmRleDogV2ViS2l0L2Nocm9taXVtL3NyYy9DaHJvbWVDbGllbnRJbXBsLmgK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gV2ViS2l0L2Nocm9taXVtL3NyYy9DaHJvbWVDbGllbnRJbXBsLmgJKHJl dmlzaW9uIDU3ODEzKQorKysgV2ViS2l0L2Nocm9taXVtL3NyYy9DaHJvbWVDbGllbnRJbXBsLmgJ KHdvcmtpbmcgY29weSkKQEAgLTE2NSw4ICsxNjUsNiBAQCBwcml2YXRlOgogICAgIGJvb2wgbV9z Y3JvbGxiYXJzVmlzaWJsZTsKICAgICBib29sIG1fbWVudWJhclZpc2libGU7CiAgICAgYm9vbCBt X3Jlc2l6YWJsZTsKLSAgICAvLyBTZXQgdG8gdHJ1ZSBpZiB0aGUgbmV4dCBTZXRDdXJzb3IgaXMg dG8gYmUgaWdub3JlZC4KLSAgICBib29sIG1faWdub3JlTmV4dFNldEN1cnNvcjsKIH07CiAKIH0g Ly8gbmFtZXNwYWNlIFdlYktpdAo=