37802 2010-04-19 08:25:10 -0700 Spatial Navigation: at @updateFocusCandidateIfCloser make an assignment shortcut when FocusCandidate is null 2010-04-26 03:26:14 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) PC All CLOSED FIXED P2 Normal --- 18662 35784 36463 1 tonikitoo tonikitoo abarth eric hausmann simon.fraser webkit.review.bot oldest_to_newest 214038 0 tonikitoo 2010-04-19 08:25:10 -0700 In updateFocusCandidateIfCloser method (see WebCore/page/FocusController.cpp), we do all bail out checks in the begining of the method body. If after those bail out checks, no "best FocusCandidate" has been taken yet (i.e. focusCandidate.isNull() == true) , we can safely take the current candidate, and exit earlier. no behavior change, it is just a safe assignment shortcut. patch coming ... 214040 1 53680 tonikitoo 2010-04-19 08:29:06 -0700 Created attachment 53680 patch v1 214954 2 53680 tonikitoo 2010-04-20 14:36:12 -0700 Comment on attachment 53680 patch v1 Clearing flags on attachment: 53680 Committed r57921: <http://trac.webkit.org/changeset/57921> 214956 3 tonikitoo 2010-04-20 14:36:48 -0700 Thank you Simon Fraser! 214999 4 webkit.review.bot 2010-04-20 15:17:12 -0700 http://trac.webkit.org/changeset/57921 might have broken Leopard Intel Release (Tests) The following changes are on the blame list: http://trac.webkit.org/changeset/57920 http://trac.webkit.org/changeset/57921 216964 5 hausmann 2010-04-26 03:26:04 -0700 Revision r57921 cherry-picked into qtwebkit-2.0 with commit 2be19c2e5f8f6902fb11932cc51a0a309eebd2d1 53680 2010-04-19 08:29:06 -0700 2010-04-20 14:36:12 -0700 patch v1 0001-Spatial-Navigation-at-updateFocusCandidateIfCloser.patch text/plain 3179 tonikitoo RnJvbSBjODNkZDRiYTQ0OTFmNmQwZmE4ODRkNjkyNzBkNDg5ODY5MzEzZDU0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRvbmlvIEdvbWVzIDx0b25pa2l0b29Ad2Via2l0Lm9yZz4K RGF0ZTogTW9uLCAxOSBBcHIgMjAxMCAxMToyNzo0OCAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIFNw YXRpYWwgTmF2aWdhdGlvbjogYXQgQHVwZGF0ZUZvY3VzQ2FuZGlkYXRlSWZDbG9zZXIgbWFrZSBh biBhc3NpZ25tZW50IHNob3J0Y3V0IHdoZW4gRm9jdXNDYW5kaWRhdGUgaXMgbnVsbAogaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM3ODAyCgpSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KUGF0Y2ggYnkgQW50b25pbyBHb21lcyA8dG9uaWtpdG9vQHdlYmtpdC5vcmc+ CgpJbiB1cGRhdGVGb2N1c0NhbmRpZGF0ZUlmQ2xvc2VyIG1ldGhvZCwgd2UgZG8gYWxsIGJhaWwg b3V0IGNoZWNrcyBpbiB0aGUgYmVnaW5pbmcgb2YKdGhlIG1ldGhvZCBib2R5LiBJZiBhZnRlciB0 aG9zZSBiYWlsIG91dCBjaGVja3MsIG5vICJiZXN0IEZvY3VzQ2FuZGlkYXRlIiBoYXMgYmVlbiB0 YWtlbgp5ZXQgKGkuZS4gZm9jdXNDYW5kaWRhdGUuaXNOdWxsKCkgPT0gdHJ1ZSksIHdlIGNhbiBz YWZlbHkgdGFrZSB0aGUgY3VycmVudCBjYW5kaWRhdGUsCmFuZCBleGl0IGVhcmxpZXIuCgpObyBi ZWhhdmlvciBjaGFuZ2UsIGl0IGlzIGp1c3QgYSBzYWZlIGFzc2lnbm1lbnQgc2hvcnRjdXQuCgoq IHBhZ2UvRm9jdXNDb250cm9sbGVyLmNwcDoKKFdlYkNvcmU6OnVwZGF0ZUZvY3VzQ2FuZGlkYXRl SWZDbG9zZXIpOgoKZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFu Z2VMb2cKaW5kZXggYzhlYmFhZS4uZDgwODc1YSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VM b2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsOCArMSwyNSBAQAorMjAxMC0wNC0xOSAg QW50b25pbyBHb21lcyAgPHRvbmlraXRvb0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNwYXRpYWwgTmF2aWdhdGlvbjogYXQgQHVw ZGF0ZUZvY3VzQ2FuZGlkYXRlSWZDbG9zZXIgbWFrZSBhbiBhc3NpZ25tZW50IHNob3J0Y3V0IHdo ZW4gRm9jdXNDYW5kaWRhdGUgaXMgbnVsbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9Mzc4MDIKKworICAgICAgICBJbiB1cGRhdGVGb2N1c0NhbmRpZGF0 ZUlmQ2xvc2VyIG1ldGhvZCwgd2UgZG8gYWxsIGJhaWwgb3V0IGNoZWNrcyBpbiB0aGUgYmVnaW5p bmcgb2YKKyAgICAgICAgdGhlIG1ldGhvZCBib2R5LiBJZiBhZnRlciB0aG9zZSBiYWlsIG91dCBj aGVja3MsIG5vICJiZXN0IEZvY3VzQ2FuZGlkYXRlIiBoYXMgYmVlbiB0YWtlbgorICAgICAgICB5 ZXQgKGkuZS4gZm9jdXNDYW5kaWRhdGUuaXNOdWxsKCkgPT0gdHJ1ZSksIHdlIGNhbiBzYWZlbHkg dGFrZSB0aGUgY3VycmVudCBjYW5kaWRhdGUsCisgICAgICAgIGFuZCBleGl0IGVhcmxpZXIuCisK KyAgICAgICAgTm8gYmVoYXZpb3IgY2hhbmdlLCBpdCBpcyBqdXN0IGEgc2FmZSBhc3NpZ25tZW50 IHNob3J0Y3V0LgorCisgICAgICAgICogcGFnZS9Gb2N1c0NvbnRyb2xsZXIuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6dXBkYXRlRm9jdXNDYW5kaWRhdGVJZkNsb3Nlcik6CisKIDIwMTAtMDQtMTcg IEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgQWRhbSBCYXJ0aC4KIAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9Mzc3MjAKICAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzc4NzM3NTI+IEhUTUxGcmFt ZVNldEVsZW1lbnQtd2luZG93LWV2ZW50TGlzdGVuZXItYXR0cmlidXRlcy5odG1sIHNvbWV0aW1l cwogICAgICAgICBjcmFzaGVzIG9uIFNub3dMZW9wYXJkIFJlbGVhc2UKIApkaWZmIC0tZ2l0IGEv V2ViQ29yZS9wYWdlL0ZvY3VzQ29udHJvbGxlci5jcHAgYi9XZWJDb3JlL3BhZ2UvRm9jdXNDb250 cm9sbGVyLmNwcAppbmRleCA0MjVhNjc4Li42ZGI5ZWY0IDEwMDY0NAotLS0gYS9XZWJDb3JlL3Bh Z2UvRm9jdXNDb250cm9sbGVyLmNwcAorKysgYi9XZWJDb3JlL3BhZ2UvRm9jdXNDb250cm9sbGVy LmNwcApAQCAtMzY1LDE2ICszNjUsMjEgQEAgc3RhdGljIHZvaWQgdXBkYXRlRm9jdXNDYW5kaWRh dGVJZkNsb3NlcihOb2RlKiBmb2N1c2VkTm9kZSwgY29uc3QgRm9jdXNDYW5kaWRhdGUKICAgICAg ICAgICYmIGNsb3Nlc3QucGFyZW50QWxpZ25tZW50IDwgY2FuZGlkYXRlLmFsaWdubWVudCkKICAg ICAgICAgICAgIGNsb3Nlc3QuZGlzdGFuY2UgPSBtYXhEaXN0YW5jZSgpOwogICAgIH0KIAogICAg IC8vIEJhaWwgb3V0IGlmIGNhbmRpZGF0ZSdzIGRpc3RhbmNlIGlzIGxhcmdlciB0aGFuIHRoYXQg b2YgdGhlIGNsb3Nlc3QgY2FuZGlkYXRlLgogICAgIGlmIChjYW5kaWRhdGUuZGlzdGFuY2UgPj0g Y2xvc2VzdC5kaXN0YW5jZSkKICAgICAgICAgcmV0dXJuOwogCisgICAgaWYgKGNsb3Nlc3QuaXNO dWxsKCkpIHsKKyAgICAgICAgY2xvc2VzdCA9IGNhbmRpZGF0ZTsKKyAgICAgICAgcmV0dXJuOwor ICAgIH0KKwogICAgIC8vIElmIHRoZSBmb2N1c2VkIG5vZGUgYW5kIHRoZSBjYW5kYWRhdGUgYXJl IGluIHRoZSBzYW1lIGRvY3VtZW50IGFuZCBjdXJyZW50CiAgICAgLy8gY2xvc2VzdCBjYW5kaWRh dGUgaXMgbm90IGluIGFuIHtpfWZyYW1lIHRoYXQgaXMgcHJlZmVyYWJsZSB0byBnZXQgZm9jdXNl ZCAuLi4KICAgICBpZiAoZm9jdXNlZE5vZGUtPmRvY3VtZW50KCkgPT0gY2FuZGlkYXRlLmRvY3Vt ZW50KCkKICAgICAgICAgJiYgY2FuZGlkYXRlLmRpc3RhbmNlIDwgY2xvc2VzdC5wYXJlbnREaXN0 YW5jZSkKICAgICAgICAgY2xvc2VzdCA9IGNhbmRpZGF0ZTsKICAgICBlbHNlIGlmIChmb2N1c2Vk Tm9kZS0+ZG9jdW1lbnQoKSAhPSBjYW5kaWRhdGUuZG9jdW1lbnQoKSkgewogICAgICAgICAvLyBJ ZiB0aGUgZm9jdXNlZE5vZGUgaXMgaW4gYW4gaW5uZXIgZG9jdW1lbnQgYW5kIGNhbmRpZGF0ZSBp cyBpbiBhCiAgICAgICAgIC8vIGRpZmZlcmVudCBkb2N1bWVudCwgd2Ugb25seSBjb25zaWRlciB0 byBjaGFuZ2UgZm9jdXMgaWYgdGhlcmUgaXMgbm90Ci0tIAoxLjYuMC40Cgo=