37796 2010-04-19 06:49:40 -0700 JPG images fail to print in Chromium 2010-04-21 14:33:44 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Mac (Intel) OS X 10.6 RESOLVED FIXED P2 Normal --- 1 avi webkit-unassigned commit-queue jamesr simon.fraser webkit.review.bot oldest_to_newest 214007 0 avi 2010-04-19 06:49:40 -0700 Upstream from http://code.google.com/p/chromium/issues/detail?id=33239 . <rdar://problem/7874035> (<http://openradar.appspot.com/7874035>): Any image source with final=false will fail to draw into a PDF context even when later updated with final=true. Therefore when the final data comes in for an image, we need to destroy and re-create the image source. 214008 1 53675 avi 2010-04-19 06:52:05 -0700 Created attachment 53675 Patch to avoid bug. 214009 2 webkit.review.bot 2010-04-19 06:56:32 -0700 Attachment 53675 did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/platform/graphics/cg/ImageSourceCG.cpp:131: Use 0 instead of NULL. [readability/null] [5] WebCore/platform/graphics/cg/ImageSourceCG.cpp:136: Use 0 instead of NULL. [readability/null] [5] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 214011 3 53676 avi 2010-04-19 07:08:46 -0700 Created attachment 53676 Yes, Miss Style Bot. 214710 4 53676 simon.fraser 2010-04-20 09:59:19 -0700 Comment on attachment 53676 Yes, Miss Style Bot. > Index: WebCore/ChangeLog > =================================================================== > --- WebCore/ChangeLog (revision 57809) > +++ WebCore/ChangeLog (working copy) > @@ -1,3 +1,13 @@ > +2010-04-19 Avi Drissman <avi@chromium.org> > + > + Reviewed by NOBODY (OOPS!). > + > + JPG images fail to print in Chromium > + https://bugs.webkit.org/show_bug.cgi?id=37796 This needs more verbage to say what the underlying problem is (referencing the radar), and what you did to fix it. r=me 214721 5 53833 avi 2010-04-20 10:07:39 -0700 Created attachment 53833 Better ChangeLog description, no code change. 214724 6 53834 avi 2010-04-20 10:08:54 -0700 Created attachment 53834 A little more precision. Still no code change. 215258 7 53834 commit-queue 2010-04-21 05:23:06 -0700 Comment on attachment 53834 A little more precision. Still no code change. Clearing flags on attachment: 53834 Committed r57969: <http://trac.webkit.org/changeset/57969> 215259 8 commit-queue 2010-04-21 05:23:11 -0700 All reviewed patches have been landed. Closing bug. 215451 9 jamesr 2010-04-21 12:57:24 -0700 I think this broke http/tests/multipart/invalid-image-data.html, see http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=http%2Ftests%2Fmultipart%2Finvalid-image-data.html&useWebKitCanary=true Is this a regression or a progression? 215480 10 avi 2010-04-21 13:44:23 -0700 I actually don't know. Lin/Win were displaying blank because they were incorrectly showing the second image which wasn't decoding correctly (see http://code.google.com/p/chromium/issues/detail?id=8729). The Mac was working correctly? Looking at the code that put the test in, it's dealing with saving/extracting the data at a level totally different than the one I'm dealing with... 215500 11 avi 2010-04-21 14:31:35 -0700 So apparently Chromium Mac is now broken in the same way as Chromium Win/Lin is, rather than unexpectedly passing. I don't know if that's a good or bad thing. 215502 12 jamesr 2010-04-21 14:33:44 -0700 Hmm. I've marked it as an expected failure for now and will file a separate bug to track it (if we don't have one already). 53675 2010-04-19 06:52:05 -0700 2010-04-19 07:08:46 -0700 Patch to avoid bug. jpg.patch text/plain 2088 avi SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NzgwOSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTAtMDQtMTkgIEF2aSBEcmlzc21hbiAgPGF2aUBjaHJvbWl1bS5v cmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSlBH IGltYWdlcyBmYWlsIHRvIHByaW50IGluIENocm9taXVtCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNzc5NgorCisgICAgICAgICogcGxhdGZvcm0vZ3Jh cGhpY3MvY2cvSW1hZ2VTb3VyY2VDRy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbWFnZVNvdXJj ZTo6c2V0RGF0YSk6CisKIDIwMTAtMDQtMTkgIEplc3NpZSBCZXJsaW4gIDxqYmVybGluQHdlYmtp dC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2ZSBIeWF0dC4KSW5kZXg6IFdlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvY2cvSW1hZ2VTb3VyY2VDRy5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jZy9JbWFnZVNvdXJjZUNHLmNwcAkocmV2aXNpb24gNTc4 MDkpCisrKyBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NnL0ltYWdlU291cmNlQ0cuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC0xMTksMTQgKzExOSwyMiBAQCBib29sIEltYWdlU291cmNlOjppbml0 aWFsaXplZCgpIGNvbnN0CiAKIHZvaWQgSW1hZ2VTb3VyY2U6OnNldERhdGEoU2hhcmVkQnVmZmVy KiBkYXRhLCBib29sIGFsbERhdGFSZWNlaXZlZCkKIHsKKyNpZiBQTEFURk9STShNQUMpCiAgICAg aWYgKCFtX2RlY29kZXIpCiAgICAgICAgIG1fZGVjb2RlciA9IENHSW1hZ2VTb3VyY2VDcmVhdGVJ bmNyZW1lbnRhbChOVUxMKTsKLSNpZiBQTEFURk9STShNQUMpCiAgICAgLy8gT24gTWFjIHRoZSBO U0RhdGEgaW5zaWRlIHRoZSBTaGFyZWRCdWZmZXIgY2FuIGJlIHNlY3JldGx5IGFwcGVuZGVkIHRv IHdpdGhvdXQgdGhlIFNoYXJlZEJ1ZmZlcidzIGtub3dsZWRnZS4gIFdlIHVzZSBTaGFyZWRCdWZm ZXIncyBhYmlsaXR5CiAgICAgLy8gdG8gd3JhcCBpdHNlbGYgaW5zaWRlIENGRGF0YSB0byBnZXQg YXJvdW5kIHRoaXMsIGVuc3VyaW5nIHRoYXQgSW1hZ2VJTyBpcyByZWFsbHkgbG9va2luZyBhdCB0 aGUgU2hhcmVkQnVmZmVyLgogICAgIFJldGFpblB0cjxDRkRhdGFSZWY+IGNmRGF0YShBZG9wdENG LCBkYXRhLT5jcmVhdGVDRkRhdGEoKSk7CiAgICAgQ0dJbWFnZVNvdXJjZVVwZGF0ZURhdGEobV9k ZWNvZGVyLCBjZkRhdGEuZ2V0KCksIGFsbERhdGFSZWNlaXZlZCk7CiAjZWxzZQorICAgIGlmICgh bV9kZWNvZGVyKSB7CisgICAgICAgIG1fZGVjb2RlciA9IENHSW1hZ2VTb3VyY2VDcmVhdGVJbmNy ZW1lbnRhbChOVUxMKTsKKyAgICB9IGVsc2UgaWYgKGFsbERhdGFSZWNlaXZlZCkgeworICAgICAg ICAvLyAxMC42IGJ1ZyB3b3JrYXJvdW5kOiBpbWFnZSBzb3VyY2VzIHdpdGggZmluYWw9ZmFsc2Ug ZmFpbCB0byBkcmF3IGludG8gUERGIGNvbnRleHRzLCBzbyByZS1jcmVhdGUgaW1hZ2Ugc291cmNl CisgICAgICAgIC8vIHdoZW4gZGF0YSBpcyBjb21wbGV0ZS4gPHJkYXI6Ly9wcm9ibGVtLzc4NzQw MzU+ICg8aHR0cDovL29wZW5yYWRhci5hcHBzcG90LmNvbS83ODc0MDM1PikKKyAgICAgICAgQ0ZS ZWxlYXNlKG1fZGVjb2Rlcik7CisgICAgICAgIG1fZGVjb2RlciA9IENHSW1hZ2VTb3VyY2VDcmVh dGVJbmNyZW1lbnRhbChOVUxMKTsKKyAgICB9CiAgICAgLy8gQ3JlYXRlIGEgQ0dEYXRhUHJvdmlk ZXIgdG8gd3JhcCB0aGUgU2hhcmVkQnVmZmVyLgogICAgIGRhdGEtPnJlZigpOwogICAgIC8vIFdl IHVzZSB0aGUgR2V0Qnl0ZXNBdFBvc2l0aW9uIGNhbGxiYWNrIHJhdGhlciB0aGFuIHRoZSBHZXRC eXRlUG9pbnRlciBvbmUgYmVjYXVzZSBTaGFyZWRCdWZmZXIK 53676 2010-04-19 07:08:46 -0700 2010-04-20 10:07:39 -0700 Yes, Miss Style Bot. jpg.patch text/plain 2140 avi SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NzgwOSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTAtMDQtMTkgIEF2aSBEcmlzc21hbiAgPGF2aUBjaHJvbWl1bS5v cmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSlBH IGltYWdlcyBmYWlsIHRvIHByaW50IGluIENocm9taXVtCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNzc5NgorCisgICAgICAgICogcGxhdGZvcm0vZ3Jh cGhpY3MvY2cvSW1hZ2VTb3VyY2VDRy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbWFnZVNvdXJj ZTo6c2V0RGF0YSk6CisKIDIwMTAtMDQtMTkgIEplc3NpZSBCZXJsaW4gIDxqYmVybGluQHdlYmtp dC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2ZSBIeWF0dC4KSW5kZXg6IFdlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvY2cvSW1hZ2VTb3VyY2VDRy5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jZy9JbWFnZVNvdXJjZUNHLmNwcAkocmV2aXNpb24gNTc4 MDkpCisrKyBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NnL0ltYWdlU291cmNlQ0cuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC0xMTksMTQgKzExOSwyMiBAQCBib29sIEltYWdlU291cmNlOjppbml0 aWFsaXplZCgpIGNvbnN0CiAKIHZvaWQgSW1hZ2VTb3VyY2U6OnNldERhdGEoU2hhcmVkQnVmZmVy KiBkYXRhLCBib29sIGFsbERhdGFSZWNlaXZlZCkKIHsKLSAgICBpZiAoIW1fZGVjb2RlcikKLSAg ICAgICAgbV9kZWNvZGVyID0gQ0dJbWFnZVNvdXJjZUNyZWF0ZUluY3JlbWVudGFsKE5VTEwpOwog I2lmIFBMQVRGT1JNKE1BQykKKyAgICBpZiAoIW1fZGVjb2RlcikKKyAgICAgICAgbV9kZWNvZGVy ID0gQ0dJbWFnZVNvdXJjZUNyZWF0ZUluY3JlbWVudGFsKDApOwogICAgIC8vIE9uIE1hYyB0aGUg TlNEYXRhIGluc2lkZSB0aGUgU2hhcmVkQnVmZmVyIGNhbiBiZSBzZWNyZXRseSBhcHBlbmRlZCB0 byB3aXRob3V0IHRoZSBTaGFyZWRCdWZmZXIncyBrbm93bGVkZ2UuICBXZSB1c2UgU2hhcmVkQnVm ZmVyJ3MgYWJpbGl0eQogICAgIC8vIHRvIHdyYXAgaXRzZWxmIGluc2lkZSBDRkRhdGEgdG8gZ2V0 IGFyb3VuZCB0aGlzLCBlbnN1cmluZyB0aGF0IEltYWdlSU8gaXMgcmVhbGx5IGxvb2tpbmcgYXQg dGhlIFNoYXJlZEJ1ZmZlci4KICAgICBSZXRhaW5QdHI8Q0ZEYXRhUmVmPiBjZkRhdGEoQWRvcHRD RiwgZGF0YS0+Y3JlYXRlQ0ZEYXRhKCkpOwogICAgIENHSW1hZ2VTb3VyY2VVcGRhdGVEYXRhKG1f ZGVjb2RlciwgY2ZEYXRhLmdldCgpLCBhbGxEYXRhUmVjZWl2ZWQpOwogI2Vsc2UKKyAgICBpZiAo IW1fZGVjb2RlcikgeworICAgICAgICBtX2RlY29kZXIgPSBDR0ltYWdlU291cmNlQ3JlYXRlSW5j cmVtZW50YWwoMCk7CisgICAgfSBlbHNlIGlmIChhbGxEYXRhUmVjZWl2ZWQpIHsKKyAgICAgICAg Ly8gMTAuNiBidWcgd29ya2Fyb3VuZDogaW1hZ2Ugc291cmNlcyB3aXRoIGZpbmFsPWZhbHNlIGZh aWwgdG8gZHJhdyBpbnRvIFBERiBjb250ZXh0cywgc28gcmUtY3JlYXRlIGltYWdlIHNvdXJjZQor ICAgICAgICAvLyB3aGVuIGRhdGEgaXMgY29tcGxldGUuIDxyZGFyOi8vcHJvYmxlbS83ODc0MDM1 PiAoPGh0dHA6Ly9vcGVucmFkYXIuYXBwc3BvdC5jb20vNzg3NDAzNT4pCisgICAgICAgIENGUmVs ZWFzZShtX2RlY29kZXIpOworICAgICAgICBtX2RlY29kZXIgPSBDR0ltYWdlU291cmNlQ3JlYXRl SW5jcmVtZW50YWwoMCk7CisgICAgfQogICAgIC8vIENyZWF0ZSBhIENHRGF0YVByb3ZpZGVyIHRv IHdyYXAgdGhlIFNoYXJlZEJ1ZmZlci4KICAgICBkYXRhLT5yZWYoKTsKICAgICAvLyBXZSB1c2Ug dGhlIEdldEJ5dGVzQXRQb3NpdGlvbiBjYWxsYmFjayByYXRoZXIgdGhhbiB0aGUgR2V0Qnl0ZVBv aW50ZXIgb25lIGJlY2F1c2UgU2hhcmVkQnVmZmVyCg== 53833 2010-04-20 10:07:39 -0700 2010-04-20 10:09:47 -0700 Better ChangeLog description, no code change. jpg.patch text/plain 2342 avi SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NzgwOSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMDQtMTkgIEF2aSBEcmlzc21hbiAgPGF2aUBjaHJvbWl1bS5v cmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSlBH IGltYWdlcyBmYWlsIHRvIHByaW50IGluIENocm9taXVtCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNzc5NgorCisgICAgICAgIEltYWdlIHNvdXJjZXMg d2l0aCBmaW5hbD1mYWxzZSBmYWlsIHRvIGRyYXcgaW50byBQREYgY29udGV4dHMgZXZlbiBpZiBs YXRlciB1cGRhdGVkICg8cmRhcjovL3Byb2JsZW0vNzg3NDAzNT4pLiBUaGVyZWZvcmUsIGRlc3Ry b3kgYW5kIHJlLWNyZWF0ZSB0aGUgaW1hZ2Ugc291cmNlIHdoZW4gdGhlIGZpbmFsIGRhdGEgYXJy aXZlcy4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2NnL0ltYWdlU291cmNlQ0cuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6SW1hZ2VTb3VyY2U6OnNldERhdGEpOgorCiAyMDEwLTA0LTE5 ICBKZXNzaWUgQmVybGluICA8amJlcmxpbkB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IERhdmUgSHlhdHQuCkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NnL0ltYWdl U291cmNlQ0cuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2cv SW1hZ2VTb3VyY2VDRy5jcHAJKHJldmlzaW9uIDU3ODA5KQorKysgV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9jZy9JbWFnZVNvdXJjZUNHLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTE5LDE0ICsx MTksMjIgQEAgYm9vbCBJbWFnZVNvdXJjZTo6aW5pdGlhbGl6ZWQoKSBjb25zdAogCiB2b2lkIElt YWdlU291cmNlOjpzZXREYXRhKFNoYXJlZEJ1ZmZlciogZGF0YSwgYm9vbCBhbGxEYXRhUmVjZWl2 ZWQpCiB7Ci0gICAgaWYgKCFtX2RlY29kZXIpCi0gICAgICAgIG1fZGVjb2RlciA9IENHSW1hZ2VT b3VyY2VDcmVhdGVJbmNyZW1lbnRhbChOVUxMKTsKICNpZiBQTEFURk9STShNQUMpCisgICAgaWYg KCFtX2RlY29kZXIpCisgICAgICAgIG1fZGVjb2RlciA9IENHSW1hZ2VTb3VyY2VDcmVhdGVJbmNy ZW1lbnRhbCgwKTsKICAgICAvLyBPbiBNYWMgdGhlIE5TRGF0YSBpbnNpZGUgdGhlIFNoYXJlZEJ1 ZmZlciBjYW4gYmUgc2VjcmV0bHkgYXBwZW5kZWQgdG8gd2l0aG91dCB0aGUgU2hhcmVkQnVmZmVy J3Mga25vd2xlZGdlLiAgV2UgdXNlIFNoYXJlZEJ1ZmZlcidzIGFiaWxpdHkKICAgICAvLyB0byB3 cmFwIGl0c2VsZiBpbnNpZGUgQ0ZEYXRhIHRvIGdldCBhcm91bmQgdGhpcywgZW5zdXJpbmcgdGhh dCBJbWFnZUlPIGlzIHJlYWxseSBsb29raW5nIGF0IHRoZSBTaGFyZWRCdWZmZXIuCiAgICAgUmV0 YWluUHRyPENGRGF0YVJlZj4gY2ZEYXRhKEFkb3B0Q0YsIGRhdGEtPmNyZWF0ZUNGRGF0YSgpKTsK ICAgICBDR0ltYWdlU291cmNlVXBkYXRlRGF0YShtX2RlY29kZXIsIGNmRGF0YS5nZXQoKSwgYWxs RGF0YVJlY2VpdmVkKTsKICNlbHNlCisgICAgaWYgKCFtX2RlY29kZXIpIHsKKyAgICAgICAgbV9k ZWNvZGVyID0gQ0dJbWFnZVNvdXJjZUNyZWF0ZUluY3JlbWVudGFsKDApOworICAgIH0gZWxzZSBp ZiAoYWxsRGF0YVJlY2VpdmVkKSB7CisgICAgICAgIC8vIDEwLjYgYnVnIHdvcmthcm91bmQ6IGlt YWdlIHNvdXJjZXMgd2l0aCBmaW5hbD1mYWxzZSBmYWlsIHRvIGRyYXcgaW50byBQREYgY29udGV4 dHMsIHNvIHJlLWNyZWF0ZSBpbWFnZSBzb3VyY2UKKyAgICAgICAgLy8gd2hlbiBkYXRhIGlzIGNv bXBsZXRlLiA8cmRhcjovL3Byb2JsZW0vNzg3NDAzNT4gKDxodHRwOi8vb3BlbnJhZGFyLmFwcHNw b3QuY29tLzc4NzQwMzU+KQorICAgICAgICBDRlJlbGVhc2UobV9kZWNvZGVyKTsKKyAgICAgICAg bV9kZWNvZGVyID0gQ0dJbWFnZVNvdXJjZUNyZWF0ZUluY3JlbWVudGFsKDApOworICAgIH0KICAg ICAvLyBDcmVhdGUgYSBDR0RhdGFQcm92aWRlciB0byB3cmFwIHRoZSBTaGFyZWRCdWZmZXIuCiAg ICAgZGF0YS0+cmVmKCk7CiAgICAgLy8gV2UgdXNlIHRoZSBHZXRCeXRlc0F0UG9zaXRpb24gY2Fs bGJhY2sgcmF0aGVyIHRoYW4gdGhlIEdldEJ5dGVQb2ludGVyIG9uZSBiZWNhdXNlIFNoYXJlZEJ1 ZmZlcgo= 53834 2010-04-20 10:08:54 -0700 2010-04-21 05:23:06 -0700 A little more precision. Still no code change. jpg.patch text/plain 2354 avi SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NzgwOSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMDQtMTkgIEF2aSBEcmlzc21hbiAgPGF2aUBjaHJvbWl1bS5v cmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSlBH IGltYWdlcyBmYWlsIHRvIHByaW50IGluIENocm9taXVtCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNzc5NgorCisgICAgICAgIEltYWdlIHNvdXJjZXMg b2YgSlBHIGRhdGEgd2l0aCBmaW5hbD1mYWxzZSBmYWlsIHRvIGRyYXcgaW50byBQREYgY29udGV4 dHMgZXZlbiBpZiBsYXRlciB1cGRhdGVkICg8cmRhcjovL3Byb2JsZW0vNzg3NDAzNT4pLiBUaGVy ZWZvcmUsIGRlc3Ryb3kgYW5kIHJlLWNyZWF0ZSB0aGUgaW1hZ2Ugc291cmNlIHdoZW4gdGhlIGZp bmFsIGRhdGEgYXJyaXZlcy4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2NnL0ltYWdl U291cmNlQ0cuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW1hZ2VTb3VyY2U6OnNldERhdGEpOgor CiAyMDEwLTA0LTE5ICBKZXNzaWUgQmVybGluICA8amJlcmxpbkB3ZWJraXQub3JnPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IERhdmUgSHlhdHQuCkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2NnL0ltYWdlU291cmNlQ0cuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvY2cvSW1hZ2VTb3VyY2VDRy5jcHAJKHJldmlzaW9uIDU3ODA5KQorKysgV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9jZy9JbWFnZVNvdXJjZUNHLmNwcAkod29ya2luZyBjb3B5KQpA QCAtMTE5LDE0ICsxMTksMjIgQEAgYm9vbCBJbWFnZVNvdXJjZTo6aW5pdGlhbGl6ZWQoKSBjb25z dAogCiB2b2lkIEltYWdlU291cmNlOjpzZXREYXRhKFNoYXJlZEJ1ZmZlciogZGF0YSwgYm9vbCBh bGxEYXRhUmVjZWl2ZWQpCiB7Ci0gICAgaWYgKCFtX2RlY29kZXIpCi0gICAgICAgIG1fZGVjb2Rl ciA9IENHSW1hZ2VTb3VyY2VDcmVhdGVJbmNyZW1lbnRhbChOVUxMKTsKICNpZiBQTEFURk9STShN QUMpCisgICAgaWYgKCFtX2RlY29kZXIpCisgICAgICAgIG1fZGVjb2RlciA9IENHSW1hZ2VTb3Vy Y2VDcmVhdGVJbmNyZW1lbnRhbCgwKTsKICAgICAvLyBPbiBNYWMgdGhlIE5TRGF0YSBpbnNpZGUg dGhlIFNoYXJlZEJ1ZmZlciBjYW4gYmUgc2VjcmV0bHkgYXBwZW5kZWQgdG8gd2l0aG91dCB0aGUg U2hhcmVkQnVmZmVyJ3Mga25vd2xlZGdlLiAgV2UgdXNlIFNoYXJlZEJ1ZmZlcidzIGFiaWxpdHkK ICAgICAvLyB0byB3cmFwIGl0c2VsZiBpbnNpZGUgQ0ZEYXRhIHRvIGdldCBhcm91bmQgdGhpcywg ZW5zdXJpbmcgdGhhdCBJbWFnZUlPIGlzIHJlYWxseSBsb29raW5nIGF0IHRoZSBTaGFyZWRCdWZm ZXIuCiAgICAgUmV0YWluUHRyPENGRGF0YVJlZj4gY2ZEYXRhKEFkb3B0Q0YsIGRhdGEtPmNyZWF0 ZUNGRGF0YSgpKTsKICAgICBDR0ltYWdlU291cmNlVXBkYXRlRGF0YShtX2RlY29kZXIsIGNmRGF0 YS5nZXQoKSwgYWxsRGF0YVJlY2VpdmVkKTsKICNlbHNlCisgICAgaWYgKCFtX2RlY29kZXIpIHsK KyAgICAgICAgbV9kZWNvZGVyID0gQ0dJbWFnZVNvdXJjZUNyZWF0ZUluY3JlbWVudGFsKDApOwor ICAgIH0gZWxzZSBpZiAoYWxsRGF0YVJlY2VpdmVkKSB7CisgICAgICAgIC8vIDEwLjYgYnVnIHdv cmthcm91bmQ6IGltYWdlIHNvdXJjZXMgd2l0aCBmaW5hbD1mYWxzZSBmYWlsIHRvIGRyYXcgaW50 byBQREYgY29udGV4dHMsIHNvIHJlLWNyZWF0ZSBpbWFnZSBzb3VyY2UKKyAgICAgICAgLy8gd2hl biBkYXRhIGlzIGNvbXBsZXRlLiA8cmRhcjovL3Byb2JsZW0vNzg3NDAzNT4gKDxodHRwOi8vb3Bl bnJhZGFyLmFwcHNwb3QuY29tLzc4NzQwMzU+KQorICAgICAgICBDRlJlbGVhc2UobV9kZWNvZGVy KTsKKyAgICAgICAgbV9kZWNvZGVyID0gQ0dJbWFnZVNvdXJjZUNyZWF0ZUluY3JlbWVudGFsKDAp OworICAgIH0KICAgICAvLyBDcmVhdGUgYSBDR0RhdGFQcm92aWRlciB0byB3cmFwIHRoZSBTaGFy ZWRCdWZmZXIuCiAgICAgZGF0YS0+cmVmKCk7CiAgICAgLy8gV2UgdXNlIHRoZSBHZXRCeXRlc0F0 UG9zaXRpb24gY2FsbGJhY2sgcmF0aGVyIHRoYW4gdGhlIEdldEJ5dGVQb2ludGVyIG9uZSBiZWNh dXNlIFNoYXJlZEJ1ZmZlcgo=