37794 2010-04-19 03:05:09 -0700 new-run-webkit-tests --verbose shows ever-increasing #EOF lines 2010-04-22 18:56:08 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric webkit-unassigned abarth commit-queue dglazkov dpranke ojan tkent tony oldest_to_newest 213976 0 eric 2010-04-19 03:05:09 -0700 new-run-webkit-tests --verbose shows ever-increasing #EOF lines 100419 03:02:32 dump_render_tree_thread.py:95 DEBUG Previous test output extra lines after dump: #EOF #EOF #EOF After every test, the number of #EOFs dumped there is larger. Eventually you just can't read the log at all. Something is wrong in the WebKit driver or in the logging or both. 214037 1 ojan 2010-04-19 08:23:59 -0700 Context: NRWT outputs the results between the #EOF for a test and the #URL... for the next test. This avoids putting the results from one test into the next (reduces flakiness). We spit this to stdout in the hopes that we can put it on the waterfall and get it fixed. In either case, it sounds like maybe DRT is printing multiple #EOF lines per test and that is confusing NRWT since it expects exactly one #EOF per #URL line. That's just a guess though. 214160 2 eric 2010-04-19 12:18:35 -0700 I believe that DRT prints out two #EOFs. One for the test content and one for the pixel content. http://trac.webkit.org/browser/trunk/WebKitTools/DumpRenderTree/mac/DumpRenderTree.mm#L1061 215785 3 eric 2010-04-22 02:10:00 -0700 The log message was just confusing. What it was actually printing was the stderr. DRT prints an #EOF on stderr too. 215787 4 54043 eric 2010-04-22 02:12:34 -0700 Created attachment 54043 Patch 215788 5 54043 abarth 2010-04-22 02:14:18 -0700 Comment on attachment 54043 Patch This seems like a bit of a hack, but this seems to be blocking you... 215790 6 eric 2010-04-22 02:21:31 -0700 Committed r58076: <http://trac.webkit.org/changeset/58076> 215803 7 eric 2010-04-22 03:19:24 -0700 You were right. It was too much of a hack. I had to add another hack to handle the case where we get nothing back from stderr. I'm still not really sure what's going on here, but hopefully Dirk does. We're definitely in a better state than we were before, but not yet where we want to end up. 215830 8 eric 2010-04-22 05:08:55 -0700 Committed r58088: <http://trac.webkit.org/changeset/58088> 216063 9 dglazkov 2010-04-22 13:58:56 -0700 This broke new-run-webkit-tests --platform=chromium-mac --use-drt, which now crashes on this assertion. Not sure whether it's a bug being tickled, just noting here what's happening. 216067 10 eric 2010-04-22 14:05:29 -0700 Yeah. I've seen the crash too. Our handling of stderr is clearly wrong. I'll add another layer of hack in a second... 216070 11 ojan 2010-04-22 14:08:17 -0700 A bit late but... Seems like the "correct" fix would be to add a read_error_line method to match read_line. Then in the appropriate loops where you are reading output, you could also read the errors. In retrospect, it's weird that read_line also processes stderr. Alternately, we could modify readline to return a (output, error_output) tuple where output or error_output may be None/empty-string. 216076 12 eric 2010-04-22 14:17:17 -0700 It appears like we're not always waiting for the full error though. That's the ASSERT dglazkov is seeing, is that sometimes the error doens't contain the #EOF. 216082 13 eric 2010-04-22 14:29:14 -0700 Reopening to fix dglazkov's assertion. 216083 14 54096 eric 2010-04-22 14:29:34 -0700 Created attachment 54096 Fix assertion 216084 15 54096 dglazkov 2010-04-22 14:30:55 -0700 Comment on attachment 54096 Fix assertion ok, makes sense. 216217 16 54096 commit-queue 2010-04-22 18:56:01 -0700 Comment on attachment 54096 Fix assertion Clearing flags on attachment: 54096 Committed r58139: <http://trac.webkit.org/changeset/58139> 216218 17 commit-queue 2010-04-22 18:56:08 -0700 All reviewed patches have been landed. Closing bug. 54043 2010-04-22 02:12:34 -0700 2010-04-22 14:29:29 -0700 Patch bug-37794-20100422021233.patch text/plain 3021 eric ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA5YjQwMGViLi43ZDZkY2ZmIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjAgQEAKIDIwMTAtMDQt MjIgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgogCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIG5ldy1ydW4td2Via2l0LXRlc3RzIC0tdmVyYm9z ZSBzaG93cyBldmVyLWluY3JlYXNpbmcgI0VPRiBsaW5lcworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzc3OTQKKworICAgICAgICAqIFNjcmlwdHMvd2Vi a2l0cHkvbGF5b3V0X3Rlc3RzL2xheW91dF9wYWNrYWdlL2R1bXBfcmVuZGVyX3RyZWVfdGhyZWFk LnB5OgorICAgICAgICAgLSBGaXggdGhlIGxvZyBtZXNzYWdlIHRvIGV4cGxhaW4gdGhhdCB0aGlz IGlzIHN0ZGVyciBvdXRwdXQsIG5vdCB0ZXN0IG91dHB1dC4KKyAgICAgICAgKiBTY3JpcHRzL3dl YmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3dlYmtpdC5weToKKyAgICAgICAgIC0gQmUgc3VyZSB0 byByZXNldCB0aGUgc2VydmVyX3Byb2Nlc3MuZXJyb3IgYWZ0ZXIgcmVhZGluZyAoc2VlbXMgbGlr ZSB0aGUgd3JvbmcKKyAgICAgICAgICAgcGxhY2UgdG8gZG8gdGhpcywgYnV0IGF0IGxlYXN0IHRo aXMgZml4ZXMgdGhlIGJ1ZyBhbmQgZHByYW5rZSBhbmQgSSBjYW4gdGFsaworICAgICAgICAgICBh Ym91dCBiZXR0ZXIgZGVzaWducyBsYXRlcikuCisgICAgICAgICAtIEFsc28gcmVtb3ZlIHRoZSAj RU9GIGZyb20gdGhlIHN0ZGVyciBvdXRwdXQgYmVmb3JlIHJldHVybmluZyBpdC4KKworMjAxMC0w NC0yMiAgRXJpYyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+CisKICAgICAgICAgVW5yZXZpZXdl ZC4gIEZpeGluZyBuZXctcnVuLXdlYmtpdC10ZXN0cyBvbiB0aGUgYm90cy4KIAogICAgICAgICAq IFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHMucHk6CmRpZmYg LS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9sYXlvdXRf cGFja2FnZS9kdW1wX3JlbmRlcl90cmVlX3RocmVhZC5weSBiL1dlYktpdFRvb2xzL1NjcmlwdHMv d2Via2l0cHkvbGF5b3V0X3Rlc3RzL2xheW91dF9wYWNrYWdlL2R1bXBfcmVuZGVyX3RyZWVfdGhy ZWFkLnB5CmluZGV4IDFlNDEyYTMuLjQ2MmEzNGIgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1Nj cmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2xheW91dF9wYWNrYWdlL2R1bXBfcmVuZGVyX3Ry ZWVfdGhyZWFkLnB5CisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rl c3RzL2xheW91dF9wYWNrYWdlL2R1bXBfcmVuZGVyX3RyZWVfdGhyZWFkLnB5CkBAIC05NSw4ICs5 NSw3IEBAIGRlZiBwcm9jZXNzX291dHB1dChwb3J0LCB0ZXN0X2luZm8sIHRlc3RfdHlwZXMsIHRl c3RfYXJncywgY29uZmlndXJhdGlvbiwKICAgICAgICAgd2l0aCBjb2RlY3Mub3BlbihmaWxlbmFt ZSwgIndiIiwgInV0Zi04IikgYXMgZmlsZToKICAgICAgICAgICAgIGZpbGUud3JpdGUoZXJyb3Ip CiAgICAgZWxpZiBlcnJvcjoKLSAgICAgICAgX2xvZy5kZWJ1ZygiUHJldmlvdXMgdGVzdCBvdXRw dXQgZXh0cmEgbGluZXMgYWZ0ZXIgZHVtcDpcbiVzIiAlCi0gICAgICAgICAgICAgICAgICAgZXJy b3IpCisgICAgICAgIF9sb2cuZGVidWcoIlByZXZpb3VzIHRlc3Qgb3V0cHV0IHN0ZGVyciBsaW5l czpcbiVzIiAlIGVycm9yKQogCiAgICAgIyBDaGVjayB0aGUgb3V0cHV0IGFuZCBzYXZlIHRoZSBy ZXN1bHRzLgogICAgIHN0YXJ0X3RpbWUgPSB0aW1lLnRpbWUoKQpkaWZmIC0tZ2l0IGEvV2ViS2l0 VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC93ZWJraXQucHkgYi9XZWJL aXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3dlYmtpdC5weQppbmRl eCA3YzU2NjkzLi40Y2YxNGNkIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtp dHB5L2xheW91dF90ZXN0cy9wb3J0L3dlYmtpdC5weQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRz L3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3dlYmtpdC5weQpAQCAtNDQyLDExICs0NDIsMTkg QEAgY2xhc3MgV2ViS2l0RHJpdmVyKGJhc2UuRHJpdmVyKToKICAgICAgICAgaWYgc2VsZi5faW1h Z2VfcGF0aCBhbmQgbGVuKHNlbGYuX2ltYWdlX3BhdGgpOgogICAgICAgICAgICAgd2l0aCBvcGVu KHNlbGYuX2ltYWdlX3BhdGgsICJ3YiIpIGFzIGltYWdlX2ZpbGU6CiAgICAgICAgICAgICAgICAg aW1hZ2VfZmlsZS53cml0ZShpbWFnZSkKKworICAgICAgICBlcnJvcl9saW5lcyA9IHNlbGYuX3Nl cnZlcl9wcm9jZXNzLmVycm9yLnNwbGl0bGluZXMoKQorICAgICAgICBlcnJvcl9lb2YgPSBlcnJv cl9saW5lcy5wb3AoKQorICAgICAgICBhc3NlcnQoZXJyb3JfZW9mID09ICIjRU9GIikKKyAgICAg ICAgZXJyb3IgPSAiXG4iLmpvaW4oZXJyb3JfbGluZXMpCisgICAgICAgICMgRklYTUU6IFRoaXMg c2VlbXMgbGlrZSB0aGUgd3Jvbmcgc2VjdGlvbiBvZiBjb2RlIHRvIGJlIGRvaW5nCisgICAgICAg ICMgdGhpcyByZXNldCBpbi4KKyAgICAgICAgc2VsZi5fc2VydmVyX3Byb2Nlc3MuZXJyb3IgPSAi IgogICAgICAgICByZXR1cm4gKHNlbGYuX3NlcnZlcl9wcm9jZXNzLmNyYXNoZWQsCiAgICAgICAg ICAgICAgICAgc2VsZi5fc2VydmVyX3Byb2Nlc3MudGltZWRfb3V0LAogICAgICAgICAgICAgICAg IGFjdHVhbF9pbWFnZV9oYXNoLAogICAgICAgICAgICAgICAgIG91dHB1dCwKLSAgICAgICAgICAg ICAgICBzZWxmLl9zZXJ2ZXJfcHJvY2Vzcy5lcnJvcikKKyAgICAgICAgICAgICAgICBlcnJvcikK IAogICAgIGRlZiBzdG9wKHNlbGYpOgogICAgICAgICBpZiBzZWxmLl9zZXJ2ZXJfcHJvY2VzczoK 54096 2010-04-22 14:29:34 -0700 2010-04-22 18:56:01 -0700 Fix assertion bug-37794-20100422142932.patch text/plain 1560 eric ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBjZmE3ZjBkLi5iMDk3MDBlIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDQt MjIgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIG5ldy1ydW4td2Via2l0LXRlc3RzIC0tdmVyYm9z ZSBzaG93cyBldmVyLWluY3JlYXNpbmcgI0VPRiBsaW5lcworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzc3OTQKKworICAgICAgICAqIFNjcmlwdHMvd2Vi a2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvd2Via2l0LnB5OgorICAgICAgICAgLSBSZW1vdmUgdGhl IGFzc2VydCgpIHNpbmNlIG91ciBTZXJ2ZXJQcm9jZXNzIGNvZGUgZG9lcyBub3QgYWx3YXlzCisg ICAgICAgICAgIHNlZW0gdG8gYmUgcmVhZGluZyB0aGUgZnVsbCBzdGRlcnIgb3V0cHV0IChvciB3 ZSdyZSBub3Qgd2FpdGluZyBmb3IgaXQgdG8pLgorCiAyMDEwLTA0LTIyICBTYW0gV2VpbmlnICA8 c2FtQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQW5kZXJzIENhcmxzc29uLgpk aWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9y dC93ZWJraXQucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9w b3J0L3dlYmtpdC5weQppbmRleCBlZjFjNGYwLi5hYWJjOWExIDEwMDY0NAotLS0gYS9XZWJLaXRU b29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3dlYmtpdC5weQorKysgYi9X ZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3dlYmtpdC5weQpA QCAtNDQ3LDkgKzQ0Nyw4IEBAIGNsYXNzIFdlYktpdERyaXZlcihiYXNlLkRyaXZlcik6CiAgICAg ICAgICMgRklYTUU6IFRoaXMgaXMgYSBoYWNrLiAgSXQgaXMgdW5jbGVhciB3aHkgc29tZXRpbWVz CiAgICAgICAgICMgd2UgZG8gbm90IGdldCBhbnkgZXJyb3IgbGluZXMgZnJvbSB0aGUgc2VydmVy X3Byb2Nlc3MKICAgICAgICAgIyBwcm9iYWJseSB3ZSBhcmUgbm90IGZsdXNoaW5nIHN0ZGVyci4K LSAgICAgICAgaWYgZXJyb3JfbGluZXM6Ci0gICAgICAgICAgICBlcnJvcl9lb2YgPSBlcnJvcl9s aW5lcy5wb3AoKQotICAgICAgICAgICAgYXNzZXJ0KGVycm9yX2VvZiA9PSAiI0VPRiIpCisgICAg ICAgIGlmIGVycm9yX2xpbmVzIGFuZCBlcnJvcl9saW5lc1stMV0gPT0gIiNFT0YiOgorICAgICAg ICAgICAgZXJyb3JfbGluZXMucG9wKCkgICMgUmVtb3ZlIHRoZSBleHBlY3RlZCAiI0VPRiIKICAg ICAgICAgZXJyb3IgPSAiXG4iLmpvaW4oZXJyb3JfbGluZXMpCiAgICAgICAgICMgRklYTUU6IFRo aXMgc2VlbXMgbGlrZSB0aGUgd3Jvbmcgc2VjdGlvbiBvZiBjb2RlIHRvIGJlIGRvaW5nCiAgICAg ICAgICMgdGhpcyByZXNldCBpbi4K