37787 2010-04-18 19:38:33 -0700 nth-* pseudo-class parsing is incorrect 2010-05-17 21:53:04 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 yuzo yuzo oldest_to_newest 213879 0 yuzo 2010-04-18 19:38:33 -0700 WebCore::CSSSelector::RareData::parseNth doesn't check whether the search for '-' in the argument was successful. This results in incorrect parsing. For example, '3n' is parsed as if it were '3n-3'. The code has been working OK just accidentally. 213880 1 53650 yuzo 2010-04-18 19:41:06 -0700 Created attachment 53650 Fix nth-* pseudo-class parsing. 215112 2 53650 hamaji 2010-04-20 19:35:46 -0700 Comment on attachment 53650 Fix nth-* pseudo-class parsing. This change looks good. How -n-3 will be parsed, by the way? I'm not sure, but I guess it will be parsed as -n-0, right? 217608 3 yuzo 2010-04-27 02:13:05 -0700 -n-3 is parsed correctly. In determining m_b, '-' is searched by argument.find('-', 1), which finds the second '-' before '3'. 217626 4 yuzo 2010-04-27 02:53:44 -0700 Committed r58300: <http://trac.webkit.org/changeset/58300> 227108 5 yuzo 2010-05-17 21:53:04 -0700 The original behavior was actually incorrect and the patch did fix it. Please see: https://bugs.webkit.org/show_bug.cgi?id=31267 . I added tests there. 53650 2010-04-18 19:41:06 -0700 2010-04-20 19:35:45 -0700 Fix nth-* pseudo-class parsing. bug-37787-20100419114104.patch text/plain 1473 yuzo ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ODE5ZDA1NS4uZDcxODY4ZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMC0wNC0xOCAgWXV6byBGdWppc2hp bWEgIDx5dXpvQGdvb2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgV2ViQ29yZTo6Q1NTU2VsZWN0b3I6OlJhcmVEYXRhOjpwYXJzZU50aCBk b2Vzbid0IGNoZWNrIHdoZXRoZXIgdGhlIHNlYXJjaCBmb3IgJy0nIGluIHRoZSBhcmd1bWVudCB3 YXMgc3VjY2Vzc2Z1bC4KKyAgICAgICAgVGhpcyByZXN1bHRzIGluIGluY29ycmVjdCBwYXJzaW5n LgorICAgICAgICBGb3IgZXhhbXBsZSwgJzNuJyBpcyBwYXJzZWQgYXMgaWYgaXQgd2VyZSAnM24t MycuIFRoZSBjb2RlIGhhcyBiZWVuIHdvcmtpbmcgT0sganVzdCBhY2NpZGVudGFsbHkuCisKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM3Nzg3CisKKyAg ICAgICAgTm8gbmV3IHRlc3RzIGFyZSBhZGRlZCBiZWNhdXNlIHRoZSBvcmlnaW5hbCBiZWhhdmlv ciBpcyBhY2NpZGVudGFsbHkgT0suCisKKyAgICAgICAgKiBjc3MvQ1NTU2VsZWN0b3IuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6Q1NTU2VsZWN0b3I6OlJhcmVEYXRhOjpwYXJzZU50aCk6CisKIDIw MTAtMDQtMTcgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvY3NzL0NTU1NlbGVj dG9yLmNwcCBiL1dlYkNvcmUvY3NzL0NTU1NlbGVjdG9yLmNwcAppbmRleCA5Y2ViNTAzLi45ODU5 MTJiIDEwMDY0NAotLS0gYS9XZWJDb3JlL2Nzcy9DU1NTZWxlY3Rvci5jcHAKKysrIGIvV2ViQ29y ZS9jc3MvQ1NTU2VsZWN0b3IuY3BwCkBAIC02MjUsNyArNjI1LDggQEAgYm9vbCBDU1NTZWxlY3Rv cjo6UmFyZURhdGE6OnBhcnNlTnRoKCkKICAgICAgICAgICAgICAgICBtX2IgPSBhcmd1bWVudC5z dWJzdHJpbmcocCArIDEsIGFyZ3VtZW50Lmxlbmd0aCgpIC0gcCAtIDEpLnRvSW50KCk7CiAgICAg ICAgICAgICBlbHNlIHsKICAgICAgICAgICAgICAgICBwID0gYXJndW1lbnQuZmluZCgnLScsIG4p OwotICAgICAgICAgICAgICAgIG1fYiA9IC1hcmd1bWVudC5zdWJzdHJpbmcocCArIDEsIGFyZ3Vt ZW50Lmxlbmd0aCgpIC0gcCAtIDEpLnRvSW50KCk7CisgICAgICAgICAgICAgICAgaWYgKHAgIT0g LTEpCisgICAgICAgICAgICAgICAgICAgIG1fYiA9IC1hcmd1bWVudC5zdWJzdHJpbmcocCArIDEs IGFyZ3VtZW50Lmxlbmd0aCgpIC0gcCAtIDEpLnRvSW50KCk7CiAgICAgICAgICAgICB9CiAgICAg ICAgIH0gZWxzZQogICAgICAgICAgICAgbV9iID0gYXJndW1lbnQudG9JbnQoKTsK