37786 2010-04-18 17:51:11 -0700 new-run-webkit-tests: checking the build should be optional 2010-04-19 17:33:14 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 dpranke dpranke abarth cjerdonek eric ojan tony oldest_to_newest 213871 0 dpranke 2010-04-18 17:51:11 -0700 Checking whether or not a build is up-to-date can take 5-10 seconds or longer, and sometime you may wish to run the tests without rebuilding, so there should be a way to skip the check_build step. 213872 1 53648 dpranke 2010-04-18 18:01:30 -0700 Created attachment 53648 Patch 213912 2 53648 eric 2010-04-18 22:25:19 -0700 Comment on attachment 53648 Patch Two notes: 1. Sad that we need this. Seems like a hack around build system lameness. 2. I hate that optparse doesn't have built in support for --no-. We need to make our own make_option wrapper which does automatic --no- generation as well as puts the default value in the help text. 214033 3 ojan 2010-04-19 08:03:21 -0700 (In reply to comment #2) > 2. I hate that optparse doesn't have built in support for --no-. We need to > make our own make_option wrapper which does automatic --no- generation as well > as puts the default value in the help text. Why do we need to have both flags? Since it defaults to True, don't we only need --no-check-build? It seems like it's the actual rebuilding that slows things down. It's a shame to get rid of all the other checks in check_build just to avoid the rebuilding. How about adding a --no-build instead? I also think that would be more intuitive to users. If I didn't know the code, it wouldn't be clear to me that check-build is the thing that causes DRT to be built. 214090 4 dpranke 2010-04-19 10:30:27 -0700 (In reply to comment #3) > (In reply to comment #2) > > 2. I hate that optparse doesn't have built in support for --no-. We need to > > make our own make_option wrapper which does automatic --no- generation as well > > as puts the default value in the help text. > > Why do we need to have both flags? Since it defaults to True, don't we only > need --no-check-build? This may be a personal thing, but I don't like having boolean command line flags where both versions of the flag aren't legal. > It seems like it's the actual rebuilding that slows things down. It's a shame > to get rid of all the other checks in check_build just to avoid the rebuilding. > How about adding a --no-build instead? I also think that would be more > intuitive to users. If I didn't know the code, it wouldn't be clear to me that > check-build is the thing that causes DRT to be built. This would be fine, and is probably safer. 214280 5 53727 dpranke 2010-04-19 15:16:55 -0700 Created attachment 53727 revise w/ ojan's feedback (rename --check-build to --build) 214287 6 ojan 2010-04-19 15:26:00 -0700 LGTM. 214314 7 53727 eric 2010-04-19 16:12:37 -0700 Comment on attachment 53727 revise w/ ojan's feedback (rename --check-build to --build) The option name and help are misleading. This will only make sure that DumpRenderTree is built. Not webkit itself. I've been trying to use full sentences in option help (start with a capital, end with a period). I think the option names can stay, but we should fix the help to explain it only builds the helper tools, not WebKit. 214334 8 53738 dpranke 2010-04-19 16:45:56 -0700 Created attachment 53738 tweak the help text, changelog 214337 9 53738 eric 2010-04-19 16:48:56 -0700 Comment on attachment 53738 tweak the help text, changelog OK. 214369 10 dpranke 2010-04-19 17:33:14 -0700 Committed r57858: <http://trac.webkit.org/changeset/57858> 53648 2010-04-18 18:01:30 -0700 2010-04-19 15:16:55 -0700 Patch bug-37786-20100418180128.patch text/plain 2057 dpranke ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA5OThhNmQzLi5kZDU0YzNjIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDQt MTggIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgbmV3LXJ1bi13ZWJraXQtdGVzdHM6IGFk ZCAtLWNoZWNrLWJ1aWxkIGFuZCAtLW5vLWNoZWNrLWJ1aWxkCisgICAgICAgIG9wdGlvbnMgdG8g bWFrZSB0aGF0IHN0ZXAgb3B0aW9uYWwuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTM3Nzg2CisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xh eW91dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzLnB5OgorCiAyMDEwLTA0LTE1ICBTYW0gV2Vpbmln ICA8c2FtQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQW5kZXJzIENhcmxzc29u LgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMv cnVuX3dlYmtpdF90ZXN0cy5weSBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0 X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHMucHkKaW5kZXggMDU5ZmQwOS4uZWE0YWM4NiAxMDA3NTUK LS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtp dF90ZXN0cy5weQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0 cy9ydW5fd2Via2l0X3Rlc3RzLnB5CkBAIC0xNTAwLDkgKzE1MDAsMTAgQEAgZGVmIG1haW4ob3B0 aW9ucywgYXJncywgcHJpbnRfcmVzdWx0cz1UcnVlKToKICAgICB0ZXN0X3J1bm5lci5wYXJzZV9l eHBlY3RhdGlvbnMocG9ydF9vYmoudGVzdF9wbGF0Zm9ybV9uYW1lKCksCiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIG9wdGlvbnMuY29uZmlndXJhdGlvbiA9PSAnRGVidWcnKQog Ci0gICAgbWV0ZXIudXBkYXRlKCJDaGVja2luZyBidWlsZCAuLi4iKQotICAgIGlmIG5vdCBwb3J0 X29iai5jaGVja19idWlsZCh0ZXN0X3J1bm5lci5uZWVkc19odHRwKCkpOgotICAgICAgICByZXR1 cm4gLTEKKyAgICBpZiBvcHRpb25zLmNoZWNrX2J1aWxkOgorICAgICAgICBtZXRlci51cGRhdGUo IkNoZWNraW5nIGJ1aWxkIC4uLiIpCisgICAgICAgIGlmIG5vdCBwb3J0X29iai5jaGVja19idWls ZCh0ZXN0X3J1bm5lci5uZWVkc19odHRwKCkpOgorICAgICAgICAgICAgcmV0dXJuIC0xCiAKICAg ICBtZXRlci51cGRhdGUoIlN0YXJ0aW5nIGhlbHBlciAuLi4iKQogICAgIHBvcnRfb2JqLnN0YXJ0 X2hlbHBlcigpCkBAIC0xNjM4LDYgKzE2MzksMTIgQEAgZGVmIHBhcnNlX2FyZ3MoYXJncz1Ob25l KToKICAgICBdCiAKICAgICB0ZXN0X29wdGlvbnMgPSBbCisgICAgICAgIG9wdHBhcnNlLm1ha2Vf b3B0aW9uKCItLWNoZWNrLWJ1aWxkIiwgZGVzdD0iY2hlY2tfYnVpbGQiLAorICAgICAgICAgICAg YWN0aW9uPSJzdG9yZV90cnVlIiwgZGVmYXVsdD1UcnVlLAorICAgICAgICAgICAgaGVscD0iY2hl Y2sgdG8gZW5zdXJlIHRoZSBidWlsZCBpcyB1cC10by1kYXRlIChkZWZhdWx0KS4iKSwKKyAgICAg ICAgb3B0cGFyc2UubWFrZV9vcHRpb24oIi0tbm8tY2hlY2stYnVpbGQiLCBkZXN0PSJjaGVja19i dWlsZCIsCisgICAgICAgICAgICBhY3Rpb249InN0b3JlX2ZhbHNlIiwKKyAgICAgICAgICAgIGhl bHA9ImRvbid0IGNoZWNrIHRvIHNlZSBpZiB0aGUgYnVpbGQgaXMgdXAtdG8tZGF0ZS4iKSwKICAg ICAgICAgIyBvbGQtcnVuLXdlYmtpdC10ZXN0cyBoYXMgLS12YWxncmluZCBpbnN0ZWFkIG9mIHdy YXBwZXIuCiAgICAgICAgIG9wdHBhcnNlLm1ha2Vfb3B0aW9uKCItLXdyYXBwZXIiLAogICAgICAg ICAgICAgaGVscD0id3JhcHBlciBjb21tYW5kIHRvIGluc2VydCBiZWZvcmUgaW52b2NhdGlvbnMg b2YgIgo= 53727 2010-04-19 15:16:55 -0700 2010-04-19 16:48:25 -0700 revise w/ ojan's feedback (rename --check-build to --build) wk37786_skip_build.diff text/plain 2782 dpranke ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA5OThhNmQzLi42NjNkZTJlIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDQt MTggIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgbmV3LXJ1bi13ZWJraXQtdGVzdHM6IGFk ZCAtLWJ1aWxkIChkZWZhdWx0KSBhbmQgLS1uby1idWlsZAorICAgICAgICBvcHRpb25zIHRvIG1h a2UgdGhhdCBzdGVwIG9wdGlvbmFsLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0zNzc4NgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlv dXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0cy5weToKKwogMjAxMC0wNC0xNSAgU2FtIFdlaW5pZyAg PHNhbUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFuZGVycyBDYXJsc3Nvbi4K ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3Bv cnQvY2hyb21pdW0ucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0 cy9wb3J0L2Nocm9taXVtLnB5CmluZGV4IGI2NjE4NGMuLjVhOGNmYmQgMTAwNjQ0Ci0tLSBhL1dl YktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW0ucHkK KysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJv bWl1bS5weQpAQCAtODAsNyArODAsNyBAQCBjbGFzcyBDaHJvbWl1bVBvcnQoYmFzZS5Qb3J0KToK ICAgICAgICAgZHVtcF9yZW5kZXJfdHJlZV9iaW5hcnlfcGF0aCA9IHNlbGYuX3BhdGhfdG9fZHJp dmVyKCkKICAgICAgICAgcmVzdWx0ID0gY2hlY2tfZmlsZV9leGlzdHMoZHVtcF9yZW5kZXJfdHJl ZV9iaW5hcnlfcGF0aCwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJ3Rlc3Qg ZHJpdmVyJykKLSAgICAgICAgaWYgcmVzdWx0OgorICAgICAgICBpZiByZXN1bHQgYW5kIHNlbGYu X29wdGlvbnMuYnVpbGQ6CiAgICAgICAgICAgICByZXN1bHQgPSAoc2VsZi5fY2hlY2tfZHJpdmVy X2J1aWxkX3VwX3RvX2RhdGUoc2VsZi5fb3B0aW9ucy5jb25maWd1cmF0aW9uKQogICAgICAgICAg ICAgICAgICAgICAgIGFuZCByZXN1bHQpCiAgICAgICAgIGVsc2U6CmRpZmYgLS1naXQgYS9XZWJL aXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3dlYmtpdC5weSBiL1dl YktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvd2Via2l0LnB5Cmlu ZGV4IGQxMGZhOTAuLmNmNjE0NTUgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvd2Via2l0LnB5CisrKyBiL1dlYktpdFRvb2xzL1Njcmlw dHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvd2Via2l0LnB5CkBAIC04OSw3ICs4OSw3IEBA IGNsYXNzIFdlYktpdFBvcnQoYmFzZS5Qb3J0KToKICAgICAgICAgcmV0dXJuIFRydWUKIAogICAg IGRlZiBjaGVja19idWlsZChzZWxmLCBuZWVkc19odHRwKToKLSAgICAgICAgaWYgbm90IHNlbGYu X2J1aWxkX2RyaXZlcigpOgorICAgICAgICBpZiBzZWxmLl9vcHRpb25zLmJ1aWxkIGFuZCBub3Qg c2VsZi5fYnVpbGRfZHJpdmVyKCk6CiAgICAgICAgICAgICByZXR1cm4gRmFsc2UKICAgICAgICAg aWYgbm90IHNlbGYuX2NoZWNrX2RyaXZlcigpOgogICAgICAgICAgICAgcmV0dXJuIEZhbHNlCmRp ZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5f d2Via2l0X3Rlc3RzLnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVz dHMvcnVuX3dlYmtpdF90ZXN0cy5weQppbmRleCAwNTlmZDA5Li4yZTE2YTgxIDEwMDc1NQotLS0g YS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rl c3RzLnB5CisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1 bl93ZWJraXRfdGVzdHMucHkKQEAgLTE2MzgsNiArMTYzOCwxMiBAQCBkZWYgcGFyc2VfYXJncyhh cmdzPU5vbmUpOgogICAgIF0KIAogICAgIHRlc3Rfb3B0aW9ucyA9IFsKKyAgICAgICAgb3B0cGFy c2UubWFrZV9vcHRpb24oIi0tYnVpbGQiLCBkZXN0PSJidWlsZCIsCisgICAgICAgICAgICBhY3Rp b249InN0b3JlX3RydWUiLCBkZWZhdWx0PVRydWUsCisgICAgICAgICAgICBoZWxwPSJjaGVjayB0 byBlbnN1cmUgdGhlIGJ1aWxkIGlzIHVwLXRvLWRhdGUgKGRlZmF1bHQpLiIpLAorICAgICAgICBv cHRwYXJzZS5tYWtlX29wdGlvbigiLS1uby1idWlsZCIsIGRlc3Q9ImJ1aWxkIiwKKyAgICAgICAg ICAgIGFjdGlvbj0ic3RvcmVfZmFsc2UiLAorICAgICAgICAgICAgaGVscD0iZG9uJ3QgY2hlY2sg dG8gc2VlIGlmIHRoZSBidWlsZCBpcyB1cC10by1kYXRlLiIpLAogICAgICAgICAjIG9sZC1ydW4t d2Via2l0LXRlc3RzIGhhcyAtLXZhbGdyaW5kIGluc3RlYWQgb2Ygd3JhcHBlci4KICAgICAgICAg b3B0cGFyc2UubWFrZV9vcHRpb24oIi0td3JhcHBlciIsCiAgICAgICAgICAgICBoZWxwPSJ3cmFw cGVyIGNvbW1hbmQgdG8gaW5zZXJ0IGJlZm9yZSBpbnZvY2F0aW9ucyBvZiAiCg== 53738 2010-04-19 16:45:56 -0700 2010-04-19 16:48:56 -0700 tweak the help text, changelog wk37786_skip_build.diff text/plain 3011 dpranke ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA5OThhNmQzLi43ZjIxNGYwIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTAtMDQt MTggIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgbmV3LXJ1bi13ZWJraXQtdGVzdHM6IGFk ZCAtLWJ1aWxkIChkZWZhdWx0KSBhbmQgLS1uby1idWlsZAorICAgICAgICBvcHRpb25zIHRvIG1h a2UgdGhhdCBzdGVwIG9wdGlvbmFsLiBUaGlzIGZsYWcgbW9kaWZpZXMgd2hhdCBoYXBwZW5zCisg ICAgICAgIGluIHBvcnQuY2hlY2tfYnVpbGQoKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzc3ODYKKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0 cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHMucHk6CisgICAgICAgICogU2NyaXB0cy93 ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bS5weToKKyAgICAgICAgKiBTY3JpcHRz L3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3dlYmtpdC5weToKKwogMjAxMC0wNC0xNSAgU2Ft IFdlaW5pZyAgPHNhbUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFuZGVycyBD YXJsc3Nvbi4KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0 X3Rlc3RzL3BvcnQvY2hyb21pdW0ucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xh eW91dF90ZXN0cy9wb3J0L2Nocm9taXVtLnB5CmluZGV4IGI2NjE4NGMuLjVhOGNmYmQgMTAwNjQ0 Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hy b21pdW0ucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMv cG9ydC9jaHJvbWl1bS5weQpAQCAtODAsNyArODAsNyBAQCBjbGFzcyBDaHJvbWl1bVBvcnQoYmFz ZS5Qb3J0KToKICAgICAgICAgZHVtcF9yZW5kZXJfdHJlZV9iaW5hcnlfcGF0aCA9IHNlbGYuX3Bh dGhfdG9fZHJpdmVyKCkKICAgICAgICAgcmVzdWx0ID0gY2hlY2tfZmlsZV9leGlzdHMoZHVtcF9y ZW5kZXJfdHJlZV9iaW5hcnlfcGF0aCwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgJ3Rlc3QgZHJpdmVyJykKLSAgICAgICAgaWYgcmVzdWx0OgorICAgICAgICBpZiByZXN1bHQg YW5kIHNlbGYuX29wdGlvbnMuYnVpbGQ6CiAgICAgICAgICAgICByZXN1bHQgPSAoc2VsZi5fY2hl Y2tfZHJpdmVyX2J1aWxkX3VwX3RvX2RhdGUoc2VsZi5fb3B0aW9ucy5jb25maWd1cmF0aW9uKQog ICAgICAgICAgICAgICAgICAgICAgIGFuZCByZXN1bHQpCiAgICAgICAgIGVsc2U6CmRpZmYgLS1n aXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3dlYmtp dC5weSBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvd2Vi a2l0LnB5CmluZGV4IGQxMGZhOTAuLmNmNjE0NTUgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1Nj cmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvd2Via2l0LnB5CisrKyBiL1dlYktpdFRv b2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvd2Via2l0LnB5CkBAIC04OSw3 ICs4OSw3IEBAIGNsYXNzIFdlYktpdFBvcnQoYmFzZS5Qb3J0KToKICAgICAgICAgcmV0dXJuIFRy dWUKIAogICAgIGRlZiBjaGVja19idWlsZChzZWxmLCBuZWVkc19odHRwKToKLSAgICAgICAgaWYg bm90IHNlbGYuX2J1aWxkX2RyaXZlcigpOgorICAgICAgICBpZiBzZWxmLl9vcHRpb25zLmJ1aWxk IGFuZCBub3Qgc2VsZi5fYnVpbGRfZHJpdmVyKCk6CiAgICAgICAgICAgICByZXR1cm4gRmFsc2UK ICAgICAgICAgaWYgbm90IHNlbGYuX2NoZWNrX2RyaXZlcigpOgogICAgICAgICAgICAgcmV0dXJu IEZhbHNlCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90 ZXN0cy9ydW5fd2Via2l0X3Rlc3RzLnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9s YXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0cy5weQppbmRleCAwNTlmZDA5Li45MDZlMjg4IDEw MDc1NQotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5f d2Via2l0X3Rlc3RzLnB5CisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0 X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHMucHkKQEAgLTE2MzgsNiArMTYzOCwxMyBAQCBkZWYgcGFy c2VfYXJncyhhcmdzPU5vbmUpOgogICAgIF0KIAogICAgIHRlc3Rfb3B0aW9ucyA9IFsKKyAgICAg ICAgb3B0cGFyc2UubWFrZV9vcHRpb24oIi0tYnVpbGQiLCBkZXN0PSJidWlsZCIsCisgICAgICAg ICAgICBhY3Rpb249InN0b3JlX3RydWUiLCBkZWZhdWx0PVRydWUsCisgICAgICAgICAgICBoZWxw PSJDaGVjayB0byBlbnN1cmUgdGhlIER1bXBSZW5kZXJUcmVlIGJ1aWxkIGlzIHVwLXRvLWRhdGUg IgorICAgICAgICAgICAgIihkZWZhdWx0KS4iKSwKKyAgICAgICAgb3B0cGFyc2UubWFrZV9vcHRp b24oIi0tbm8tYnVpbGQiLCBkZXN0PSJidWlsZCIsCisgICAgICAgICAgICBhY3Rpb249InN0b3Jl X2ZhbHNlIiwgaGVscD0iRG9uJ3QgY2hlY2sgdG8gc2VlIGlmIHRoZSAiCisgICAgICAgICAgICAi RHVtcFJlbmRlclRyZWUgYnVpbGQgaXMgdXAtdG8tZGF0ZS4iKSwKICAgICAgICAgIyBvbGQtcnVu LXdlYmtpdC10ZXN0cyBoYXMgLS12YWxncmluZCBpbnN0ZWFkIG9mIHdyYXBwZXIuCiAgICAgICAg IG9wdHBhcnNlLm1ha2Vfb3B0aW9uKCItLXdyYXBwZXIiLAogICAgICAgICAgICAgaGVscD0id3Jh cHBlciBjb21tYW5kIHRvIGluc2VydCBiZWZvcmUgaW52b2NhdGlvbnMgb2YgIgo=