37785 2010-04-18 17:43:04 -0700 new-run-webkit-tests: add more --log options 2010-04-19 14:39:53 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 dpranke dpranke abarth cjerdonek eric ojan tony oldest_to_newest 213868 0 dpranke 2010-04-18 17:43:04 -0700 We should add options to be able to turn off and on all of the blocks that are sent to stderr. Most are currently configurable, but we can't turn off the default progress meter, or the unexpected results or the summary at the end of the run. It would also be good to have a way to indicate that you explicitly want nothing logged (--log '' can be easily lost in shell escaping mechanisms). 213869 1 53647 dpranke 2010-04-18 17:43:38 -0700 Created attachment 53647 Patch 213925 2 53647 eric 2010-04-19 00:07:33 -0700 Comment on attachment 53647 Patch Seems strange that some of these are constants and some are not: LOG_VALUES = ",".join(("actual", "config", LOG_DETAILED_PROGRESS, "expected", 100 LOG_NOTHING, LOG_PROGRESS, LOG_SUMMARY, "timing", 101 LOG_UNEXPECTED, LOG_UNEXPECTED_RESULTS)) Seems OK. I don't know much about python's built in logging. I wonder if we're re-inventing any of that here. 213937 3 cjerdonek 2010-04-19 00:47:23 -0700 (In reply to comment #2) > (From update of attachment 53647 [details]) > Seems strange that some of these are constants and some are not: > LOG_VALUES = ",".join(("actual", "config", LOG_DETAILED_PROGRESS, "expected", > 100 LOG_NOTHING, LOG_PROGRESS, LOG_SUMMARY, "timing", > 101 LOG_UNEXPECTED, LOG_UNEXPECTED_RESULTS)) > > Seems OK. I don't know much about python's built in logging. I wonder if > we're re-inventing any of that here. I was wondering that myself. The logging module allows one to turn various loggers on and off using different techniques when configuring logging (e.g. by name using the name hierarchy, based on the message, etc). By the way, a function (e.g. log_values()) might be more appropriate here than a constant built from other constants. 214251 4 dpranke 2010-04-19 14:38:09 -0700 (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 53647 [details] [details]) > > Seems strange that some of these are constants and some are not: > > LOG_VALUES = ",".join(("actual", "config", LOG_DETAILED_PROGRESS, "expected", > > 100 LOG_NOTHING, LOG_PROGRESS, LOG_SUMMARY, "timing", > > 101 LOG_UNEXPECTED, LOG_UNEXPECTED_RESULTS)) > > > > Seems OK. I don't know much about python's built in logging. I wonder if > > we're re-inventing any of that here. > > I was wondering that myself. The logging module allows one to turn various > loggers on and off using different techniques when configuring logging (e.g. by > name using the name hierarchy, based on the message, etc). > From my limited looking at the logging docs, it looked like it would be a lot more cumbersome, if possible at all. > By the way, a function (e.g. log_values()) might be more appropriate here than > a constant built from other constants. This whole thing is about to get rewritten to be easier to maintain, so I'll deal with it then. 214252 5 53647 dpranke 2010-04-19 14:39:48 -0700 Comment on attachment 53647 Patch Clearing flags on attachment: 53647 Committed r57840: <http://trac.webkit.org/changeset/57840> 214253 6 dpranke 2010-04-19 14:39:53 -0700 All reviewed patches have been landed. Closing bug. 53647 2010-04-18 17:43:38 -0700 2010-04-19 14:39:47 -0700 Patch bug-37785-20100418174337.patch text/plain 5167 dpranke ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA5OThhNmQzLi4yY2VjY2YxIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjYgQEAKKzIwMTAtMDQt MTggIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgbmV3LXJ1bi13ZWJraXQtdGVzdHM6IGFk ZCAnc3VtbWFyeScgYW5kICd1bmV4cGVjdGVkLXJlc3VsdHMnIG9wdGlvbnMKKyAgICAgICAgdG8g dGhlIC0tbG9nIGZsYWcuIEFsc28gYWRkIGEgJ3Byb2dyZXNzJyBmbGFnIHRvIGVuYWJsZSB0aGUg cmVndWxhcgorICAgICAgICBwcm9ncmVzcyBiYXIgKGFzIG9wcG9zZWQgdG8gJ2RldGFpbGVkLXBy b2dyZXNzJywgd2hpY2ggZW5hYmxlcyB0aGUKKyAgICAgICAgZG90cykuIEFsc28gYWRkIGEgJ25v dGhpbmcnIGZsYWcgdG8gYWxsb3cgeW91IHRvIGJlIGV4cGxpY2l0IHRoYXQKKyAgICAgICAgeW91 IGRvbid0IHdhbnQgYW55IGxvZ2dpbmcgb24gdGhlIGNvbW1hbmQgbGluZS4KKworICAgICAgICBU aGUgZGVmYXVsdCBpcworICAgICAgICAnLS1sb2cgZGV0YWlsZWQtcHJvZ3Jlc3Msc3VtbWFyeSx1 bmV4cGVjdGVkLHVuZXhwZWN0ZWQtcmVzdWx0cycKKworICAgICAgICAoVGhlIGRlZmF1bHQgbG9n Z2luZyBpcyB1bmNoYW5nZWQgYnkgdGhpcyBwYXRjaCwgdGhpcyBqdXN0IG1ha2VzIHRoaW5ncwor ICAgICAgICBwcm9wZXJseSBjb25maWd1cmFibGUpLgorCisgICAgICAgIE5vdGUgdGhhdCAnbm90 aGluZycgZG9lc24ndCB3b3JrIHByb3Blcmx5IHlldDsgSSBuZWVkIGEgY291cGxlIG90aGVyCisg ICAgICAgIHBhdGNoZXMgdG8gbGFuZCB0byBhdm9pZCByZXdyaXRpbmcgdGhpbmdzIHNldmVyYWwg ZGlmZmVyZW50IHdheXMuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTM3Nzg1CisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0 cy9ydW5fd2Via2l0X3Rlc3RzLnB5OgorCiAyMDEwLTA0LTE1ICBTYW0gV2VpbmlnICA8c2FtQHdl YmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQW5kZXJzIENhcmxzc29uLgpkaWZmIC0t Z2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtp dF90ZXN0cy5weSBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1 bl93ZWJraXRfdGVzdHMucHkKaW5kZXggMDU5ZmQwOS4uMWIwZjk3ZCAxMDA3NTUKLS0tIGEvV2Vi S2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0cy5w eQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5fd2Vi a2l0X3Rlc3RzLnB5CkBAIC03NywxMyArNzcsMzAgQEAgaW1wb3J0IHBvcnQKIAogX2xvZyA9IGxv Z2dpbmcuZ2V0TG9nZ2VyKCJ3ZWJraXRweS5sYXlvdXRfdGVzdHMucnVuX3dlYmtpdF90ZXN0cyIp CiAKKyMgZHVtbXkgdmFsdWUgdXNlZCBmb3IgY29tbWFuZC1saW5lIGV4cGxpY2l0bmVzcyB0byBk aXNhYmxlIGRlZmF1bHRzCitMT0dfTk9USElORyA9ICdub3RoaW5nJworCisjIERpc3BsYXkgdGhl IG9uZS1saW5lIHByb2dyZXNzIGJhciAoJSBjb21wbGV0ZWQpIHdoaWxlIHRlc3RpbmcKK0xPR19Q Uk9HUkVTUyA9ICdwcm9ncmVzcycKKwogIyBJbmRpY2F0ZXMgdGhhdCB3ZSB3YW50IGRldGFpbGVk IHByb2dyZXNzIHVwZGF0ZXMgaW4gdGhlIG91dHB1dCAocHJpbnRzCiAjIGRpcmVjdG9yeS1ieS1k aXJlY3RvcnkgZmVlZGJhY2spLgogTE9HX0RFVEFJTEVEX1BST0dSRVNTID0gJ2RldGFpbGVkLXBy b2dyZXNzJwogCisjIExvZyB0aGUgb25lLWxpbmUgc3VtbWFyeSBhdCB0aGUgZW5kIG9mIHRoZSBy dW4KK0xPR19TVU1NQVJZID0gJ3N1bW1hcnknCisKICMgTG9nIGFueSB1bmV4cGVjdGVkIHJlc3Vs dHMgd2hpbGUgcnVubmluZyAoaW5zdGVhZCBvZiBqdXN0IGF0IHRoZSBlbmQpLgogTE9HX1VORVhQ RUNURUQgPSAndW5leHBlY3RlZCcKIAorIyBMb2cgYW55IHVuZXhwZWN0ZWQgcmVzdWx0cyBhdCB0 aGUgZW5kCitMT0dfVU5FWFBFQ1RFRF9SRVNVTFRTID0gJ3VuZXhwZWN0ZWRfcmVzdWx0cycKKwor TE9HX1ZBTFVFUyA9ICIsIi5qb2luKCgiYWN0dWFsIiwgImNvbmZpZyIsIExPR19ERVRBSUxFRF9Q Uk9HUkVTUywgImV4cGVjdGVkIiwKKyAgICAgICAgICAgICAgICAgICAgICBMT0dfTk9USElORywg TE9HX1BST0dSRVNTLCBMT0dfU1VNTUFSWSwgInRpbWluZyIsCisgICAgICAgICAgICAgICAgICAg ICAgTE9HX1VORVhQRUNURUQsIExPR19VTkVYUEVDVEVEX1JFU1VMVFMpKQorTE9HX0RFRkFVTFRf VkFMVUUgPSAiZGV0YWlsZWQtcHJvZ3Jlc3Msc3VtbWFyeSx1bmV4cGVjdGVkLHVuZXhwZWN0ZWQt cmVzdWx0cyIKKwogIyBCdWlsZGVyIGJhc2UgVVJMIHdoZXJlIHdlIGhhdmUgdGhlIGFyY2hpdmVk IHRlc3QgcmVzdWx0cy4KIEJVSUxERVJfQkFTRV9VUkwgPSAiaHR0cDovL2J1aWxkLmNocm9taXVt Lm9yZy9idWlsZGJvdC9sYXlvdXRfdGVzdF9yZXN1bHRzLyIKIApAQCAtNjc1LDEyICs2OTIsMTQg QEAgY2xhc3MgVGVzdFJ1bm5lcjoKICAgICAgICAgICAgICAgICAoTE9HX1VORVhQRUNURUQgaW4g c2VsZi5fb3B0aW9ucy5sb2cgYW5kCiAgICAgICAgICAgICAgICAgIHJlc3VsdF9zdW1tYXJ5LnRv dGFsICE9IHJlc3VsdF9zdW1tYXJ5LmV4cGVjdGVkKSk6CiAgICAgICAgICAgICAgICAgcHJpbnQK LSAgICAgICAgICAgIHNlbGYuX3ByaW50X29uZV9saW5lX3N1bW1hcnkocmVzdWx0X3N1bW1hcnku dG90YWwsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHJlc3VsdF9z dW1tYXJ5LmV4cGVjdGVkKQorICAgICAgICAgICAgaWYgTE9HX1NVTU1BUlkgaW4gc2VsZi5fb3B0 aW9ucy5sb2c6CisgICAgICAgICAgICAgICAgc2VsZi5fcHJpbnRfb25lX2xpbmVfc3VtbWFyeShy ZXN1bHRfc3VtbWFyeS50b3RhbCwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIHJlc3VsdF9zdW1tYXJ5LmV4cGVjdGVkKQogCiAgICAgICAgIHVuZXhwZWN0ZWRf cmVzdWx0cyA9IHNlbGYuX3N1bW1hcml6ZV91bmV4cGVjdGVkX3Jlc3VsdHMocmVzdWx0X3N1bW1h cnksCiAgICAgICAgICAgICByZXRyeV9zdW1tYXJ5KQotICAgICAgICBzZWxmLl9wcmludF91bmV4 cGVjdGVkX3Jlc3VsdHModW5leHBlY3RlZF9yZXN1bHRzKQorICAgICAgICBpZiBMT0dfVU5FWFBF Q1RFRF9SRVNVTFRTIGluIHNlbGYuX29wdGlvbnMubG9nOgorICAgICAgICAgICAgc2VsZi5fcHJp bnRfdW5leHBlY3RlZF9yZXN1bHRzKHVuZXhwZWN0ZWRfcmVzdWx0cykKIAogICAgICAgICAjIFdy aXRlIHRoZSBzYW1lIGRhdGEgdG8gbG9nIGZpbGVzLgogICAgICAgICBzZWxmLl93cml0ZV9qc29u X2ZpbGVzKHVuZXhwZWN0ZWRfcmVzdWx0cywgcmVzdWx0X3N1bW1hcnksCkBAIC03MTEsNyArNzMw LDggQEAgY2xhc3MgVGVzdFJ1bm5lcjoKICAgICAgICAgICAgICAgICBlbHNlOgogICAgICAgICAg ICAgICAgICAgICBpZiBub3QgZXhwZWN0ZWQgYW5kIExPR19VTkVYUEVDVEVEIGluIHNlbGYuX29w dGlvbnMubG9nOgogICAgICAgICAgICAgICAgICAgICAgICAgc2VsZi5fcHJpbnRfdW5leHBlY3Rl ZF90ZXN0X3Jlc3VsdCh0ZXN0LCByZXN1bHQpCi0gICAgICAgICAgICAgICAgICAgIHNlbGYuX2Rp c3BsYXlfb25lX2xpbmVfcHJvZ3Jlc3MocmVzdWx0X3N1bW1hcnkpCisgICAgICAgICAgICAgICAg ICAgIGlmIExPR19QUk9HUkVTUyBpbiBzZWxmLl9vcHRpb25zLmxvZzoKKyAgICAgICAgICAgICAg ICAgICAgICAgIHNlbGYuX2Rpc3BsYXlfb25lX2xpbmVfcHJvZ3Jlc3MocmVzdWx0X3N1bW1hcnkp CiAgICAgICAgICAgICBleGNlcHQgUXVldWUuRW1wdHk6CiAgICAgICAgICAgICAgICAgcmV0dXJu CiAKQEAgLTE1NTYsMTMgKzE1NzYsMTEgQEAgZGVmIHBhcnNlX2FyZ3MoYXJncz1Ob25lKToKIAog ICAgIGxvZ2dpbmdfb3B0aW9ucyA9IFsKICAgICAgICAgb3B0cGFyc2UubWFrZV9vcHRpb24oIi0t bG9nIiwgYWN0aW9uPSJzdG9yZSIsCi0gICAgICAgICAgICBkZWZhdWx0PSJkZXRhaWxlZC1wcm9n cmVzcyx1bmV4cGVjdGVkIiwKLSAgICAgICAgICAgIGhlbHA9ImxvZyB2YXJpb3VzIHR5cGVzIG9m IGRhdGEuIFRoZSBwYXJhbSBzaG91bGQgYmUgYSAiICsKLSAgICAgICAgICAgICAgICAgImNvbW1h LXNlcGFyYXRlZCBsaXN0IG9mIHZhbHVlcyBmcm9tOiAiICsKLSAgICAgICAgICAgICAgICAgImFj dHVhbCxjb25maWcsIiArIExPR19ERVRBSUxFRF9QUk9HUkVTUyArCi0gICAgICAgICAgICAgICAg ICIsZXhwZWN0ZWQsdGltaW5nLCIgKyBMT0dfVU5FWFBFQ1RFRCArICIgIiArCi0gICAgICAgICAg ICAgICAgICIoZGVmYXVsdHMgdG8gIiArICItLWxvZyBkZXRhaWxlZC1wcm9ncmVzcyx1bmV4cGVj dGVkKSIpLAotICAgICAgICBvcHRwYXJzZS5tYWtlX29wdGlvbigiLXYiLCAiLS12ZXJib3NlIiwg YWN0aW9uPSJzdG9yZV90cnVlIiwKKyAgICAgICAgICAgIGRlZmF1bHQ9TE9HX0RFRkFVTFRfVkFM VUUsCisgICAgICAgICAgICBoZWxwPSgibG9nIHZhcmlvdXMgdHlwZXMgb2YgZGF0YS4gVGhlIGFy Z3VtZW50IHZhbHVlIHNob3VsZCBiZSBhICIKKyAgICAgICAgICAgICAgICAgICJjb21tYS1zZXBh cmF0ZWQgbGlzdCBvZiB2YWx1ZXMgZnJvbTogJXMgKGRlZmF1bHRzIHRvICIKKyAgICAgICAgICAg ICAgICAgICItLWxvZyAlcykiICUgKExPR19WQUxVRVMsIExPR19ERUZBVUxUX1ZBTFVFKSkpLAor ICAgICAgIG9wdHBhcnNlLm1ha2Vfb3B0aW9uKCItdiIsICItLXZlcmJvc2UiLCBhY3Rpb249InN0 b3JlX3RydWUiLAogICAgICAgICAgICAgZGVmYXVsdD1GYWxzZSwgaGVscD0iaW5jbHVkZSBkZWJ1 Zy1sZXZlbCBsb2dnaW5nIiksCiAgICAgICAgIG9wdHBhcnNlLm1ha2Vfb3B0aW9uKCItLXNvdXJj ZXMiLCBhY3Rpb249InN0b3JlX3RydWUiLAogICAgICAgICAgICAgaGVscD0ic2hvdyBleHBlY3Rl ZCByZXN1bHQgZmlsZSBwYXRoIGZvciBlYWNoIHRlc3QgIiArCg==