37780 2010-04-18 16:04:22 -0700 new-run-webkit-tests: some messages need to be preserved in --verbose mode 2010-04-19 14:41:19 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 37643 1 dpranke dpranke abarth cjerdonek eric mjs ojan oldest_to_newest 213835 0 dpranke 2010-04-18 16:04:22 -0700 A bunch of messages are currently disabled in --verbose mode; this means we lose profiling information. We should log all messages except for the ones that are truly incremental progress-style updates. 213838 1 53641 dpranke 2010-04-18 16:09:38 -0700 Created attachment 53641 Patch 213929 2 53641 eric 2010-04-19 00:10:57 -0700 Comment on attachment 53641 Patch OK. 214039 3 ojan 2010-04-19 08:26:13 -0700 This patch is fine. I think we should try to move in the direction of --verbose just implying --log all or something like that. 214103 4 dpranke 2010-04-19 10:42:29 -0700 (In reply to comment #3) > This patch is fine. I think we should try to move in the direction of --verbose > just implying --log all or something like that. It more or less does, except it turns off the progress bars. 214255 5 53641 dpranke 2010-04-19 14:41:14 -0700 Comment on attachment 53641 Patch Clearing flags on attachment: 53641 Committed r57841: <http://trac.webkit.org/changeset/57841> 214256 6 dpranke 2010-04-19 14:41:19 -0700 All reviewed patches have been landed. Closing bug. 53641 2010-04-18 16:09:38 -0700 2010-04-19 14:41:14 -0700 Patch bug-37780-20100418160937.patch text/plain 5515 dpranke ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA5OThhNmQzLi5iZDk5ZTRlIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDQt MTggIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVzdHJ1Y3R1cmUgdGhlIGxvZ2dpbmcg aW4gbmV3LXJ1bi13ZWJraXQtdGVzdHMgc28gdGhhdCBtYW55IG9mIGxvZworICAgICAgICBtZXNz YWdlcyB0aGF0IHdlcmUgbG9nZ2VkIHRvIHRoZSBNZXRlcmVkU3RyZWFtIGFsc28gZ2V0IGxvZ2dl ZCBpbgorICAgICAgICAtLXZlcmJvc2UgbW9kZS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzc3ODAKKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0 cHkvbGF5b3V0X3Rlc3RzL2xheW91dF9wYWNrYWdlL21ldGVyZWRfc3RyZWFtLnB5OgorICAgICAg ICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHMucHk6CisK IDIwMTAtMDQtMTUgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZp ZXdlZCBieSBBbmRlcnMgQ2FybHNzb24uCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRz L3dlYmtpdHB5L2xheW91dF90ZXN0cy9sYXlvdXRfcGFja2FnZS9tZXRlcmVkX3N0cmVhbS5weSBi L1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2xheW91dF9wYWNrYWdl L21ldGVyZWRfc3RyZWFtLnB5CmluZGV4IDcyYjMwYTEuLjkzMGI5ZTQgMTAwNjQ0Ci0tLSBhL1dl YktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2xheW91dF9wYWNrYWdlL21l dGVyZWRfc3RyZWFtLnB5CisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0 X3Rlc3RzL2xheW91dF9wYWNrYWdlL21ldGVyZWRfc3RyZWFtLnB5CkBAIC0zNCw2ICszNCwxMCBA QCBhbmQgcmV3cml0dGVuIHJlcGVhdGVkbHksIHdpdGhvdXQgcHJvZHVjaW5nIG11bHRpcGxlIGxp bmVzIG9mIG91dHB1dC4gSXQKIGNhbiBiZSB1c2VkIHRvIHByb2R1Y2UgZWZmZWN0cyBsaWtlIHBy b2dyZXNzIGJhcnMuCiAiIiIKIAoraW1wb3J0IGxvZ2dpbmcKKworX2xvZyA9IGxvZ2dpbmcuZ2V0 TG9nZ2VyKCJ3ZWJraXRweS5sYXlvdXRfdGVzdHMubWV0ZXJlZF9zdHJlYW0iKQorCiAKIGNsYXNz IE1ldGVyZWRTdHJlYW06CiAgICAgIiIiVGhpcyBjbGFzcyBpcyBhIHdyYXBwZXIgYXJvdW5kIGEg c3RyZWFtIHRoYXQgYWxsb3dzIHlvdSB0byBpbXBsZW1lbnQKQEAgLTU3LDggKzYxLDcgQEAgY2xh c3MgTWV0ZXJlZFN0cmVhbToKICAgICAgICAgc2VsZi5fbGFzdF91cGRhdGUgPSAiIgogCiAgICAg ZGVmIHdyaXRlKHNlbGYsIHR4dCk6Ci0gICAgICAgICIiIldyaXRlIHRleHQgZGlyZWN0bHkgdG8g dGhlIHN0cmVhbSwgb3ZlcndyaXRpbmcgYW5kIHJlc2V0dGluZyB0aGUKLSAgICAgICAgbWV0ZXIu IiIiCisgICAgICAgICIiIldyaXRlIHRvIHRoZSBzdHJlYW0sIG92ZXJ3cml0aW5nIGFuZCByZXNl dHRpbmcgdGhlIG1ldGVyLiIiIgogICAgICAgICBpZiBzZWxmLl9kaXJ0eToKICAgICAgICAgICAg IHNlbGYudXBkYXRlKCIiKQogICAgICAgICAgICAgc2VsZi5fZGlydHkgPSBGYWxzZQpAQCAtNjgs MjIgKzcxLDQzIEBAIGNsYXNzIE1ldGVyZWRTdHJlYW06CiAgICAgICAgICIiIkZsdXNoIGFueSBi dWZmZXJlZCBvdXRwdXQuIiIiCiAgICAgICAgIHNlbGYuX3N0cmVhbS5mbHVzaCgpCiAKLSAgICBk ZWYgdXBkYXRlKHNlbGYsIHN0cik6Ci0gICAgICAgICIiIldyaXRlIGFuIHVwZGF0ZSB0byB0aGUg c3RyZWFtIHRoYXQgd2lsbCBnZXQgb3ZlcndyaXR0ZW4gYnkgdGhlIG5leHQKLSAgICAgICAgdXBk YXRlKCkgb3IgYnkgYSB3cml0ZSgpLgorICAgIGRlZiBwcm9ncmVzcyhzZWxmLCBzdHIpOgorICAg ICAgICAiIiIKKyAgICAgICAgV3JpdGUgYSBtZXNzYWdlIHRvIHRoZSBzdHJlYW0gdGhhdCB3aWxs IGdldCBvdmVyd3JpdHRlbi4KIAogICAgICAgICBUaGlzIGlzIHVzZWQgZm9yIHByb2dyZXNzIHVw ZGF0ZXMgdGhhdCBkb24ndCBuZWVkIHRvIGJlIHByZXNlcnZlZCBpbgotICAgICAgICB0aGUgbG9n LiBOb3RlIHRoYXQgdmVyYm9zZSBkaXNhYmxlcyB0aGlzIHJvdXRpbmU7IHdlIGhhdmUgdGhpcyBp bgotICAgICAgICBjYXNlIHdlIGFyZSBsb2dnaW5nIGxvdHMgb2Ygb3V0cHV0IGFuZCB0aGUgdXBk YXRlKClzIHdpbGwgZ2V0IGxvc3QKLSAgICAgICAgb3Igd29uJ3Qgd29yayBwcm9wZXJseSAodHlw aWNhbGx5IGJlY2F1c2UgdmVyYm9zZSBzdHJlYW1zIGFyZQotICAgICAgICByZWRpcmVjdGVkIHRv IGZpbGVzLgotCi0gICAgICAgIFRPRE8oZHByYW5rZSk6IGZpZ3VyZSBvdXQgaWYgdGhlcmUgaXMg YSB3YXkgdG8gZGV0ZWN0IGlmIHdlJ3JlIHdyaXRpbmcKLSAgICAgICAgdG8gYSBzdHJlYW0gdGhh dCBoYW5kbGVzIENScyBjb3JyZWN0bHkgKGUuZy4sIHRlcm1pbmFscykuIFRoYXQgbWlnaHQKLSAg ICAgICAgYmUgYSBjbGVhbmVyIHdheSBvZiBoYW5kbGluZyB0aGlzLgorICAgICAgICB0aGUgbG9n LiBJZiB0aGUgTWV0ZXJlZFN0cmVhbSB3YXMgaW5pdGlhbGl6ZWQgd2l0aCB2ZXJib3NlPT1UcnVl LAorICAgICAgICB0aGVuIHRoaXMgb3V0cHV0IGlzIGRpc2NhcmRlZC4gV2UgaGF2ZSB0aGlzIGlu IGNhc2Ugd2UgYXJlIGxvZ2dpbmcKKyAgICAgICAgbG90cyBvZiBvdXRwdXQgYW5kIHRoZSB1cGRh dGUoKXMgd2lsbCBnZXQgbG9zdCBvciB3b24ndCB3b3JrCisgICAgICAgIHByb3Blcmx5ICh0eXBp Y2FsbHkgYmVjYXVzZSB2ZXJib3NlIHN0cmVhbXMgYXJlIHJlZGlyZWN0ZWQgdG8gZmlsZXMpLgor CiAgICAgICAgICIiIgogICAgICAgICBpZiBzZWxmLl92ZXJib3NlOgogICAgICAgICAgICAgcmV0 dXJuCisgICAgICAgIHNlbGYuX3dyaXRlKHN0cikKKworICAgIGRlZiB1cGRhdGUoc2VsZiwgc3Ry KToKKyAgICAgICAgIiIiCisgICAgICAgIFdyaXRlIGEgbWVzc2FnZSB0aGF0IGlzIGFsc28gaW5j bHVkZWQgd2hlbiBsb2dnaW5nIHZlcmJvc2VseS4KKworICAgICAgICBUaGlzIHJvdXRpbmUgcHJl c2VydmVzIHRoZSBzYW1lIGNvbnNvbGUgbG9nZ2luZyBiZWhhdmlvciBhcyBwcm9ncmVzcygpLAor ICAgICAgICBidXQgd2lsbCBhbHNvIGxvZyB0aGUgbWVzc2FnZSBpZiB2ZXJib3NlKCkgd2FzIHRy dWUuCisKKyAgICAgICAgIiIiCisgICAgICAgICMgTm90ZSB0aGlzIGlzIGEgc2VwYXJhdGUgcm91 dGluZSB0aGF0IGNhbGxzIGVpdGhlciBpbnRvIHRoZSBsb2dnZXIKKyAgICAgICAgIyBvciB0aGUg bWV0ZXJpbmcgc3RyZWFtLiBXZSBoYXZlIHRvIGJlIGNhcmVmdWwgdG8gYXZvaWQgYSBsYXllcmlu ZworICAgICAgICAjIGludmVyc2lvbiAoc3RyZWFtIGNhbGxpbmcgYmFjayBpbnRvIHRoZSBsb2dn ZXIpLgorICAgICAgICBpZiBzZWxmLl92ZXJib3NlOgorICAgICAgICAgICAgX2xvZy5pbmZvKHN0 cikKKyAgICAgICAgZWxzZToKKyAgICAgICAgICAgIHNlbGYuX3dyaXRlKHN0cikKKworICAgIGRl ZiBfd3JpdGUoc2VsZiwgc3RyKToKKyAgICAgICAgIiIiQWN0dWFsbHkgd3JpdGUgdGhlIG1lc3Nh Z2UgdG8gdGhlIHN0cmVhbS4iIiIKKworICAgICAgICAjIEZJWE1FOiBGaWd1cmUgb3V0IGlmIHRo ZXJlIGlzIGEgd2F5IHRvIGRldGVjdCBpZiB3ZSdyZSB3cml0aW5nCisgICAgICAgICMgdG8gYSBz dHJlYW0gdGhhdCBoYW5kbGVzIENScyBjb3JyZWN0bHkgKGUuZy4sIHRlcm1pbmFscykuIFRoYXQg bWlnaHQKKyAgICAgICAgIyBiZSBhIGNsZWFuZXIgd2F5IG9mIGhhbmRsaW5nIHRoaXMuCiAKICAg ICAgICAgIyBQcmludCB0aGUgbmVjZXNzYXJ5IG51bWJlciBvZiBiYWNrc3BhY2VzIHRvIGVyYXNl IHRoZSBwcmV2aW91cwogICAgICAgICAjIG1lc3NhZ2UuCmRpZmYgLS1naXQgYS9XZWJLaXRUb29s cy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzLnB5IGIvV2Vi S2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0cy5w eQppbmRleCAwNTlmZDA5Li5iYjQ5NTI3IDEwMDc1NQotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRz L3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzLnB5CisrKyBiL1dlYktpdFRv b2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHMucHkKQEAg LTcxOSw3ICs3MTksNyBAQCBjbGFzcyBUZXN0UnVubmVyOgogICAgICAgICAiIiJEaXNwbGF5cyB0 aGUgcHJvZ3Jlc3MgdGhyb3VnaCB0aGUgdGVzdCBydW4uIiIiCiAgICAgICAgIHBlcmNlbnRfY29t cGxldGUgPSAxMDAgKiAocmVzdWx0X3N1bW1hcnkuZXhwZWN0ZWQgKwogICAgICAgICAgICAgcmVz dWx0X3N1bW1hcnkudW5leHBlY3RlZCkgLyByZXN1bHRfc3VtbWFyeS50b3RhbAotICAgICAgICBz ZWxmLl9tZXRlci51cGRhdGUoIlRlc3RpbmcgKCVkJSUpOiAlZCByYW4gYXMgZXhwZWN0ZWQsICVk IGRpZG4ndCwiCisgICAgICAgIHNlbGYuX21ldGVyLnByb2dyZXNzKCJUZXN0aW5nICglZCUlKTog JWQgcmFuIGFzIGV4cGVjdGVkLCAlZCBkaWRuJ3QsIgogICAgICAgICAgICAgIiAlZCBsZWZ0IiAl IChwZXJjZW50X2NvbXBsZXRlLCByZXN1bHRfc3VtbWFyeS5leHBlY3RlZCwKICAgICAgICAgICAg ICByZXN1bHRfc3VtbWFyeS51bmV4cGVjdGVkLCByZXN1bHRfc3VtbWFyeS5yZW1haW5pbmcpKQog CkBAIC03NjIsMTAgKzc2MiwxMCBAQCBjbGFzcyBUZXN0UnVubmVyOgogCiAgICAgICAgIGlmIHJl c3VsdF9zdW1tYXJ5LnJlbWFpbmluZzoKICAgICAgICAgICAgIHJlbWFpbl9zdHIgPSAiICglZCki ICUgKHJlc3VsdF9zdW1tYXJ5LnJlbWFpbmluZykKLSAgICAgICAgICAgIHNlbGYuX21ldGVyLnVw ZGF0ZSgiJXMlcyIgJQotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChzZWxmLl9jdXJy ZW50X3Byb2dyZXNzX3N0ciwgcmVtYWluX3N0cikpCisgICAgICAgICAgICBzZWxmLl9tZXRlci5w cm9ncmVzcygiJXMlcyIgJQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKHNlbGYu X2N1cnJlbnRfcHJvZ3Jlc3Nfc3RyLCByZW1haW5fc3RyKSkKICAgICAgICAgZWxzZToKLSAgICAg ICAgICAgIHNlbGYuX21ldGVyLndyaXRlKCIlc1xuIiAlIChzZWxmLl9jdXJyZW50X3Byb2dyZXNz X3N0cikpCisgICAgICAgICAgICBzZWxmLl9tZXRlci5wcm9ncmVzcygiJXNcbiIgJSAoc2VsZi5f Y3VycmVudF9wcm9ncmVzc19zdHIpKQogCiAgICAgZGVmIF9nZXRfZmFpbHVyZXMoc2VsZiwgcmVz dWx0X3N1bW1hcnksIGluY2x1ZGVfY3Jhc2hlcyk6CiAgICAgICAgICIiIkZpbHRlcnMgYSBkaWN0 IG9mIHJlc3VsdHMgYW5kIHJldHVybnMgb25seSB0aGUgZmFpbHVyZXMuCg==