37772 2010-04-18 07:12:41 -0700 WebGL rendering context does not activate unless accelerated compositing is enabled from settings. 2010-06-10 03:29:00 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 0 jarkko.j.sakkinen webkit-unassigned cmarrin commit-queue eric hausmann kbr oldest_to_newest 213756 0 jarkko.j.sakkinen 2010-04-18 07:12:41 -0700 When QtLauncher is used (for example) web pages that have WebGL content don't load unless accelerated compositing is enabled from QWebSettings. 213757 1 jarkko.j.sakkinen 2010-04-18 07:33:04 -0700 I have an idea about cause of this bug. Posting patch as soon as I have verified that it fixes the issue. 214824 2 53861 jarkko.j.sakkinen 2010-04-20 12:00:12 -0700 Created attachment 53861 Allows creation of WebGL rendering context if webGLEnabled flag is true and does not also require acceleratedCompositing flag also to be true. 218567 3 hausmann 2010-04-28 12:40:19 -0700 It looks like the original change from bug https://bugs.webkit.org/show_bug.cgi?id=35759 was intentional... 218603 4 53861 cmarrin 2010-04-28 13:38:15 -0700 Comment on attachment 53861 Allows creation of WebGL rendering context if webGLEnabled flag is true and does not also require acceleratedCompositing flag also to be true. > diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog > index 82feb24..22c8c71 100644 > --- a/WebCore/ChangeLog > +++ b/WebCore/ChangeLog > @@ -1,3 +1,17 @@ > +2010-04-20 Jarkko Sakkinen <jarkko.sakkinen@tieto.com> > + > + Reviewed by NOBODY (OOPS!). > + > + [Qt] WebGL rendering context does not activate unless accelerated compositing is enabled from settings. > + https://bugs.webkit.org/show_bug.cgi?id=37772 > + > + Allows WebGL rendering context creation is webGLEnabled flag > + is true in the document settings and does not require > + also acceleratedCompositing flag also to be enabled. > + > + * html/HTMLCanvasElement.cpp: > + (WebCore::HTMLCanvasElement::getContext): > + > 2010-04-19 Kevin Ollivier <kevino@theolliviers.com> > > Fix the Mac builders for now by restoring the keepAlive function. > diff --git a/WebCore/html/HTMLCanvasElement.cpp b/WebCore/html/HTMLCanvasElement.cpp > index ef85323..5367040 100644 > --- a/WebCore/html/HTMLCanvasElement.cpp > +++ b/WebCore/html/HTMLCanvasElement.cpp > @@ -145,7 +145,7 @@ CanvasRenderingContext* HTMLCanvasElement::getContext(const String& type, Canvas > } > #if ENABLE(3D_CANVAS) > Settings* settings = document()->settings(); > - if (settings && settings->webGLEnabled() && settings->acceleratedCompositingEnabled()) { > + if (settings && settings->webGLEnabled()) { > // Accept the legacy "webkit-3d" name as well as the provisional "experimental-webgl" name. > // Once ratified, we will also accept "webgl" as the context name. > if ((type == "webkit-3d") || The Mac implementation requires acceleratedCompositing for WebGL rendering. It's reasonable to remove the test for acceleratedCompositing here as long as, for the Mac platform, webGLEnabled has a test to prevent it from being true unless acceleratedCompositing is also true. 223099 5 53861 kbr 2010-05-09 15:28:11 -0700 Comment on attachment 53861 Allows creation of WebGL rendering context if webGLEnabled flag is true and does not also require acceleratedCompositing flag also to be true. This change looks fine. I'm surprised Chromium's WebGL support wasn't broken by the original patch. 234774 6 53861 hausmann 2010-06-07 04:10:46 -0700 Comment on attachment 53861 Allows creation of WebGL rendering context if webGLEnabled flag is true and does not also require acceleratedCompositing flag also to be true. It does not appear that this patch takes Chris' commen into account: "The Mac implementation requires acceleratedCompositing for WebGL rendering. It's reasonable to remove the test for acceleratedCompositing here as long as, for the Mac platform, webGLEnabled has a test to prevent it from being true unless acceleratedCompositing is also true." So landing this fix would re-open Bug 35759 234952 7 kbr 2010-06-07 11:31:11 -0700 (In reply to comment #6) > (From update of attachment 53861 [details]) > It does not appear that this patch takes Chris' commen into account: > > "The Mac implementation requires acceleratedCompositing for WebGL rendering. It's reasonable to remove the test for acceleratedCompositing here as long as, for the Mac platform, webGLEnabled has a test to prevent it from being true unless acceleratedCompositing is also true." > > So landing this fix would re-open Bug 35759 Note that in https://bugs.webkit.org/show_bug.cgi?id=40085 a patch was landed adding an #ifdef around the test of accelerated compositing being enabled. You could add another arm to the #if with something like #if !PLATFORM(CHROMIUM) && !PLATFORM(QT) Or, if you're willing to do the build plumbing, you could completely generalize this into a new build flag per https://bugs.webkit.org/show_bug.cgi?id=40091 . 235173 8 58122 jarkko.j.sakkinen 2010-06-08 01:07:29 -0700 Created attachment 58122 Based on suggestion by Kenneth Russel 236131 9 58122 commit-queue 2010-06-09 19:29:11 -0700 Comment on attachment 58122 Based on suggestion by Kenneth Russel Clearing flags on attachment: 58122 Committed r60930: <http://trac.webkit.org/changeset/60930> 236132 10 commit-queue 2010-06-09 19:29:19 -0700 All reviewed patches have been landed. Closing bug. 236279 11 hausmann 2010-06-10 03:29:00 -0700 WebGL is not part of the qtwebkit-2.0 branch, so I'm removing this bug from the list of bugs/patches to include in the release branch. 53861 2010-04-20 12:00:12 -0700 2010-06-08 01:07:29 -0700 Allows creation of WebGL rendering context if webGLEnabled flag is true and does not also require acceleratedCompositing flag also to be true. 37772-1.diff text/plain 1585 jarkko.j.sakkinen ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ODJmZWIyNC4uMjJjOGM3MSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMC0wNC0yMCAgSmFya2tvIFNha2tp bmVuICA8amFya2tvLnNha2tpbmVuQHRpZXRvLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIFdlYkdMIHJlbmRlcmluZyBjb250ZXh0IGRv ZXMgbm90IGFjdGl2YXRlIHVubGVzcyBhY2NlbGVyYXRlZCBjb21wb3NpdGluZyBpcyBlbmFibGVk IGZyb20gc2V0dGluZ3MuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0zNzc3MgorICAgICAgICAKKyAgICAgICAgQWxsb3dzIFdlYkdMIHJlbmRlcmluZyBj b250ZXh0IGNyZWF0aW9uIGlzIHdlYkdMRW5hYmxlZCBmbGFnCisgICAgICAgIGlzIHRydWUgaW4g dGhlIGRvY3VtZW50IHNldHRpbmdzIGFuZCBkb2VzIG5vdCByZXF1aXJlIAorICAgICAgICBhbHNv IGFjY2VsZXJhdGVkQ29tcG9zaXRpbmcgZmxhZyBhbHNvIHRvIGJlIGVuYWJsZWQuCisKKyAgICAg ICAgKiBodG1sL0hUTUxDYW52YXNFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxD YW52YXNFbGVtZW50OjpnZXRDb250ZXh0KToKKwogMjAxMC0wNC0xOSAgS2V2aW4gT2xsaXZpZXIg IDxrZXZpbm9AdGhlb2xsaXZpZXJzLmNvbT4KIAogICAgICAgICBGaXggdGhlIE1hYyBidWlsZGVy cyBmb3Igbm93IGJ5IHJlc3RvcmluZyB0aGUga2VlcEFsaXZlIGZ1bmN0aW9uLgpkaWZmIC0tZ2l0 IGEvV2ViQ29yZS9odG1sL0hUTUxDYW52YXNFbGVtZW50LmNwcCBiL1dlYkNvcmUvaHRtbC9IVE1M Q2FudmFzRWxlbWVudC5jcHAKaW5kZXggZWY4NTMyMy4uNTM2NzA0MCAxMDA2NDQKLS0tIGEvV2Vi Q29yZS9odG1sL0hUTUxDYW52YXNFbGVtZW50LmNwcAorKysgYi9XZWJDb3JlL2h0bWwvSFRNTENh bnZhc0VsZW1lbnQuY3BwCkBAIC0xNDUsNyArMTQ1LDcgQEAgQ2FudmFzUmVuZGVyaW5nQ29udGV4 dCogSFRNTENhbnZhc0VsZW1lbnQ6OmdldENvbnRleHQoY29uc3QgU3RyaW5nJiB0eXBlLCBDYW52 YXMKICAgICB9CiAjaWYgRU5BQkxFKDNEX0NBTlZBUykgICAgCiAgICAgU2V0dGluZ3MqIHNldHRp bmdzID0gZG9jdW1lbnQoKS0+c2V0dGluZ3MoKTsKLSAgICBpZiAoc2V0dGluZ3MgJiYgc2V0dGlu Z3MtPndlYkdMRW5hYmxlZCgpICYmIHNldHRpbmdzLT5hY2NlbGVyYXRlZENvbXBvc2l0aW5nRW5h YmxlZCgpKSB7CisgICAgaWYgKHNldHRpbmdzICYmIHNldHRpbmdzLT53ZWJHTEVuYWJsZWQoKSkg ewogICAgICAgICAvLyBBY2NlcHQgdGhlIGxlZ2FjeSAid2Via2l0LTNkIiBuYW1lIGFzIHdlbGwg YXMgdGhlIHByb3Zpc2lvbmFsICJleHBlcmltZW50YWwtd2ViZ2wiIG5hbWUuCiAgICAgICAgIC8v IE9uY2UgcmF0aWZpZWQsIHdlIHdpbGwgYWxzbyBhY2NlcHQgIndlYmdsIiBhcyB0aGUgY29udGV4 dCBuYW1lLgogICAgICAgICBpZiAoKHR5cGUgPT0gIndlYmtpdC0zZCIpIHx8Cg== 58122 2010-06-08 01:07:29 -0700 2010-06-09 19:29:11 -0700 Based on suggestion by Kenneth Russel 37772-2.diff text/plain 1155 jarkko.j.sakkinen ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZmYzOGQzYS4uNDI1OTA3ZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0wNi0wOCAgSmFya2tvIFNha2tp bmVuICA8amFya2tvLmouc2Fra2luZW5AZ21haWwuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlYkdMIHJlbmRlcmluZyBjb250ZXh0IGRvZXMg bm90IGFjdGl2YXRlIHVubGVzcyBhY2NlbGVyYXRlZAorICAgICAgICBjb21wb3NpdGluZyBpcyBl bmFibGVkIGZyb20gc2V0dGluZ3MuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0zNzc3MgorCisgICAgICAgICogaHRtbC9IVE1MQ2FudmFzRWxlbWVudC5j cHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MQ2FudmFzRWxlbWVudDo6Z2V0Q29udGV4dCk6CisK IDIwMTAtMDYtMDcgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IEFkYW0gQmFydGguCmRpZmYgLS1naXQgYS9XZWJDb3JlL2h0bWwvSFRNTENhbnZh c0VsZW1lbnQuY3BwIGIvV2ViQ29yZS9odG1sL0hUTUxDYW52YXNFbGVtZW50LmNwcAppbmRleCA1 ZDQwMzgyLi43MjM0M2FhIDEwMDY0NAotLS0gYS9XZWJDb3JlL2h0bWwvSFRNTENhbnZhc0VsZW1l bnQuY3BwCisrKyBiL1dlYkNvcmUvaHRtbC9IVE1MQ2FudmFzRWxlbWVudC5jcHAKQEAgLTE1Nyw3 ICsxNTcsNyBAQCBDYW52YXNSZW5kZXJpbmdDb250ZXh0KiBIVE1MQ2FudmFzRWxlbWVudDo6Z2V0 Q29udGV4dChjb25zdCBTdHJpbmcmIHR5cGUsIENhbnZhcwogI2lmIEVOQUJMRSgzRF9DQU5WQVMp ICAgIAogICAgIFNldHRpbmdzKiBzZXR0aW5ncyA9IGRvY3VtZW50KCktPnNldHRpbmdzKCk7CiAg ICAgaWYgKHNldHRpbmdzICYmIHNldHRpbmdzLT53ZWJHTEVuYWJsZWQoKQotI2lmICFQTEFURk9S TShDSFJPTUlVTSkKKyNpZiAhUExBVEZPUk0oQ0hST01JVU0pICYmICFQTEFURk9STShRVCkKICAg ICAgICAgJiYgc2V0dGluZ3MtPmFjY2VsZXJhdGVkQ29tcG9zaXRpbmdFbmFibGVkKCkKICNlbmRp ZgogICAgICAgICApIHsK