37762 2010-04-17 20:54:30 -0700 Sandbox option does not work (typo) 2010-04-18 21:08:44 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 mforney webkit-unassigned commit-queue webkit.review.bot oldest_to_newest 213707 0 53623 mforney 2010-04-17 20:54:30 -0700 Created attachment 53623 Fixes the sandbox option When you try to build WebKit with --{enable,disable}-sandbox, configure complains because it is not a valid option. This is because it is declared with AC_ARG_ENABLE(ruby ...) in configure.ac, a cut and paste error from the ruby option. Configure output: configure: WARNING: unrecognized options: --disable-sandbox The attached patch fixes this issue. 213753 1 mrowe 2010-04-18 06:17:11 -0700 If this patch had a ChangeLog entry and the review flag set to ? I’d have been more than happy to r+ it and mark it as ready to be committed. 213754 2 mrowe 2010-04-18 06:17:47 -0700 By the way, you can see <http://webkit.org/coding/contributing.html> for some more info about that. 213788 3 53631 mforney 2010-04-18 12:50:23 -0700 Created attachment 53631 Fixes the sandbox option Sorry about that. Here is an updated patch. 213789 4 webkit.review.bot 2010-04-18 12:54:58 -0700 Attachment 53631 did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 ChangeLog:9: Line contains tab character. [whitespace/tab] [5] ChangeLog:10: Line contains tab character. [whitespace/tab] [5] ChangeLog:11: Line contains tab character. [whitespace/tab] [5] Total errors found: 3 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 213813 5 53637 mforney 2010-04-18 15:19:25 -0700 Created attachment 53637 Fixes the sandbox option Fixed the tabs. 213890 6 53637 laszlo.gombos 2010-04-18 20:38:39 -0700 Comment on attachment 53637 Fixes the sandbox option lgtm, r+. 213895 7 53637 commit-queue 2010-04-18 21:08:39 -0700 Comment on attachment 53637 Fixes the sandbox option Clearing flags on attachment: 53637 Committed r57801: <http://trac.webkit.org/changeset/57801> 213896 8 commit-queue 2010-04-18 21:08:44 -0700 All reviewed patches have been landed. Closing bug. 53623 2010-04-17 20:54:30 -0700 2010-04-18 12:50:23 -0700 Fixes the sandbox option 0001-Fix-sandbox-configure-option.patch text/plain 798 mforney RnJvbSA1M2FhNzAwMjQwNTE1OGU2YzcyMGIxMjk1ZTM2NjU4OTgyNDgyOTk0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNaWNoYWVsIEZvcm5leSA8bWljaGFlbEBvYmJlcm9uLmNvbT4K RGF0ZTogU2F0LCAxNyBBcHIgMjAxMCAyMDozMDo0OCAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIEZp eCBzYW5kYm94IGNvbmZpZ3VyZSBvcHRpb24KCi0tLQogY29uZmlndXJlLmFjIHwgICAgMiArLQog MSBmaWxlcyBjaGFuZ2VkLCAxIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb25zKC0pCgpkaWZmIC0t Z2l0IGEvY29uZmlndXJlLmFjIGIvY29uZmlndXJlLmFjCmluZGV4IDIyYmQ1NDUuLmQ0NWRkNDAg MTAwNjQ0Ci0tLSBhL2NvbmZpZ3VyZS5hYworKysgYi9jb25maWd1cmUuYWMKQEAgLTM4OSw3ICsz ODksNyBAQCBBQ19NU0dfUkVTVUxUKFskZW5hYmxlX3J1YnldKQogCiAjIGNoZWNrIHdoZXRoZXIg dG8gZW5hYmxlIEhUTUw1IHNhbmRib3ggaWZyYW1lIHN1cHBvcnQKIEFDX01TR19DSEVDS0lORyhb d2hldGhlciB0byBlbmFibGUgSFRNTDUgc2FuZGJveGVkIGlmcmFtZSBzdXBwb3J0XSkKLUFDX0FS R19FTkFCTEUocnVieSwKK0FDX0FSR19FTkFCTEUoc2FuZGJveCwKICAgICAgICAgICAgICAgQUNf SEVMUF9TVFJJTkcoWy0tZW5hYmxlLXNhbmRib3hdLAogICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBbZW5hYmxlIEhUTUw1IHNhbmRib3hlZCBpZnJhbWUgc3VwcG9ydCBbZGVmYXVsdD15ZXNd XSksCiAgICAgICAgICAgICAgIFtdLFtlbmFibGVfc2FuZGJveD0ieWVzIl0pCi0tIAoxLjcuMAoK 53631 2010-04-18 12:50:23 -0700 2010-04-18 15:19:25 -0700 Fixes the sandbox option 0001-Fix-sandbox-configure-option.patch text/plain 1402 mforney RnJvbSBmNTFiNjNlNjM1NTE3NTA3Y2NhMTk1ZWQwZWE0Mjc4OGYzNDZkM2RkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNaWNoYWVsIEZvcm5leSA8bWZvcm5leUBtZm9ybmV5Lm9yZz4K RGF0ZTogU3VuLCAxOCBBcHIgMjAxMCAxMjo0MzoxMiAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIEZp eCBzYW5kYm94IGNvbmZpZ3VyZSBvcHRpb24uCgotLS0KIENoYW5nZUxvZyAgICB8ICAgMTIgKysr KysrKysrKysrCiBjb25maWd1cmUuYWMgfCAgICAyICstCiAyIGZpbGVzIGNoYW5nZWQsIDEzIGlu c2VydGlvbnMoKyksIDEgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hh bmdlTG9nCmluZGV4IDg5MzM5N2EuLjYzM2FmOTcgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysg Yi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wNC0xOCAgTWljaGFlbCBGb3JuZXkg IDxtaWNoYWVsQG1mb3JuZXkub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0z Nzc2MgorCisgICAgICAgIEZpeGVzIHRoZSBzYW5kYm94IG9wdGlvbiBpbiBjb25maWd1cmUuCisK KwkqIGNvbmZpZ3VyZS5hYzogRml4IGN1dCBhbmQgcGFzdGUgZXJyb3IgaW4gdGhlIHNhbmRib3gg b3B0aW9uIGNhdXNpbmcKKwktLXtlbmFibGUsZGlzYWJsZX0tc2FuZGJveCB0byBiZSBpbmVmZmVj dGl2ZSwgYW5kIGl0IHRvIGJlIGNvbnRyb2xsZWQKKwlieSB0aGUgcnVieSBmbGFnLgorCiAyMDEw LTA0LTA5ICBTaW1vbiBIYXVzbWFubiAgPHNpbW9uLmhhdXNtYW5uQG5va2lhLmNvbT4KIAogICAg ICAgICBVbnJldmlld2VkIGNyYXNoIGZpeC4KZGlmZiAtLWdpdCBhL2NvbmZpZ3VyZS5hYyBiL2Nv bmZpZ3VyZS5hYwppbmRleCAyMmJkNTQ1Li5kNDVkZDQwIDEwMDY0NAotLS0gYS9jb25maWd1cmUu YWMKKysrIGIvY29uZmlndXJlLmFjCkBAIC0zODksNyArMzg5LDcgQEAgQUNfTVNHX1JFU1VMVChb JGVuYWJsZV9ydWJ5XSkKIAogIyBjaGVjayB3aGV0aGVyIHRvIGVuYWJsZSBIVE1MNSBzYW5kYm94 IGlmcmFtZSBzdXBwb3J0CiBBQ19NU0dfQ0hFQ0tJTkcoW3doZXRoZXIgdG8gZW5hYmxlIEhUTUw1 IHNhbmRib3hlZCBpZnJhbWUgc3VwcG9ydF0pCi1BQ19BUkdfRU5BQkxFKHJ1YnksCitBQ19BUkdf RU5BQkxFKHNhbmRib3gsCiAgICAgICAgICAgICAgIEFDX0hFTFBfU1RSSU5HKFstLWVuYWJsZS1z YW5kYm94XSwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgW2VuYWJsZSBIVE1MNSBzYW5k Ym94ZWQgaWZyYW1lIHN1cHBvcnQgW2RlZmF1bHQ9eWVzXV0pLAogICAgICAgICAgICAgICBbXSxb ZW5hYmxlX3NhbmRib3g9InllcyJdKQotLSAKMS43LjAKCg== 53637 2010-04-18 15:19:25 -0700 2010-04-18 21:08:39 -0700 Fixes the sandbox option 0001-Fix-sandbox-configure-option.patch text/plain 1423 mforney RnJvbSAyN2E2MDJhMWY2NDU1NWJjNjhiYzBlNDIyMDQ2OGQ0ZmNjYTc0ZTBjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNaWNoYWVsIEZvcm5leSA8bWZvcm5leUBtZm9ybmV5Lm9yZz4K RGF0ZTogU3VuLCAxOCBBcHIgMjAxMCAxMjo0MzoxMiAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIEZp eCBzYW5kYm94IGNvbmZpZ3VyZSBvcHRpb24uCgotLS0KIENoYW5nZUxvZyAgICB8ICAgMTIgKysr KysrKysrKysrCiBjb25maWd1cmUuYWMgfCAgICAyICstCiAyIGZpbGVzIGNoYW5nZWQsIDEzIGlu c2VydGlvbnMoKyksIDEgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hh bmdlTG9nCmluZGV4IDg5MzM5N2EuLmZlYjY3MjggMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysg Yi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wNC0xOCAgTWljaGFlbCBGb3JuZXkg IDxtaWNoYWVsQG1mb3JuZXkub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0z Nzc2MgorCisgICAgICAgIEZpeGVzIHRoZSBzYW5kYm94IG9wdGlvbiBpbiBjb25maWd1cmUuCisK KyAgICAgICAgKiBjb25maWd1cmUuYWM6IEZpeCBjdXQgYW5kIHBhc3RlIGVycm9yIGluIHRoZSBz YW5kYm94IG9wdGlvbiBjYXVzaW5nCisgICAgICAgIC0te2VuYWJsZSxkaXNhYmxlfS1zYW5kYm94 IHRvIGJlIGluZWZmZWN0aXZlLCBhbmQgaXQgdG8gYmUgY29udHJvbGxlZAorICAgICAgICBieSB0 aGUgcnVieSBmbGFnLgorCiAyMDEwLTA0LTA5ICBTaW1vbiBIYXVzbWFubiAgPHNpbW9uLmhhdXNt YW5uQG5va2lhLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkIGNyYXNoIGZpeC4KZGlmZiAtLWdp dCBhL2NvbmZpZ3VyZS5hYyBiL2NvbmZpZ3VyZS5hYwppbmRleCAyMmJkNTQ1Li5kNDVkZDQwIDEw MDY0NAotLS0gYS9jb25maWd1cmUuYWMKKysrIGIvY29uZmlndXJlLmFjCkBAIC0zODksNyArMzg5 LDcgQEAgQUNfTVNHX1JFU1VMVChbJGVuYWJsZV9ydWJ5XSkKIAogIyBjaGVjayB3aGV0aGVyIHRv IGVuYWJsZSBIVE1MNSBzYW5kYm94IGlmcmFtZSBzdXBwb3J0CiBBQ19NU0dfQ0hFQ0tJTkcoW3do ZXRoZXIgdG8gZW5hYmxlIEhUTUw1IHNhbmRib3hlZCBpZnJhbWUgc3VwcG9ydF0pCi1BQ19BUkdf RU5BQkxFKHJ1YnksCitBQ19BUkdfRU5BQkxFKHNhbmRib3gsCiAgICAgICAgICAgICAgIEFDX0hF TFBfU1RSSU5HKFstLWVuYWJsZS1zYW5kYm94XSwKICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgW2VuYWJsZSBIVE1MNSBzYW5kYm94ZWQgaWZyYW1lIHN1cHBvcnQgW2RlZmF1bHQ9eWVzXV0p LAogICAgICAgICAgICAgICBbXSxbZW5hYmxlX3NhbmRib3g9InllcyJdKQotLSAKMS43LjAKCg==