37761 2010-04-17 20:46:43 -0700 WebKit won't build with --disable-database 2014-04-08 18:36:25 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Linux RESOLVED INVALID P2 Normal --- 0 mforney webkit-unassigned commit-queue mrobinson ssiloti oldest_to_newest 213706 0 53622 mforney 2010-04-17 20:46:43 -0700 Created attachment 53622 Patch fixing this issue JSDOMWindowCustom.cpp tries to include the generated file "JSDatabase.h" even when --disable-database is specified. Build log: <snip> CXX WebCore/bindings/js/libwebkit_1_0_la-JSCSSStyleDeclarationCustom.lo CXX WebCore/bindings/js/libwebkit_1_0_la-JSCSSValueCustom.lo CXX WebCore/bindings/js/libwebkit_1_0_la-JSCallbackData.lo CXX WebCore/bindings/js/libwebkit_1_0_la-JSCanvasRenderingContextCustom.lo CXX WebCore/bindings/js/libwebkit_1_0_la-JSCanvasRenderingContext2DCustom.lo CXX WebCore/bindings/js/libwebkit_1_0_la-JSClipboardCustom.lo CXX WebCore/bindings/js/libwebkit_1_0_la-JSConsoleCustom.lo CXX WebCore/bindings/js/libwebkit_1_0_la-JSCoordinatesCustom.lo CXX WebCore/bindings/js/libwebkit_1_0_la-JSCustomPositionCallback.lo CXX WebCore/bindings/js/libwebkit_1_0_la-JSCustomPositionErrorCallback.lo CXX WebCore/bindings/js/libwebkit_1_0_la-JSCustomVoidCallback.lo CXX WebCore/bindings/js/libwebkit_1_0_la-JSCustomXPathNSResolver.lo CXX WebCore/bindings/js/libwebkit_1_0_la-JSDOMBinding.lo CXX WebCore/bindings/js/libwebkit_1_0_la-JSDOMFormDataCustom.lo CXX WebCore/bindings/js/libwebkit_1_0_la-JSDOMGlobalObject.lo CXX WebCore/bindings/js/libwebkit_1_0_la-JSDOMWindowBase.lo CXX WebCore/bindings/js/libwebkit_1_0_la-JSDOMWindowCustom.lo WebCore/bindings/js/JSDOMWindowCustom.cpp:39:24: error: JSDatabase.h: No such file or directory make[1]: *** [WebCore/bindings/js/libwebkit_1_0_la-JSDOMWindowCustom.lo] Error 1 make[1]: Leaving directory `/home/michael/tmp/webkit-gtk' make: *** [all] Error 2 This is fixed by the attached patch. 213717 1 mforney 2010-04-17 22:32:46 -0700 It looks like this is not the only issue preventing webkit from being built with --disable-database. ./.libs/libwebkit-1.0.so: undefined reference to `WebCore::SQLiteTransaction::SQLiteTransaction(WebCore::SQLiteDatabase&, bool)' ./.libs/libwebkit-1.0.so: undefined reference to `WebCore::SQLiteStatement::getColumnDouble(int)' ./.libs/libwebkit-1.0.so: undefined reference to `WebCore::SQLResultOk' ./.libs/libwebkit-1.0.so: undefined reference to `WebCore::SQLiteStatement::bindInt64(int, long)' ./.libs/libwebkit-1.0.so: undefined reference to `WebCore::SQLiteStatement::executeCommand()' ./.libs/libwebkit-1.0.so: undefined reference to `WebCore::SQLiteDatabase::executeCommand(WebCore::String const&)' ./.libs/libwebkit-1.0.so: undefined reference to `WebCore::SQLiteStatement::~SQLiteStatement()' ./.libs/libwebkit-1.0.so: undefined reference to `WebCore::SQLiteDatabase::~SQLiteDatabase()' ./.libs/libwebkit-1.0.so: undefined reference to `WebCore::SQLiteDatabase::SQLiteDatabase()' ./.libs/libwebkit-1.0.so: undefined reference to `WebCore::SQLiteStatement::SQLiteStatement(WebCore::SQLiteDatabase&, WebCore::String const&)' ./.libs/libwebkit-1.0.so: undefined reference to `WebCore::SQLiteStatement::getColumnValue(int)' ./.libs/libwebkit-1.0.so: undefined reference to `WebCore::SQLiteStatement::bindDouble(int, double)' ./.libs/libwebkit-1.0.so: undefined reference to `WebCore::SQLiteStatement::bindNull(int)' ./.libs/libwebkit-1.0.so: undefined reference to `WebCore::SQLResultRow' ./.libs/libwebkit-1.0.so: undefined reference to `WebCore::SQLiteDatabase::open(WebCore::String const&)' ./.libs/libwebkit-1.0.so: undefined reference to `WebCore::SQLiteTransaction::commit()' ./.libs/libwebkit-1.0.so: undefined reference to `WebCore::SQLiteStatement::step()' ./.libs/libwebkit-1.0.so: undefined reference to `WebCore::SQLiteStatement::prepare()' ./.libs/libwebkit-1.0.so: undefined reference to `WebCore::SQLiteFileSystem::appendDatabaseFileNameToPath(WebCore::String const&, WebCore::String const&)' ./.libs/libwebkit-1.0.so: undefined reference to `WebCore::SQLiteTransaction::~SQLiteTransaction()' ./.libs/libwebkit-1.0.so: undefined reference to `WebCore::SQLiteStatement::getColumnInt64(int)' collect2: ld returned 1 exit status make[1]: *** [Programs/unittests/testhttpbackend] Error 1 make[1]: *** Waiting for unfinished jobs.... ./.libs/libwebkit-1.0.so: undefined reference to `WebCore::SQLiteTransaction::SQLiteTransaction(WebCore::SQLiteDatabase&, bool)' ./.libs/libwebkit-1.0.so: undefined reference to `WebCore::SQLiteStatement::getColumnDouble(int)' ./.libs/libwebkit-1.0.so: undefined reference to `WebCore::SQLResultOk' ./.libs/libwebkit-1.0.so: undefined reference to `WebCore::SQLiteStatement::bindInt64(int, long)' ./.libs/libwebkit-1.0.so: undefined reference to `WebCore::SQLiteStatement::executeCommand()' ./.libs/libwebkit-1.0.so: undefined reference to `WebCore::SQLiteDatabase::executeCommand(WebCore::String const&)' ./.libs/libwebkit-1.0.so: undefined reference to `WebCore::SQLiteStatement::~SQLiteStatement()' ./.libs/libwebkit-1.0.so: undefined reference to `WebCore::SQLiteDatabase::~SQLiteDatabase()' ./.libs/libwebkit-1.0.so: undefined reference to `WebCore::SQLiteDatabase::SQLiteDatabase()' ./.libs/libwebkit-1.0.so: undefined reference to `WebCore::SQLiteStatement::SQLiteStatement(WebCore::SQLiteDatabase&, WebCore::String const&)' ./.libs/libwebkit-1.0.so: undefined reference to `WebCore::SQLiteStatement::getColumnValue(int)' ./.libs/libwebkit-1.0.so: undefined reference to `WebCore::SQLiteStatement::bindDouble(int, double)' ./.libs/libwebkit-1.0.so: undefined reference to `WebCore::SQLiteStatement::bindNull(int)' ./.libs/libwebkit-1.0.so: undefined reference to `WebCore::SQLResultRow' ./.libs/libwebkit-1.0.so: undefined reference to `WebCore::SQLiteDatabase::open(WebCore::String const&)' ./.libs/libwebkit-1.0.so: undefined reference to `WebCore::SQLiteTransaction::commit()' ./.libs/libwebkit-1.0.so: undefined reference to `WebCore::SQLiteStatement::step()' ./.libs/libwebkit-1.0.so: undefined reference to `WebCore::SQLiteStatement::prepare()' ./.libs/libwebkit-1.0.so: undefined reference to `WebCore::SQLiteFileSystem::appendDatabaseFileNameToPath(WebCore::String const&, WebCore::String const&)' ./.libs/libwebkit-1.0.so: undefined reference to `WebCore::SQLiteTransaction::~SQLiteTransaction()' ./.libs/libwebkit-1.0.so: undefined reference to `WebCore::SQLiteStatement::getColumnInt64(int)' collect2: ld returned 1 exit status make[1]: *** [Programs/GtkLauncher] Error 1 I think this is because offline-web-applications is dependent on database, but I'm not quite sure how to fix this one. 213863 2 53645 mforney 2010-04-18 16:49:01 -0700 Created attachment 53645 Partially fix build with --disable-database. Update patch for style requirements. 216044 3 53645 abarth 2010-04-22 13:03:00 -0700 Comment on attachment 53645 Partially fix build with --disable-database. Thanks! 216259 4 53645 commit-queue 2010-04-22 21:20:10 -0700 Comment on attachment 53645 Partially fix build with --disable-database. Clearing flags on attachment: 53645 Committed r58145: <http://trac.webkit.org/changeset/58145> 216260 5 commit-queue 2010-04-22 21:20:14 -0700 All reviewed patches have been landed. Closing bug. 216691 6 mforney 2010-04-23 21:49:22 -0700 This bug is not yet fixed because of the second issue I mentioned regarding linking failures. 278718 7 ssiloti 2010-09-13 21:53:10 -0700 The link errors are due to GeolocationPositionCache depending on SQLite platform support. To fix this we could either include the SQLite platform sources if ENABLE(GEOLOCATION) or make GeolocationPositionCache support conditional on ENABLE(DATABASE). I'm not sure which would be more appropriate. 998992 8 mrobinson 2014-04-08 18:36:25 -0700 Patch is probably quite out of date. Let's reopen if this is still an issue and post a new fix. 53622 2010-04-17 20:46:43 -0700 2010-04-18 16:49:01 -0700 Patch fixing this issue 0001-Fix-build-with-disable-database.patch text/plain 908 mforney RnJvbSA0YmExZjNjZjE4ZDc2NzQ3MjMxNGVmZjc0YTc0OTgxMDEwYzdhNWMxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNaWNoYWVsIEZvcm5leSA8bWljaGFlbEBvYmJlcm9uLmNvbT4K RGF0ZTogU2F0LCAxNyBBcHIgMjAxMCAyMDoyNDowOSAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIEZp eCBidWlsZCB3aXRoIC0tZGlzYWJsZS1kYXRhYmFzZS4KCk5vdywgSlNEYXRhYmFzZS5oIGFuZCBK U0RhdGFiYXNlQ2FsbGJhY2suaCBhcmUgb25seSBpbmNsdWRlZCB3aGVuCmRhdGFiYXNlIGlzIGVu YWJsZWQuCi0tLQogV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RPTVdpbmRvd0N1c3RvbS5jcHAgfCAg ICAyICsrCiAxIGZpbGVzIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMCBkZWxldGlvbnMoLSkK CmRpZmYgLS1naXQgYS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTRE9NV2luZG93Q3VzdG9tLmNwcCBi L1dlYkNvcmUvYmluZGluZ3MvanMvSlNET01XaW5kb3dDdXN0b20uY3BwCmluZGV4IDdmMDU5OTEu LjQ4OGFjMDQgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvYmluZGluZ3MvanMvSlNET01XaW5kb3dDdXN0 b20uY3BwCisrKyBiL1dlYkNvcmUvYmluZGluZ3MvanMvSlNET01XaW5kb3dDdXN0b20uY3BwCkBA IC0zNiw4ICszNiwxMCBAQAogI2luY2x1ZGUgIkhUTUxEb2N1bWVudC5oIgogI2luY2x1ZGUgIkhp c3RvcnkuaCIKICNpbmNsdWRlICJKU0F1ZGlvQ29uc3RydWN0b3IuaCIKKyNpZiBFTkFCTEUoREFU QUJBU0UpCiAjaW5jbHVkZSAiSlNEYXRhYmFzZS5oIgogI2luY2x1ZGUgIkpTRGF0YWJhc2VDYWxs YmFjay5oIgorI2VuZGlmCiAjaW5jbHVkZSAiSlNET01XaW5kb3dTaGVsbC5oIgogI2luY2x1ZGUg IkpTRXZlbnQuaCIKICNpbmNsdWRlICJKU0V2ZW50TGlzdGVuZXIuaCIKLS0gCjEuNy4wCgo= 53645 2010-04-18 16:49:01 -0700 2010-06-11 11:36:04 -0700 Partially fix build with --disable-database. 0001-Partially-fix-build-with-disable-database.patch text/plain 1618 mforney RnJvbSAyNWE5ZWZhNTU0NWUyMWY3NzkyZjQ5YTA1ODQzYzFkYTUzYjg4ZjZlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNaWNoYWVsIEZvcm5leSA8bWZvcm5leUBtZm9ybmV5Lm9yZz4K RGF0ZTogU3VuLCAxOCBBcHIgMjAxMCAxNTo0NDozNSAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIFBh cnRpYWxseSBmaXggYnVpbGQgd2l0aCAtLWRpc2FibGUtZGF0YWJhc2UuCgpPbmx5IGluY2x1ZGUg SlNEYXRhYmFzZS5oIGFuZCBKU0RhdGFiYXNlQ2FsbGJhY2suaCB3aGVuIGRhdGFiYXNlIGlzCmVu YWJsZWQuCi0tLQogV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgICAgfCAg IDEyICsrKysrKysrKysrKwogV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RPTVdpbmRvd0N1c3RvbS5j cHAgfCAgICAyICsrCiAyIGZpbGVzIGNoYW5nZWQsIDE0IGluc2VydGlvbnMoKyksIDAgZGVsZXRp b25zKC0pCgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxv ZwppbmRleCA4MTlkMDU1Li44MTFhZDQwIDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZwor KysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEwLTA0LTE4ICBNaWNo YWVsIEZvcm5leSAgPG1mb3JuZXlAbWZvcm5leS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTM3NzYxCisKKyAgICAgICAgT25seSBpbmNsdWRlIEpTRGF0YWJhc2UuaCBhbmQg SlNEYXRhYmFzZUNhbGxiYWNrLmggd2hlbiBkYXRhYmFzZSBpcworICAgICAgICBlbmFibGVkLiBU aGlzIHBhcnRpYWxseSBmaXhlcyBidWlsZGluZyB3aXRoIC0tZGlzYWJsZS1kYXRhYmFzZS4KKwor ICAgICAgICAqIGJpbmRpbmdzL2pzL0pTRE9NV2luZG93Q3VzdG9tLmNwcDogQWRkIGEgY2hlY2sg Zm9yIGRhdGFiYXNlIGFyb3VuZAorICAgICAgICBkYXRhYmFzZS1yZWxhdGVkIGhlYWRlcnMuCisK IDIwMTAtMDQtMTcgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvYmluZGluZ3Mv anMvSlNET01XaW5kb3dDdXN0b20uY3BwIGIvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RPTVdpbmRv d0N1c3RvbS5jcHAKaW5kZXggN2YwNTk5MS4uNDg4YWMwNCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9i aW5kaW5ncy9qcy9KU0RPTVdpbmRvd0N1c3RvbS5jcHAKKysrIGIvV2ViQ29yZS9iaW5kaW5ncy9q cy9KU0RPTVdpbmRvd0N1c3RvbS5jcHAKQEAgLTM2LDggKzM2LDEwIEBACiAjaW5jbHVkZSAiSFRN TERvY3VtZW50LmgiCiAjaW5jbHVkZSAiSGlzdG9yeS5oIgogI2luY2x1ZGUgIkpTQXVkaW9Db25z dHJ1Y3Rvci5oIgorI2lmIEVOQUJMRShEQVRBQkFTRSkKICNpbmNsdWRlICJKU0RhdGFiYXNlLmgi CiAjaW5jbHVkZSAiSlNEYXRhYmFzZUNhbGxiYWNrLmgiCisjZW5kaWYKICNpbmNsdWRlICJKU0RP TVdpbmRvd1NoZWxsLmgiCiAjaW5jbHVkZSAiSlNFdmVudC5oIgogI2luY2x1ZGUgIkpTRXZlbnRM aXN0ZW5lci5oIgotLSAKMS43LjAKCg==