37733 2010-04-16 16:27:32 -0700 [Chromium] Get rid of the UNUSED_PARAM macro in GraphicsContext3D.cpp 2010-04-16 19:34:22 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 dumi dumi dglazkov eric webkit.review.bot oldest_to_newest 213481 0 dumi 2010-04-16 16:27:32 -0700 I believe we do not use the UNUSED_PARAM macro in Chromium code. At least, grepping for it in all code in WebKit/chromium/src/ yields a single result: GraphicsContext3D.cpp. There is a better way to achieve the same thing: don't give names to parameters. We should clean that up. 213485 1 eric 2010-04-16 16:35:21 -0700 UNUSED_PARAM is only needed when ifdeffing out code. You use UNUSED_PARAM in the #else block. 213493 2 53581 dumi 2010-04-16 16:51:47 -0700 Created attachment 53581 patch 213496 3 webkit.review.bot 2010-04-16 16:54:09 -0700 Attachment 53581 did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKit/chromium/ChangeLog:6: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 213503 4 53581 eric 2010-04-16 17:03:44 -0700 Comment on attachment 53581 patch LGTM. 213564 5 dumi 2010-04-16 19:34:22 -0700 Landed as r57771. 53581 2010-04-16 16:51:47 -0700 2010-04-16 17:03:43 -0700 patch patch text/plain 1396 dumi SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNTc3NjMpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDQtMTYgIER1bWl0 cnUgRGFuaWxpdWMgIDxkdW1pQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBHZXQgcmlkIG9mIHRoZSBVTlVTRURfUEFSQU0gbWFj cm8gaW4gR3JhcGhpY3NDb250ZXh0M0QuY3BwLgorCWh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0zNzczMworCisgICAgICAgICogc3JjL0dyYXBoaWNzQ29udGV4dDNELmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dDNEOjpHcmFwaGljc0NvbnRleHQz RCk6CisKIDIwMTAtMDQtMTYgIEFsYmVydCBKLiBXb25nICA8YWp3b25nQGNocm9taXVtLm9yZz4K IAogICAgICAgICBOb3QgcmV2aWV3ZWQuIEJ1aWxkIGZpeC4KSW5kZXg6IFdlYktpdC9jaHJvbWl1 bS9zcmMvR3JhcGhpY3NDb250ZXh0M0QuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9jaHJvbWl1 bS9zcmMvR3JhcGhpY3NDb250ZXh0M0QuY3BwCShyZXZpc2lvbiA1Nzc2MSkKKysrIFdlYktpdC9j aHJvbWl1bS9zcmMvR3JhcGhpY3NDb250ZXh0M0QuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01Nyw3 ICs1Nyw2IEBACiAKICNpbmNsdWRlIDxzdGRpby5oPgogI2luY2x1ZGUgPHd0Zi9GYXN0TWFsbG9j Lmg+Ci0jaW5jbHVkZSA8d3RmL1VudXNlZFBhcmFtLmg+CiAjaW5jbHVkZSA8d3RmL3RleHQvQ1N0 cmluZy5oPgogCiAjaWYgUExBVEZPUk0oQ0cpCkBAIC0xMDQ5LDkgKzEwNDgsOCBAQCBydCBHcmFw aGljc0NvbnRleHQzRDo6bmFtZSh0MSBhMSwgdDIgYTIsCiAgICAgcmV0dXJuIG1faW50ZXJuYWwt Pm5hbWUoYTEsIGEyLCBhMywgYTQsIGE1LCBhNiwgYTcsIGE4LCBhOSk7ICAgXAogfQogCi1HcmFw aGljc0NvbnRleHQzRDo6R3JhcGhpY3NDb250ZXh0M0QoR3JhcGhpY3NDb250ZXh0M0Q6OkF0dHJp YnV0ZXMgYXR0cnMsIEhvc3RXaW5kb3cqIGhvc3RXaW5kb3cpCitHcmFwaGljc0NvbnRleHQzRDo6 R3JhcGhpY3NDb250ZXh0M0QoR3JhcGhpY3NDb250ZXh0M0Q6OkF0dHJpYnV0ZXMsIEhvc3RXaW5k b3cqKQogewotICAgIFVOVVNFRF9QQVJBTShob3N0V2luZG93KTsKIH0KIAogR3JhcGhpY3NDb250 ZXh0M0Q6On5HcmFwaGljc0NvbnRleHQzRCgpCg==