37724 2010-04-16 12:47:27 -0700 Always pass a view to the AppKit drawing functions. 2010-04-16 12:58:20 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 andersca webkit-unassigned oldest_to_newest 213372 0 andersca 2010-04-16 12:47:27 -0700 Always pass a view to the AppKit drawing functions. 213373 1 53552 andersca 2010-04-16 12:49:23 -0700 Created attachment 53552 Patch 213374 2 53552 hyatt 2010-04-16 12:51:40 -0700 Comment on attachment 53552 Patch r=me 213378 3 andersca 2010-04-16 12:58:20 -0700 Committed r57734: <http://trac.webkit.org/changeset/57734> 53552 2010-04-16 12:49:23 -0700 2010-04-16 12:51:39 -0700 Patch bug-37724-20100416124922.patch text/plain 5274 andersca SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NzczMykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjMgQEAKKzIwMTAtMDQtMTYgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFw cGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBBbHdheXMgcGFzcyBhIHZpZXcgdG8gdGhlIEFwcEtpdCBkcmF3aW5nIGZ1bmN0aW9ucy4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM3NzI0CisKKyAg ICAgICAgTm8gbmV3IHRlc3RzLiAoT09QUyEpCisKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvVGhl bWVNYWMubW06CisgICAgICAgIChXZWJDb3JlOjpwYWludENoZWNrYm94KToKKyAgICAgICAgKFdl YkNvcmU6OnBhaW50UmFkaW8pOgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJUaGVtZU1hYy5t bToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRoZW1lTWFjOjpwYWludE1lbnVMaXN0KToKKyAg ICAgICAgKFdlYkNvcmU6OlJlbmRlclRoZW1lTWFjOjpwYWludFNsaWRlclRodW1iKToKKyAgICAg ICAgKFdlYkNvcmU6OlJlbmRlclRoZW1lTWFjOjpwYWludFNlYXJjaEZpZWxkKToKKyAgICAgICAg KFdlYkNvcmU6OlJlbmRlclRoZW1lTWFjOjpwYWludFNlYXJjaEZpZWxkQ2FuY2VsQnV0dG9uKToK KyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRoZW1lTWFjOjpwYWludFNlYXJjaEZpZWxkUmVzdWx0 c0RlY29yYXRpb24pOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVGhlbWVNYWM6OnBhaW50U2Vh cmNoRmllbGRSZXN1bHRzQnV0dG9uKToKKwogMjAxMC0wNC0xNiAgQWxleGV5IFByb3NrdXJ5YWtv diAgPGFwQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYW4gQmVybnN0ZWluLgpJ bmRleDogV2ViQ29yZS9wbGF0Zm9ybS9tYWMvVGhlbWVNYWMubW0KPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi Q29yZS9wbGF0Zm9ybS9tYWMvVGhlbWVNYWMubW0JKHJldmlzaW9uIDU3NzI0KQorKysgV2ViQ29y ZS9wbGF0Zm9ybS9tYWMvVGhlbWVNYWMubW0JKHdvcmtpbmcgY29weSkKQEAgLTIzMCw3ICsyMzAs NyBAQCBzdGF0aWMgdm9pZCBwYWludENoZWNrYm94KENvbnRyb2xTdGF0ZXMgCiAgICAgICAgIGNv bnRleHQtPnRyYW5zbGF0ZSgtaW5mbGF0ZWRSZWN0LngoKSwgLWluZmxhdGVkUmVjdC55KCkpOwog ICAgIH0KICAgICAKLSAgICBbY2hlY2tib3hDZWxsIGRyYXdXaXRoRnJhbWU6TlNSZWN0KGluZmxh dGVkUmVjdCkgaW5WaWV3OnNjcm9sbFZpZXctPmRvY3VtZW50VmlldygpXTsKKyAgICBbY2hlY2ti b3hDZWxsIGRyYXdXaXRoRnJhbWU6TlNSZWN0KGluZmxhdGVkUmVjdCkgaW5WaWV3OlRoZW1lTWFj OjplbnN1cmVkVmlldyhzY3JvbGxWaWV3KV07CiAgICAgW2NoZWNrYm94Q2VsbCBzZXRDb250cm9s VmlldzpuaWxdOwogCiAgICAgY29udGV4dC0+cmVzdG9yZSgpOwpAQCAtMzA4LDcgKzMwOCw3IEBA IHN0YXRpYyB2b2lkIHBhaW50UmFkaW8oQ29udHJvbFN0YXRlcyBzdGEKICAgICB9CiAgICAgCiAg ICAgQkVHSU5fQkxPQ0tfT0JKQ19FWENFUFRJT05TCi0gICAgW3JhZGlvQ2VsbCBkcmF3V2l0aEZy YW1lOk5TUmVjdChpbmZsYXRlZFJlY3QpIGluVmlldzpzY3JvbGxWaWV3LT5kb2N1bWVudFZpZXco KV07CisgICAgW3JhZGlvQ2VsbCBkcmF3V2l0aEZyYW1lOk5TUmVjdChpbmZsYXRlZFJlY3QpIGlu VmlldzpUaGVtZU1hYzo6ZW5zdXJlZFZpZXcoc2Nyb2xsVmlldyldOwogICAgIFtyYWRpb0NlbGwg c2V0Q29udHJvbFZpZXc6bmlsXTsKICAgICBFTkRfQkxPQ0tfT0JKQ19FWENFUFRJT05TCiAKSW5k ZXg6IFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lTWFjLm1tCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdl YkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lTWFjLm1tCShyZXZpc2lvbiA1NzcyNCkKKysrIFdl YkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lTWFjLm1tCSh3b3JraW5nIGNvcHkpCkBAIC00MCw2 ICs0MCw3IEBACiAjaW1wb3J0ICJSZW5kZXJWaWV3LmgiCiAjaW1wb3J0ICJTaGFyZWRCdWZmZXIu aCIKICNpbXBvcnQgIlRpbWVSYW5nZXMuaCIKKyNpbXBvcnQgIlRoZW1lTWFjLmgiCiAjaW1wb3J0 ICJXZWJDb3JlU3lzdGVtSW50ZXJmYWNlLmgiCiAjaW1wb3J0ICJVc2VyQWdlbnRTdHlsZVNoZWV0 cy5oIgogI2ltcG9ydCA8Q2FyYm9uL0NhcmJvbi5oPgpAQCAtNzc0LDcgKzc3NSw3IEBAIGJvb2wg UmVuZGVyVGhlbWVNYWM6OnBhaW50TWVudUxpc3QoUmVuZGUKICAgICAgICAgcGFpbnRJbmZvLmNv bnRleHQtPnRyYW5zbGF0ZSgtaW5mbGF0ZWRSZWN0LngoKSwgLWluZmxhdGVkUmVjdC55KCkpOwog ICAgIH0KIAotICAgIFtwb3B1cEJ1dHRvbiBkcmF3V2l0aEZyYW1lOmluZmxhdGVkUmVjdCBpblZp ZXc6by0+dmlldygpLT5mcmFtZVZpZXcoKS0+ZG9jdW1lbnRWaWV3KCldOworICAgIFtwb3B1cEJ1 dHRvbiBkcmF3V2l0aEZyYW1lOmluZmxhdGVkUmVjdCBpblZpZXc6VGhlbWVNYWM6OmVuc3VyZWRW aWV3KG8tPnZpZXcoKS0+ZnJhbWVWaWV3KCkpXTsKICAgICBbcG9wdXBCdXR0b24gc2V0Q29udHJv bFZpZXc6bmlsXTsKIAogICAgIHBhaW50SW5mby5jb250ZXh0LT5yZXN0b3JlKCk7CkBAIC0xMjMy LDcgKzEyMzMsNyBAQCBib29sIFJlbmRlclRoZW1lTWFjOjpwYWludFNsaWRlclRodW1iKFJlCiAg ICAgICAgIHBhaW50SW5mby5jb250ZXh0LT50cmFuc2xhdGUoLXVuem9vbWVkUmVjdC54KCksIC11 bnpvb21lZFJlY3QueSgpKTsKICAgICB9CiAKLSAgICBbc2xpZGVyVGh1bWJDZWxsIGRyYXdXaXRo RnJhbWU6dW56b29tZWRSZWN0IGluVmlldzpvLT52aWV3KCktPmZyYW1lVmlldygpLT5kb2N1bWVu dFZpZXcoKV07CisgICAgW3NsaWRlclRodW1iQ2VsbCBkcmF3V2l0aEZyYW1lOnVuem9vbWVkUmVj dCBpblZpZXc6VGhlbWVNYWM6OmVuc3VyZWRWaWV3KG8tPnZpZXcoKS0+ZnJhbWVWaWV3KCkpXTsK ICAgICBbc2xpZGVyVGh1bWJDZWxsIHNldENvbnRyb2xWaWV3Om5pbF07CiAKICAgICBwYWludElu Zm8uY29udGV4dC0+cmVzdG9yZSgpOwpAQCAtMTI2NCw3ICsxMjY1LDcgQEAgYm9vbCBSZW5kZXJU aGVtZU1hYzo6cGFpbnRTZWFyY2hGaWVsZChSZQogICAgIC8vIFNldCB0aGUgc2VhcmNoIGJ1dHRv biB0byBuaWwgYmVmb3JlIGRyYXdpbmcuICBUaGVuIHJlc2V0IGl0IHNvIHdlIGNhbiBkcmF3IGl0 IGxhdGVyLgogICAgIFtzZWFyY2ggc2V0U2VhcmNoQnV0dG9uQ2VsbDpuaWxdOwogCi0gICAgW3Nl YXJjaCBkcmF3V2l0aEZyYW1lOk5TUmVjdCh1bnpvb21lZFJlY3QpIGluVmlldzpvLT52aWV3KCkt PmZyYW1lVmlldygpLT5kb2N1bWVudFZpZXcoKV07CisgICAgW3NlYXJjaCBkcmF3V2l0aEZyYW1l Ok5TUmVjdCh1bnpvb21lZFJlY3QpIGluVmlldzpUaGVtZU1hYzo6ZW5zdXJlZFZpZXcoby0+dmll dygpLT5mcmFtZVZpZXcoKSldOwogI2lmZGVmIEJVSUxESU5HX09OX1RJR0VSCiAgICAgaWYgKFtz ZWFyY2ggc2hvd3NGaXJzdFJlc3BvbmRlcl0pCiAgICAgICAgIHdrRHJhd1RleHRGaWVsZENlbGxG b2N1c1Jpbmcoc2VhcmNoLCBOU1JlY3QodW56b29tZWRSZWN0KSk7CkBAIC0xMzY0LDcgKzEzNjUs NyBAQCBib29sIFJlbmRlclRoZW1lTWFjOjpwYWludFNlYXJjaEZpZWxkQ2FuCiAgICAgICAgIHBh aW50SW5mby5jb250ZXh0LT50cmFuc2xhdGUoLXVuem9vbWVkUmVjdC54KCksIC11bnpvb21lZFJl Y3QueSgpKTsKICAgICB9CiAKLSAgICBbW3NlYXJjaCBjYW5jZWxCdXR0b25DZWxsXSBkcmF3V2l0 aEZyYW1lOnVuem9vbWVkUmVjdCBpblZpZXc6by0+dmlldygpLT5mcmFtZVZpZXcoKS0+ZG9jdW1l bnRWaWV3KCldOworICAgIFtbc2VhcmNoIGNhbmNlbEJ1dHRvbkNlbGxdIGRyYXdXaXRoRnJhbWU6 dW56b29tZWRSZWN0IGluVmlldzpUaGVtZU1hYzo6ZW5zdXJlZFZpZXcoby0+dmlldygpLT5mcmFt ZVZpZXcoKSldOwogICAgIFtbc2VhcmNoIGNhbmNlbEJ1dHRvbkNlbGxdIHNldENvbnRyb2xWaWV3 Om5pbF07CiAKICAgICBwYWludEluZm8uY29udGV4dC0+cmVzdG9yZSgpOwpAQCAtMTQyOSw3ICsx NDMwLDcgQEAgYm9vbCBSZW5kZXJUaGVtZU1hYzo6cGFpbnRTZWFyY2hGaWVsZFJlcwogICAgIEZs b2F0UmVjdCBsb2NhbEJvdW5kcyA9IFtzZWFyY2ggc2VhcmNoQnV0dG9uUmVjdEZvckJvdW5kczpO U1JlY3QoaW5wdXQtPnJlbmRlckJveCgpLT5ib3JkZXJCb3hSZWN0KCkpXTsKICAgICBsb2NhbEJv dW5kcyA9IGNvbnZlcnRUb1BhaW50aW5nUmVjdChpbnB1dC0+cmVuZGVyZXIoKSwgbywgbG9jYWxC b3VuZHMsIHIpOwogCi0gICAgW1tzZWFyY2ggc2VhcmNoQnV0dG9uQ2VsbF0gZHJhd1dpdGhGcmFt ZTpsb2NhbEJvdW5kcyBpblZpZXc6by0+dmlldygpLT5mcmFtZVZpZXcoKS0+ZG9jdW1lbnRWaWV3 KCldOworICAgIFtbc2VhcmNoIHNlYXJjaEJ1dHRvbkNlbGxdIGRyYXdXaXRoRnJhbWU6bG9jYWxC b3VuZHMgaW5WaWV3OlRoZW1lTWFjOjplbnN1cmVkVmlldyhvLT52aWV3KCktPmZyYW1lVmlldygp KV07CiAgICAgW1tzZWFyY2ggc2VhcmNoQnV0dG9uQ2VsbF0gc2V0Q29udHJvbFZpZXc6bmlsXTsK ICAgICByZXR1cm4gZmFsc2U7CiB9CkBAIC0xNDcyLDcgKzE0NzMsNyBAQCBib29sIFJlbmRlclRo ZW1lTWFjOjpwYWludFNlYXJjaEZpZWxkUmVzCiAgICAgICAgIHBhaW50SW5mby5jb250ZXh0LT50 cmFuc2xhdGUoLXVuem9vbWVkUmVjdC54KCksIC11bnpvb21lZFJlY3QueSgpKTsKICAgICB9CiAK LSAgICBbW3NlYXJjaCBzZWFyY2hCdXR0b25DZWxsXSBkcmF3V2l0aEZyYW1lOnVuem9vbWVkUmVj dCBpblZpZXc6by0+dmlldygpLT5mcmFtZVZpZXcoKS0+ZG9jdW1lbnRWaWV3KCldOworICAgIFtb c2VhcmNoIHNlYXJjaEJ1dHRvbkNlbGxdIGRyYXdXaXRoRnJhbWU6dW56b29tZWRSZWN0IGluVmll dzpUaGVtZU1hYzo6ZW5zdXJlZFZpZXcoby0+dmlldygpLT5mcmFtZVZpZXcoKSldOwogICAgIFtb c2VhcmNoIHNlYXJjaEJ1dHRvbkNlbGxdIHNldENvbnRyb2xWaWV3Om5pbF07CiAgICAgCiAgICAg cGFpbnRJbmZvLmNvbnRleHQtPnJlc3RvcmUoKTsK