37718 2010-04-16 11:46:53 -0700 Safari crashes with certain JavaScript charCode events in EventHandler::needsKeyboardEventDisambiguationQuirks 2010-04-16 12:45:56 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED InRadar P1 Normal --- 1 ap ap oldest_to_newest 213330 0 ap 2010-04-16 11:46:53 -0700 Steps to Reproduce: 1. Open http://tlrobinson.net/Recorder/ (with the slash) 2. Click Record 3. In the "Source List" table, double click on an entry and change it ("21" to "Foo Bar" or something) 4. Click stop. 5. Click play. 6. When it tries to replay you entering the text, it crashes. <rdar://problem/7757812> 213363 1 53550 ap 2010-04-16 12:18:59 -0700 Created attachment 53550 proposed fix This only fixes the crash - the original test case still fails, as replayed keyboard events don't result in text input. I'm not sure if that's necessarily a bad thing. 213371 2 ap 2010-04-16 12:45:56 -0700 Committed <http://trac.webkit.org/changeset/57733>. 53550 2010-04-16 12:18:59 -0700 2010-04-16 12:21:16 -0700 proposed fix RecordedKeydown.txt text/plain 4042 ap SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NzczMSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMDQtMTYgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBs ZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM3NzE4CisgICAgICAgIFNh ZmFyaSBjcmFzaGVzIHdpdGggY2VydGFpbiBKYXZhU2NyaXB0IGNoYXJDb2RlIGV2ZW50cyBpbiBF dmVudEhhbmRsZXI6Om5lZWRzS2V5Ym9hcmRFdmVudERpc2FtYmlndWF0aW9uUXVpcmtzCisKKyAg ICAgICAgVGVzdDogZmFzdC9ldmVudHMvcmVjb3JkZWQta2V5ZG93bi1ldmVudC5odG1sCisKKyAg ICAgICAgKiBkb20vS2V5Ym9hcmRFdmVudC5jcHA6IChXZWJDb3JlOjpLZXlib2FyZEV2ZW50Ojpj aGFyQ29kZSk6IENoZWNrIGlmIHRoZSB2aWV3ICh3aW5kb3cpIGlzCisgICAgICAgIGZyYW1lbGVz cy4KKwogMjAxMC0wNC0xNiAgSmlhbiBMaSAgPGppYW5saUBjaHJvbWl1bS5vcmc+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgRG1pdHJ5IFRpdG92LgpJbmRleDogV2ViQ29yZS9kb20vS2V5Ym9hcmRF dmVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9kb20vS2V5Ym9hcmRFdmVudC5jcHAJKHJl dmlzaW9uIDU3NjU0KQorKysgV2ViQ29yZS9kb20vS2V5Ym9hcmRFdmVudC5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTEzMSw3ICsxMzEsNyBAQCBpbnQgS2V5Ym9hcmRFdmVudDo6Y2hhckNvZGUoKSBj b25zdAogICAgIC8vIEZpcmVmb3g6IDAgZm9yIGtleWRvd24va2V5dXAgZXZlbnRzLCBjaGFyYWN0 ZXIgY29kZSBmb3Iga2V5cHJlc3MKICAgICAvLyBXZSBtYXRjaCBGaXJlZm94LCB1bmxlc3MgaW4g YmFja3dhcmQgY29tcGF0aWJpbGl0eSBtb2RlLCB3aGVyZSB3ZSBhbHdheXMgcmV0dXJuIHRoZSBj aGFyYWN0ZXIgY29kZS4KICAgICBib29sIGJhY2t3YXJkQ29tcGF0aWJpbGl0eU1vZGUgPSBmYWxz ZTsKLSAgICBpZiAodmlldygpKQorICAgIGlmICh2aWV3KCkgJiYgdmlldygpLT5mcmFtZSgpKQog ICAgICAgICBiYWNrd2FyZENvbXBhdGliaWxpdHlNb2RlID0gdmlldygpLT5mcmFtZSgpLT5ldmVu dEhhbmRsZXIoKS0+bmVlZHNLZXlib2FyZEV2ZW50RGlzYW1iaWd1YXRpb25RdWlya3MoKTsKIAog ICAgIGlmICghbV9rZXlFdmVudCB8fCAodHlwZSgpICE9IGV2ZW50TmFtZXMoKS5rZXlwcmVzc0V2 ZW50ICYmICFiYWNrd2FyZENvbXBhdGliaWxpdHlNb2RlKSkKSW5kZXg6IExheW91dFRlc3RzL0No YW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDU3 NzMxKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEs MTMgQEAKKzIwMTAtMDQtMTYgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM3NzE4CisgICAgICAgIFNhZmFyaSBjcmFz aGVzIHdpdGggY2VydGFpbiBKYXZhU2NyaXB0IGNoYXJDb2RlIGV2ZW50cyBpbiBFdmVudEhhbmRs ZXI6Om5lZWRzS2V5Ym9hcmRFdmVudERpc2FtYmlndWF0aW9uUXVpcmtzCisKKyAgICAgICAgKiBm YXN0L2V2ZW50cy9yZWNvcmRlZC1rZXlkb3duLWV2ZW50LWV4cGVjdGVkLnR4dDogQWRkZWQuCisg ICAgICAgICogZmFzdC9ldmVudHMvcmVjb3JkZWQta2V5ZG93bi1ldmVudC5odG1sOiBBZGRlZC4K KwogMjAxMC0wNC0xNiAgQWRhbSBSb2JlbiAgPGFyb2JlbkBhcHBsZS5jb20+CiAKICAgICAgICAg U2tpcCBIVE1MRnJhbWVTZXRFbGVtZW50LXdpbmRvdy1ldmVudExpc3RlbmVyLWF0dHJpYnV0ZXMu aHRtbCBvbiBTbm93TGVvcGFyZApJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvcmVjb3Jk ZWQta2V5ZG93bi1ldmVudC1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMv ZmFzdC9ldmVudHMvcmVjb3JkZWQta2V5ZG93bi1ldmVudC1leHBlY3RlZC50eHQJKHJldmlzaW9u IDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9yZWNvcmRlZC1rZXlkb3duLWV2ZW50LWV4 cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwzIEBACitUZXN0IGZvciBidWcgMzc3 MTg6IENyYXNoIHdoZW4gcmVwbGF5aW5nIGEgc2VxdWVuY2Ugb2Yga2V5Ym9hcmQgZXZlbnRzLgor CitQQVNTCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9yZWNvcmRlZC1rZXlkb3duLWV2 ZW50Lmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvcmVjb3JkZWQt a2V5ZG93bi1ldmVudC5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9ldmVu dHMvcmVjb3JkZWQta2V5ZG93bi1ldmVudC5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDQx IEBACis8Ym9keSBvbmxvYWQ9InRlc3QoKSI+Cis8cD5UZXN0IGZvciA8YSBocmVmPSJodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzc3MTgiPmJ1ZyAzNzcxODwvYT46CitD cmFzaCB3aGVuIHJlcGxheWluZyBhIHNlcXVlbmNlIG9mIGtleWJvYXJkIGV2ZW50cy48L3A+Cis8 aWZyYW1lIHNyYz0iYWJvdXQ6YmxhbmsiPjwvaWZyYW1lPgorPHNjcmlwdD4KK2lmICh3aW5kb3cu bGF5b3V0VGVzdENvbnRyb2xsZXIpIHsKKyAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNU ZXh0KCk7CisgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIud2FpdFVudGlsRG9uZSgpOworfQorCitm dW5jdGlvbiB0ZXN0KCkKK3sKKyAgICBmcmFtZXNbMF0uZG9jdW1lbnQud3JpdGUoIjxkaXYgY29u dGVudGVkaXRhYmxlIG9ua2V5ZG93bj0ndG9wLnJlY29yZChldmVudCknPjwvZGl2PiIpOworICAg IGZyYW1lc1swXS5kb2N1bWVudC5nZXRFbGVtZW50c0J5VGFnTmFtZSgiZGl2IilbMF0uZm9jdXMo KTsKKyAgICBpZiAod2luZG93LmV2ZW50U2VuZGVyKQorICAgICAgICBldmVudFNlbmRlci5rZXlE b3duKCJhIik7Cit9CisKK2Z1bmN0aW9uIHJlY29yZChldmVudCkKK3sKKyAgICBkb2N1bWVudC5n ZXRFbGVtZW50QnlJZCgicCIpLmlubmVySFRNTCA9ICJUZXN0aW5nLi4uIjsKKyAgICB3aW5kb3cu cmVjb3JkZWRFdmVudCA9IGV2ZW50OworCisgICAgc2V0VGltZW91dChmdW5jdGlvbigpIHsKKwor ICAgICAgICBkb2N1bWVudC5ib2R5LnJlbW92ZUNoaWxkKGRvY3VtZW50LmdldEVsZW1lbnRzQnlU YWdOYW1lKCJpZnJhbWUiKVswXSk7CisKKyAgICAgICAgc2V0VGltZW91dChmdW5jdGlvbigpIHsK KworICAgICAgICAgICAgd2luZG93LnJlY29yZGVkRXZlbnQuY2hhckNvZGU7CisgICAgICAgICAg ICB3aW5kb3cucmVjb3JkZWRFdmVudC5rZXlDb2RlOworICAgICAgICAgICAgZG9jdW1lbnQuZ2V0 RWxlbWVudEJ5SWQoInAiKS5pbm5lckhUTUwgPSAiUEFTUyI7CisgICAgICAgICAgICBpZiAod2lu ZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorICAgICAgICAgICAgICAgIGxheW91dFRlc3RDb250 cm9sbGVyLm5vdGlmeURvbmUoKTsKKworICAgICAgICB9LCAwKTsKKyAgICB9LCAwKTsKK30KKzwv c2NyaXB0PgorPHAgaWQ9cD5QbGVhc2UgcHJlc3MgYW55IGtleS48L3A+Cis8L2JvZHk+Cg==