37716 2010-04-16 11:12:20 -0700 WebKit/qt/WebCoreSupport/NotificationPresenterClientQt.h does not compile with minimal cofigured Qt 2010-04-19 06:40:26 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC S60 3rd edition RESOLVED DUPLICATE 37442 Qt P2 Normal --- 1 cshu cshu laszlo.gombos oldest_to_newest 213307 0 cshu 2010-04-16 11:12:20 -0700 NotificationPresenterClientQt.h refers QSystemTrayIcon in qsystemtrayicon.h. But QSystemTrayIcon is not declared with QT_NO_SYSTEMTRAYICON defined, which is true in minimal and small config of Qt. 213318 1 53544 cshu 2010-04-16 11:26:24 -0700 Created attachment 53544 fix patch 213902 2 53544 laszlo.gombos 2010-04-18 21:32:59 -0700 Comment on attachment 53544 fix patch This patch would be more future-proof and would work in more build setups if test would check if QT_NO_SYSTEMTRAYICON is defined. I would also prefer to guard "DEFINES += ENABLE_NOTIFICATIONS=1" statement. 213903 3 laszlo.gombos 2010-04-18 21:33:39 -0700 *** This bug has been marked as a duplicate of bug 37442 *** 214004 4 cshu 2010-04-19 06:40:26 -0700 (In reply to comment #2) > (From update of attachment 53544 [details]) > This patch would be more future-proof and would work in more build setups if > test would check if QT_NO_SYSTEMTRAYICON is defined. > > I would also prefer to guard "DEFINES += ENABLE_NOTIFICATIONS=1" statement. I don't think the pri file is able to detect if QT_NO_SYSTEMTRAYICON is defined. 53544 2010-04-16 11:26:24 -0700 2010-04-18 21:32:59 -0700 fix patch bug37716_1.patch text/plain 1260 cshu SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NzcyNSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTAtMDQtMTYgIFNodSBDaGFuZyAgPGNoYW5nLnNodUBub2tpYS5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0 XSBOT1RJRklDQVRJT05TIGRlcGVuZHMgb24gU1lTVEVNVFJBWUlDT04gaW4gUXQuIFdpdGggUVRf Tk9fU1lTVEVNVFJBWUlDT04KKyAgICAgICAgZGVmaW5lZCBpbiBtaW5pbWFsIGFuZCBzbWFsbCBj b25maWcsIE5PVElGSUNBVElPTlMgbXVzdCBiZSBkaXNhYmxlZC4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM3NzE2CisKKyAgICAgICAgKiBXZWJDb3Jl LnByaToKKwogMjAxMC0wNC0xNiAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29t PgogCiAgICAgICAgIEZpeCBXZWJLaXQyIGJ1aWxkLgpJbmRleDogV2ViQ29yZS9XZWJDb3JlLnBy aQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL1dlYkNvcmUucHJpCShyZXZpc2lvbiA1NzcyMykKKysr IFdlYkNvcmUvV2ViQ29yZS5wcmkJKHdvcmtpbmcgY29weSkKQEAgLTU4LDYgKzU4LDkgQEAgY29u dGFpbnMoREVGSU5FUywgRU5BQkxFX1NJTkdMRV9USFJFQURFRAogIWNvbnRhaW5zKERFRklORVMs IEVOQUJMRV9CTE9CX1NMSUNFPS4pOiBERUZJTkVTICs9IEVOQUJMRV9CTE9CX1NMSUNFPTAKICFj b250YWlucyhERUZJTkVTLCBFTkFCTEVfTk9USUZJQ0FUSU9OUz0uKTogREVGSU5FUyArPSBFTkFC TEVfTk9USUZJQ0FUSU9OUz0xCiAKKyMgU2hvdWxkIG5vdCBlbmFibGUgTk9USUZJQ0FUSU9OUyBp ZiBRdCBkaXNhYmxlcyBTWVNURU1UUkFZSUNPTgorQ09ORklHKG1pbmltYWwtY29uZmlnKSB8fCBD T05GSUcoc21hbGwtY29uZmlnKTogREVGSU5FUyAtPSBFTkFCTEVfTk9USUZJQ0FUSU9OUz0xCisK IGdyZWF0ZXJUaGFuKFFUX01JTk9SX1ZFUlNJT04sIDUpIHsKICAgICAhY29udGFpbnMoREVGSU5F UywgRU5BQkxFXzNEX1JFTkRFUklORz0uKTogREVGSU5FUyArPSBFTkFCTEVfM0RfUkVOREVSSU5H PTEKIH0K