37699 2010-04-16 00:01:00 -0700 [Qt] WebKit compilation fails with --3d-canvas 2010-04-16 14:27:18 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 0 jarkko.j.sakkinen webkit-unassigned commit-queue hausmann oldest_to_newest 213208 0 jarkko.j.sakkinen 2010-04-16 00:01:00 -0700 GraphicsContext3D.h API has suddenly changed from PassRefPtr<WebGLArray> readPixels(long x, long y, unsigned long width, unsigned long height, unsigned long format, unsigned long type) to void readPixels(long x, long y, unsigned long width, unsigned long height, unsigned long format, unsigned long type, void* data). 213213 1 53519 jarkko.j.sakkinen 2010-04-16 00:12:15 -0700 Created attachment 53519 Changes to readPixels() 213229 2 jarkko.j.sakkinen 2010-04-16 00:58:38 -0700 Simon, can you go through this? 213427 3 53519 commit-queue 2010-04-16 14:27:13 -0700 Comment on attachment 53519 Changes to readPixels() Clearing flags on attachment: 53519 Committed r57745: <http://trac.webkit.org/changeset/57745> 213428 4 commit-queue 2010-04-16 14:27:18 -0700 All reviewed patches have been landed. Closing bug. 53519 2010-04-16 00:12:15 -0700 2010-04-16 14:27:12 -0700 Changes to readPixels() 37699.diff text/plain 1869 jarkko.j.sakkinen ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NzcyYzI3YS4uMDdhNDVmZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wNC0xNiAgSmFya2tvIFNha2tp bmVuICA8amFya2tvLmouc2Fra2luZW5AZ21haWwuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gV2ViS2l0IGNvbXBpbGF0aW9uIGZhaWxz IHdpdGggLS0zZC1jYW52YXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTM3Njk5IAorICAgICAgICAKKyAgICAgICAgQVBJIGZvciByZWFkUGl4ZWxzKCkg aGFzIGJlZW4gY2hhbmdlZC4gCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFw aGljc0NvbnRleHQzRFF0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dDNE OjpyZWFkUGl4ZWxzKToKKwogMjAxMC0wNC0xNSAgQ2hyaXMgRmxlaXphY2ggIDxjZmxlaXphY2hA YXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEJldGggRGFraW4uCmRpZmYgLS1naXQg YS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNzQ29udGV4dDNEUXQuY3BwIGIv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGljc0NvbnRleHQzRFF0LmNwcAppbmRl eCBjYWE4MDVjLi42MzZjMjU4IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L3F0L0dyYXBoaWNzQ29udGV4dDNEUXQuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvcXQvR3JhcGhpY3NDb250ZXh0M0RRdC5jcHAKQEAgLTk5NCwxNiArOTk0LDE0IEBAIHZvaWQg R3JhcGhpY3NDb250ZXh0M0Q6OnBvbHlnb25PZmZzZXQoZG91YmxlIGZhY3RvciwgZG91YmxlIHVu aXRzKQogICAgIGdsUG9seWdvbk9mZnNldChzdGF0aWNfY2FzdDxmbG9hdD4oZmFjdG9yKSwgc3Rh dGljX2Nhc3Q8ZmxvYXQ+KHVuaXRzKSk7CiB9CiAKLVBhc3NSZWZQdHI8V2ViR0xBcnJheT4gR3Jh cGhpY3NDb250ZXh0M0Q6OnJlYWRQaXhlbHMobG9uZyB4LCBsb25nIHksIHVuc2lnbmVkIGxvbmcg d2lkdGgsIHVuc2lnbmVkIGxvbmcgaGVpZ2h0LCB1bnNpZ25lZCBsb25nIGZvcm1hdCwgdW5zaWdu ZWQgbG9uZyB0eXBlKQordm9pZCBHcmFwaGljc0NvbnRleHQzRDo6cmVhZFBpeGVscyhsb25nIHgs IGxvbmcgeSwgdW5zaWduZWQgbG9uZyB3aWR0aCwgdW5zaWduZWQgbG9uZyBoZWlnaHQsIHVuc2ln bmVkIGxvbmcgZm9ybWF0LCB1bnNpZ25lZCBsb25nIHR5cGUsIHZvaWQqIGRhdGEpCiB7CiAgICAg bV9pbnRlcm5hbC0+bV9nbFdpZGdldC0+bWFrZUN1cnJlbnQoKTsKICAgICAKICAgICBpZiAodHlw ZSAhPSBHcmFwaGljc0NvbnRleHQzRDo6VU5TSUdORURfQllURSB8fCBmb3JtYXQgIT0gR3JhcGhp Y3NDb250ZXh0M0Q6OlJHQkEpCi0gICAgICAgIHJldHVybiAwOworICAgICAgICByZXR1cm47CiAg ICAgICAgIAotICAgIFJlZlB0cjxXZWJHTFVuc2lnbmVkQnl0ZUFycmF5PiBhcnJheSA9IFdlYkdM VW5zaWduZWRCeXRlQXJyYXk6OmNyZWF0ZSh3aWR0aCAqIGhlaWdodCAqIDQpOwotICAgIGdsUmVh ZFBpeGVscyh4LCB5LCB3aWR0aCwgaGVpZ2h0LCBmb3JtYXQsIHR5cGUsIChHTHZvaWQqKSBhcnJh eS0+ZGF0YSgpKTsKLSAgICByZXR1cm4gYXJyYXk7ICAgIAorICAgIGdsUmVhZFBpeGVscyh4LCB5 LCB3aWR0aCwgaGVpZ2h0LCBmb3JtYXQsIHR5cGUsIChHTHZvaWQqKSBkYXRhKTsKIH0KIAogdm9p ZCBHcmFwaGljc0NvbnRleHQzRDo6cmVsZWFzZVNoYWRlckNvbXBpbGVyKCkK