37694 2010-04-15 20:46:50 -0700 [Qt] Issue with using QWebPage::setLinkDelegationPolicy... 2010-05-08 06:31:27 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) All All RESOLVED FIXED Qt P2 Normal --- 0 adawit webkit-unassigned commit-queue jturcotte oldest_to_newest 213190 0 adawit 2010-04-15 20:46:50 -0700 Clicking on the type of links shown below completely renders QWebPage::setLinkDelegationPolicy(QWebPage::DelegateAllLinks) calls useless: <a href="javascript:window.location='http://qt.nokia.com'">Click me</a> When you click on a link like the one above, you will never receive the linkClicked signal. Instead the click will be treated as a non-click event and handled internally as if the default QWebPage::DontDelegateLinks is set. I guess this happens because the click triggers the execution of a javascript code which might do things other than making navigation requests. Regardless, the setLinkDelegationPolicy should mention this issue or perhaps there should be another NavigationType, QWebPage::NavigationTypeJavascript ??? 221713 1 jturcotte 2010-05-06 09:02:45 -0700 In this case it is hard to know if the navigation was trigger by a user action from other types of events, so linkClicked cannot fit reliably. A NavigationTypeJavascript might make sense if you cannot rely on re-implementing acceptNavigationRequest listening for NavigationTypeOther requests. 221724 2 adawit 2010-05-06 09:25:14 -0700 (In reply to comment #1) > In this case it is hard to know if the navigation was trigger by a user action > from other types of events, so linkClicked cannot fit reliably. > > A NavigationTypeJavascript might make sense if you cannot rely on > re-implementing acceptNavigationRequest listening for NavigationTypeOther > requests. Unfortunately that is the case. That is one cannot rely on the meaning of NavigationTypeOther since there is no way you can distinguish that from say a call that originated from QWebView::load(...). :( After opening this bug report I took a look at the Qtwebkit source code and realized that this issue is actually the result of QtWebKit directly relying on the navigation types present in WebKit. All the Navigation types in QtWebKit are an exact equivalent right down to the name of the ones that exist in WebKit ; so the problem I guess is beyond just QtWebKit. Anyhow, I guess I have to come up with yet another hack to distinguish between requests that originate from a user clicking on a javascript link and those that originated from other means. In the meantime could this perhaps be clearly documented in the API ? 222253 3 55353 jturcotte 2010-05-07 02:58:21 -0700 Created attachment 55353 Document the limitation How about that? 222294 4 55353 kenneth 2010-05-07 05:43:41 -0700 Comment on attachment 55353 Document the limitation > + \note This signal possibly won't be emitted for clicked links which use > + JavaScript to trigger navigation. I don't like the 'possibly' \note The signal will not be emitted for navigation triggered by JavaScript, such as ... 222877 5 55353 commit-queue 2010-05-08 06:31:22 -0700 Comment on attachment 55353 Document the limitation Clearing flags on attachment: 55353 Committed r59026: <http://trac.webkit.org/changeset/59026> 222878 6 commit-queue 2010-05-08 06:31:27 -0700 All reviewed patches have been landed. Closing bug. 55353 2010-05-07 02:58:21 -0700 2010-05-08 06:31:22 -0700 Document the limitation linkclicked_doc.patch text/plain 965 jturcotte ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9BcGkvcXdlYnBhZ2UuY3BwIGIvV2ViS2l0L3F0L0FwaS9x d2VicGFnZS5jcHAKaW5kZXggYzlmYzIxMC4uNDYxOGUwNiAxMDA2NDQKLS0tIGEvV2ViS2l0L3F0 L0FwaS9xd2VicGFnZS5jcHAKKysrIGIvV2ViS2l0L3F0L0FwaS9xd2VicGFnZS5jcHAKQEAgLTM0 OTUsNiArMzQ5NSw5IEBAIHF1aW50NjQgUVdlYlBhZ2U6OmJ5dGVzUmVjZWl2ZWQoKSBjb25zdAog CiAgICAgQnkgZGVmYXVsdCBubyBsaW5rcyBhcmUgZGVsZWdhdGVkIGFuZCBhcmUgaGFuZGxlZCBi eSBRV2ViUGFnZSBpbnN0ZWFkLgogCisgICAgXG5vdGUgVGhpcyBzaWduYWwgcG9zc2libHkgd29u J3QgYmUgZW1pdHRlZCBmb3IgY2xpY2tlZCBsaW5rcyB3aGljaCB1c2UKKyAgICBKYXZhU2NyaXB0 IHRvIHRyaWdnZXIgbmF2aWdhdGlvbi4KKwogICAgIFxzYSBsaW5rSG92ZXJlZCgpCiAqLwogCmRp ZmYgLS1naXQgYS9XZWJLaXQvcXQvQ2hhbmdlTG9nIGIvV2ViS2l0L3F0L0NoYW5nZUxvZwppbmRl eCA1ZWFkY2YyLi5mYjUyNjk2IDEwMDY0NAotLS0gYS9XZWJLaXQvcXQvQ2hhbmdlTG9nCisrKyBi L1dlYktpdC9xdC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxMC0wNS0wNyAgSm9jZWx5 biBUdXJjb3R0ZSAgPGpvY2VseW4udHVyY290dGVAbm9raWEuY29tPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gRG9jdW1lbnQgYSBsaW1pdGF0 aW9uIG9mIFFXZWJQYWdlOjpsaW5rQ2xpY2tlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzc2OTQKKworICAgICAgICAqIEFwaS9xd2VicGFnZS5jcHA6 CisKIDIwMTAtMDUtMDQgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29t PgogCiAgICAgICAgIFJldmlld2VkIGJ5IEtlbm5ldGggUm9oZGUgQ2hyaXN0aWFuc2VuLgo=