37692 2010-04-15 19:22:13 -0700 [chromium] ignore IME events if the keydown event was prevented 2010-05-18 19:33:19 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 tony webkit-unassigned oldest_to_newest 213174 0 tony 2010-04-15 19:22:13 -0700 [chromium] ignore IME events if the keydown event was prevented 213175 1 53504 tony 2010-04-15 19:24:55 -0700 Created attachment 53504 Patch 213177 2 tony 2010-04-15 19:26:08 -0700 Discussion of this bug can be found http://code.google.com/p/chromium/issues/detail?id=9883 and a review by hbono and suzhe can be found http://codereview.chromium.org/1630015/show 213178 3 tony 2010-04-15 19:27:18 -0700 Oh, and no layout test because I don't know how to test IME behavior changes. I guess at some point we should build functionality into eventSender to send IME events. 215047 4 53504 jianli 2010-04-20 16:14:40 -0700 Comment on attachment 53504 Patch Generally looks good. Do we have a layout test for this? 215115 5 tony 2010-04-20 19:47:01 -0700 (In reply to comment #4) > (From update of attachment 53504 [details]) > Generally looks good. Do we have a layout test for this? Since posting comment #3, I learned about textInputController, so I tried to write a layout test. However, this doesn't work since textInputController call methods directly on WebFrame and this check is in WebView. I don't think it would make sense to move this check into WebFrame (since WebView knows about the state and does similar checks). Maybe we could change textInputController.setMarkedText to call WebView::handleCompositionEvent instead, but that seems to deviate from DRT mac. It's not clear to me that that's what we want either. 222986 6 53504 eric 2010-05-08 23:28:52 -0700 Comment on attachment 53504 Patch How do we test this? 223128 7 55514 tony 2010-05-09 18:32:49 -0700 Created attachment 55514 Patch 223129 8 tony 2010-05-09 18:33:33 -0700 (In reply to comment #6) > (From update of attachment 53504 [details]) > How do we test this? Since I wasn't able to write a layout test for it, I've added a manual test. 227619 9 tony 2010-05-18 19:33:19 -0700 Committed r59735: <http://trac.webkit.org/changeset/59735> 53504 2010-04-15 19:24:55 -0700 2010-05-09 18:32:43 -0700 Patch bug-37692-20100416112453.patch text/plain 1336 tony ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDNhOGNhNzIuLmU1NjJkNWUgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSw1ICsx LDE1IEBACiAyMDEwLTA0LTE1ICBUb255IENoYW5nICA8dG9ueUBjaHJvbWl1bS5vcmc+CiAKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW2Nocm9taXVtXSBp Z25vcmUgSU1FIGV2ZW50cyBpZiB0aGUga2V5ZG93biBldmVudCB3YXMgcHJldmVudGVkCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNzY5MgorCisgICAg ICAgICogc3JjL1dlYlZpZXdJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViVmlld0ltcGw6 OmhhbmRsZUNvbXBvc2l0aW9uRXZlbnQpOgorCisyMDEwLTA0LTE1ICBUb255IENoYW5nICA8dG9u eUBjaHJvbWl1bS5vcmc+CisKICAgICAgICAgUmV2aWV3ZWQgYnkgRGltaXRyaSBHbGF6a292Lgog CiAgICAgICAgIGJ1aWxkIERSVCBvbiBjaHJvbWl1bSBtYWMKZGlmZiAtLWdpdCBhL1dlYktpdC9j aHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwIGIvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3 SW1wbC5jcHAKaW5kZXggNDY4MTc3NS4uMWNhMzgyZiAxMDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9t aXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAKKysrIGIvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3 SW1wbC5jcHAKQEAgLTExMjUsNyArMTEyNSw5IEBAIGJvb2wgV2ViVmlld0ltcGw6OmhhbmRsZUNv bXBvc2l0aW9uRXZlbnQoV2ViQ29tcG9zaXRpb25Db21tYW5kIGNvbW1hbmQsCiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IFdlYlN0cmluZyYgaW1lU3RyaW5n KQogewogICAgIEZyYW1lKiBmb2N1c2VkID0gZm9jdXNlZFdlYkNvcmVGcmFtZSgpOwotICAgIGlm ICghZm9jdXNlZCB8fCAhbV9pbWVBY2NlcHRFdmVudHMpCisgICAgLy8gSWYgd2UncmUgbm90IGdv aW5nIHRvIGZpcmUgYSBrZXlwcmVzcyBldmVudCwgdGhlbiB0aGUga2V5ZG93biBldmVudCB3YXMK KyAgICAvLyBjYW5jZWxlZCBzbyBkb24ndCB1cGRhdGUgdGhlIElNRS4KKyAgICBpZiAoIWZvY3Vz ZWQgfHwgIW1faW1lQWNjZXB0RXZlbnRzIHx8IG1fc3VwcHJlc3NOZXh0S2V5cHJlc3NFdmVudCkK ICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgIEVkaXRvciogZWRpdG9yID0gZm9jdXNlZC0+ZWRp dG9yKCk7CiAgICAgaWYgKCFlZGl0b3IpCg== 55514 2010-05-09 18:32:49 -0700 2010-05-18 11:21:15 -0700 Patch bug-37692-20100510103247.patch text/plain 3384 tony ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YTRiNzdiYWIzMzZmMjcxOGMxNmNhZTM5NDA4N2E5ZmZkNGI2ZWMzZC4uMjBiNjQwNDc2OWE0ODIx ZmViNDQxZmI5YWZlNDc3ZDhiNGE5ZTk4MyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wNS0wOSAgVG9u eSBDaGFuZyAgPHRvbnlAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtjaHJvbWl1bV0gaWdub3JlIElNRSBldmVudHMgaWYgdGhl IGtleWRvd24gZXZlbnQgd2FzIHByZXZlbnRlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzc2OTIKKworICAgICAgICBBIG1hbnVhbCB0ZXN0IHRvIHZl cmlmeSB0aGUgSU1FIGJlaGF2aW9yIHNpbmNlIHRoZSBleGlzdGluZyBtZXRob2RzIG9mCisgICAg ICAgIHRleHRJbnB1dENvbnRyb2xsZXIgdGVzdCBhdCBhIGxvd2VyIGxldmVsIHRoYW4gdGhlIGZp eC4KKworICAgICAgICAqIG1hbnVhbC10ZXN0cy9pbWUta2V5ZG93bi1wcmV2ZW50ZGVmYXVsdC5o dG1sOiBBZGRlZC4KKwogMjAxMC0wNS0xMCAgSWx5YSBUaWtob25vdnNreSAgPGxvaXNsb0BjaHJv bWl1bS5vcmc+CiAKICAgICAgICAgTm90IHJldmlld2VkOiByb2xsYmFjayB0aGUgY29tbWl0IHI1 OTA2MgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9tYW51YWwtdGVzdHMvaW1lLWtleWRvd24tcHJldmVu dGRlZmF1bHQuaHRtbCBiL1dlYkNvcmUvbWFudWFsLXRlc3RzL2ltZS1rZXlkb3duLXByZXZlbnRk ZWZhdWx0Lmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uYWE0NzRlOTM3ZWIxZGU3ZWZiMjdhNDE5YTcyYTk4ZjYw MWMyNzVkYQotLS0gL2Rldi9udWxsCisrKyBiL1dlYkNvcmUvbWFudWFsLXRlc3RzL2ltZS1rZXlk b3duLXByZXZlbnRkZWZhdWx0Lmh0bWwKQEAgLTAsMCArMSwyNyBAQAorPGh0bWw+Cis8Ym9keT4K KzxwPlR5cGluZyBpbiB0aGUgaW5wdXQgZmllbGRzIGJlbG93IHNob3VsZCBub3QgZ2VuZXJhdGUg dGV4dCwgZXZlbiB3aXRoIGFuIElNRSBlbmFibGVkLjwvcD4KKworVHlwZSBpbnRvIHRoZSBpbnB1 dDoKKzxpbnB1dCB0eXBlPXRleHQgaWQ9J2lucHV0Jz48L2lucHV0Pjxicj4KKzxkaXYgaWQ9J291 dCcgc3R5bGU9ImZsb2F0OiByaWdodCI+PC9kaXY+CitPciB0aGUgdGV4dCBhcmVhOgorPHRleHRh cmVhIGlkPSdhcmVhJz48L3RleHRhcmVhPjxicj4KK09yIHRoZSBjb250ZW50RWRpdGFibGUgYXJl YToKKzxkaXYgY29udGVudEVkaXRhYmxlIGlkPSdjZScgc3R5bGU9ImJvcmRlcjoxcHggc29saWQg cmVkOyBoZWlnaHQ6MzAwcHg7IHdpZHRoOjMwMHB4OyI+PC9kaXY+Cis8c2NyaXB0PgordmFyIGlu cHV0ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2lucHV0Jyk7Cit2YXIgYXJlYSA9IGRvY3Vt ZW50LmdldEVsZW1lbnRCeUlkKCdhcmVhJyk7Cit2YXIgY2UgPSBkb2N1bWVudC5nZXRFbGVtZW50 QnlJZCgnY2UnKTsKKwordmFyIGhhbmRsZUtleURvd24gPSBmdW5jdGlvbihlKSB7CisgIGRvY3Vt ZW50LmdldEVsZW1lbnRCeUlkKCdvdXQnKS5pbm5lckhUTUwgKz0gIjxicj5Hb3QgYSBrZXkgZXZl bnQgLS0gY2FuY2VsbGluZyI7CisgIGUucHJldmVudERlZmF1bHQoKTsKK30KKworaW5wdXQuYWRk RXZlbnRMaXN0ZW5lcigna2V5ZG93bicsIGhhbmRsZUtleURvd24sIGZhbHNlKTsKK2FyZWEuYWRk RXZlbnRMaXN0ZW5lcigna2V5ZG93bicsIGhhbmRsZUtleURvd24sIGZhbHNlKTsKK2NlLmFkZEV2 ZW50TGlzdGVuZXIoJ2tleWRvd24nLCBoYW5kbGVLZXlEb3duLCBmYWxzZSk7Cis8L3NjcmlwdD4K KzwvYm9keT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cg Yi9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4IDEzZTExN2QzZjUyMGFkOTkzNjk1ZTU3 OTNiZTZiNjZlYjdmMjJiNmEuLjI0ZTYzZjBhYzE1OWFhODIzOTE2ZTg1NzMyMzg5MzdiMGQ0YmRi MTkgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEwLTA1LTA5ICBUb255IENoYW5n ICA8dG9ueUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgW2Nocm9taXVtXSBpZ25vcmUgSU1FIGV2ZW50cyBpZiB0aGUga2V5ZG93 biBldmVudCB3YXMgcHJldmVudGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0zNzY5MgorCisgICAgICAgICogc3JjL1dlYlZpZXdJbXBsLmNwcDoKKyAg ICAgICAgKFdlYktpdDo6V2ViVmlld0ltcGw6OmhhbmRsZUNvbXBvc2l0aW9uRXZlbnQpOgorCiAy MDEwLTA1LTA4ICBKZW5zIEFsZmtlICA8c25lakBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgRGFyaW4gRmlzaGVyLgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2Nocm9taXVtL3NyYy9X ZWJWaWV3SW1wbC5jcHAgYi9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcAppbmRl eCA4MWE0ZmYzZThlNzUyNjg4ZWE2NWMxNjVkODRiZDIxNjFhOTZlN2E1Li5kZDc3ODU2OTM3ZDJi Nzc1YjI2NWMyMjVhYTg3MTA5MzY5OGU1OThmIDEwMDY0NAotLS0gYS9XZWJLaXQvY2hyb21pdW0v c3JjL1dlYlZpZXdJbXBsLmNwcAorKysgYi9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBs LmNwcApAQCAtMTE0Niw3ICsxMTQ2LDkgQEAgYm9vbCBXZWJWaWV3SW1wbDo6aGFuZGxlQ29tcG9z aXRpb25FdmVudChXZWJDb21wb3NpdGlvbkNvbW1hbmQgY29tbWFuZCwKICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3QgV2ViU3RyaW5nJiBpbWVTdHJpbmcpCiB7 CiAgICAgRnJhbWUqIGZvY3VzZWQgPSBmb2N1c2VkV2ViQ29yZUZyYW1lKCk7Ci0gICAgaWYgKCFm b2N1c2VkIHx8ICFtX2ltZUFjY2VwdEV2ZW50cykKKyAgICAvLyBJZiB3ZSdyZSBub3QgZ29pbmcg dG8gZmlyZSBhIGtleXByZXNzIGV2ZW50LCB0aGVuIHRoZSBrZXlkb3duIGV2ZW50IHdhcworICAg IC8vIGNhbmNlbGVkIHNvIGRvbid0IHVwZGF0ZSB0aGUgSU1FLgorICAgIGlmICghZm9jdXNlZCB8 fCAhbV9pbWVBY2NlcHRFdmVudHMgfHwgbV9zdXBwcmVzc05leHRLZXlwcmVzc0V2ZW50KQogICAg ICAgICByZXR1cm4gZmFsc2U7CiAgICAgRWRpdG9yKiBlZGl0b3IgPSBmb2N1c2VkLT5lZGl0b3Io KTsKICAgICBpZiAoIWVkaXRvcikK