<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>37689</bug_id>
          
          <creation_ts>2010-04-15 18:26:16 -0700</creation_ts>
          <short_desc>Update FormDataList to fix style violations in old code.</short_desc>
          <delta_ts>2010-04-22 15:51:11 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore JavaScript</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P3</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Jian Li">jianli</reporter>
          <assigned_to name="Jian Li">jianli</assigned_to>
          <cc>dimich</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>213158</commentid>
    <comment_count>0</comment_count>
    <who name="Jian Li">jianli</who>
    <bug_when>2010-04-15 18:26:16 -0700</bug_when>
    <thetext>It is pointed out when dimich reviewed bug 36678: 

  the style bot complained because the change happens around old code with
style violation in it. Perhaps it would be nice to have a separate patch to fix
the style of that code.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>213159</commentid>
    <comment_count>1</comment_count>
      <attachid>53500</attachid>
    <who name="Jian Li">jianli</who>
    <bug_when>2010-04-15 18:27:39 -0700</bug_when>
    <thetext>Created attachment 53500
Proposed Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>213161</commentid>
    <comment_count>2</comment_count>
      <attachid>53500</attachid>
    <who name="Dmitry Titov">dimich</who>
    <bug_when>2010-04-15 18:30:33 -0700</bug_when>
    <thetext>Comment on attachment 53500
Proposed Patch

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>216118</commentid>
    <comment_count>3</comment_count>
    <who name="Jian Li">jianli</who>
    <bug_when>2010-04-22 15:51:11 -0700</bug_when>
    <thetext>Committed as http://trac.webkit.org/changeset/57726.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>53500</attachid>
            <date>2010-04-15 18:27:39 -0700</date>
            <delta_ts>2010-04-15 18:30:33 -0700</delta_ts>
            <desc>Proposed Patch</desc>
            <filename>37689</filename>
            <type>text/plain</type>
            <size>1614</size>
            <attacher name="Jian Li">jianli</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg
MTcxNGM4OC4uYjAwNWUxYSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi
Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0wNC0xNSAgSmlhbiBMaSAgPGpp
YW5saUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku
CisKKyAgICAgICAgVXBkYXRlIEZvcm1EYXRhTGlzdCB0byBmaXggc3R5bGUgdmlvbGF0aW9ucyBp
biBvbGQgY29kZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp
P2lkPTM3Njg5CisKKyAgICAgICAgKiBodG1sL0Zvcm1EYXRhTGlzdC5oOgorICAgICAgICAoV2Vi
Q29yZTo6Rm9ybURhdGFMaXN0OjphcHBlbmREYXRhKToKKyAgICAgICAgKFdlYkNvcmU6OkZvcm1E
YXRhTGlzdDo6YXBwZW5kQmxvYik6CisKIDIwMTAtMDQtMTUgIFl1cnkgU2VtaWtoYXRza3kgIDx5
dXJ5c0Bnb29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFBhdmVsIEZlbGRtYW4uCmRp
ZmYgLS1naXQgYS9XZWJDb3JlL2h0bWwvRm9ybURhdGFMaXN0LmggYi9XZWJDb3JlL2h0bWwvRm9y
bURhdGFMaXN0LmgKaW5kZXggNGJmOGNhZi4uOGVjZjY0ZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9o
dG1sL0Zvcm1EYXRhTGlzdC5oCisrKyBiL1dlYkNvcmUvaHRtbC9Gb3JtRGF0YUxpc3QuaApAQCAt
MzIsMTMgKzMyLDI1IEBAIHB1YmxpYzoKICAgICBGb3JtRGF0YUxpc3QoY29uc3QgVGV4dEVuY29k
aW5nJik7CiAKICAgICB2b2lkIGFwcGVuZERhdGEoY29uc3QgU3RyaW5nJiBrZXksIGNvbnN0IFN0
cmluZyYgdmFsdWUpCi0gICAgICAgIHsgYXBwZW5kU3RyaW5nKGtleSk7IGFwcGVuZFN0cmluZyh2
YWx1ZSk7IH0KKyAgICB7CisgICAgICAgIGFwcGVuZFN0cmluZyhrZXkpOworICAgICAgICBhcHBl
bmRTdHJpbmcodmFsdWUpOworICAgIH0KICAgICB2b2lkIGFwcGVuZERhdGEoY29uc3QgU3RyaW5n
JiBrZXksIGNvbnN0IFdURjo6Q1N0cmluZyYgdmFsdWUpCi0gICAgICAgIHsgYXBwZW5kU3RyaW5n
KGtleSk7IGFwcGVuZFN0cmluZyh2YWx1ZSk7IH0KKyAgICB7CisgICAgICAgIGFwcGVuZFN0cmlu
ZyhrZXkpOworICAgICAgICBhcHBlbmRTdHJpbmcodmFsdWUpOworICAgIH0KICAgICB2b2lkIGFw
cGVuZERhdGEoY29uc3QgU3RyaW5nJiBrZXksIGludCB2YWx1ZSkKLSAgICAgICAgeyBhcHBlbmRT
dHJpbmcoa2V5KTsgYXBwZW5kU3RyaW5nKFN0cmluZzo6bnVtYmVyKHZhbHVlKSk7IH0KKyAgICB7
CisgICAgICAgIGFwcGVuZFN0cmluZyhrZXkpOworICAgICAgICBhcHBlbmRTdHJpbmcoU3RyaW5n
OjpudW1iZXIodmFsdWUpKTsKKyAgICB9CiAgICAgdm9pZCBhcHBlbmRCbG9iKGNvbnN0IFN0cmlu
ZyYga2V5LCBQYXNzUmVmUHRyPEJsb2I+IGJsb2IpCi0gICAgICAgIHsgYXBwZW5kU3RyaW5nKGtl
eSk7IG1fbGlzdC5hcHBlbmQoYmxvYik7IH0KKyAgICB7CisgICAgICAgIGFwcGVuZFN0cmluZyhr
ZXkpOworICAgICAgICBtX2xpc3QuYXBwZW5kKGJsb2IpOworICAgIH0KIAogICAgIGNsYXNzIEl0
ZW0gewogICAgIHB1YmxpYzoK
</data>
<flag name="review"
          id="37266"
          type_id="1"
          status="+"
          setter="dimich"
    />
    <flag name="commit-queue"
          id="37267"
          type_id="3"
          status="-"
          setter="jianli"
    />
          </attachment>
      

    </bug>

</bugzilla>