37687 2010-04-15 17:52:32 -0700 Chromium: WebKit::WebURLResponse::addHTTPHeaderField will crash if response is invalid UTF-8 2010-04-16 11:19:45 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 ukai webkit-unassigned jianli oldest_to_newest 213140 0 ukai 2010-04-15 17:52:32 -0700 If HTTP response contains invalid UTF-8, WebKit::WebURLResponse::addHTTPHeaderField will crash. See more detail in http://code.google.com/p/chromium/issues/detail?id=41148 213141 1 53495 ukai 2010-04-15 17:54:57 -0700 Created attachment 53495 Patch 213303 2 53495 jianli 2010-04-16 11:09:20 -0700 Comment on attachment 53495 Patch r=me Please update the bug title and ChangeLog to replace "Chromium:" with "[Chromium]" before landing. Thanks. 213308 3 jianli 2010-04-16 11:14:46 -0700 There is also a typo in your ChangeLog. Please replace "ignore is" with "ignore if". 213312 4 ukai 2010-04-16 11:19:45 -0700 Committed r57728: <http://trac.webkit.org/changeset/57728> 53495 2010-04-15 17:54:57 -0700 2010-04-16 11:09:20 -0700 Patch bug-37687-20100416095455.patch text/plain 1299 ukai ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDRiYjc3ZGUuLjkyYTkwMGMgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsx LDEzIEBACisyMDEwLTA0LTE1ICBGdW1pdG9zaGkgVWthaSAgPHVrYWlAY2hyb21pdW0ub3JnPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENocm9taXVt OiBXZWJLaXQ6OldlYlVSTFJlc3BvbnNlOjphZGRIVFRQSGVhZGVyRmllbGQgd2lsbCBjcmFzaCBp ZiByZXNwb25zZSBpcyBpbnZhbGlkIFVURi04CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0zNzY4NworCisgICAgICAgICogc3JjL1dlYlVSTFJlc3BvbnNl LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViVVJMUmVzcG9uc2U6OmFkZEhUVFBIZWFkZXJGaWVs ZCk6IGlnbm9yZSBpcyBuYW1lIG9yIHZhbHVlIGlzIG51bGwgc3RyaW5nLgorCiAyMDEwLTA0LTE1 ICBBbGJlcnQgSi4gV29uZyAgPGFqd29uZ0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZp ZXdlZCwgcm9sbGluZyBvdXQgcjU3NjYwLgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2Nocm9taXVtL3Ny Yy9XZWJVUkxSZXNwb25zZS5jcHAgYi9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlVSTFJlc3BvbnNl LmNwcAppbmRleCA3N2ZjNjU1Li4zYjA2MDBjIDEwMDY0NAotLS0gYS9XZWJLaXQvY2hyb21pdW0v c3JjL1dlYlVSTFJlc3BvbnNlLmNwcAorKysgYi9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlVSTFJl c3BvbnNlLmNwcApAQCAtMTY1LDYgKzE2NSw4IEBAIHZvaWQgV2ViVVJMUmVzcG9uc2U6OnNldEhU VFBIZWFkZXJGaWVsZChjb25zdCBXZWJTdHJpbmcmIG5hbWUsIGNvbnN0IFdlYlN0cmluZyYKIAog dm9pZCBXZWJVUkxSZXNwb25zZTo6YWRkSFRUUEhlYWRlckZpZWxkKGNvbnN0IFdlYlN0cmluZyYg bmFtZSwgY29uc3QgV2ViU3RyaW5nJiB2YWx1ZSkKIHsKKyAgICBpZiAobmFtZS5pc051bGwoKSB8 fCB2YWx1ZS5pc051bGwoKSkKKyAgICAgICAgcmV0dXJuOwogICAgIC8vIEZJWE1FOiBBZGQgYW4g YWRkSFRUUEhlYWRlckZpZWxkIG1ldGhvZCB0byBSZXNvdXJjZVJlc3BvbnNlLgogICAgIGNvbnN0 IEhUVFBIZWFkZXJNYXAmIG1hcCA9IG1fcHJpdmF0ZS0+bV9yZXNvdXJjZVJlc3BvbnNlLT5odHRw SGVhZGVyRmllbGRzKCk7CiAgICAgU3RyaW5nIHZhbHVlU3RyKHZhbHVlKTsK