37683 2010-04-15 16:47:10 -0700 [Qt] WebCore::Font::font() causes a QFont detach 2010-04-20 12:05:58 -0700 1 1 1 Unclassified WebKit Text 528+ (Nightly build) All All CLOSED FIXED Qt P2 Normal --- 35784 1 hausmann hausmann commit-queue tonikitoo oldest_to_newest 213107 0 hausmann 2010-04-15 16:47:10 -0700 WebCore::Font::font() in platform/graphics/qt/FontQt.cpp calls f.setStyleStrategy(QFont::ForceIntegerMetrics); This causes the QFont object that is owned in FontPlatformData to get detached. Since the value is always the same, the setStyleStrategy call should be moved to FontPlatformData. 213116 1 53491 hausmann 2010-04-15 17:03:34 -0700 Created attachment 53491 Patch 213214 2 53491 commit-queue 2010-04-16 00:14:28 -0700 Comment on attachment 53491 Patch Clearing flags on attachment: 53491 Committed r57717: <http://trac.webkit.org/changeset/57717> 213215 3 commit-queue 2010-04-16 00:14:34 -0700 All reviewed patches have been landed. Closing bug. 213251 4 tonikitoo 2010-04-16 07:12:43 -0700 (build fix): Committed r57721: <http://trac.webkit.org/changeset/57721> 213256 5 hausmann 2010-04-16 08:08:50 -0700 Thanks Antonio! I don't know how that happened ;( I built with 4.7. Thanks for the fix! 214828 6 hausmann 2010-04-20 12:05:39 -0700 Revision r57717 cherry-picked into qtwebkit-2.0 with commit bed19437e88439572670da41126d0dc463be3298Revision r57721 cherry-picked into qtwebkit-2.0 with commit a4221d7729d4f1ea2a89982f23148c0c59fb9d41 53491 2010-04-15 17:03:34 -0700 2010-04-16 00:14:28 -0700 Patch bug-37683-20100416020332.patch text/plain 2050 hausmann ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NzcyYzI3YS4uZWNhYjBlMCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMC0wNC0xNSAgU2ltb24gSGF1c21h bm4gIDxzaW1vbi5oYXVzbWFubkBub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBXZWJDb3JlOjpGb250Ojpmb250KCkgY2F1c2Vz IGEgUUZvbnQgZGV0YWNoCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0zNzY4MworCisgICAgICAgIE1vdmVkIHRoZSBzZXRTdHlsZVN0cmF0ZWd5IGNhbGwg dG8gRm9udFBsYXRmb3JtRGF0YQorICAgICAgICB0byBhdm9pZCB0aGUgZGV0YWNoLgorCisgICAg ICAgIFRoYW5rcyB0byBIb2xnZXIgZm9yIHNwb3R0aW5nIHRoaXMuCisKKyAgICAgICAgKiBwbGF0 Zm9ybS9ncmFwaGljcy9xdC9Gb250UGxhdGZvcm1EYXRhUXQuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6Rm9udFBsYXRmb3JtRGF0YTo6Rm9udFBsYXRmb3JtRGF0YSk6CisgICAgICAgICogcGxhdGZv cm0vZ3JhcGhpY3MvcXQvRm9udFF0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZvbnQ6OmZvbnQp OgorCiAyMDEwLTA0LTE1ICBDaHJpcyBGbGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgQmV0aCBEYWtpbi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvcXQvRm9udFBsYXRmb3JtRGF0YVF0LmNwcCBiL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvcXQvRm9udFBsYXRmb3JtRGF0YVF0LmNwcAppbmRleCAwYTEwNzVmLi4wMDM5 NDJiIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0ZvbnRQbGF0Zm9y bURhdGFRdC5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9Gb250UGxhdGZv cm1EYXRhUXQuY3BwCkBAIC01OCw2ICs1OCw5IEBAIEZvbnRQbGF0Zm9ybURhdGE6OkZvbnRQbGF0 Zm9ybURhdGEoY29uc3QgRm9udERlc2NyaXB0aW9uJiBkZXNjcmlwdGlvbiwgY29uc3QgQXRvCiAg ICAgZm9udC5zZXRMZXR0ZXJTcGFjaW5nKFFGb250OjpBYnNvbHV0ZVNwYWNpbmcsIGxldHRlclNw YWNpbmcpOwogICAgIGNvbnN0IGJvb2wgc21hbGxDYXBzID0gZGVzY3JpcHRpb24uc21hbGxDYXBz KCk7CiAgICAgZm9udC5zZXRDYXBpdGFsaXphdGlvbihzbWFsbENhcHMgPyBRRm9udDo6U21hbGxD YXBzIDogUUZvbnQ6Ok1peGVkQ2FzZSk7CisjaWYgUVRfVkVSU0lPTiA+PSBRVF9WRVJTSU9OX0NI RUNLKDQsIDcsIDApCisgICAgZi5zZXRTdHlsZVN0cmF0ZWd5KFFGb250OjpGb3JjZUludGVnZXJN ZXRyaWNzKTsKKyNlbmRpZgogCiAgICAgbV9kYXRhLT5ib2xkID0gZm9udC5ib2xkKCk7CiAgICAg bV9kYXRhLT5zaXplID0gZm9udC5wb2ludFNpemVGKCk7CmRpZmYgLS1naXQgYS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL3F0L0ZvbnRRdC5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L3F0L0ZvbnRRdC5jcHAKaW5kZXggOGMxN2NjZC4uOTc0YzE3OSAxMDA2NDQKLS0tIGEvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9Gb250UXQuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvcXQvRm9udFF0LmNwcApAQCAtMjI3LDExICsyMjcsNiBAQCBRRm9udCBGb250Ojpm b250KCkgY29uc3QKICAgICAgICAgZi5zZXRMZXR0ZXJTcGFjaW5nKFFGb250OjpBYnNvbHV0ZVNw YWNpbmcsIG1fbGV0dGVyU3BhY2luZyk7CiAgICAgaWYgKG1fd29yZFNwYWNpbmcgIT0gMCkKICAg ICAgICAgZi5zZXRXb3JkU3BhY2luZyhtX3dvcmRTcGFjaW5nKTsKLQotI2lmIFFUX1ZFUlNJT04g Pj0gUVRfVkVSU0lPTl9DSEVDSyg0LCA3LCAwKQotICAgIGYuc2V0U3R5bGVTdHJhdGVneShRRm9u dDo6Rm9yY2VJbnRlZ2VyTWV0cmljcyk7Ci0jZW5kaWYKLQogICAgIHJldHVybiBmOwogfQogCg==