37681 2010-04-15 16:11:49 -0700 Remove the main frame check when injecting v8 extensions into a script context 2010-04-15 23:20:44 -0700 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) PC Windows Vista RESOLVED FIXED P2 Normal --- 1 mpcomplete mpcomplete commit-queue oldest_to_newest 213096 0 mpcomplete 2010-04-15 16:11:49 -0700 Previously we had restricted v8 extensions to script contexts where both the frame and its main frame had matched that extension's scheme restriction. I want to remove the main frame check. Chromium can make this check elsewhere, which gives us finer-grained control over what extensions run and what APIs are exposed to web content. This is related to Chromium bug http://code.google.com/p/chromium/issues/detail?id=37920 . 213102 1 53486 mpcomplete 2010-04-15 16:35:46 -0700 Created attachment 53486 simple patch 213121 2 53486 abarth 2010-04-15 17:08:11 -0700 Comment on attachment 53486 simple patch Ok. I never liked that check. :) Grabbing the URL off the activeDocumentLoader is kind of scary, but is probably ok. 213203 3 53486 commit-queue 2010-04-15 23:20:39 -0700 Comment on attachment 53486 simple patch Clearing flags on attachment: 53486 Committed r57715: <http://trac.webkit.org/changeset/57715> 213204 4 commit-queue 2010-04-15 23:20:44 -0700 All reviewed patches have been landed. Closing bug. 53486 2010-04-15 16:35:46 -0700 2010-04-15 23:20:39 -0700 simple patch iframe.patch text/plain 1802 mpcomplete SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gV2ViQ29yZS9DaGFuZ2VM b2cJKHJldmlzaW9uIDU3NjgzKQorKysgV2ViQ29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkK QEAgLTEsMyArMSwxNiBAQAorMjAxMC0wNC0xNSAgTWF0dCBQZXJyeSAgPG1wY29tcGxldGVAY2hy b21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFJlbW92ZSB0aGUgY2hlY2sgZm9yIHRoZSBtYWluIGZyYW1lJ3Mgc2NoZW1lIHdoZW4gZGVj aWRpbmcgd2hpY2gKKyAgICAgICAgdjggZXh0ZW5zaW9ucyB0byBhZGQgdG8gYSBzY3JpcHQgY29u dGV4dC4gSW5zdGVhZCwgQ2hyb21pdW0gd2lsbAorICAgICAgICBoYW5kbGUgdGhhdCBjaGVjayBl bHNld2hlcmUgdG8gYWxsb3cgZmluZXItZ3JhaW5lZCBjb250cm9sIG92ZXIKKyAgICAgICAgd2hh dCBBUElzIHdlIGV4cG9zZSB0byB3ZWIgcGFnZXMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNzY4MQorCisgICAgICAgICogYmluZGluZ3MvdjgvVjhE T01XaW5kb3dTaGVsbC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpWOERPTVdpbmRvd1NoZWxsOjpj cmVhdGVOZXdDb250ZXh0KToKKwogMjAxMC0wNC0xNSAgQWRhbSBSb2JlbiAgPGFyb2JlbkBhcHBs ZS5jb20+CiAKICAgICAgICAgRXhwb3NlIFVzZXJDb250ZW50VVJMUGF0dGVybiBhcyBXZWJLaXQg U1BJCkluZGV4OiBXZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4RE9NV2luZG93U2hlbGwuY3BwDQo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09DQotLS0gV2ViQ29yZS9iaW5kaW5ncy92OC9WOERPTVdpbmRvd1NoZWxsLmNwcAkocmV2 aXNpb24gNTc2ODMpCisrKyBXZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4RE9NV2luZG93U2hlbGwuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC0zMzEsNyArMzMxLDcgQEAgdjg6OlBlcnNpc3RlbnQ8djg6OkNv bnRleHQ+IFY4RE9NV2luZG93UwogICAgICAgICAvLyBOb3RlOiB3ZSBjaGVjayB0aGUgbG9hZGVy IFVSTCBoZXJlIGluc3RlYWQgb2YgdGhlIGRvY3VtZW50IFVSTAogICAgICAgICAvLyBiZWNhdXNl IHdlIG1pZ2h0IGJlIGN1cnJlbnRseSBsb2FkaW5nIGFuIFVSTCBpbnRvIGEgYmxhbmsgcGFnZS4K ICAgICAgICAgLy8gU2VlIGh0dHA6Ly9jb2RlLmdvb2dsZS5jb20vcC9jaHJvbWl1bS9pc3N1ZXMv ZGV0YWlsP2lkPTEwOTI0Ci0gICAgICAgIGlmIChleHRlbnNpb25zW2ldLnNjaGVtZS5sZW5ndGgo KSA+IDAgJiYgKGV4dGVuc2lvbnNbaV0uc2NoZW1lICE9IG1fZnJhbWUtPmxvYWRlcigpLT5hY3Rp dmVEb2N1bWVudExvYWRlcigpLT51cmwoKS5wcm90b2NvbCgpIHx8IGV4dGVuc2lvbnNbaV0uc2No ZW1lICE9IG1fZnJhbWUtPnBhZ2UoKS0+bWFpbkZyYW1lKCktPmxvYWRlcigpLT5hY3RpdmVEb2N1 bWVudExvYWRlcigpLT51cmwoKS5wcm90b2NvbCgpKSkKKyAgICAgICAgaWYgKGV4dGVuc2lvbnNb aV0uc2NoZW1lLmxlbmd0aCgpID4gMCAmJiAoZXh0ZW5zaW9uc1tpXS5zY2hlbWUgIT0gbV9mcmFt ZS0+bG9hZGVyKCktPmFjdGl2ZURvY3VtZW50TG9hZGVyKCktPnVybCgpLnByb3RvY29sKCkpKQog ICAgICAgICAgICAgY29udGludWU7CiAKICAgICAgICAgZXh0ZW5zaW9uTmFtZXNbaW5kZXgrK10g PSBleHRlbnNpb25zW2ldLmV4dGVuc2lvbi0+bmFtZSgpOwo=