37677 2010-04-15 14:46:12 -0700 Include codereview issue number in patch description 2010-04-15 15:18:28 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ojan webkit-unassigned oldest_to_newest 213063 0 ojan 2010-04-15 14:46:12 -0700 Include codereview issue number in patch description 213064 1 53480 ojan 2010-04-15 14:46:59 -0700 Created attachment 53480 Patch 213065 2 53480 abarth 2010-04-15 14:48:58 -0700 Comment on attachment 53480 Patch Ok. We'll probably want to change this at some point, but this seems fine to experiment with. 213082 3 ojan 2010-04-15 15:18:28 -0700 Committed r57679: <http://trac.webkit.org/changeset/57679> 53480 2010-04-15 14:46:59 -0700 2010-04-15 14:48:58 -0700 Patch bug-37677-20100415144658.patch text/plain 2536 ojan ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCAwZDUxZjhlLi5kOTAxNTRkIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTAtMDQt MTUgIE9qYW4gVmFmYWkgIDxvamFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbmNsdWRlIGNvZGVyZXZpZXcgaXNzdWUgbnVt YmVyIGluIHBhdGNoIGRlc2NyaXB0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0zNzY3NworCisgICAgICAgIFRoaXMgbGV0cyB1cyBrbm93IHdoaWNo IHJpZXR2ZWxkIGlzc3VlIHRoaXMgcGF0Y2ggaXMgdGllZCB0by4KKworICAgICAgICBBbHNvLCBt YWtlIGl0IHNvIHRoYXQgLS1mYW5jeS1yZXZpZXcgb3ZlcnJpZGVzIC0tbm8tcmV2aWV3LgorCisg ICAgICAgICogU2NyaXB0cy93ZWJraXRweS90b29sL3N0ZXBzL3Bvc3Rjb2RlcmV2aWV3LnB5Ogor ICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvdG9vbC9zdGVwcy9wb3N0ZGlmZi5weToKKwogMjAx MC0wNC0xMyAgT2phbiBWYWZhaSAgPG9qYW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmll d2VkIGJ5IERhdmlkIExldmluLgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJr aXRweS90b29sL3N0ZXBzL3Bvc3Rjb2RlcmV2aWV3LnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93 ZWJraXRweS90b29sL3N0ZXBzL3Bvc3Rjb2RlcmV2aWV3LnB5CmluZGV4IDRkYTUyODUuLjNlN2Vk NzYgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zdGVwcy9w b3N0Y29kZXJldmlldy5weQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wv c3RlcHMvcG9zdGNvZGVyZXZpZXcucHkKQEAgLTQzLDggKzQzLDYgQEAgY2xhc3MgUG9zdENvZGVS ZXZpZXcoQWJzdHJhY3RTdGVwKToKICAgICBkZWYgcnVuKHNlbGYsIHN0YXRlKToKICAgICAgICAg aWYgbm90IHNlbGYuX29wdGlvbnMuZmFuY3lfcmV2aWV3OgogICAgICAgICAgICAgcmV0dXJuCi0g ICAgICAgIGlmIG5vdCBzZWxmLl9vcHRpb25zLnJldmlldzoKLSAgICAgICAgICAgIHJldHVybgog ICAgICAgICAjIEZJWE1FOiBUaGlzIHdpbGwgYWx3YXlzIGJlIE5vbmUgYmVjYXVzZSB3ZSBkb24n dCByZXRyaWV2ZSB0aGUgaXNzdWUKICAgICAgICAgIyAgICAgICAgbnVtYmVyIGZyb20gdGhlIENo YW5nZUxvZyB5ZXQuCiAgICAgICAgIGNvZGVyZXZpZXdfaXNzdWUgPSBzdGF0ZS5nZXQoImNvZGVy ZXZpZXdfaXNzdWUiKQpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS90 b29sL3N0ZXBzL3Bvc3RkaWZmLnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29s L3N0ZXBzL3Bvc3RkaWZmLnB5CmluZGV4IDViMjgzODMuLjZhM2RlZTQgMTAwNjQ0Ci0tLSBhL1dl YktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zdGVwcy9wb3N0ZGlmZi5weQorKysgYi9X ZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc3RlcHMvcG9zdGRpZmYucHkKQEAgLTQ4 LDggKzQ4LDEwIEBAIGNsYXNzIFBvc3REaWZmKEFic3RyYWN0U3RlcCk6CiAgICAgICAgIGRlc2Ny aXB0aW9uID0gc2VsZi5fb3B0aW9ucy5kZXNjcmlwdGlvbiBvciAiUGF0Y2giCiAgICAgICAgIGNv bW1lbnRfdGV4dCA9IE5vbmUKICAgICAgICAgY29kZXJldmlld19pc3N1ZSA9IHN0YXRlLmdldCgi Y29kZXJldmlld19pc3N1ZSIpCisgICAgICAgICMgSW5jbHVkZSBjb2RlcmV2aWV3IGlzc3VlIG51 bWJlciBpbiBwYXRjaCBuYW1lLiBUaGlzIGlzIGEgYml0IG9mIGEgaGFjaywKKyAgICAgICAgIyBi dXQgaXQgbWFrZXMgZG9pbmcgdGhlIHJpZXR2ZWxkIGludGVncmF0aW9uIGEgbG90IGVhc2llci4K ICAgICAgICAgaWYgY29kZXJldmlld19pc3N1ZToKLSAgICAgICAgICAgIGNvbW1lbnRfdGV4dCA9 ICJGZWVsIGZyZWUgdG8gcHJvdmlkZSBjb21tZW50cyBhdCAlcyIgJSBzZWxmLl90b29sLmNvZGVy ZXZpZXcudXJsX2Zvcl9pc3N1ZShjb2RlcmV2aWV3X2lzc3VlKQorICAgICAgICAgICAgZGVzY3Jp cHRpb24gKz0gIi0lcyIgJSBzdGF0ZVsiY29kZXJldmlld19pc3N1ZSJdCiAgICAgICAgIHNlbGYu X3Rvb2wuYnVncy5hZGRfcGF0Y2hfdG9fYnVnKHN0YXRlWyJidWdfaWQiXSwgZGlmZl9maWxlLCBk ZXNjcmlwdGlvbiwgY29tbWVudF90ZXh0PWNvbW1lbnRfdGV4dCwgbWFya19mb3JfcmV2aWV3PXNl bGYuX29wdGlvbnMucmV2aWV3LCBtYXJrX2Zvcl9jb21taXRfcXVldWU9c2VsZi5fb3B0aW9ucy5y ZXF1ZXN0X2NvbW1pdCkKICAgICAgICAgaWYgc2VsZi5fb3B0aW9ucy5vcGVuX2J1ZzoKICAgICAg ICAgICAgIHNlbGYuX3Rvb2wudXNlci5vcGVuX3VybChzZWxmLl90b29sLmJ1Z3MuYnVnX3VybF9m b3JfYnVnX2lkKHN0YXRlWyJidWdfaWQiXSkpCg==