37655 2010-04-15 06:28:06 -0700 [v8] mark Array.prototype.sort tests which verify if sorting is stable as passing for Chromium 2010-04-15 13:28:43 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 antonm webkit-unassigned ager ajwong commit-queue levin oldest_to_newest 212827 0 53430 antonm 2010-04-15 06:28:06 -0700 Created attachment 53430 First take Recently algorithm for sorting small arrays (<= 22 elements) was changed and now sorting for those arrays is stable. Note that larger arrays are sorted with quick sort, so sorting is not stable for them. 212870 1 levin 2010-04-15 08:33:57 -0700 I would update the comment in test_expectation.txt because it is very confusing to see "// V8 doesn't stable sort and we currently have no intention of // changing this." Followed by two passing tests which are marked as WONTFIX! Reading your comment in this bug it completely makes sense. 212874 2 antonm 2010-04-15 08:43:55 -0700 (In reply to comment #1) > I would update the comment in test_expectation.txt because it is very confusing > to see > "// V8 doesn't stable sort and we currently have no intention of > // changing this." > Followed by two passing tests which are marked as WONTFIX! > > Reading your comment in this bug it completely makes sense. :) David, if you have any suggestions how to make it more obvious, I'd really appreciate that. 212879 3 levin 2010-04-15 08:59:46 -0700 Perhaps: "// V8 doesn't stable sort and we currently have no intention of // changing this. The following test only happen to pass due to // the current algorithm used for sorting small arrays. If larger // arrays were used in the tests, they would fail." 212887 4 53442 antonm 2010-04-15 09:36:27 -0700 Created attachment 53442 Changing the wording per David suggestion 212889 5 antonm 2010-04-15 09:37:23 -0700 (In reply to comment #3) > Perhaps: > "// V8 doesn't stable sort and we currently have no intention of > // changing this. The following test only happen to pass due to > // the current algorithm used for sorting small arrays. If larger > // arrays were used in the tests, they would fail." Thanks, David, changed as per your suggestion. 212969 6 53442 antonm 2010-04-15 12:04:31 -0700 Comment on attachment 53442 Changing the wording per David suggestion Thanks a lot, David 213001 7 53442 commit-queue 2010-04-15 13:28:37 -0700 Comment on attachment 53442 Changing the wording per David suggestion Clearing flags on attachment: 53442 Committed r57666: <http://trac.webkit.org/changeset/57666> 213002 8 commit-queue 2010-04-15 13:28:43 -0700 All reviewed patches have been landed. Closing bug. 53430 2010-04-15 06:28:06 -0700 2010-04-15 09:36:20 -0700 First take LT.patch text/plain 1441 antonm SW5kZXg6IHRoaXJkX3BhcnR5L1dlYktpdC9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gdGhpcmRfcGFydHkvV2ViS2l0L0xheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24g NTc2NDEpCisrKyB0aGlyZF9wYXJ0eS9XZWJLaXQvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTEgQEAKKzIwMTAtMDQtMTUgIEFudG9uIE11aGluICAgPGFu dG9ubUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgTWFyayBBcnJheS5wcm90b3R5cGUuc29ydCB0ZXN0cyB3aGljaCB2ZXJpZnkg aWYgc29ydGluZyBpcyBzdGFibGUgYXMgcGFzc2luZyBmb3IgQ2hyb21pdW0KKworICAgICAgICAq IHBsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dDoKKwogMjAxMC0wNC0xNSAg QW50b24gTXVoaW4gICA8YW50b25tQGNocm9taXVtLm9yZz4KIAogICAgICAgICBOb3QgcmV2aWV3 ZWQsIHNoZXJpZmZpbmcuCkluZGV4OiB0aGlyZF9wYXJ0eS9XZWJLaXQvTGF5b3V0VGVzdHMvcGxh dGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0Cj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHRoaXJk X3BhcnR5L1dlYktpdC9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0 aW9ucy50eHQJKHJldmlzaW9uIDU3NjQwKQorKysgdGhpcmRfcGFydHkvV2ViS2l0L0xheW91dFRl c3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dAkod29ya2luZyBjb3B5 KQpAQCAtNDE1LDggKzQxNSw4IEBAIFdPTlRGSVggOiBmYXN0L2RvbS9nZXR0ZXItb24td2luZG93 LW9iamUKIC8vIFY4IGRvZXNuJ3Qgc3RhYmxlIHNvcnQgYW5kIHdlIGN1cnJlbnRseSBoYXZlIG5v IGludGVudGlvbiBvZgogLy8gY2hhbmdpbmcgdGhpcy4gSXQgaXMgdHJhY2tlZCBieToKIC8vIGh0 dHA6Ly9jb2RlLmdvb2dsZS5jb20vcC92OC9pc3N1ZXMvZGV0YWlsP2lkPTkwCi1XT05URklYIDog ZmFzdC9qcy9jb21wYXJlZm4tc29ydC1zdGFiaWxpdHkuaHRtbCA9IEZBSUwKLVdPTlRGSVggOiBm YXN0L2pzL3NvcnQtc3RhYmlsaXR5Lmh0bWwgPSBGQUlMCitXT05URklYIDogZmFzdC9qcy9jb21w YXJlZm4tc29ydC1zdGFiaWxpdHkuaHRtbCA9IFBBU1MKK1dPTlRGSVggOiBmYXN0L2pzL3NvcnQt c3RhYmlsaXR5Lmh0bWwgPSBQQVNTCiAKIC8vIFdlIGhhdmUgbm8gaW5kaWNhdGlvbiB0aGF0IGFu eW9uZSBtaXNzZXMgdGhpcyBhbmQgaGF2ZSBjdXJyZW50bHkgbm8KIC8vIGludGVudGlvbiBvZiBp bXBsZW1lbnRpbmcgaXQuCg== 53442 2010-04-15 09:36:27 -0700 2010-04-15 13:28:37 -0700 Changing the wording per David suggestion bug-37655-20100415203625.patch text/plain 1693 antonm ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBjYzU2MmI2Li4wOTU4ODFjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMDQt MTUgIEFudG9uIE11aGluICA8YW50b25tQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbdjhdIG1hcmsgQXJyYXkucHJvdG90eXBl LnNvcnQgdGVzdHMgd2hpY2ggdmVyaWZ5IGlmIHNvcnRpbmcgaXMgc3RhYmxlIGFzIHBhc3Npbmcg Zm9yIENocm9taXVtCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0zNzY1NQorCisgICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlv bnMudHh0OgorCiAyMDEwLTA0LTE1ICBBbnRvbiBNdWhpbiAgIDxhbnRvbm1AY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIE5vdCByZXZpZXdlZCwgc2hlcmlmZmluZy4KZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dCBiL0xheW91dFRl c3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dAppbmRleCBlMDJhM2I5 Li5hOTkyN2UyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0 X2V4cGVjdGF0aW9ucy50eHQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vdGVz dF9leHBlY3RhdGlvbnMudHh0CkBAIC00MTMsMTAgKzQxMywxMiBAQCBXT05URklYIDogaHR0cC90 ZXN0cy9oaXN0b3J5L3JlZGlyZWN0LW1ldGEtcmVmcmVzaC0wLXNlY29uZHMuaHRtbCA9IEZBSUwK IFdPTlRGSVggOiBmYXN0L2RvbS9nZXR0ZXItb24td2luZG93LW9iamVjdDIuaHRtbCA9IEZBSUwK IAogLy8gVjggZG9lc24ndCBzdGFibGUgc29ydCBhbmQgd2UgY3VycmVudGx5IGhhdmUgbm8gaW50 ZW50aW9uIG9mCi0vLyBjaGFuZ2luZyB0aGlzLiBJdCBpcyB0cmFja2VkIGJ5OgotLy8gaHR0cDov L2NvZGUuZ29vZ2xlLmNvbS9wL3Y4L2lzc3Vlcy9kZXRhaWw/aWQ9OTAKLVdPTlRGSVggOiBmYXN0 L2pzL2NvbXBhcmVmbi1zb3J0LXN0YWJpbGl0eS5odG1sID0gRkFJTAotV09OVEZJWCA6IGZhc3Qv anMvc29ydC1zdGFiaWxpdHkuaHRtbCA9IEZBSUwKKy8vIGNoYW5naW5nIHRoaXMuICBUaGUgZm9s bG93aW5nIHRlc3RzIG9ubHkgaGFwcGVuIHRvIHBhc3MgZHVlIHRvCisvLyB0aGUgY3VycmVudCBh bGdvcml0aG0gdXNlZCBmb3Igc29ydGluZyBzbWFsbCBhcnJheXMuIElmIGxhcmdlcgorLy8gYXJy YXlzIHdlcmUgdXNlZCBpbiB0aGUgdGVzdHMsIHRoZXkgd291bGQgZmFpbC4KKy8vIEl0IGlzIHRy YWNrZWQgYnk6IGh0dHA6Ly9jb2RlLmdvb2dsZS5jb20vcC92OC9pc3N1ZXMvZGV0YWlsP2lkPTkw CitXT05URklYIDogZmFzdC9qcy9jb21wYXJlZm4tc29ydC1zdGFiaWxpdHkuaHRtbCA9IFBBU1MK K1dPTlRGSVggOiBmYXN0L2pzL3NvcnQtc3RhYmlsaXR5Lmh0bWwgPSBQQVNTCiAKIC8vIFdlIGhh dmUgbm8gaW5kaWNhdGlvbiB0aGF0IGFueW9uZSBtaXNzZXMgdGhpcyBhbmQgaGF2ZSBjdXJyZW50 bHkgbm8KIC8vIGludGVudGlvbiBvZiBpbXBsZW1lbnRpbmcgaXQuCg==