37635 2010-04-14 21:11:32 -0700 Spatial Navigation: make hasOffscreenRect() to earlier return 'true' if absoluteClippedOverflowRect() gives an empty rect 2010-04-20 13:22:24 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) PC All CLOSED FIXED P2 Normal --- 18662 35784 1 tonikitoo tonikitoo dglazkov eric gustavo hausmann kenneth simon.fraser webkit-ews webkit.review.bot xan.lopez oldest_to_newest 212734 0 tonikitoo 2010-04-14 21:11:32 -0700 absoluteClippedOverflowRect implemention does return an empty rect for offscreen nodes. so hasOffscreenRect (SpatialNavigation.cpp) can bail out earlier in such cases. see related discussion in webkit-dev in [1] [1] http://lists.macosforge.org/pipermail/webkit-dev/2010-March/012075.html 212737 1 53405 tonikitoo 2010-04-14 21:17:04 -0700 Created attachment 53405 patch v1 212738 2 webkit.review.bot 2010-04-14 21:20:14 -0700 Attachment 53405 did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/1591506 212739 3 webkit.review.bot 2010-04-14 21:23:12 -0700 Attachment 53405 did not build on gtk: Build output: http://webkit-commit-queue.appspot.com/results/1552523 212740 4 eric 2010-04-14 21:23:31 -0700 Attachment 53405 did not build on mac: Build output: http://webkit-commit-queue.appspot.com/results/1689241 212741 5 webkit-ews 2010-04-14 21:24:44 -0700 Attachment 53405 did not build on qt: Build output: http://webkit-commit-queue.appspot.com/results/1686255 212860 6 53438 tonikitoo 2010-04-15 08:15:05 -0700 Created attachment 53438 (committed: r57663) patch v2 same as patch v1, but un-bitrotted and builds 212980 7 53438 tonikitoo 2010-04-15 12:39:44 -0700 Comment on attachment 53438 (committed: r57663) patch v2 Clearing flags on attachment: 53438 Committed r57663: <http://trac.webkit.org/changeset/57663> 212981 8 tonikitoo 2010-04-15 12:40:52 -0700 Thank you Simon Fraser! 214912 9 hausmann 2010-04-20 13:22:10 -0700 Revision r57663 cherry-picked into qtwebkit-2.0 with commit bf61de5859ad29d41a76791862ac4c02b336d6da 53405 2010-04-14 21:17:04 -0700 2010-04-15 08:15:05 -0700 patch v1 0001-Spatial-Navigation-make-hasOffscreenRect-to-earli.patch text/plain 2269 tonikitoo RnJvbSA2NGQ1ZWIxMDhkNmEzZDkxNzQ5ZTVkNmFhODhlNjlmOGJiMzNmZDAyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRvbmlvIEdvbWVzIDx0b25pa2l0b29Ad2Via2l0Lm9yZz4K RGF0ZTogVGh1LCAxNSBBcHIgMjAxMCAwMDoxMzozOCAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIFNw YXRpYWwgTmF2aWdhdGlvbjogbWFrZSBoYXNPZmZzY3JlZW5SZWN0KCkgdG8gZWFybGllciByZXR1 cm4gJ3RydWUnIGlmIGFic29sdXRlQ2xpcHBlZE92ZXJmbG93UmVjdCgpIGdpdmVzIGFuIGVtcHR5 IHJlY3QKIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNzYzNQoKUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuClBhdGNoIGJ5IEFudG9uaW8gR29tZXMgPHRvbmlraXRv b0B3ZWJraXQub3JnPgoKYWJzb2x1dGVDbGlwcGVkT3ZlcmZsb3dSZWN0IG1ldGhvZCBvZiBSZW5k ZXJPYmplY3QgZG9lcyByZXR1cm4gYW4gZW1wdHkgSW50UmVjdCBmb3Igb2Zmc2NyZWVuIG5vZGVz LgpTbyBoYXNPZmZzY3JlZW5SZWN0IG1ldGhvZCAoU3BhdGlhbE5hdmlnYXRpb24uY3BwKSBjYW4g c2FmaWx5IGJhaWwgb3V0IGVhcmxpZXIgaW4gc3VjaCBjYXNlcy4KCiogcGFnZS9TcGF0aWFsTmF2 aWdhdGlvbi5jcHA6CihXZWJDb3JlOjpoYXNPZmZzY3JlZW5SZWN0KToKLS0tCiBXZWJDb3JlL0No YW5nZUxvZyAgICAgICAgICAgICAgICAgIHwgICAxMyArKysrKysrKysrKysrCiBXZWJDb3JlL3Bh Z2UvU3BhdGlhbE5hdmlnYXRpb24uY3BwIHwgICAgMiArKwogMiBmaWxlcyBjaGFuZ2VkLCAxNSBp bnNlcnRpb25zKCspLCAwIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdl TG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTY2MjQyOC4uNzg3ZDYwNSAxMDA2NDQKLS0t IGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTIsNiArMiwx OSBAQAogCiAgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgogCisgICAgICAgIFNw YXRpYWwgTmF2aWdhdGlvbjogbWFrZSBoYXNPZmZzY3JlZW5SZWN0KCkgdG8gZWFybGllciByZXR1 cm4gJ3RydWUnIGlmIGFic29sdXRlQ2xpcHBlZE92ZXJmbG93UmVjdCgpIGdpdmVzIGFuIGVtcHR5 IHJlY3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM3 NjM1CisKKyAgICAgICAgYWJzb2x1dGVDbGlwcGVkT3ZlcmZsb3dSZWN0IG1ldGhvZCBvZiBSZW5k ZXJPYmplY3QgZG9lcyByZXR1cm4gYW4gZW1wdHkgSW50UmVjdCBmb3Igb2Zmc2NyZWVuIG5vZGVz LgorICAgICAgICBTbyBoYXNPZmZzY3JlZW5SZWN0IG1ldGhvZCAoU3BhdGlhbE5hdmlnYXRpb24u Y3BwKSBjYW4gc2FmaWx5IGJhaWwgb3V0IGVhcmxpZXIgaW4gc3VjaCBjYXNlcy4KKworICAgICAg ICAqIHBhZ2UvU3BhdGlhbE5hdmlnYXRpb24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6aGFzT2Zm c2NyZWVuUmVjdCk6CisKKzIwMTAtMDQtMTQgIEFudG9uaW8gR29tZXMgIDx0b25pa2l0b29Ad2Vi a2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwogICAgICAg ICBTcGF0aWFsIE5hdmlnYXRpb246IHJlbW92ZSB1bm5lY2Vzc2VyeSBhc3NpZ25tZW50IGluIHVw ZGF0ZUZvY3VzQ2FuZGlkYXRlSWZDbG9zZXIgbWV0aG9kCiAgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNzYzNAogCmRpZmYgLS1naXQgYS9XZWJDb3JlL3Bh Z2UvU3BhdGlhbE5hdmlnYXRpb24uY3BwIGIvV2ViQ29yZS9wYWdlL1NwYXRpYWxOYXZpZ2F0aW9u LmNwcAppbmRleCAyYWVkZTcxLi45YmI5MDNkIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BhZ2UvU3Bh dGlhbE5hdmlnYXRpb24uY3BwCisrKyBiL1dlYkNvcmUvcGFnZS9TcGF0aWFsTmF2aWdhdGlvbi5j cHAKQEAgLTQzNSw2ICs0MzUsOCBAQCBib29sIGhhc09mZnNjcmVlblJlY3QoTm9kZSogbm9kZSkK ICAgICAgICAgcmV0dXJuIHRydWU7CiAKICAgICBJbnRSZWN0IHJlY3QocmVuZGVyLT5hYnNvbHV0 ZUNsaXBwZWRPdmVyZmxvd1JlY3QoKSk7CisgICAgaWYgKHJlY3QuaXNFbXB0eSgpKQorICAgICAg ICByZXR1cm4gdHJ1ZTsKIAogICAgIGlmICgocmVjdC53aWR0aCgpICsgMiAqIGZ1ZGdlRmFjdG9y KCkgPiAwKSAmJiAocmVjdC5oZWlnaHQoKSArIDIgKiBmdWRnZUZhY3RvcigpID4gMCkpCiAgICAg ICAgIHJlY3QuaW5mbGF0ZShmdWRnZUZhY3RvcigpKTsKLS0gCjEuNi4wLjQKCg== 53438 2010-04-15 08:15:05 -0700 2010-04-15 12:39:44 -0700 (committed: r57663) patch v2 0001-Spatial-Navigation-make-hasOffscreenRect-to-earli.patch text/plain 2198 tonikitoo RnJvbSA1ODNiYTZjNGE3Y2JlN2EyN2QxODVhNmJjMmI1NzkzYmEyOWRmOWNkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRvbmlvIEdvbWVzIDx0b25pa2l0b29Ad2Via2l0Lm9yZz4K RGF0ZTogVGh1LCAxNSBBcHIgMjAxMCAwMDoxMzozOCAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIFNw YXRpYWwgTmF2aWdhdGlvbjogbWFrZSBoYXNPZmZzY3JlZW5SZWN0KCkgdG8gZWFybGllciByZXR1 cm4gJ3RydWUnIGlmIGFic29sdXRlQ2xpcHBlZE92ZXJmbG93UmVjdCgpIGdpdmVzIGFuIGVtcHR5 IHJlY3QKIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNzYzNQoKUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuClBhdGNoIGJ5IEFudG9uaW8gR29tZXMgPHRvbmlraXRv b0B3ZWJraXQub3JnPgoKYWJzb2x1dGVDbGlwcGVkT3ZlcmZsb3dSZWN0IG1ldGhvZCBvZiBSZW5k ZXJPYmplY3QgZG9lcyByZXR1cm4gYW4gZW1wdHkgSW50UmVjdCBmb3Igb2Zmc2NyZWVuIG5vZGVz LgpTbyBoYXNPZmZzY3JlZW5SZWN0IG1ldGhvZCAoU3BhdGlhbE5hdmlnYXRpb24uY3BwKSBjYW4g c2FmaWx5IGJhaWwgb3V0IGVhcmxpZXIgaW4gc3VjaCBjYXNlcy4KCiogcGFnZS9TcGF0aWFsTmF2 aWdhdGlvbi5jcHA6CihXZWJDb3JlOjpoYXNPZmZzY3JlZW5SZWN0KToKLS0tCiBXZWJDb3JlL0No YW5nZUxvZyAgICAgICAgICAgICAgICAgIHwgICAxMyArKysrKysrKysrKysrCiBXZWJDb3JlL3Bh Z2UvU3BhdGlhbE5hdmlnYXRpb24uY3BwIHwgICAgMyArKysKIDIgZmlsZXMgY2hhbmdlZCwgMTYg aW5zZXJ0aW9ucygrKSwgMCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5n ZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGQxNWYwODAuLmUyMjUwNGMgMTAwNjQ0Ci0t LSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0yLDYgKzIs MTkgQEAKIAogICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KIAorICAgICAgICBT cGF0aWFsIE5hdmlnYXRpb246IG1ha2UgaGFzT2Zmc2NyZWVuUmVjdCgpIHRvIGVhcmxpZXIgcmV0 dXJuICd0cnVlJyBpZiBhYnNvbHV0ZUNsaXBwZWRPdmVyZmxvd1JlY3QoKSBnaXZlcyBhbiBlbXB0 eSByZWN0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0z NzYzNQorCisgICAgICAgIGFic29sdXRlQ2xpcHBlZE92ZXJmbG93UmVjdCBtZXRob2Qgb2YgUmVu ZGVyT2JqZWN0IGRvZXMgcmV0dXJuIGFuIGVtcHR5IEludFJlY3QgZm9yIG9mZnNjcmVlbiBub2Rl cy4KKyAgICAgICAgU28gaGFzT2Zmc2NyZWVuUmVjdCBtZXRob2QgKFNwYXRpYWxOYXZpZ2F0aW9u LmNwcCkgY2FuIHNhZmlseSBiYWlsIG91dCBlYXJsaWVyIGluIHN1Y2ggY2FzZXMuCisKKyAgICAg ICAgKiBwYWdlL1NwYXRpYWxOYXZpZ2F0aW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Omhhc09m ZnNjcmVlblJlY3QpOgorCisyMDEwLTA0LTE0ICBBbnRvbmlvIEdvbWVzICA8dG9uaWtpdG9vQHdl YmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKICAgICAg ICAgU3BhdGlhbCBOYXZpZ2F0aW9uOiByZW1vdmUgdW5uZWNlc3NlcnkgYXNzaWdubWVudCBpbiB1 cGRhdGVGb2N1c0NhbmRpZGF0ZUlmQ2xvc2VyIG1ldGhvZAogICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzc2MzQKIApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9w YWdlL1NwYXRpYWxOYXZpZ2F0aW9uLmNwcCBiL1dlYkNvcmUvcGFnZS9TcGF0aWFsTmF2aWdhdGlv bi5jcHAKaW5kZXggNDRlMDdmYS4uODkwZWFjZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wYWdlL1Nw YXRpYWxOYXZpZ2F0aW9uLmNwcAorKysgYi9XZWJDb3JlL3BhZ2UvU3BhdGlhbE5hdmlnYXRpb24u Y3BwCkBAIC00MzYsNiArNDM2LDkgQEAgYm9vbCBoYXNPZmZzY3JlZW5SZWN0KE5vZGUqIG5vZGUp CiAgICAgICAgIHJldHVybiB0cnVlOwogCiAgICAgSW50UmVjdCByZWN0KHJlbmRlci0+YWJzb2x1 dGVDbGlwcGVkT3ZlcmZsb3dSZWN0KCkpOworICAgIGlmIChyZWN0LmlzRW1wdHkoKSkKKyAgICAg ICAgcmV0dXJuIHRydWU7CisKICAgICByZXR1cm4gIWNvbnRhaW5lclZpZXdwb3J0UmVjdC5pbnRl cnNlY3RzKHJlY3QpOwogfQogCi0tIAoxLjYuMC40Cgo=