37634 2010-04-14 21:01:20 -0700 Spatial Navigation: remove unnecessery assignment in updateFocusCandidateIfCloser method 2010-04-15 12:43:20 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 18662 35874 1 tonikitoo tonikitoo kenneth simon.fraser oldest_to_newest 212729 0 tonikitoo 2010-04-14 21:01:20 -0700 in the quoted code below, the assignment line is not needed any more after bug 36168 (patch 51940) landed. @@ -364,8 +364,6 @@ static void updateFocusCandidateIfCloser(Node* focusedNode, const FocusCandidate if (closest.alignment < candidate.alignment && closest.parentAlignment < candidate.alignment) closest.distance = maxDistance(); - - closest.alignment = candidate.alignment; } reason, all assignment takes place lines below in the same method, and not class member by class member. in other words, now instead of: closest.alignment = candidate.alignment, we have closest = candidate later on in the same method. 212733 1 53404 tonikitoo 2010-04-14 21:06:16 -0700 Created attachment 53404 (committed: r57662) patch v1 212983 2 53404 tonikitoo 2010-04-15 12:42:27 -0700 Comment on attachment 53404 (committed: r57662) patch v1 Clearing flags on attachment: 53434 Committed r57662: <http://trac.webkit.org/changeset/57662> 212984 3 tonikitoo 2010-04-15 12:43:20 -0700 Thank you Simon Fraser! 53404 2010-04-14 21:06:16 -0700 2010-04-15 12:42:27 -0700 (committed: r57662) patch v1 0001-Spatial-Navigation-remove-unnecessery-assignment-in.patch text/plain 2177 tonikitoo RnJvbSBiNzUxMTNlMjA3NzhlZDM4YzUzYTYyYjg5YjdhY2NjNjVjYWQ0ZTQzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRvbmlvIEdvbWVzIDx0b25pa2l0b29Ad2Via2l0Lm9yZz4K RGF0ZTogVGh1LCAxNSBBcHIgMjAxMCAwMDowNToxMCAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIFNw YXRpYWwgTmF2aWdhdGlvbjogcmVtb3ZlIHVubmVjZXNzZXJ5IGFzc2lnbm1lbnQgaW4gdXBkYXRl Rm9jdXNDYW5kaWRhdGVJZkNsb3NlciBtZXRob2QKIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0zNzYzNAoKUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuClBhdGNoIGJ5 IEFudG9uaW8gR29tZXMgPHRvbmlraXRvb0B3ZWJraXQub3JnPgoKVGhpcyBhc3NpZ25tZW50IGxp bmUgaXMgbm90IGxvbmdlciBuZWVkZWQgYWZ0ZXIgcjU3MDYxLCBidWcgdGhhdCByZWZhY3RvcmVk IGFsbAphc3NpZ25tZW50IGxvZ2ljIHRvIGhhcHBlbiBsaW5lcyBiZWxvdyBpbiB0aGUgbWV0aG9k LgoKKiBwYWdlL0ZvY3VzQ29udHJvbGxlci5jcHA6CihXZWJDb3JlOjp1cGRhdGVGb2N1c0NhbmRp ZGF0ZUlmQ2xvc2VyKToKLS0tCiBXZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICB8ICAg MTMgKysrKysrKysrKysrKwogV2ViQ29yZS9wYWdlL0ZvY3VzQ29udHJvbGxlci5jcHAgfCAgICAy IC0tCiAyIGZpbGVzIGNoYW5nZWQsIDEzIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpk aWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBh NzQ3MzMxLi45NjYyNDI4IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJD b3JlL0NoYW5nZUxvZwpAQCAtMiw2ICsyLDE5IEBACiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCiAKKyAgICAgICAgU3BhdGlhbCBOYXZpZ2F0aW9uOiByZW1vdmUgdW5uZWNl c3NlcnkgYXNzaWdubWVudCBpbiB1cGRhdGVGb2N1c0NhbmRpZGF0ZUlmQ2xvc2VyIG1ldGhvZAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzc2MzQKKwor ICAgICAgICBUaGlzIGFzc2lnbm1lbnQgbGluZSBpcyBub3QgbG9uZ2VyIG5lZWRlZCBhZnRlciBy NTcwNjEsIGJ1ZyB0aGF0IHJlZmFjdG9yZWQgYWxsCisgICAgICAgIGFzc2lnbm1lbnQgbG9naWMg dG8gaGFwcGVuIGxpbmVzIGJlbG93IGluIHRoZSBtZXRob2QuCisKKyAgICAgICAgKiBwYWdlL0Zv Y3VzQ29udHJvbGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjp1cGRhdGVGb2N1c0NhbmRpZGF0 ZUlmQ2xvc2VyKToKKworMjAxMC0wNC0xNCAgQW50b25pbyBHb21lcyAgPHRvbmlraXRvb0B3ZWJr aXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCiAgICAgICAg IFNwYXRpYWwgTmF2aWdhdGlvbjogdXNlIGEgc3RhdGljIHZhciBpbiBtYXhEaXN0YW5jZSBtZXRo b2QgKCBTcGF0aWFsTmF2aWdhdGlvbi5oICkKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTM3NjMzCiAKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGFnZS9Gb2N1 c0NvbnRyb2xsZXIuY3BwIGIvV2ViQ29yZS9wYWdlL0ZvY3VzQ29udHJvbGxlci5jcHAKaW5kZXgg OTQwMjdhYS4uNmRiOWVmNCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wYWdlL0ZvY3VzQ29udHJvbGxl ci5jcHAKKysrIGIvV2ViQ29yZS9wYWdlL0ZvY3VzQ29udHJvbGxlci5jcHAKQEAgLTM2NCw4ICsz NjQsNiBAQCBzdGF0aWMgdm9pZCB1cGRhdGVGb2N1c0NhbmRpZGF0ZUlmQ2xvc2VyKE5vZGUqIGZv Y3VzZWROb2RlLCBjb25zdCBGb2N1c0NhbmRpZGF0ZQogICAgICAgICBpZiAoY2xvc2VzdC5hbGln bm1lbnQgPCBjYW5kaWRhdGUuYWxpZ25tZW50CiAgICAgICAgICAmJiBjbG9zZXN0LnBhcmVudEFs aWdubWVudCA8IGNhbmRpZGF0ZS5hbGlnbm1lbnQpCiAgICAgICAgICAgICBjbG9zZXN0LmRpc3Rh bmNlID0gbWF4RGlzdGFuY2UoKTsKLQotICAgICAgICBjbG9zZXN0LmFsaWdubWVudCA9IGNhbmRp ZGF0ZS5hbGlnbm1lbnQ7CiAgICAgfQogCiAgICAgLy8gQmFpbCBvdXQgaWYgY2FuZGlkYXRlJ3Mg ZGlzdGFuY2UgaXMgbGFyZ2VyIHRoYW4gdGhhdCBvZiB0aGUgY2xvc2VzdCBjYW5kaWRhdGUuCi0t IAoxLjYuMC40Cgo=