37631 2010-04-14 19:20:35 -0700 new-run-webkit-tests should not assume the test driver is called "DumpRenderTree" 2010-04-15 15:09:28 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 dpranke dpranke abarth dglazkov eric ojan pam tony victorw webkit.review.bot oldest_to_newest 212700 0 dpranke 2010-04-14 19:20:35 -0700 In https://bugs.webkit.org/show_bug.cgi?id=37371 , abarth reported (correctly) that "test_shell" means nothing to the webkit.org community, and renamed everything to DumpRenderTree (or dump_render_tree). This has three problems. The first is that DumpRenderTree equally means nothing to non-webkitters (or, at least not as much). If we had to choose a single name, I could admit that picking DumpRenderTree is better than test_shell just in terms of familiarity in the community (although, like several other changes that have been landing lately, I fear that these are being done at the risk of confusing the people in Chromium that do know this code the best and yet perhaps aren't being kept in the loop - people like tc@, ojan@, victorw@, pamg@, etc., all copied here). The second is that if you happen to be testing multiple platforms that do use different names, using an inaccurate name is confusing. I was thrown when, the first time after that patch landed (and I didn't realize it) suddenly my chromium regressions were mentioning DumpRenderTree; I was worried that I was using the wrong command line switches. Of course, even Chromium isn't consistent here (test_shell on Win and Linux, TestShell on the Mac). So, we should make the user-visible name get pulled from the Port. The third problem -- as the other bug also mentioned -- is that both DumpRenderTree and test_shell aren't great names (which is why I used Driver as the class name, which admittedly also isn't a great name). Given that the script uses a standard master-slave design, perhaps we should call these "slaves", "workers", or "children" instead? I notice that you at least renamed --num-test-shells to --child-processes, so maybe we should use that instead? 212702 1 abarth 2010-04-14 19:44:46 -0700 1) We can change the UI if you like. 2) We have a team killing test_shell and replacing it with DumpRenderTree for the Chromium port, so this problem will solve itself naturally. 212705 2 dpranke 2010-04-14 19:48:19 -0700 (In reply to comment #1) > 1) We can change the UI if you like. > Yeah, I'm about to submit a patch to do so :) > 2) We have a team killing test_shell and replacing it with DumpRenderTree for > the Chromium port, so this problem will solve itself naturally. Yes, I know. I look forward to it, but would like to avoid confusion (not the least of which is my own) in the meantime. 212706 3 tony 2010-04-14 19:48:46 -0700 FWIW, I'm in support of just calling in DumpRenderTree (or DRT). Chromium devs can learn to adapt. Maybe we should have a gyp step that copies test_shell to DumpRenderTree :) 212708 4 dpranke 2010-04-14 19:56:36 -0700 As long as DumpRenderTree has the ability to generate text-only diffs (which are prefered) and pixel dumps (which are sometimes necessary), I continue to think its name should be changed :) 212713 5 53401 dpranke 2010-04-14 20:03:10 -0700 Created attachment 53401 Patch 212985 6 53401 dglazkov 2010-04-15 12:51:18 -0700 Comment on attachment 53401 Patch ok. 213027 7 53401 dpranke 2010-04-15 14:01:21 -0700 Comment on attachment 53401 Patch Clearing flags on attachment: 53401 Committed r57672: <http://trac.webkit.org/changeset/57672> 213028 8 dpranke 2010-04-15 14:01:27 -0700 All reviewed patches have been landed. Closing bug. 213076 9 webkit.review.bot 2010-04-15 15:09:28 -0700 http://trac.webkit.org/changeset/57672 might have broken Tiger Intel Release The following changes are on the blame list: http://trac.webkit.org/changeset/57672 http://trac.webkit.org/changeset/57673 http://trac.webkit.org/changeset/57674 http://trac.webkit.org/changeset/57675 http://trac.webkit.org/changeset/57676 53401 2010-04-14 20:03:10 -0700 2010-04-15 14:01:20 -0700 Patch bug-37631-20100414200309.patch text/plain 5546 dpranke ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA1ZDgwYTIyLi44YzVmNDZiIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTAtMDQt MTQgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGEgd2F5IHRvIG92ZXJyaWRlIHRo ZSB1c2VyLXZpc2libGUgbmFtZSBmb3IgdGhlIHRlc3QgYmluYXJ5IHNpbmNlCisgICAgICAgIHNv bWUgcG9ydHMgZG9uJ3QgY2FsbCBpdCBEdW1wUmVuZGVyVHJlZSAoZS5nLiwgQ2hyb21pdW0gV2lu IHVzZXMKKyAgICAgICAgdGVzdF9zaGVsbCwgQ2hyb21pdW0gTWFjIHVzZXMgVGVzdFNoZWxsKSBi eSBhZGRpbmcgYSBkcml2ZXJfbmFtZSgpCisgICAgICAgIG1ldGhvZCB0byB0aGUgUG9ydCBpbnRl cmZhY2UuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTM3NjMxCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Jh c2UucHk6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJv bWl1bS5weToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2No cm9taXVtX21hYy5weToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9y dW5fd2Via2l0X3Rlc3RzLnB5OgorCiAyMDEwLTA0LTE1ICBEaXJrIFByYW5rZSAgPGRwcmFua2VA Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFydGguCmRpZmYgLS1n aXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Jhc2Uu cHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Jhc2Uu cHkKaW5kZXggOGIyMmE5NS4uZmJkNjI1NCAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0 cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9iYXNlLnB5CisrKyBiL1dlYktpdFRvb2xzL1Nj cmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvYmFzZS5weQpAQCAtMTYxLDYgKzE2MSwx MyBAQCBjbGFzcyBQb3J0KG9iamVjdCk6CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBhY3R1YWxfZmlsZW5hbWUpCiAgICAgICAgIHJldHVybiAnJy5qb2luKGRpZmYpCiAKKyAg ICBkZWYgZHJpdmVyX25hbWUoc2VsZik6CisgICAgICAgICIiIlJldHVybnMgdGhlIG5hbWUgb2Yg dGhlIGFjdHVhbCBiaW5hcnkgdGhhdCBpcyBwZXJmb3JtaW5nIHRoZSB0ZXN0LAorICAgICAgICBz byB0aGF0IGl0IGNhbiBiZSByZWZlcnJlZCB0byBpbiBsb2cgbWVzc2FnZXMuIEluIG1vc3QgY2Fz ZXMgdGhpcworICAgICAgICB3aWxsIGJlIER1bXBSZW5kZXJUcmVlLCBidXQgaWYgYSBwb3J0IHVz ZXMgYSBiaW5hcnkgd2l0aCBhIGRpZmZlcmVudAorICAgICAgICBuYW1lLCBpdCBjYW4gYmUgb3Zl cnJpZGRlbiBoZXJlLiIiIgorICAgICAgICByZXR1cm4gIkR1bXBSZW5kZXJUcmVlIgorCiAgICAg ZGVmIGV4cGVjdGVkX2Jhc2VsaW5lcyhzZWxmLCBmaWxlbmFtZSwgc3VmZml4LCBhbGxfYmFzZWxp bmVzPUZhbHNlKToKICAgICAgICAgIiIiR2l2ZW4gYSB0ZXN0IG5hbWUsIGZpbmRzIHdoZXJlIHRo ZSBiYXNlbGluZSByZXN1bHRzIGFyZSBsb2NhdGVkLgogCmRpZmYgLS1naXQgYS9XZWJLaXRUb29s cy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtLnB5IGIvV2ViS2l0 VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bS5weQppbmRl eCA1YjkwYjg1Li5iNjYxODRjIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtp dHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtLnB5CisrKyBiL1dlYktpdFRvb2xzL1Njcmlw dHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW0ucHkKQEAgLTExMyw2ICsxMTMs OSBAQCBjbGFzcyBDaHJvbWl1bVBvcnQoYmFzZS5Qb3J0KToKICAgICAgICAgcmV0dXJuIGNoZWNr X2ZpbGVfZXhpc3RzKGltYWdlX2RpZmZfcGF0aCwgJ2ltYWdlIGRpZmYgZXhlJywKICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIG92ZXJyaWRlX3N0ZXAsIGxvZ2dpbmcpCiAKKyAgICBk ZWYgZHJpdmVyX25hbWUoc2VsZik6CisgICAgICAgIHJldHVybiAidGVzdF9zaGVsbCIKKwogICAg IGRlZiBwYXRoX2Zyb21fY2hyb21pdW1fYmFzZShzZWxmLCAqY29tcHMpOgogICAgICAgICAiIiJS ZXR1cm5zIHRoZSBmdWxsIHBhdGggdG8gcGF0aCBtYWRlIGJ5IGpvaW5pbmcgdGhlIHRvcCBvZiB0 aGUKICAgICAgICAgQ2hyb21pdW0gc291cmNlIHRyZWUgYW5kIHRoZSBsaXN0IG9mIHBhdGggY29t cG9uZW50cyBpbiB8KmNvbXBzfC4iIiIKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMv d2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW1fbWFjLnB5IGIvV2ViS2l0VG9vbHMv U2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bV9tYWMucHkKaW5kZXgg MmQ5YjFhMy4uODBiNWMyNiAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRw eS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bV9tYWMucHkKKysrIGIvV2ViS2l0VG9vbHMvU2Ny aXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bV9tYWMucHkKQEAgLTY2LDYg KzY2LDEwIEBAIGNsYXNzIENocm9taXVtTWFjUG9ydChjaHJvbWl1bS5DaHJvbWl1bVBvcnQpOgog ICAgICAgICAgICAgICAgICAgICAgICAnTWFjQnVpbGRJbnN0cnVjdGlvbnMnKQogICAgICAgICBy ZXR1cm4gcmVzdWx0CiAKKyAgICBkZWYgZHJpdmVyX25hbWUoc2VsZik6CisgICAgICAgICIiIm5h bWUgZm9yIHRoaXMgcG9ydCdzIGVxdWl2YWxlbnQgb2YgRHVtcFJlbmRlclRyZWUuIiIiCisgICAg ICAgIHJldHVybiAiVGVzdFNoZWxsIgorCiAgICAgZGVmIHRlc3RfcGxhdGZvcm1fbmFtZShzZWxm KToKICAgICAgICAgIyBXZSB1c2UgJ21hYycgaW5zdGVhZCBvZiAnY2hyb21pdW0tbWFjJwogICAg ICAgICByZXR1cm4gJ21hYycKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0 cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHMucHkgYi9XZWJLaXRUb29scy9TY3JpcHRz L3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzLnB5CmluZGV4IGQ2ZTU5MGEu LmVlZDE4YjAgMTAwNzU1Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0 X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHMucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJr aXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0cy5weQpAQCAtMjcsNyArMjcsNyBAQAog IyAoSU5DTFVESU5HIE5FR0xJR0VOQ0UgT1IgT1RIRVJXSVNFKSBBUklTSU5HIElOIEFOWSBXQVkg T1VUIE9GIFRIRSBVU0UKICMgT0YgVEhJUyBTT0ZUV0FSRSwgRVZFTiBJRiBBRFZJU0VEIE9GIFRI RSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4KIAotIiIiUnVuIGxheW91dCB0ZXN0cyB1c2lu ZyBEdW1wUmVuZGVyVHJlZS4KKyIiIlJ1biBsYXlvdXQgdGVzdHMuCiAKIFRoaXMgaXMgYSBwb3J0 IG9mIHRoZSBleGlzdGluZyB3ZWJraXQgdGVzdCBzY3JpcHQgcnVuLXdlYmtpdC10ZXN0cy4KIApA QCAtNTU4LDcgKzU1OCwxMSBAQCBjbGFzcyBUZXN0UnVubmVyOgogICAgICAgICAgICAgICBpbiB0 aGUgZm9ybSB7ZmlsZW5hbWU6ZmlsZW5hbWUsIHRlc3RfcnVuX3RpbWU6dGVzdF9ydW5fdGltZX0K ICAgICAgICAgICAgIHJlc3VsdF9zdW1tYXJ5OiBzdW1tYXJ5IG9iamVjdCB0byBwb3B1bGF0ZSB3 aXRoIHRoZSByZXN1bHRzCiAgICAgICAgICIiIgotICAgICAgICBzZWxmLl9tZXRlci51cGRhdGUo J1N0YXJ0aW5nIER1bXBSZW5kZXJUcmVlcyAuLi4nKQorICAgICAgICBwbHVyYWwgPSAiIgorICAg ICAgICBpZiBzZWxmLl9vcHRpb25zLmNoaWxkX3Byb2Nlc3NlcyA+IDE6CisgICAgICAgICAgICBw bHVyYWwgPSAicyIKKyAgICAgICAgc2VsZi5fbWV0ZXIudXBkYXRlKCdTdGFydGluZyAlcyVzIC4u LicgJQorICAgICAgICAgICAgICAgICAgICAgICAgICAgKHNlbGYuX3BvcnQuZHJpdmVyX25hbWUo KSwgcGx1cmFsKSkKICAgICAgICAgdGhyZWFkcyA9IHNlbGYuX2luc3RhbnRpYXRlX2R1bXBfcmVu ZGVyX3RyZWVfdGhyZWFkcyhmaWxlX2xpc3QsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcmVzdWx0X3N1bW1hcnkpCiAKQEAgLTY4 Niw4ICs2OTAsNyBAQCBjbGFzcyBUZXN0UnVubmVyOgogICAgICAgICBzZWxmLl93cml0ZV9qc29u X2ZpbGVzKHVuZXhwZWN0ZWRfcmVzdWx0cywgcmVzdWx0X3N1bW1hcnksCiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIGluZGl2aWR1YWxfdGVzdF90aW1pbmdzKQogCi0gICAgICAgICMgV3Jp dGUgdGhlIHN1bW1hcnkgdG8gZGlzayAocmVzdWx0cy5odG1sKSBhbmQgbWF5YmUgb3BlbiB0aGUK LSAgICAgICAgIyBEdW1wUmVuZGVyVHJlZSB0byB0aGlzIGZpbGUuCisgICAgICAgICMgV3JpdGUg dGhlIHN1bW1hcnkgdG8gZGlzayAocmVzdWx0cy5odG1sKSBhbmQgZGlzcGxheSBpdCBpZiByZXF1 ZXN0ZWQuCiAgICAgICAgIHdyb3RlX3Jlc3VsdHMgPSBzZWxmLl93cml0ZV9yZXN1bHRzX2h0bWxf ZmlsZShyZXN1bHRfc3VtbWFyeSkKICAgICAgICAgaWYgbm90IHNlbGYuX29wdGlvbnMubm9zaG93 X3Jlc3VsdHMgYW5kIHdyb3RlX3Jlc3VsdHM6CiAgICAgICAgICAgICBzZWxmLl9zaG93X3Jlc3Vs dHNfaHRtbF9maWxlKCkKQEAgLTE0MzYsNyArMTQzOSwxMSBAQCBkZWYgbWFpbihvcHRpb25zLCBh cmdzLCBwcmludF9yZXN1bHRzPVRydWUpOgogICAgICAgICBvcHRpb25zLmNoaWxkX3Byb2Nlc3Nl cyA9IHBvcnRfb2JqLmRlZmF1bHRfY2hpbGRfcHJvY2Vzc2VzKCkKIAogICAgIHdyaXRlID0gY3Jl YXRlX2xvZ2dpbmdfd3JpdGVyKG9wdGlvbnMsICdjb25maWcnKQotICAgIHdyaXRlKCJSdW5uaW5n ICVzIER1bXBSZW5kZXJUcmVlcyBpbiBwYXJhbGxlbCIgJSBvcHRpb25zLmNoaWxkX3Byb2Nlc3Nl cykKKyAgICBpZiBvcHRpb25zLmNoaWxkX3Byb2Nlc3NlcyA9PSAxOgorICAgICAgICB3cml0ZSgi UnVubmluZyBvbmUgJXMiICUgcG9ydF9vYmouZHJpdmVyX25hbWUpCisgICAgZWxzZToKKyAgICAg ICAgd3JpdGUoIlJ1bm5pbmcgJXMgJXNzIGluIHBhcmFsbGVsIiAlICgKKyAgICAgICAgICAgICAg b3B0aW9ucy5jaGlsZF9wcm9jZXNzZXMsIHBvcnRfb2JqLmRyaXZlcl9uYW1lKCkpKQogCiAgICAg aWYgbm90IG9wdGlvbnMudGltZV9vdXRfbXM6CiAgICAgICAgIGlmIG9wdGlvbnMuY29uZmlndXJh dGlvbiA9PSAiRGVidWciOgo=