37617 2010-04-14 15:36:41 -0700 [Qt] QScriptValue::inherits has a memory leak. 2010-04-14 20:17:43 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED Qt P2 Normal --- 31863 1 jedrzej.nowacki jedrzej.nowacki commit-queue jedrzej.nowacki kenneth kent.hansen oldest_to_newest 212621 0 jedrzej.nowacki 2010-04-14 15:36:41 -0700 Valgrind report memory leak inside QScriptValue::inherits. ==7532== 34 (24 direct, 10 indirect) bytes in 1 blocks are definitely lost in loss record 72 of 243 ==7532== at 0x4C221A7: malloc (vg_replace_malloc.c:195) ==7532== by 0x50BCBC4: WTF::fastMalloc(unsigned long) (FastMalloc.cpp:249) ==7532== by 0x5007369: WTF::FastAllocBase::operator new(unsigned long) (FastAllocBase.h:96) ==7532== by 0x50208BF: OpaqueJSString::create(unsigned short const*, unsigned int) (OpaqueJSString.h:45) ==7532== by 0x502051F: JSStringCreateWithUTF8CString (JSStringRef.cpp:50) ==7532== by 0x50026DD: QScriptConverter::toString(char const*) (qscriptconverter_p.h:63) ==7532== by 0x5004B50: QScriptValuePrivate::inherits(char const*) (qscriptvalue_p.h:765) ==7532== by 0x5003C04: QScriptValuePrivate::isError() (qscriptvalue_p.h:413) ==7532== by 0x500212D: QScriptValue::isError() const (qscriptvalue.cpp:291) ==7532== by 0x4064C5: tst_QScriptEngine::evaluateProgram() (tst_qscriptengine.cpp:161) ==7532== by 0x409C39: tst_QScriptEngine::qt_metacall(QMetaObject::Call, int, void**) (tst_qscriptengine.moc:90) 212625 1 53378 jedrzej.nowacki 2010-04-14 15:39:04 -0700 Created attachment 53378 Fix v1 212719 2 53378 commit-queue 2010-04-14 20:17:38 -0700 Comment on attachment 53378 Fix v1 Clearing flags on attachment: 53378 Committed r57628: <http://trac.webkit.org/changeset/57628> 212720 3 commit-queue 2010-04-14 20:17:43 -0700 All reviewed patches have been landed. Closing bug. 53378 2010-04-14 15:39:04 -0700 2010-04-14 20:17:38 -0700 Fix v1 memleak.diff text/plain 1546 jedrzej.nowacki ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCA2NmViNjI2Li5hMGZlM2IwIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0yLDYgKzIsMTgg QEAKIAogICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KIAorICAgICAgICBGaXgg YSBtZW1vcnkgbGVhayBpbiBRU2NyaXB0VmFsdWU6OmluaGVyaXRzLgorCisgICAgICAgIFtRdF0g UVNjcmlwdFZhbHVlOjppbmhlcml0cyBoYXMgYSBtZW1vcnkgbGVhay4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM3NjE3CisKKyAgICAgICAgKiBxdC9h cGkvcXNjcmlwdHZhbHVlX3AuaDoKKyAgICAgICAgKFFTY3JpcHRWYWx1ZVByaXZhdGU6OmluaGVy aXRzKToKKworMjAxMC0wNC0xNCAgSmVkcnplaiBOb3dhY2tpICA8amVkcnplai5ub3dhY2tpQG5v a2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwogICAgICAg ICBGaXggYSBmZXcgbWVtb3J5IGxlYWtzIGluIFFTY3JpcHRFbmdpbmUuCiAKICAgICAgICAgU3lu dGF4IGNoZWNraW5nIGNhdXNlZCBtZW1vcnkgbGVhaywgbm90IGFsbCB0ZW1wb3JhcnkgdmFyaWFi bGVzIHdlcmUgcmVsZWFzZWQuCmRpZmYgLS1naXQgYS9KYXZhU2NyaXB0Q29yZS9xdC9hcGkvcXNj cmlwdHZhbHVlX3AuaCBiL0phdmFTY3JpcHRDb3JlL3F0L2FwaS9xc2NyaXB0dmFsdWVfcC5oCmlu ZGV4IGU3YzZmZjguLmYwMDIyNDUgMTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRDb3JlL3F0L2FwaS9x c2NyaXB0dmFsdWVfcC5oCisrKyBiL0phdmFTY3JpcHRDb3JlL3F0L2FwaS9xc2NyaXB0dmFsdWVf cC5oCkBAIC03NjIsNyArNzYyLDkgQEAgYm9vbCBRU2NyaXB0VmFsdWVQcml2YXRlOjppbmhlcml0 cyhjb25zdCBjaGFyKiBuYW1lKQogewogICAgIFFfQVNTRVJUKGlzSlNCYXNlZCgpKTsKICAgICBK U09iamVjdFJlZiBnbG9iYWxPYmplY3QgPSBKU0NvbnRleHRHZXRHbG9iYWxPYmplY3QoY29udGV4 dCgpKTsKLSAgICBKU1ZhbHVlUmVmIGVycm9yID0gSlNPYmplY3RHZXRQcm9wZXJ0eShjb250ZXh0 KCksIGdsb2JhbE9iamVjdCwgUVNjcmlwdENvbnZlcnRlcjo6dG9TdHJpbmcobmFtZSksIDApOwor ICAgIEpTU3RyaW5nUmVmIGVycm9yQXR0ck5hbWUgPSBRU2NyaXB0Q29udmVydGVyOjp0b1N0cmlu ZyhuYW1lKTsKKyAgICBKU1ZhbHVlUmVmIGVycm9yID0gSlNPYmplY3RHZXRQcm9wZXJ0eShjb250 ZXh0KCksIGdsb2JhbE9iamVjdCwgZXJyb3JBdHRyTmFtZSwgLyogZXhjZXB0aW9uICovIDApOwor ICAgIEpTU3RyaW5nUmVsZWFzZShlcnJvckF0dHJOYW1lKTsKICAgICByZXR1cm4gSlNWYWx1ZUlz SW5zdGFuY2VPZkNvbnN0cnVjdG9yKGNvbnRleHQoKSwgdmFsdWUoKSwgSlNWYWx1ZVRvT2JqZWN0 KGNvbnRleHQoKSwgZXJyb3IsIC8qIGV4Y2VwdGlvbiAqLyAwKSwgLyogZXhjZXB0aW9uICovIDAp OwogfQogCg==