3761 2005-06-29 00:56:25 -0700 Code Cleanup: Remove all uncessary #include statements from .h files 2024-12-01 21:47:30 -0800 1 1 1 Unclassified WebKit New Bugs 412 Mac OS X 10.4 NEW GoodFirstBug P3 Enhancement --- 4749 31964 31965 31966 40350 1 eric webkit-unassigned akshay1992kalbhor ddkilzer fujii ggaren ian karlcow sam oldest_to_newest 13472 0 eric 2005-06-29 00:56:25 -0700 Code Cleanup: Remove all uncessary #include statements from .h files Many, many, many kwq (and khtml) files have uncessary #include statements in the headers, which causes massive compile-time dependencies... meaning that a single change in kwq header basically amounts to rebuilding all of WebCore (due to the header cascade. It would be really nice to see this cleaned up. I will eventually get around to it if noone else does.. but in case new WebCore hackers are looking for something easy (and useful), this is such a bug. 13473 1 eric 2005-06-29 00:58:33 -0700 To be clear: This means replacing things like: #include <qstring.h> with class QString; instead. This is only possible when QString is neither returned from a function in the class, nor used as an instance variable on the class itself. 17758 2 3611 arthur_webkit 2005-08-27 17:21:08 -0700 Created attachment 3611 please ignore This is my proposed patch to add support for optional identifiers to function expression statements. This is my first ever cvs patch, so please excuse any mistakes. 17759 3 3611 arthur_webkit 2005-08-27 17:24:20 -0700 Comment on attachment 3611 please ignore Sorry, sorry, wrong bugreport! Never mind my comments 17760 4 juhagman 2005-08-27 17:46:33 -0700 (In reply to comment #0) > in case new WebCore hackers are looking for something easy (and useful), this is such a bug. This sounds like my kind of a job! Are there any issues or tips I should know before I start doing the cleanup? Is there any difference where I should start? Should I make one enormous patch or several small ones? 17908 5 mjs 2005-08-30 02:23:26 -0700 I think doing it incrementally is a good idea. I did some of the work in 4749 391826 6 eric 2011-04-25 10:44:25 -0700 I tried this again with bug 40350. We should probably just dup these. 1732789 7 akshay1992kalbhor 2021-02-23 22:23:41 -0800 I know this is an old bug, but it seems beginner-friendly. Is the cleanup still going to help or are all files already clean? Any extra information would be helpful. 1732794 8 fujii 2021-02-23 23:16:08 -0800 See also: Bug 211821 – [IWYU] Try removing redundant includes in WTF implementation files Bug 211867 – [IWYU] Remove unnecessary includes from JSC implementation files 3611 2005-08-27 17:21:08 -0700 2005-08-27 17:24:20 -0700 please ignore NamedFuncExpr.txt text/plain 2902 arthur_webkit SW5kZXg6IGtqcy9ncmFtbWFyLnkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9yb290L0phdmFT Y3JpcHRDb3JlL2tqcy9ncmFtbWFyLnksdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMjYKZGlmZiAt cCAtdSAtcjEuMjYga2pzL2dyYW1tYXIueQotLS0ga2pzL2dyYW1tYXIueQkyNiBBdWcgMjAwNSAy Mzo0MjoxNyAtMDAwMAkxLjI2CisrKyBranMvZ3JhbW1hci55CTI4IEF1ZyAyMDA1IDAwOjE5OjI5 IC0wMDAwCkBAIC02NzIsMTAgKzY3MiwxMiBAQCBGdW5jdGlvbkRlY2xhcmF0aW9uOgogICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICB7ICQkID0gbmV3IEZ1bmNEZWNsTm9kZSgqJDIs ICQ0LCAkNik7IH0KIAogRnVuY3Rpb25FeHByOgotICAgIEZVTkNUSU9OICcoJyAnKScgRnVuY3Rp b25Cb2R5ICB7ICQkID0gbmV3IEZ1bmNFeHByTm9kZSgkNCk7IH0KKyAgICBGVU5DVElPTiAnKCcg JyknIEZ1bmN0aW9uQm9keSAgeyAkJCA9IG5ldyBGdW5jRXhwck5vZGUoSWRlbnRpZmllcjo6bnVs bCgpLCAkNCk7IH0KICAgfCBGVU5DVElPTiAnKCcgRm9ybWFsUGFyYW1ldGVyTGlzdCAnKScgRnVu Y3Rpb25Cb2R5Ci0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHsgJCQgPSBuZXcg RnVuY0V4cHJOb2RlKCQzLCAkNSk7IH0KLQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICB7ICQkID0gbmV3IEZ1bmNFeHByTm9kZShJZGVudGlmaWVyOjpudWxsKCksICQzLCAkNSk7 IH0KKyAgfCBGVU5DVElPTiBJREVOVCAnKCcgJyknIEZ1bmN0aW9uQm9keSAgICB7ICQkID0gbmV3 IEZ1bmNFeHByTm9kZSgqJDIsICQ1KTsgfQorICB8IEZVTkNUSU9OIElERU5UICcoJyBGb3JtYWxQ YXJhbWV0ZXJMaXN0ICcpJyBGdW5jdGlvbkJvZHkKKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgeyAkJCA9IG5ldyBGdW5jRXhwck5vZGUoKiQyLCAkNCwgJDYpOyB9CiA7CiAKIEZv cm1hbFBhcmFtZXRlckxpc3Q6CkluZGV4OiBranMvbm9kZXMuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZp bGU6IC9jdnMvcm9vdC9KYXZhU2NyaXB0Q29yZS9ranMvbm9kZXMuY3BwLHYKcmV0cmlldmluZyBy ZXZpc2lvbiAxLjc4CmRpZmYgLXAgLXUgLXIxLjc4IGtqcy9ub2Rlcy5jcHAKLS0tIGtqcy9ub2Rl cy5jcHAJMjYgQXVnIDIwMDUgMjM6NDY6MjcgLTAwMDAJMS43OAorKysga2pzL25vZGVzLmNwcAky OCBBdWcgMjAwNSAwMDoxOTozMCAtMDAwMApAQCAtMjExNyw3ICsyMTE3LDcgQEAgdm9pZCBGdW5j RGVjbE5vZGU6OnByb2Nlc3NGdW5jRGVjbChFeGVjUwogLy8gRUNNQSAxMwogVmFsdWVJbXAgKkZ1 bmNFeHByTm9kZTo6ZXZhbHVhdGUoRXhlY1N0YXRlICpleGVjKQogewotICBGdW5jdGlvbkltcCAq ZmltcCA9IG5ldyBEZWNsYXJlZEZ1bmN0aW9uSW1wKGV4ZWMsIElkZW50aWZpZXI6Om51bGwoKSwg Ym9keS5nZXQoKSwgZXhlYy0+Y29udGV4dCgpLmltcCgpLT5zY29wZUNoYWluKCkpOworICBGdW5j dGlvbkltcCAqZmltcCA9IG5ldyBEZWNsYXJlZEZ1bmN0aW9uSW1wKGV4ZWMsIGlkZW50LCBib2R5 LmdldCgpLCBleGVjLT5jb250ZXh0KCkuaW1wKCktPnNjb3BlQ2hhaW4oKSk7CiAgIFZhbHVlSW1w ICpyZXQoZmltcCk7CiAgIFZhbHVlSW1wICpwcm90byA9IGV4ZWMtPmxleGljYWxJbnRlcnByZXRl cigpLT5idWlsdGluT2JqZWN0KCktPmNvbnN0cnVjdChleGVjLCBMaXN0OjplbXB0eSgpKTsKICAg ZmltcC0+cHV0KGV4ZWMsIHByb3RvdHlwZVByb3BlcnR5TmFtZSwgcHJvdG8sIEludGVybmFsfERv bnREZWxldGUpOwpJbmRleDoga2pzL25vZGVzLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9y b290L0phdmFTY3JpcHRDb3JlL2tqcy9ub2Rlcy5oLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjI5 CmRpZmYgLXAgLXUgLXIxLjI5IGtqcy9ub2Rlcy5oCi0tLSBranMvbm9kZXMuaAkyNiBBdWcgMjAw NSAyMzo0NjoyNyAtMDAwMAkxLjI5CisrKyBranMvbm9kZXMuaAkyOCBBdWcgMjAwNSAwMDoxOToz MSAtMDAwMApAQCAtOTcwLDEyICs5NzAsMTQgQEAgbmFtZXNwYWNlIEtKUyB7CiAKICAgY2xhc3Mg RnVuY0V4cHJOb2RlIDogcHVibGljIE5vZGUgewogICBwdWJsaWM6Ci0gICAgRnVuY0V4cHJOb2Rl KEZ1bmN0aW9uQm9keU5vZGUgKmIpIDogcGFyYW0oMCksIGJvZHkoYikgeyB9Ci0gICAgRnVuY0V4 cHJOb2RlKFBhcmFtZXRlck5vZGUgKnAsIEZ1bmN0aW9uQm9keU5vZGUgKmIpCi0gICAgICA6IHBh cmFtKHAtPm5leHQpLCBib2R5KGIpIHsgcC0+bmV4dCA9IDA7IH0KKyAgICBGdW5jRXhwck5vZGUo Y29uc3QgSWRlbnRpZmllciAmaSwgRnVuY3Rpb25Cb2R5Tm9kZSAqYikKKyAgICAgIDogaWRlbnQo aSksIHBhcmFtKDApLCBib2R5KGIpIHsgfQorICAgIEZ1bmNFeHByTm9kZShjb25zdCBJZGVudGlm aWVyICZpLCBQYXJhbWV0ZXJOb2RlICpwLCBGdW5jdGlvbkJvZHlOb2RlICpiKQorICAgICAgOiBp ZGVudChpKSwgcGFyYW0ocC0+bmV4dCksIGJvZHkoYikgeyBwLT5uZXh0ID0gMDsgfQogICAgIFZh bHVlSW1wICpldmFsdWF0ZShFeGVjU3RhdGUgKmV4ZWMpOwogICAgIHZpcnR1YWwgdm9pZCBzdHJl YW1UbyhTb3VyY2VTdHJlYW0gJnMpIGNvbnN0OwogICBwcml2YXRlOgorICAgIElkZW50aWZpZXIg aWRlbnQ7CiAgICAga3htbGNvcmU6OlNoYXJlZFB0cjxQYXJhbWV0ZXJOb2RlPiBwYXJhbTsKICAg ICBreG1sY29yZTo6U2hhcmVkUHRyPEZ1bmN0aW9uQm9keU5vZGU+IGJvZHk7CiAgIH07Cg==