37606 2010-04-14 14:06:37 -0700 new-run-webkit-tests: make the retry step more explicit 2010-04-23 03:12:02 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 vestbo webkit-unassigned abarth dpranke eric ojan oldest_to_newest 212560 0 vestbo 2010-04-14 14:06:37 -0700 new-run-webkit-tests: make the retry step more explicit 212562 1 53366 vestbo 2010-04-14 14:09:24 -0700 Created attachment 53366 Patch 212566 2 53366 eric 2010-04-14 14:16:04 -0700 Comment on attachment 53366 Patch Did you mean to change it from log.debug to log.info? 212573 3 vestbo 2010-04-14 14:28:30 -0700 (In reply to comment #2) > (From update of attachment 53366 [details]) > Did you mean to change it from log.debug to log.info? Yes. Retries is on by default, so if you run without any flags (no --verbose), we will do retries but you won't see at which point we switched to retry mode. With info this line is printed even without --verbose, so the user sees what's going on (not just the meter changing from "Testing" to "Retrying"). 213619 4 53366 abarth 2010-04-17 10:59:46 -0700 Comment on attachment 53366 Patch I think we want to keep debug-level logging. The design is to only print one line of status, not spew to the console in non-verbose mode. 213620 5 dpranke 2010-04-17 11:02:23 -0700 I'm not a reviewer, so I can't R+ this, but I actually really like this change. I have also thought that it's a bit confusing to know when things are being retried, and I would like some visual separation between the initial set of failures and the retried set. 213621 6 dpranke 2010-04-17 11:04:12 -0700 Oh, additionally, the design is to only print one line of status, as you say, but it is okay to print things when something goes wrong (warnings, errors, etc). The fact that you have to retry thing qualifies in my book. The retry is not quite a warning, but it's a little more severe than a transient status message. 213626 7 53366 abarth 2010-04-17 11:12:00 -0700 Comment on attachment 53366 Patch ok. 213874 8 dpranke 2010-04-18 18:12:50 -0700 This patch is good, but if you felt like it, I would actually tweak it slightly. The current code supports more than one retry, but in practice we've never actually needed this. I suggest we change the counter to a boolean. Also, we should add a "--no-retry-failures" flag to not retry the failures at all. Let me know if you want to make these changes, or if you want to land the patch as is and let me change things, or if you want me to make the changes and land the revised patch 214304 9 dpranke 2010-04-19 16:05:54 -0700 Committed r57850: <http://trac.webkit.org/changeset/57850> 214305 10 dpranke 2010-04-19 16:06:21 -0700 patch landed (had to change the spelling of the name; apologies). 216358 11 vestbo 2010-04-23 03:12:02 -0700 (In reply to comment #10) > patch landed (had to change the spelling of the name; apologies). Thanks, np :) 53366 2010-04-14 14:09:24 -0700 2010-04-17 11:12:00 -0700 Patch bug-37606-20100414170923.patch text/plain 3084 vestbo ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA1MmNkMjc4Li5jNDFkZTFjIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0yLDYgKzIsMTkgQEAKIAogICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KIAorICAgICAgICBuZXctcnVuLXdlYmtpdC10 ZXN0czogbWFrZSB0aGUgcmV0cnkgc3RlcCBtb3JlIGV4cGxpY2l0CisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNzYwNgorCisgICAgICAgIEl0IG1pZ2h0 IGJlIGNvbmZ1c2luZyB0byBzZWUgdGhlIHRlc3QgYW5kIHBlcmNlbnQgY291bnRlcnMKKyAgICAg ICAgcmVzZXQgd2l0aG91dCBhbnkgbm90aWNlIG9mIHdoYXQncyBnb2luZyBvbiwgc28gd2UgbWFr ZSB0aGUKKyAgICAgICAgbWVzc2FnZSB0aGF0IGEgcmV0cnktcnVuIGlzIHN0YXJ0ZWQgZXhwbGlj aXQuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0 X3Rlc3RzLnB5OgorCisyMDEwLTA0LTE0ICBUb3IgQXJuZSBWZXN0YsO4ICA8dG9yLmFybmUudmVz dGJvQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwog ICAgICAgICBNYWtlIG5ldy1ydW4td2Via2l0LXRlc3RzIHdvcmsgZm9yIHRoZSBRdCBwb3J0CiAg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNzU4OAogCmRp ZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5f d2Via2l0X3Rlc3RzLnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVz dHMvcnVuX3dlYmtpdF90ZXN0cy5weQppbmRleCA5NjkyZmYyLi45MDQxMzBiIDEwMDc1NQotLS0g YS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rl c3RzLnB5CisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1 bl93ZWJraXRfdGVzdHMucHkKQEAgLTIwMSw2ICsyMDEsOCBAQCBjbGFzcyBUZXN0UnVubmVyOgog ICAgICAgICBzZWxmLl9jdXJyZW50X3Byb2dyZXNzX3N0ciA9ICIiCiAgICAgICAgIHNlbGYuX2N1 cnJlbnRfdGVzdF9udW1iZXIgPSAwCiAKKyAgICAgICAgc2VsZi5fcmV0cmllcyA9IDAKKwogICAg IGRlZiBfX2RlbF9fKHNlbGYpOgogICAgICAgICBfbG9nLmRlYnVnKCJmbHVzaGluZyBzdGRvdXQi KQogICAgICAgICBzeXMuc3Rkb3V0LmZsdXNoKCkKQEAgLTYzNSwxMiArNjM3LDEyIEBAIGNsYXNz IFRlc3RSdW5uZXI6CiAgICAgICAgICMgV2UgZXhjbHVkZSB0aGUgY3Jhc2hlcyBmcm9tIHRoZSBs aXN0IG9mIHJlc3VsdHMgdG8gcmV0cnksIGJlY2F1c2UKICAgICAgICAgIyB3ZSB3YW50IHRvIHRy ZWF0IGV2ZW4gYSBwb3RlbnRpYWxseSBmbGFreSBjcmFzaCBhcyBhbiBlcnJvci4KICAgICAgICAg ZmFpbHVyZXMgPSBzZWxmLl9nZXRfZmFpbHVyZXMocmVzdWx0X3N1bW1hcnksIGluY2x1ZGVfY3Jh c2hlcz1GYWxzZSkKLSAgICAgICAgcmV0cmllcyA9IDAKICAgICAgICAgcmV0cnlfc3VtbWFyeSA9 IHJlc3VsdF9zdW1tYXJ5Ci0gICAgICAgIHdoaWxlIChyZXRyaWVzIDwgc2VsZi5OVU1fUkVUUllf T05fVU5FWFBFQ1RFRF9GQUlMVVJFIGFuZAorICAgICAgICB3aGlsZSAoc2VsZi5fcmV0cmllcyA8 IHNlbGYuTlVNX1JFVFJZX09OX1VORVhQRUNURURfRkFJTFVSRSBhbmQKICAgICAgICAgICAgICAg IGxlbihmYWlsdXJlcykpOgotICAgICAgICAgICAgX2xvZy5kZWJ1ZygiUmV0cnlpbmcgJWQgdW5l eHBlY3RlZCBmYWlsdXJlKHMpIiAlIGxlbihmYWlsdXJlcykpCi0gICAgICAgICAgICByZXRyaWVz ICs9IDEKKyAgICAgICAgICAgIF9sb2cuaW5mbygnJykKKyAgICAgICAgICAgIF9sb2cuaW5mbygi UmV0cnlpbmcgJWQgdW5leHBlY3RlZCBmYWlsdXJlKHMpIiAlIGxlbihmYWlsdXJlcykpCisgICAg ICAgICAgICBzZWxmLl9yZXRyaWVzICs9IDEKICAgICAgICAgICAgIHJldHJ5X3N1bW1hcnkgPSBS ZXN1bHRTdW1tYXJ5KHNlbGYuX2V4cGVjdGF0aW9ucywgZmFpbHVyZXMua2V5cygpKQogICAgICAg ICAgICAgc2VsZi5fcnVuX3Rlc3RzKGZhaWx1cmVzLmtleXMoKSwgcmV0cnlfc3VtbWFyeSkKICAg ICAgICAgICAgIGZhaWx1cmVzID0gc2VsZi5fZ2V0X2ZhaWx1cmVzKHJldHJ5X3N1bW1hcnksIGlu Y2x1ZGVfY3Jhc2hlcz1UcnVlKQpAQCAtNzE2LDkgKzcxOCwxMyBAQCBjbGFzcyBUZXN0UnVubmVy OgogCiAgICAgZGVmIF9kaXNwbGF5X29uZV9saW5lX3Byb2dyZXNzKHNlbGYsIHJlc3VsdF9zdW1t YXJ5KToKICAgICAgICAgIiIiRGlzcGxheXMgdGhlIHByb2dyZXNzIHRocm91Z2ggdGhlIHRlc3Qg cnVuLiIiIgorICAgICAgICBhY3Rpb24gPSAiVGVzdGluZyIKKyAgICAgICAgaWYgc2VsZi5fcmV0 cmllcyA+IDA6CisgICAgICAgICAgICBhY3Rpb24gPSAiUmV0cnlpbmciCisKICAgICAgICAgcGVy Y2VudF9jb21wbGV0ZSA9IDEwMCAqIChyZXN1bHRfc3VtbWFyeS5leHBlY3RlZCArIHJlc3VsdF9z dW1tYXJ5LnVuZXhwZWN0ZWQpIC8gcmVzdWx0X3N1bW1hcnkudG90YWwKLSAgICAgICAgc2VsZi5f bWV0ZXIudXBkYXRlKCJUZXN0aW5nICglZCUlKTogJWQgcmFuIGFzIGV4cGVjdGVkLCAlZCBkaWRu J3QsICVkIGxlZnQiICUKLSAgICAgICAgICAgIChwZXJjZW50X2NvbXBsZXRlLCByZXN1bHRfc3Vt bWFyeS5leHBlY3RlZCwKKyAgICAgICAgc2VsZi5fbWV0ZXIudXBkYXRlKCIlcyAoJWQlJSk6ICVk IHJhbiBhcyBleHBlY3RlZCwgJWQgZGlkbid0LCAlZCBsZWZ0IiAlCisgICAgICAgICAgICAoYWN0 aW9uLCBwZXJjZW50X2NvbXBsZXRlLCByZXN1bHRfc3VtbWFyeS5leHBlY3RlZCwKICAgICAgICAg ICAgICByZXN1bHRfc3VtbWFyeS51bmV4cGVjdGVkLCByZXN1bHRfc3VtbWFyeS5yZW1haW5pbmcp KQogCiAgICAgZGVmIF9kaXNwbGF5X2RldGFpbGVkX3Byb2dyZXNzKHNlbGYsIHJlc3VsdF9zdW1t YXJ5KToK