37601 2010-04-14 13:31:04 -0700 Add ThemeMac::ensuredView and get rid of a workaround in ThemeMac::paintButton." 2010-04-14 13:39:54 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 andersca webkit-unassigned oldest_to_newest 212534 0 andersca 2010-04-14 13:31:04 -0700 Add ThemeMac::ensuredView and get rid of a workaround in ThemeMac::paintButton." 212537 1 53359 andersca 2010-04-14 13:34:32 -0700 Created attachment 53359 Patch 212539 2 53359 sam 2010-04-14 13:36:45 -0700 Comment on attachment 53359 Patch > + > + No new tests. (OOPS!) No need to keep this bit here. 212540 3 andersca 2010-04-14 13:39:54 -0700 Committed r57603: <http://trac.webkit.org/changeset/57603> 53359 2010-04-14 13:34:32 -0700 2010-04-14 13:36:45 -0700 Patch bug-37601-20100414133431.patch text/plain 3669 andersca SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NzYwMSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMTAtMDQtMTQgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFw cGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBBZGQgVGhlbWVNYWM6OmVuc3VyZWRWaWV3IGFuZCBnZXQgcmlkIG9mIGEgd29ya2Fyb3VuZCBp biBUaGVtZU1hYzo6cGFpbnRCdXR0b24uIgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9Mzc2MDEKKworICAgICAgICBObyBuZXcgdGVzdHMuIChPT1BTISkK KworICAgICAgICAqIHBsYXRmb3JtL21hYy9UaGVtZU1hYy5oOgorICAgICAgICAqIHBsYXRmb3Jt L21hYy9UaGVtZU1hYy5tbToKKyAgICAgICAgKC1bV2ViQ29yZUZsaXBwZWRWaWV3IGlzRmxpcHBl ZF0pOgorICAgICAgICAoV2ViQ29yZTo6cGFpbnRCdXR0b24pOgorICAgICAgICAoV2ViQ29yZTo6 VGhlbWVNYWM6OmVuc3VyZWRWaWV3KToKKwogMjAxMC0wNC0xNCAgSmF5IENpdmVsbGkgIDxqY2l2 ZWxsaUBjaHJvbWl1bS5vcmc+CiAgCiAgICAgICAgIFJldmlld2VkIGJ5IERpbWl0cmkgR2xhemtv di4KSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vbWFjL1RoZW1lTWFjLmgKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2ViQ29yZS9wbGF0Zm9ybS9tYWMvVGhlbWVNYWMuaAkocmV2aXNpb24gNTc2MDEpCisrKyBXZWJD b3JlL3BsYXRmb3JtL21hYy9UaGVtZU1hYy5oCSh3b3JraW5nIGNvcHkpCkBAIC00OSw2ICs0OSw5 IEBAIHB1YmxpYzoKIAogICAgIHZpcnR1YWwgdm9pZCBwYWludChDb250cm9sUGFydCwgQ29udHJv bFN0YXRlcywgR3JhcGhpY3NDb250ZXh0KiwgY29uc3QgSW50UmVjdCYsIGZsb2F0IHpvb21GYWN0 b3IsIFNjcm9sbFZpZXcqKSBjb25zdDsKICAgICB2aXJ0dWFsIHZvaWQgaW5mbGF0ZUNvbnRyb2xQ YWludFJlY3QoQ29udHJvbFBhcnQsIENvbnRyb2xTdGF0ZXMsIEludFJlY3QmLCBmbG9hdCB6b29t RmFjdG9yKSBjb25zdDsKKworICAgIC8vIEZJWE1FOiBPbmNlIFJlbmRlclRoZW1lTWFjIGlzIGNv bnZlcnRlZCBvdmVyIHRvIHVzZSBUaGVtZSB0aGVuIHRoaXMgY2FuIGJlIGludGVybmFsIHRvIFRo ZW1lTWFjLgorICAgIHN0YXRpYyBOU1ZpZXcqIGVuc3VyZWRWaWV3KFNjcm9sbFZpZXcqKTsKIH07 CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vbWFjL1Ro ZW1lTWFjLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vbWFjL1RoZW1lTWFjLm1t CShyZXZpc2lvbiA1NzYwMSkKKysrIFdlYkNvcmUvcGxhdGZvcm0vbWFjL1RoZW1lTWFjLm1tCSh3 b3JraW5nIGNvcHkpCkBAIC0zNSw2ICszNSwxOSBAQAogCiB1c2luZyBuYW1lc3BhY2Ugc3RkOwog CisvLyBUaGlzIGlzIGEgdmlldyB3aG9zZSBzb2xlIHB1cnBvc2UgaXMgdG8gdGVsbCBBcHBLaXQg dGhhdCBpdCdzIGZsaXBwZWQuCitAaW50ZXJmYWNlIFdlYkNvcmVGbGlwcGVkVmlldyA6IE5TVmll dworQGVuZAorCitAaW1wbGVtZW50YXRpb24gV2ViQ29yZUZsaXBwZWRWaWV3CisKKy0gKEJPT0wp aXNGbGlwcGVkCit7CisgICAgcmV0dXJuIFlFUzsKK30KKworQGVuZAorCiAvLyBGSVhNRTogRGVm YXVsdCBidXR0b25zIHJlYWxseSBzaG91bGQgYmUgbW9yZSBsaWtlIHB1c2ggYnV0dG9ucyBhbmQg bm90IGxpa2UgYnV0dG9ucy4KIAogbmFtZXNwYWNlIFdlYkNvcmUgewpAQCAtNDA1LDcgKzQxOCw3 IEBAIHN0YXRpYyB2b2lkIHBhaW50QnV0dG9uKENvbnRyb2xQYXJ0IHBhcnQKICAgICAgICAgfQog ICAgIH0gCiAKLSAgICBOU1ZpZXcgKnZpZXcgPSBzY3JvbGxWaWV3LT5kb2N1bWVudFZpZXcoKTsK KyAgICBOU1ZpZXcgKnZpZXcgPSBUaGVtZU1hYzo6ZW5zdXJlZFZpZXcoc2Nyb2xsVmlldyk7CiAg ICAgTlNXaW5kb3cgKndpbmRvdyA9IFt2aWV3IHdpbmRvd107CiAgICAgTlNCdXR0b25DZWxsICpw cmV2aW91c0RlZmF1bHRCdXR0b25DZWxsID0gW3dpbmRvdyBkZWZhdWx0QnV0dG9uQ2VsbF07CiAK QEAgLTQxNSwyNiArNDI4LDI4IEBAIHN0YXRpYyB2b2lkIHBhaW50QnV0dG9uKENvbnRyb2xQYXJ0 IHBhcnQKICAgICB9IGVsc2UgaWYgKFtwcmV2aW91c0RlZmF1bHRCdXR0b25DZWxsIGlzRXF1YWw6 YnV0dG9uQ2VsbF0pCiAgICAgICAgIFt3aW5kb3cgc2V0RGVmYXVsdEJ1dHRvbkNlbGw6bmlsXTsK IAotICAgIGlmICghdmlldykgewotICAgICAgICBjb250ZXh0LT5zYXZlKCk7Ci0gICAgICAgIGNv bnRleHQtPnRyYW5zbGF0ZShpbmZsYXRlZFJlY3QueCgpLCBpbmZsYXRlZFJlY3QueSgpKTsKLSAg ICAgICAgY29udGV4dC0+c2NhbGUoRmxvYXRTaXplKDEsIC0xKSk7Ci0gICAgICAgIGNvbnRleHQt PnRyYW5zbGF0ZSgwLCAtaW5mbGF0ZWRSZWN0LmhlaWdodCgpKTsKLSAgICAgICAgaW5mbGF0ZWRS ZWN0LnNldExvY2F0aW9uKEludFBvaW50KCkpOwotICAgIH0KLQogICAgIFtidXR0b25DZWxsIGRy YXdXaXRoRnJhbWU6TlNSZWN0KGluZmxhdGVkUmVjdCkgaW5WaWV3OnZpZXddOwogICAgIFtidXR0 b25DZWxsIHNldENvbnRyb2xWaWV3Om5pbF07CiAKLSAgICBpZiAoIXZpZXcpCi0gICAgICAgIGNv bnRleHQtPnJlc3RvcmUoKTsKLQogICAgIGlmICghW3ByZXZpb3VzRGVmYXVsdEJ1dHRvbkNlbGwg aXNFcXVhbDpidXR0b25DZWxsXSkKICAgICAgICAgW3dpbmRvdyBzZXREZWZhdWx0QnV0dG9uQ2Vs bDpwcmV2aW91c0RlZmF1bHRCdXR0b25DZWxsXTsKIAogICAgIEVORF9CTE9DS19PQkpDX0VYQ0VQ VElPTlMKIH0KIAorLy8gVGhpcyB3aWxsIGVuc3VyZSB0aGF0IHdlIGFsd2F5cyByZXR1cm4gYSB2 YWxpZCBOU1ZpZXcsIGV2ZW4gaWYgU2Nyb2xsVmlldyBkb2Vzbid0IGhhdmUgYW4gYXNzb2NpYXRl ZCBkb2N1bWVudCBOU1ZpZXcuCisvLyBJZiB0aGUgU2Nyb2xsVmlldyBkb2Vzbid0IGhhdmUgYW4g TlNWaWV3LCB3ZSB3aWxsIHJldHVybiBhIGZha2UgTlNWaWV3IHdob3NlIHNvbGUgcHVycG9zZSBp cyB0byB0ZWxsIEFwcEtpdCB0aGF0IGl0J3MgZmxpcHBlZC4KK05TVmlldyAqVGhlbWVNYWM6OmVu c3VyZWRWaWV3KFNjcm9sbFZpZXcqIHNjcm9sbFZpZXcpCit7CisgICAgaWYgKE5TVmlldyAqZG9j dW1lbnRWaWV3ID0gc2Nyb2xsVmlldy0+ZG9jdW1lbnRWaWV3KCkpCisgICAgICAgIHJldHVybiBk b2N1bWVudFZpZXc7CisgICAgCisgICAgLy8gVXNlIGEgZmFrZSBmbGlwcGVkIHZpZXcuCisgICAg c3RhdGljIE5TVmlldyAqZmxpcHBlZFZpZXcgPSBbW1dlYkNvcmVGbGlwcGVkVmlldyBhbGxvY10g aW5pdF07CisgICAgCisgICAgcmV0dXJuIGZsaXBwZWRWaWV3OworfQorICAgIAogLy8gVGhlbWUg b3ZlcnJpZGVzCiAKIGludCBUaGVtZU1hYzo6YmFzZWxpbmVQb3NpdGlvbkFkanVzdG1lbnQoQ29u dHJvbFBhcnQgcGFydCkgY29uc3QK