37594 2010-04-14 12:23:40 -0700 Factor code to paint into an update chunk out into a separate function. 2010-04-14 12:42:49 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 andersca webkit-unassigned oldest_to_newest 212489 0 andersca 2010-04-14 12:23:40 -0700 Factor code to paint into an update chunk out into a separate function. 212491 1 53350 andersca 2010-04-14 12:26:10 -0700 Created attachment 53350 Patch 212501 2 53350 sam 2010-04-14 12:40:31 -0700 Comment on attachment 53350 Patch > > +void DrawingAreaUpdateChunk::paintIntoUpdateChunk(UpdateChunk *updateChunk) > private: > + void paintIntoUpdateChunk(UpdateChunk *); * should be on the other side. otherwise, r=me. 212502 3 andersca 2010-04-14 12:42:49 -0700 Committed r57596: <http://trac.webkit.org/changeset/57596> 53350 2010-04-14 12:26:10 -0700 2010-04-14 12:40:30 -0700 Patch bug-37594-20100414122609.patch text/plain 4695 andersca SW5kZXg6IFdlYktpdDIvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdDIvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NzU5NCkKKysrIFdlYktpdDIvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMDQtMTQgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFw cGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBGYWN0b3IgY29kZSB0byBwYWludCBpbnRvIGFuIHVwZGF0ZSBjaHVuayBvdXQgaW50byBhIHNl cGFyYXRlIGZ1bmN0aW9uLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9Mzc1OTQKKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9tYWMvRHJhd2lu Z0FyZWFVcGRhdGVDaHVuay5jcHA6CisgICAgICAgIChXZWJLaXQ6OkRyYXdpbmdBcmVhVXBkYXRl Q2h1bms6OnBhaW50SW50b1VwZGF0ZUNodW5rKToKKyAgICAgICAgKFdlYktpdDo6RHJhd2luZ0Fy ZWFVcGRhdGVDaHVuazo6ZGlzcGxheSk6CisgICAgICAgIChXZWJLaXQ6OkRyYXdpbmdBcmVhVXBk YXRlQ2h1bms6OnNldFNpemUpOgorICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9tYWMvRHJh d2luZ0FyZWFVcGRhdGVDaHVuay5oOgorCiAyMDEwLTA0LTEzICBTYW0gV2VpbmlnICA8c2FtQHdl YmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQW5kZXJzIENhcmxzc29uLgpJbmRleDog V2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL0RyYXdpbmdBcmVhVXBkYXRlQ2h1bmsuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFdlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9EcmF3aW5nQXJl YVVwZGF0ZUNodW5rLmNwcAkocmV2aXNpb24gNTc1ODYpCisrKyBXZWJLaXQyL1dlYlByb2Nlc3Mv V2ViUGFnZS9tYWMvRHJhd2luZ0FyZWFVcGRhdGVDaHVuay5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTc3LDYgKzc3LDE4IEBAIHZvaWQgRHJhd2luZ0FyZWFVcGRhdGVDaHVuazo6c2V0TmVlZHNEaXMK ICAgICBzY2hlZHVsZURpc3BsYXkoKTsKIH0KIAordm9pZCBEcmF3aW5nQXJlYVVwZGF0ZUNodW5r OjpwYWludEludG9VcGRhdGVDaHVuayhVcGRhdGVDaHVuayAqdXBkYXRlQ2h1bmspCit7CisgICAg UmV0YWluUHRyPENHQ29sb3JTcGFjZVJlZj4gY29sb3JTcGFjZShBZG9wdENGLCBDR0NvbG9yU3Bh Y2VDcmVhdGVEZXZpY2VSR0IoKSk7CisgICAgUmV0YWluUHRyPENHQ29udGV4dFJlZj4gYml0bWFw Q29udGV4dChBZG9wdENGLCBDR0JpdG1hcENvbnRleHRDcmVhdGUodXBkYXRlQ2h1bmstPmRhdGEo KSwgdXBkYXRlQ2h1bmstPnJlY3QoKS53aWR0aCgpLCB1cGRhdGVDaHVuay0+cmVjdCgpLmhlaWdo dCgpLCA4LCB1cGRhdGVDaHVuay0+cmVjdCgpLndpZHRoKCkgKiA0LCBjb2xvclNwYWNlLmdldCgp LCBrQ0dJbWFnZUFscGhhUHJlbXVsdGlwbGllZExhc3QpKTsKKyAgICAKKyAgICAvLyBOb3cgcGFp bnQgaW50byB0aGUgYmFja2luZyBzdG9yZS4KKyAgICBHcmFwaGljc0NvbnRleHQgZ3JhcGhpY3ND b250ZXh0KGJpdG1hcENvbnRleHQuZ2V0KCkpOworICAgIGdyYXBoaWNzQ29udGV4dC50cmFuc2xh dGUoLXVwZGF0ZUNodW5rLT5yZWN0KCkueCgpLCAtdXBkYXRlQ2h1bmstPnJlY3QoKS55KCkpOwor ICAgIAorICAgIG1fd2ViUGFnZS0+ZHJhd1JlY3QoZ3JhcGhpY3NDb250ZXh0LCB1cGRhdGVDaHVu ay0+cmVjdCgpKTsKK30KKwogdm9pZCBEcmF3aW5nQXJlYVVwZGF0ZUNodW5rOjpkaXNwbGF5KCkK IHsKICAgICBpZiAobV9kaXJ0eVJlY3QuaXNFbXB0eSgpKQpAQCAtODgsMTkgKzEwMCw5IEBAIHZv aWQgRHJhd2luZ0FyZWFVcGRhdGVDaHVuazo6ZGlzcGxheSgpCiAgICAgSW50UmVjdCBkaXJ0eVJl Y3QgPSBtX2RpcnR5UmVjdDsKICAgICBtX2RpcnR5UmVjdCA9IEludFJlY3QoKTsKIAotICAgIC8v IEZJWE1FOiBNb3ZlIHRoaXMgY29kZSB0byBkcmF3IGludG8gYW4gVXBkYXRlQ2h1bmsgaW50byBh IHNlcGVyYXRlIGZ1bmN0aW9uLgotCiAgICAgLy8gQ3JlYXRlIGEgbmV3IFVwZGF0ZUNodW5rIGFu ZCBwYWludCBpbnRvIGl0LgogICAgIFVwZGF0ZUNodW5rIHVwZGF0ZUNodW5rKGRpcnR5UmVjdCk7 Ci0KLSAgICBSZXRhaW5QdHI8Q0dDb2xvclNwYWNlUmVmPiBjb2xvclNwYWNlKEFkb3B0Q0YsIENH Q29sb3JTcGFjZUNyZWF0ZURldmljZVJHQigpKTsKLSAgICBSZXRhaW5QdHI8Q0dDb250ZXh0UmVm PiBiaXRtYXBDb250ZXh0KEFkb3B0Q0YsIENHQml0bWFwQ29udGV4dENyZWF0ZSh1cGRhdGVDaHVu ay5kYXRhKCksIGRpcnR5UmVjdC53aWR0aCgpLCBkaXJ0eVJlY3QuaGVpZ2h0KCksIDgsIGRpcnR5 UmVjdC53aWR0aCgpICogNCwgY29sb3JTcGFjZS5nZXQoKSwga0NHSW1hZ2VBbHBoYVByZW11bHRp cGxpZWRMYXN0KSk7Ci0KLSAgICAvLyBOb3cgcGFpbnQgaW50byB0aGUgYmFja2luZyBzdG9yZS4K LSAgICBHcmFwaGljc0NvbnRleHQgZ3JhcGhpY3NDb250ZXh0KGJpdG1hcENvbnRleHQuZ2V0KCkp OwotICAgIGdyYXBoaWNzQ29udGV4dC50cmFuc2xhdGUoLWRpcnR5UmVjdC54KCksIC1kaXJ0eVJl Y3QueSgpKTsKLQotICAgIG1fd2ViUGFnZS0+ZHJhd1JlY3QoZ3JhcGhpY3NDb250ZXh0LCBkaXJ0 eVJlY3QpOworICAgIHBhaW50SW50b1VwZGF0ZUNodW5rKCZ1cGRhdGVDaHVuayk7CiAKICAgICBX ZWJQcm9jZXNzOjpzaGFyZWQoKS5jb25uZWN0aW9uKCktPnNlbmQoRHJhd2luZ0FyZWFQcm94eU1l c3NhZ2U6OlVwZGF0ZSwgbV93ZWJQYWdlLT5wYWdlSUQoKSwgQ29yZUlQQzo6SW4odXBkYXRlQ2h1 bmspKTsKIApAQCAtMTE5LDI0ICsxMjEsMTIgQEAgdm9pZCBEcmF3aW5nQXJlYVVwZGF0ZUNodW5r OjpzZXRTaXplKGNvbgogewogICAgIG1fd2ViUGFnZS0+c2V0U2l6ZSh2aWV3U2l6ZSk7CiAKLSAg ICAvLyBGSVhNRTogTW92ZSB0aGlzIGNvZGUgdG8gZHJhdyBpbnRvIGFuIFVwZGF0ZUNodW5rIGlu dG8gYSBzZXBlcmF0ZSBmdW5jdGlvbi4KLQogICAgIC8vIExheW91dCBpZiBuZWNlc3NhcnkuCiAg ICAgbV93ZWJQYWdlLT5sYXlvdXRJZk5lZWRlZCgpOwogCi0gICAgSW50UmVjdCByZWN0KDAsIDAs IHZpZXdTaXplLndpZHRoKCksIHZpZXdTaXplLmhlaWdodCgpKTsKLQogICAgIC8vIENyZWF0ZSBh IG5ldyBVcGRhdGVDaHVuayBhbmQgcGFpbnQgaW50byBpdC4KLSAgICBVcGRhdGVDaHVuayB1cGRh dGVDaHVuayhyZWN0KTsKLQotICAgIFJldGFpblB0cjxDR0NvbG9yU3BhY2VSZWY+IGNvbG9yU3Bh Y2UoQWRvcHRDRiwgQ0dDb2xvclNwYWNlQ3JlYXRlRGV2aWNlUkdCKCkpOwotICAgIFJldGFpblB0 cjxDR0NvbnRleHRSZWY+IGJpdG1hcENvbnRleHQoQWRvcHRDRiwgQ0dCaXRtYXBDb250ZXh0Q3Jl YXRlKHVwZGF0ZUNodW5rLmRhdGEoKSwgcmVjdC53aWR0aCgpLCByZWN0LmhlaWdodCgpLCA4LCBy ZWN0LndpZHRoKCkgKiA0LCBjb2xvclNwYWNlLmdldCgpLCBrQ0dJbWFnZUFscGhhUHJlbXVsdGlw bGllZExhc3QpKTsKLQotICAgIC8vIE5vdyBwYWludCBpbnRvIHRoZSBiYWNraW5nIHN0b3JlLgot ICAgIEdyYXBoaWNzQ29udGV4dCBncmFwaGljc0NvbnRleHQoYml0bWFwQ29udGV4dC5nZXQoKSk7 Ci0gICAgZ3JhcGhpY3NDb250ZXh0LnRyYW5zbGF0ZSgtcmVjdC54KCksIC1yZWN0LnkoKSk7Ci0K LSAgICBtX3dlYlBhZ2UtPmRyYXdSZWN0KGdyYXBoaWNzQ29udGV4dCwgcmVjdCk7CisgICAgVXBk YXRlQ2h1bmsgdXBkYXRlQ2h1bmsoSW50UmVjdCgwLCAwLCB2aWV3U2l6ZS53aWR0aCgpLCB2aWV3 U2l6ZS5oZWlnaHQoKSkpOworICAgIHBhaW50SW50b1VwZGF0ZUNodW5rKCZ1cGRhdGVDaHVuayk7 CiAKICAgICBtX2Rpc3BsYXlUaW1lci5zdG9wKCk7CiAKSW5kZXg6IFdlYktpdDIvV2ViUHJvY2Vz cy9XZWJQYWdlL21hYy9EcmF3aW5nQXJlYVVwZGF0ZUNodW5rLmgKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi S2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL0RyYXdpbmdBcmVhVXBkYXRlQ2h1bmsuaAkocmV2 aXNpb24gNTc1ODYpCisrKyBXZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMvRHJhd2luZ0Fy ZWFVcGRhdGVDaHVuay5oCSh3b3JraW5nIGNvcHkpCkBAIC0zMiw2ICszMiw4IEBACiAKIG5hbWVz cGFjZSBXZWJLaXQgewogCitjbGFzcyBVcGRhdGVDaHVuazsKKwogY2xhc3MgRHJhd2luZ0FyZWFV cGRhdGVDaHVuayA6IHB1YmxpYyBEcmF3aW5nQXJlYSB7CiBwdWJsaWM6CiAgICAgRHJhd2luZ0Fy ZWFVcGRhdGVDaHVuayhXZWJQYWdlKik7CkBAIC00Nyw2ICs0OSw4IEBAIHB1YmxpYzoKICAgICB2 aXJ0dWFsIHZvaWQgZGlkUmVjZWl2ZU1lc3NhZ2UoQ29yZUlQQzo6Q29ubmVjdGlvbiosIENvcmVJ UEM6Ok1lc3NhZ2VJRCwgQ29yZUlQQzo6QXJndW1lbnREZWNvZGVyJik7CiAKIHByaXZhdGU6Cisg ICAgdm9pZCBwYWludEludG9VcGRhdGVDaHVuayhVcGRhdGVDaHVuayAqKTsKKyAgICAKICAgICB2 b2lkIHNjaGVkdWxlRGlzcGxheSgpOwogICAgIHZvaWQgc2V0U2l6ZShjb25zdCBXZWJDb3JlOjpJ bnRTaXplJiB2aWV3U2l6ZSk7CiAK