37587 2010-04-14 11:04:08 -0700 new-run-webkit-tests: try to detect alternate apache path 2010-04-21 03:57:56 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 37765 1 vestbo webkit-unassigned commit-queue eric oldest_to_newest 212436 0 vestbo 2010-04-14 11:04:08 -0700 new-run-webkit-tests: try to detect alternate apache path 212439 1 53345 vestbo 2010-04-14 11:06:13 -0700 Created attachment 53345 Patch 212468 2 53345 eric 2010-04-14 11:38:38 -0700 Comment on attachment 53345 Patch Seems reasonable. We should add a comment about why we have to detect multiple apaches. Also, it seems like we might want to cache this information so we're not stating the file repeatedly? 212514 3 53356 vestbo 2010-04-14 13:03:34 -0700 Created attachment 53356 Patch 212524 4 53356 eric 2010-04-14 13:16:41 -0700 Comment on attachment 53356 Patch Fantastic! 212707 5 53356 commit-queue 2010-04-14 19:48:59 -0700 Comment on attachment 53356 Patch Rejecting patch 53356 from commit-queue. Unexpected failure when landing patch! Please file a bug against webkit-patch. Failed to run "['WebKitTools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', 'land-attachment', '--force-clean', '--build', '--test', '--non-interactive', '--ignore-builders', '--build-style=both', '--quiet', '53356', '--parent-command=commit-queue', '--no-update']" exit_code: 1 Last 500 characters of output: ', 'commit', '--all', '-F', '-'], input=message) File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/webkitpy/common/system/executive.py", line 85, in run_command return Executive().run_command(*args, **kwargs) File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/webkitpy/common/system/executive.py", line 186, in run_command string_to_communicate = str(input) UnicodeEncodeError: 'ascii' codec can't encode character u'\xf8' in position 26: ordinal not in range(128) 212718 6 eric 2010-04-14 20:13:22 -0700 I think I know how to fix this now. We can use codec.encode(input, "latin1") (or some variant) to encode the utf-8 down to latin1 w/o exception before passing to to the subprocess? 212721 7 eric 2010-04-14 20:23:43 -0700 Actually, I mispoke. We likely want to encode the python unicode object into utf8 to feed to our subproccess. 214164 8 eric 2010-04-19 12:24:05 -0700 Sorry. If bug 37765 isn't landed today, I'll land this change by hand. 214895 9 53356 eric 2010-04-20 12:57:51 -0700 Comment on attachment 53356 Patch Sorry again for the trouble. 215227 10 53356 eric 2010-04-21 03:48:51 -0700 Comment on attachment 53356 Patch The fix for bug 37765 was rolled out. So this will fail to land. Hopefully I'll reland the fix tomorrow at which point I'll cq+ this again. 215232 11 53356 eric 2010-04-21 03:57:46 -0700 Comment on attachment 53356 Patch Clearing flags on attachment: 53356 Committed r57964: <http://trac.webkit.org/changeset/57964> 215233 12 eric 2010-04-21 03:57:56 -0700 All reviewed patches have been landed. Closing bug. 53345 2010-04-14 11:06:13 -0700 2010-04-14 13:03:30 -0700 Patch bug-37587-20100414140612.patch text/plain 1721 vestbo ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBlZWRlYjRiLi4xZDFiM2FiIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDQt MTQgIFRvciBBcm5lIFZlc3Riw7ggIDx0b3IuYXJuZS52ZXN0Ym9Abm9raWEuY29tPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIG5ldy1ydW4td2Via2l0 LXRlc3RzOiB0cnkgdG8gZGV0ZWN0IGFsdGVybmF0ZSBhcGFjaGUgcGF0aAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzc1ODcKKworICAgICAgICBfY2hl Y2tfcG9ydF9idWlsZCgpIGFsc28gbmVlZHMgdG8gcmV0dXJuIHRydWUgaW4gdGhlCisgICAgICAg IGJhc2UgaW1wbGVtZW50YXRpb24gdG8gbm90IGZhaWwgdGhlIGNoZWNrX2J1aWxkIHN0ZXAuCisK KyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3dlYmtpdC5weToK KwogMjAxMC0wNC0xNCAgRXJpYyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMv d2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvd2Via2l0LnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0 cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC93ZWJraXQucHkKaW5kZXggZDEwZmE5MC4uZjBj ZWE3MiAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVz dHMvcG9ydC93ZWJraXQucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlv dXRfdGVzdHMvcG9ydC93ZWJraXQucHkKQEAgLTEwMiw3ICsxMDIsNyBAQCBjbGFzcyBXZWJLaXRQ b3J0KGJhc2UuUG9ydCk6CiAKICAgICBkZWYgX2NoZWNrX3BvcnRfYnVpbGQoc2VsZik6CiAgICAg ICAgICMgUG9ydHMgY2FuIG92ZXJyaWRlIHRoaXMgbWV0aG9kIHRvIGRvIGFkZGl0aW9uYWwgY2hl Y2tzLgotICAgICAgICBwYXNzCisgICAgICAgIHJldHVybiBUcnVlCiAKICAgICBkZWYgY2hlY2tf aW1hZ2VfZGlmZihzZWxmLCBvdmVycmlkZV9zdGVwPU5vbmUsIGxvZ2dpbmc9VHJ1ZSk6CiAgICAg ICAgIGltYWdlX2RpZmZfcGF0aCA9IHNlbGYuX3BhdGhfdG9faW1hZ2VfZGlmZigpCkBAIC0zMjMs NyArMzIzLDEzIEBAIGNsYXNzIFdlYktpdFBvcnQoYmFzZS5Qb3J0KToKICAgICAgICAgcmV0dXJu ICd3ZGlmZicKIAogICAgIGRlZiBfcGF0aF90b19hcGFjaGUoc2VsZik6Ci0gICAgICAgIHJldHVy biAnL3Vzci9zYmluL2h0dHBkJworICAgICAgICBpZiBvcy5wYXRoLmV4aXN0cygnL3Vzci9zYmlu L2h0dHBkJyk6CisgICAgICAgICAgICByZXR1cm4gJy91c3Ivc2Jpbi9odHRwZCcKKyAgICAgICAg ZWxpZiBvcy5wYXRoLmV4aXN0cygnL3Vzci9zYmluL2FwYWNoZTInKToKKyAgICAgICAgICAgIHJl dHVybiAnL3Vzci9zYmluL2FwYWNoZTInCisgICAgICAgIGVsc2U6CisgICAgICAgICAgICBfbG9n LmVycm9yKCJDb3VsZCBub3QgZmluZCBhcGFjaGUuIE5vdCBpbnN0YWxsZWQgb3IgdW5rbm93biBw YXRoLiIpCisgICAgICAgICAgICByZXR1cm4gJycKIAogCiBjbGFzcyBXZWJLaXREcml2ZXIoYmFz ZS5Ecml2ZXIpOgo= 53356 2010-04-14 13:03:34 -0700 2010-04-21 03:57:46 -0700 Patch bug-37587-20100414160332.patch text/plain 2323 vestbo ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBlZWRlYjRiLi4xZDFiM2FiIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDQt MTQgIFRvciBBcm5lIFZlc3Riw7ggIDx0b3IuYXJuZS52ZXN0Ym9Abm9raWEuY29tPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIG5ldy1ydW4td2Via2l0 LXRlc3RzOiB0cnkgdG8gZGV0ZWN0IGFsdGVybmF0ZSBhcGFjaGUgcGF0aAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzc1ODcKKworICAgICAgICBfY2hl Y2tfcG9ydF9idWlsZCgpIGFsc28gbmVlZHMgdG8gcmV0dXJuIHRydWUgaW4gdGhlCisgICAgICAg IGJhc2UgaW1wbGVtZW50YXRpb24gdG8gbm90IGZhaWwgdGhlIGNoZWNrX2J1aWxkIHN0ZXAuCisK KyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3dlYmtpdC5weToK KwogMjAxMC0wNC0xNCAgRXJpYyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMv d2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvd2Via2l0LnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0 cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC93ZWJraXQucHkKaW5kZXggZDEwZmE5MC4uZGZk MGJlNiAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVz dHMvcG9ydC93ZWJraXQucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlv dXRfdGVzdHMvcG9ydC93ZWJraXQucHkKQEAgLTU0LDYgKzU0LDcgQEAgY2xhc3MgV2ViS2l0UG9y dChiYXNlLlBvcnQpOgogICAgIGRlZiBfX2luaXRfXyhzZWxmLCBwb3J0X25hbWU9Tm9uZSwgb3B0 aW9ucz1Ob25lKToKICAgICAgICAgYmFzZS5Qb3J0Ll9faW5pdF9fKHNlbGYsIHBvcnRfbmFtZSwg b3B0aW9ucykKICAgICAgICAgc2VsZi5fY2FjaGVkX2J1aWxkX3Jvb3QgPSBOb25lCisgICAgICAg IHNlbGYuX2NhY2hlZF9hcGFjaGVfcGF0aCA9IE5vbmUKIAogICAgICAgICAjIEZJWE1FOiBkaXNh YmxlIHBpeGVsIHRlc3RzIHVudGlsIHRoZXkgYXJlIHJ1biBieSBkZWZhdWx0IG9uIHRoZQogICAg ICAgICAjIGJ1aWxkIG1hY2hpbmVzLgpAQCAtMTAyLDcgKzEwMyw3IEBAIGNsYXNzIFdlYktpdFBv cnQoYmFzZS5Qb3J0KToKIAogICAgIGRlZiBfY2hlY2tfcG9ydF9idWlsZChzZWxmKToKICAgICAg ICAgIyBQb3J0cyBjYW4gb3ZlcnJpZGUgdGhpcyBtZXRob2QgdG8gZG8gYWRkaXRpb25hbCBjaGVj a3MuCi0gICAgICAgIHBhc3MKKyAgICAgICAgcmV0dXJuIFRydWUKIAogICAgIGRlZiBjaGVja19p bWFnZV9kaWZmKHNlbGYsIG92ZXJyaWRlX3N0ZXA9Tm9uZSwgbG9nZ2luZz1UcnVlKToKICAgICAg ICAgaW1hZ2VfZGlmZl9wYXRoID0gc2VsZi5fcGF0aF90b19pbWFnZV9kaWZmKCkKQEAgLTMyMyw3 ICszMjQsMTggQEAgY2xhc3MgV2ViS2l0UG9ydChiYXNlLlBvcnQpOgogICAgICAgICByZXR1cm4g J3dkaWZmJwogCiAgICAgZGVmIF9wYXRoX3RvX2FwYWNoZShzZWxmKToKLSAgICAgICAgcmV0dXJu ICcvdXNyL3NiaW4vaHR0cGQnCisgICAgICAgIGlmIG5vdCBzZWxmLl9jYWNoZWRfYXBhY2hlX3Bh dGg6CisgICAgICAgICAgICAjIFRoZSBBcGFjaGUgYmluYXJ5IHBhdGggY2FuIHZhcnkgZGVwZW5k aW5nIG9uIE9TIGFuZCBkaXN0cmlidXRpb24KKyAgICAgICAgICAgICMgU2VlIGh0dHA6Ly93aWtp LmFwYWNoZS5vcmcvaHR0cGQvRGlzdHJvc0RlZmF1bHRMYXlvdXQKKyAgICAgICAgICAgIGZvciBw YXRoIGluIFsiL3Vzci9zYmluL2h0dHBkIiwgIi91c3Ivc2Jpbi9hcGFjaGUyIl06CisgICAgICAg ICAgICAgICAgaWYgb3MucGF0aC5leGlzdHMocGF0aCk6CisgICAgICAgICAgICAgICAgICAgIHNl bGYuX2NhY2hlZF9hcGFjaGVfcGF0aCA9IHBhdGgKKyAgICAgICAgICAgICAgICAgICAgYnJlYWsK KworICAgICAgICAgICAgaWYgbm90IHNlbGYuX2NhY2hlZF9hcGFjaGVfcGF0aDoKKyAgICAgICAg ICAgICAgICBfbG9nLmVycm9yKCJDb3VsZCBub3QgZmluZCBhcGFjaGUuIE5vdCBpbnN0YWxsZWQg b3IgdW5rbm93biBwYXRoLiIpCisKKyAgICAgICAgcmV0dXJuIHNlbGYuX2NhY2hlZF9hcGFjaGVf cGF0aAogCiAKIGNsYXNzIFdlYktpdERyaXZlcihiYXNlLkRyaXZlcik6Cg==