37582 2010-04-14 09:41:38 -0700 Web Inspector: Console: Shift-Tab does not cycle autocompletions in the reverse order 2010-04-14 11:42:26 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 apavlov apavlov bweinstein commit-queue joepeck keishi pfeldman pmuellr rik timothy oldest_to_newest 212391 0 apavlov 2010-04-14 09:41:38 -0700 When Shift is depressed, Tab cycles autocompletion suggestions in the forward direction rather than reverse. 212403 1 53340 apavlov 2010-04-14 09:57:31 -0700 Created attachment 53340 [PATCH] Suggested solution 212420 2 joepeck 2010-04-14 10:27:32 -0700 Looks good! I just noticed this was missing the other day, glad to see you add it =) [Collision: I agree with Tim's r+] > + var nextIndex = foundIndex + (reverse ? -1 : 1); I haven't seen a case where we use (null + #) but this works fine in JavaScript and the code is pretty clean here. > + this.complete(false, event.shiftKey); Is just event.shiftKey enough? Do you feel that we should say something stronger like this: event.shiftKey && !event.ctrlKey && !event.metaKey TextMate for example allows Shift+Esc to go back through a list but not Shift+Ctrl+Esc or Shift+Alt+Esc. Apparently Safari / OS X captures these combinations and handles other actions, but it could be possible that other platforms would let such a combination through. Either way, I think this is unlikely to occur, but something to think about. 212472 3 53340 commit-queue 2010-04-14 11:42:20 -0700 Comment on attachment 53340 [PATCH] Suggested solution Clearing flags on attachment: 53340 Committed r57592: <http://trac.webkit.org/changeset/57592> 212473 4 commit-queue 2010-04-14 11:42:26 -0700 All reviewed patches have been landed. Closing bug. 53340 2010-04-14 09:57:31 -0700 2010-04-14 11:42:20 -0700 [PATCH] Suggested solution shifttab.patch text/plain 3074 apavlov ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZDU3NmU5NS4uZTU0YmFkYiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wNC0xNCAgQWxleGFuZGVyIFBh dmxvdiAgPGFwYXZsb3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IENvbnNvbGU6IFNoaWZ0LVRhYiBk b2VzIG5vdCBjeWNsZSBhdXRvY29tcGxldGlvbnMgaW4gdGhlIHJldmVyc2Ugb3JkZXIKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM3NTgyCisKKyAgICAg ICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL1RleHRQcm9tcHQuanM6CisgICAgICAgIChXZWJJbnNw ZWN0b3IuVGV4dFByb21wdC5wcm90b3R5cGUuY29tcGxldGUpOgorICAgICAgICAoV2ViSW5zcGVj dG9yLlRleHRQcm9tcHQucHJvdG90eXBlLl9jb21wbGV0aW9uc1JlYWR5KToKKyAgICAgICAgKFdl Ykluc3BlY3Rvci5UZXh0UHJvbXB0LnByb3RvdHlwZS5fdGFiS2V5UHJlc3NlZCk6CisKIDIwMTAt MDQtMTMgIFN0ZXBoYW4gQcOfbXVzICA8c3VwZXJzdGlwcGlAZ214LmRlPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IERhdmlkIExldmluLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJv bnQtZW5kL1RleHRQcm9tcHQuanMgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvVGV4dFBy b21wdC5qcwppbmRleCA4ZGUzNjVhLi42YWU4ZmU2IDEwMDY0NAotLS0gYS9XZWJDb3JlL2luc3Bl Y3Rvci9mcm9udC1lbmQvVGV4dFByb21wdC5qcworKysgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9u dC1lbmQvVGV4dFByb21wdC5qcwpAQCAtMTcyLDcgKzE3Miw3IEBAIFdlYkluc3BlY3Rvci5UZXh0 UHJvbXB0LnByb3RvdHlwZSA9IHsKICAgICAgICAgICAgIHRoaXMuX2NvbXBsZXRlVGltZW91dCA9 IHNldFRpbWVvdXQodGhpcy5jb21wbGV0ZS5iaW5kKHRoaXMsIHRydWUpLCAyNTApOwogICAgIH0s CiAKLSAgICBjb21wbGV0ZTogZnVuY3Rpb24oYXV0bykKKyAgICBjb21wbGV0ZTogZnVuY3Rpb24o YXV0bywgcmV2ZXJzZSkKICAgICB7CiAgICAgICAgIHRoaXMuY2xlYXJBdXRvQ29tcGxldGUodHJ1 ZSk7CiAgICAgICAgIHZhciBzZWxlY3Rpb24gPSB3aW5kb3cuZ2V0U2VsZWN0aW9uKCk7CkBAIC0x ODUsMTAgKzE4NSwxMCBAQCBXZWJJbnNwZWN0b3IuVGV4dFByb21wdC5wcm90b3R5cGUgPSB7CiAg ICAgICAgIGlmIChhdXRvICYmICF0aGlzLmlzQ2FyZXRBdEVuZE9mUHJvbXB0KCkpCiAgICAgICAg ICAgICByZXR1cm47CiAgICAgICAgIHZhciB3b3JkUHJlZml4UmFuZ2UgPSBzZWxlY3Rpb25SYW5n ZS5zdGFydENvbnRhaW5lci5yYW5nZU9mV29yZChzZWxlY3Rpb25SYW5nZS5zdGFydE9mZnNldCwg dGhpcy5jb21wbGV0aW9uU3RvcENoYXJhY3RlcnMsIHRoaXMuZWxlbWVudCwgImJhY2t3YXJkIik7 Ci0gICAgICAgIHRoaXMuY29tcGxldGlvbnMod29yZFByZWZpeFJhbmdlLCBhdXRvLCB0aGlzLl9j b21wbGV0aW9uc1JlYWR5LmJpbmQodGhpcywgc2VsZWN0aW9uLCBhdXRvLCB3b3JkUHJlZml4UmFu Z2UpKTsKKyAgICAgICAgdGhpcy5jb21wbGV0aW9ucyh3b3JkUHJlZml4UmFuZ2UsIGF1dG8sIHRo aXMuX2NvbXBsZXRpb25zUmVhZHkuYmluZCh0aGlzLCBzZWxlY3Rpb24sIGF1dG8sIHdvcmRQcmVm aXhSYW5nZSwgcmV2ZXJzZSkpOwogICAgIH0sCiAKLSAgICBfY29tcGxldGlvbnNSZWFkeTogZnVu Y3Rpb24oc2VsZWN0aW9uLCBhdXRvLCBvcmlnaW5hbFdvcmRQcmVmaXhSYW5nZSwgY29tcGxldGlv bnMpCisgICAgX2NvbXBsZXRpb25zUmVhZHk6IGZ1bmN0aW9uKHNlbGVjdGlvbiwgYXV0bywgb3Jp Z2luYWxXb3JkUHJlZml4UmFuZ2UsIHJldmVyc2UsIGNvbXBsZXRpb25zKQogICAgIHsKICAgICAg ICAgaWYgKCFjb21wbGV0aW9ucyB8fCAhY29tcGxldGlvbnMubGVuZ3RoKQogICAgICAgICAgICAg cmV0dXJuOwpAQCAtMjEyLDEwICsyMTIsMTMgQEAgV2ViSW5zcGVjdG9yLlRleHRQcm9tcHQucHJv dG90eXBlID0gewogICAgICAgICAgICAgICAgIGlmIChjb21wbGV0aW9uc1tpXSA9PT0gY3VycmVu dFRleHQpCiAgICAgICAgICAgICAgICAgICAgIGZvdW5kSW5kZXggPSBpOwogCi0gICAgICAgICAg ICBpZiAoZm91bmRJbmRleCA9PT0gbnVsbCB8fCAoZm91bmRJbmRleCArIDEpID49IGNvbXBsZXRp b25zLmxlbmd0aCkKKyAgICAgICAgICAgIHZhciBuZXh0SW5kZXggPSBmb3VuZEluZGV4ICsgKHJl dmVyc2UgPyAtMSA6IDEpOworICAgICAgICAgICAgaWYgKGZvdW5kSW5kZXggPT09IG51bGwgfHwg bmV4dEluZGV4ID49IGNvbXBsZXRpb25zLmxlbmd0aCkKICAgICAgICAgICAgICAgICB2YXIgY29t cGxldGlvblRleHQgPSBjb21wbGV0aW9uc1swXTsKKyAgICAgICAgICAgIGVsc2UgaWYgKG5leHRJ bmRleCA8IDApCisgICAgICAgICAgICAgICAgdmFyIGNvbXBsZXRpb25UZXh0ID0gY29tcGxldGlv bnNbY29tcGxldGlvbnMubGVuZ3RoIC0gMV07CiAgICAgICAgICAgICBlbHNlCi0gICAgICAgICAg ICAgICAgdmFyIGNvbXBsZXRpb25UZXh0ID0gY29tcGxldGlvbnNbZm91bmRJbmRleCArIDFdOwor ICAgICAgICAgICAgICAgIHZhciBjb21wbGV0aW9uVGV4dCA9IGNvbXBsZXRpb25zW25leHRJbmRl eF07CiAgICAgICAgIH0KIAogICAgICAgICB2YXIgd29yZFByZWZpeExlbmd0aCA9IG9yaWdpbmFs V29yZFByZWZpeFJhbmdlLnRvU3RyaW5nKCkubGVuZ3RoOwpAQCAtMzU0LDcgKzM1Nyw3IEBAIFdl Ykluc3BlY3Rvci5UZXh0UHJvbXB0LnByb3RvdHlwZSA9IHsKICAgICAgICAgZXZlbnQucHJldmVu dERlZmF1bHQoKTsKICAgICAgICAgZXZlbnQuc3RvcFByb3BhZ2F0aW9uKCk7CiAKLSAgICAgICAg dGhpcy5jb21wbGV0ZSgpOworICAgICAgICB0aGlzLmNvbXBsZXRlKGZhbHNlLCBldmVudC5zaGlm dEtleSk7CiAgICAgfSwKIAogICAgIF91cEtleVByZXNzZWQ6IGZ1bmN0aW9uKGV2ZW50KQo=