37579 2010-04-14 09:18:39 -0700 Web Inspector: Ctrl-L (Clear Console) does nothing on Windows 2010-04-14 11:18:50 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P2 Normal --- 1 apavlov apavlov bweinstein commit-queue joepeck keishi pfeldman pmuellr rik timothy oldest_to_newest 212370 0 apavlov 2010-04-14 09:18:39 -0700 The console is not cleared on non-Mac platforms when Ctrl-L is hit in the text prompt. 212374 1 53337 apavlov 2010-04-14 09:23:55 -0700 Created attachment 53337 [PATCH] Trivial fix 212392 2 53337 joepeck 2010-04-14 09:42:31 -0700 Comment on attachment 53337 [PATCH] Trivial fix I don't understand how this fixes Ctrl "L" on Windows. > 1 var clearConsoleHandler = this.requestClearMessages.bind(this); > 2 > 3 shortcut = WebInspector.KeyboardShortcut.makeKey("k", WebInspector.KeyboardShortcut.Modifiers.Meta); > 4 - this._shortcuts[shortcut] = clearConsoleHandler; > 5 + this._shortcuts[shortcut] = this.requestClearMessages.bind(this); > 6 this._shortcuts[shortcut].isMacOnly = true; > 7 shortcut = WebInspector.KeyboardShortcut.makeKey("l", WebInspector.KeyboardShortcut.Modifiers.Ctrl); > 8 this._shortcuts[shortcut] = clearConsoleHandler; Line 1 shows that the clearConsoleHandler variable already has the requestClearMessages bound to this already. So the change doesn't appear to do anything. Also, the change is made to the Mac only <Cmd>K clear shortcut, not to the Windows <Ctrl>L part. Is there something I am missing? 212395 3 53337 joepeck 2010-04-14 09:46:04 -0700 Comment on attachment 53337 [PATCH] Trivial fix Ahhhh, I think I got it. The "isMacOnly" property was being set on the shared bound function, and so all other cases (like Windows) see the isMacOnly property and don't run. Thats unfortunate. r=me if you Provide a comment explaining this (because its tricky). You might even want to reorder the code slightly if that helps make it clearer as well. 212406 4 53342 apavlov 2010-04-14 10:02:34 -0700 Created attachment 53342 [PATCH] Comments addressed 212409 5 53342 joepeck 2010-04-14 10:10:25 -0700 Comment on attachment 53342 [PATCH] Comments addressed Excellent. Thanks! 212447 6 53342 commit-queue 2010-04-14 11:18:43 -0700 Comment on attachment 53342 [PATCH] Comments addressed Clearing flags on attachment: 53342 Committed r57590: <http://trac.webkit.org/changeset/57590> 212448 7 commit-queue 2010-04-14 11:18:50 -0700 All reviewed patches have been landed. Closing bug. 53337 2010-04-14 09:23:55 -0700 2010-04-14 10:02:34 -0700 [PATCH] Trivial fix clearhistory.patch text/plain 1343 apavlov ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZDU3NmU5NS4uN2YwZjA0OSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wNC0xNCAgQWxleGFuZGVyIFBh dmxvdiAgPGFwYXZsb3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IEN0cmwtTCAoQ2xlYXIgSGlzdG9y eSkgZG9lcyBub3RoaW5nIG9uIFdpbmRvd3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTM3NTc5CisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5k L0NvbnNvbGVWaWV3LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkNvbnNvbGVWaWV3KToKKwog MjAxMC0wNC0xMyAgU3RlcGhhbiBBw59tdXMgIDxzdXBlcnN0aXBwaUBnbXguZGU+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgRGF2aWQgTGV2aW4uCmRpZmYgLS1naXQgYS9XZWJDb3JlL2luc3BlY3Rv ci9mcm9udC1lbmQvQ29uc29sZVZpZXcuanMgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQv Q29uc29sZVZpZXcuanMKaW5kZXggYTdhODAxZS4uNzcwZWU1MCAxMDA2NDQKLS0tIGEvV2ViQ29y ZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0NvbnNvbGVWaWV3LmpzCisrKyBiL1dlYkNvcmUvaW5zcGVj dG9yL2Zyb250LWVuZC9Db25zb2xlVmlldy5qcwpAQCAtOTYsNyArOTYsNyBAQCBXZWJJbnNwZWN0 b3IuQ29uc29sZVZpZXcgPSBmdW5jdGlvbihkcmF3ZXIpCiAgICAgdmFyIGNsZWFyQ29uc29sZUhh bmRsZXIgPSB0aGlzLnJlcXVlc3RDbGVhck1lc3NhZ2VzLmJpbmQodGhpcyk7CiAKICAgICBzaG9y dGN1dCA9IFdlYkluc3BlY3Rvci5LZXlib2FyZFNob3J0Y3V0Lm1ha2VLZXkoImsiLCBXZWJJbnNw ZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dC5Nb2RpZmllcnMuTWV0YSk7Ci0gICAgdGhpcy5fc2hvcnRj dXRzW3Nob3J0Y3V0XSA9IGNsZWFyQ29uc29sZUhhbmRsZXI7CisgICAgdGhpcy5fc2hvcnRjdXRz W3Nob3J0Y3V0XSA9IHRoaXMucmVxdWVzdENsZWFyTWVzc2FnZXMuYmluZCh0aGlzKTsKICAgICB0 aGlzLl9zaG9ydGN1dHNbc2hvcnRjdXRdLmlzTWFjT25seSA9IHRydWU7CiAgICAgc2hvcnRjdXQg PSBXZWJJbnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dC5tYWtlS2V5KCJsIiwgV2ViSW5zcGVjdG9y LktleWJvYXJkU2hvcnRjdXQuTW9kaWZpZXJzLkN0cmwpOwogICAgIHRoaXMuX3Nob3J0Y3V0c1tz aG9ydGN1dF0gPSBjbGVhckNvbnNvbGVIYW5kbGVyOwo= 53342 2010-04-14 10:02:34 -0700 2010-04-14 11:18:43 -0700 [PATCH] Comments addressed clearhistory.patch text/plain 1601 apavlov ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZDU3NmU5NS4uN2YwZjA0OSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wNC0xNCAgQWxleGFuZGVyIFBh dmxvdiAgPGFwYXZsb3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IEN0cmwtTCAoQ2xlYXIgSGlzdG9y eSkgZG9lcyBub3RoaW5nIG9uIFdpbmRvd3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTM3NTc5CisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5k L0NvbnNvbGVWaWV3LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkNvbnNvbGVWaWV3KToKKwog MjAxMC0wNC0xMyAgU3RlcGhhbiBBw59tdXMgIDxzdXBlcnN0aXBwaUBnbXguZGU+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgRGF2aWQgTGV2aW4uCmRpZmYgLS1naXQgYS9XZWJDb3JlL2luc3BlY3Rv ci9mcm9udC1lbmQvQ29uc29sZVZpZXcuanMgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQv Q29uc29sZVZpZXcuanMKaW5kZXggYTdhODAxZS4uZjg0MGE4MSAxMDA2NDQKLS0tIGEvV2ViQ29y ZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0NvbnNvbGVWaWV3LmpzCisrKyBiL1dlYkNvcmUvaW5zcGVj dG9yL2Zyb250LWVuZC9Db25zb2xlVmlldy5qcwpAQCAtOTMsMTEgKzkzLDEzIEBAIFdlYkluc3Bl Y3Rvci5Db25zb2xlVmlldyA9IGZ1bmN0aW9uKGRyYXdlcikKICAgICB0aGlzLl9zaG9ydGN1dHMg PSB7fTsKIAogICAgIHZhciBzaG9ydGN1dDsKLSAgICB2YXIgY2xlYXJDb25zb2xlSGFuZGxlciA9 IHRoaXMucmVxdWVzdENsZWFyTWVzc2FnZXMuYmluZCh0aGlzKTsKIAogICAgIHNob3J0Y3V0ID0g V2ViSW5zcGVjdG9yLktleWJvYXJkU2hvcnRjdXQubWFrZUtleSgiayIsIFdlYkluc3BlY3Rvci5L ZXlib2FyZFNob3J0Y3V0Lk1vZGlmaWVycy5NZXRhKTsKLSAgICB0aGlzLl9zaG9ydGN1dHNbc2hv cnRjdXRdID0gY2xlYXJDb25zb2xlSGFuZGxlcjsKKyAgICAvLyBUaGlzIGNhc2UgcmVxdWlyZXMg YSBzZXBhcmF0ZSBib3VuZCBmdW5jdGlvbiBhcyBpdHMgaXNNYWNPbmx5IHByb3BlcnR5IHNob3Vs ZCBub3QgYmUgc2hhcmVkIGFtb25nIGRpZmZlcmVudCBzaG9ydGN1dCBoYW5kbGVycy4KKyAgICB0 aGlzLl9zaG9ydGN1dHNbc2hvcnRjdXRdID0gdGhpcy5yZXF1ZXN0Q2xlYXJNZXNzYWdlcy5iaW5k KHRoaXMpOwogICAgIHRoaXMuX3Nob3J0Y3V0c1tzaG9ydGN1dF0uaXNNYWNPbmx5ID0gdHJ1ZTsK KworICAgIHZhciBjbGVhckNvbnNvbGVIYW5kbGVyID0gdGhpcy5yZXF1ZXN0Q2xlYXJNZXNzYWdl cy5iaW5kKHRoaXMpOwogICAgIHNob3J0Y3V0ID0gV2ViSW5zcGVjdG9yLktleWJvYXJkU2hvcnRj dXQubWFrZUtleSgibCIsIFdlYkluc3BlY3Rvci5LZXlib2FyZFNob3J0Y3V0Lk1vZGlmaWVycy5D dHJsKTsKICAgICB0aGlzLl9zaG9ydGN1dHNbc2hvcnRjdXRdID0gY2xlYXJDb25zb2xlSGFuZGxl cjsKIAo=