37571 2010-04-14 07:12:40 -0700 Do YARR JIT fallback earlier than the JIT code generation 2010-04-14 14:38:58 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 pvarga webkit-unassigned abecsi barraclough commit-queue ggaren ossy zherczeg oldest_to_newest 212330 0 pvarga 2010-04-14 07:12:40 -0700 Now the detection of the YARR JIT fallback to pcre happens during the JIT code generation phase. It can be done earlier in the YARR compiler phase. Thus the unnecessary code generation can be avoided in the fallback cases. This modification improve performance to YARR JIT when it does fallback. The WindScorpion's email.js regexp performance test run 1.26x as fast (3463.2ms +/- 0.4% -> 2754.4ms +/-0.4%). You download our benchmark suit from this link: http://www.sed.hu/webkit/?page=downloads&dl=windscorpion.zip 212331 1 53329 pvarga 2010-04-14 07:16:47 -0700 Created attachment 53329 proposed patch v1 Move the YARR JIT fallback detection from RegexJIT.cpp to RegexCompiler.cpp. 212376 2 ggaren 2010-04-14 09:25:49 -0700 Can you provide SunSpider results too please? 212378 3 53329 ggaren 2010-04-14 09:26:12 -0700 Comment on attachment 53329 proposed patch v1 r-, waiting on SunSpider results. 212385 4 abecsi 2010-04-14 09:33:58 -0700 (In reply to comment #2) > Can you provide SunSpider results too please? I do not think SunSpider has tests where this fallback occures, so the gain won't show there, but let's test. 212400 5 53329 ossy 2010-04-14 09:55:51 -0700 Comment on attachment 53329 proposed patch v1 SunSpider result: 642.5ms +/- 0.6% -> 639.6ms +/- 0.3% V8 result: 3432.1ms +/- 0.4% -> 3442.6ms +/- 0.2% There are no gains on SunSpider and on V8 as we expected, so I marked the patch with r? flag to wait for review. 212410 6 53329 ggaren 2010-04-14 10:11:08 -0700 Comment on attachment 53329 proposed patch v1 r=me 212441 7 zherczeg 2010-04-14 11:10:00 -0700 nice work! 212580 8 53329 commit-queue 2010-04-14 14:38:52 -0700 Comment on attachment 53329 proposed patch v1 Clearing flags on attachment: 53329 Committed r57608: <http://trac.webkit.org/changeset/57608> 212581 9 commit-queue 2010-04-14 14:38:58 -0700 All reviewed patches have been landed. Closing bug. 53329 2010-04-14 07:16:47 -0700 2010-04-14 14:38:52 -0700 proposed patch v1 0001-YARR-JIT-fallback.patch text/plain 6588 pvarga RnJvbSAxYTdhMDc3ZmY5ZGEwODdkNTRmNzhiZjY2NTM0NGI4ZjQ4NTQ0MTVkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQZXRlciBWYXJnYSA8cHZhcmdhQGluZi51LXN6ZWdlZC5odT4K RGF0ZTogV2VkLCAxNCBBcHIgMjAxMCAxNjoxMzo1MiArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIFlB UlIgSklUIGZhbGxiYWNrCgotLS0KIEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyAgICAgICAgICAg ICAgfCAgIDIyICsrKysrKysrKysrKysrKysrKysrKysKIEphdmFTY3JpcHRDb3JlL3lhcnIvUmVn ZXhDb21waWxlci5jcHAgfCAgICA0ICsrKysKIEphdmFTY3JpcHRDb3JlL3lhcnIvUmVnZXhKSVQu Y3BwICAgICAgfCAgIDIzICsrKysrKystLS0tLS0tLS0tLS0tLS0tCiBKYXZhU2NyaXB0Q29yZS95 YXJyL1JlZ2V4SklULmggICAgICAgIHwgICAgMiArLQogSmF2YVNjcmlwdENvcmUveWFyci9SZWdl eFBhdHRlcm4uaCAgICB8ICAgIDQgKysrKwogNSBmaWxlcyBjaGFuZ2VkLCAzOCBpbnNlcnRpb25z KCspLCAxNyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VM b2cgYi9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKaW5kZXggOWRjYWVkZS4uNjBjNTVlZiAxMDA2 NDQKLS0tIGEvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCisrKyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEwLTA0LTE0ICBQZXRlciBWYXJnYSAgPHB2YXJn YUBpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgTW92ZSB0aGUgWUFSUiBKSVQgZmFsbGJhY2sgZGV0ZWN0aW9uIGZyb20gUmVn ZXhKSVQuY3BwIHRvCisgICAgICAgIFJlZ2V4Q29tcGlsZXIuY3BwLgorCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNzU3MQorCisgICAgICAgICogeWFy ci9SZWdleENvbXBpbGVyLmNwcDoKKyAgICAgICAgKEpTQzo6WWFycjo6UmVnZXhQYXR0ZXJuQ29u c3RydWN0b3I6OmF0b21CYWNrUmVmZXJlbmNlKToKKyAgICAgICAgKEpTQzo6WWFycjo6UmVnZXhQ YXR0ZXJuQ29uc3RydWN0b3I6OnF1YW50aWZ5QXRvbSk6CisgICAgICAgICogeWFyci9SZWdleEpJ VC5jcHA6CisgICAgICAgIChKU0M6OllhcnI6OlJlZ2V4R2VuZXJhdG9yOjpnZW5lcmF0ZVRlcm0p OgorICAgICAgICAoSlNDOjpZYXJyOjpSZWdleEdlbmVyYXRvcjo6UmVnZXhHZW5lcmF0b3IpOgor ICAgICAgICAoSlNDOjpZYXJyOjpqaXRDb21waWxlUmVnZXgpOgorICAgICAgICAqIHlhcnIvUmVn ZXhKSVQuaDoKKyAgICAgICAgKEpTQzo6WWFycjo6UmVnZXhDb2RlQmxvY2s6Om9wZXJhdG9yISk6 CisgICAgICAgICogeWFyci9SZWdleFBhdHRlcm4uaDoKKyAgICAgICAgKEpTQzo6WWFycjo6UmVn ZXhQYXR0ZXJuOjpSZWdleFBhdHRlcm4pOgorICAgICAgICAoSlNDOjpZYXJyOjpSZWdleFBhdHRl cm46OnJlc2V0KToKKwogMjAxMC0wNC0xMiAgSm9jZWx5biBUdXJjb3R0ZSAgPGpvY2VseW4udHVy Y290dGVAbm9raWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IG5vYm9keSwgYnVpbGQgZml4 LgpkaWZmIC0tZ2l0IGEvSmF2YVNjcmlwdENvcmUveWFyci9SZWdleENvbXBpbGVyLmNwcCBiL0ph dmFTY3JpcHRDb3JlL3lhcnIvUmVnZXhDb21waWxlci5jcHAKaW5kZXggOWNkM2QxMi4uNmFkMDEw NiAxMDA2NDQKLS0tIGEvSmF2YVNjcmlwdENvcmUveWFyci9SZWdleENvbXBpbGVyLmNwcAorKysg Yi9KYXZhU2NyaXB0Q29yZS95YXJyL1JlZ2V4Q29tcGlsZXIuY3BwCkBAIC00NjksNiArNDY5LDcg QEAgcHVibGljOgogICAgIHZvaWQgYXRvbUJhY2tSZWZlcmVuY2UodW5zaWduZWQgc3VicGF0dGVy bklkKQogICAgIHsKICAgICAgICAgQVNTRVJUKHN1YnBhdHRlcm5JZCk7CisgICAgICAgIG1fcGF0 dGVybi5tX3Nob3VsZEZhbGxCYWNrID0gdHJ1ZTsKICAgICAgICAgbV9wYXR0ZXJuLm1fbWF4QmFj a1JlZmVyZW5jZSA9IHN0ZDo6bWF4KG1fcGF0dGVybi5tX21heEJhY2tSZWZlcmVuY2UsIHN1YnBh dHRlcm5JZCk7CiAKICAgICAgICAgaWYgKHN1YnBhdHRlcm5JZCA+IG1fcGF0dGVybi5tX251bVN1 YnBhdHRlcm5zKSB7CkBAIC01NDQsNiArNTQ1LDkgQEAgcHVibGljOgogICAgICAgICAgICAgcmV0 dXJuOwogICAgICAgICB9CiAKKyAgICAgICAgaWYgKG1heCA+IDEgJiYgdGVybS50eXBlID09IFBh dHRlcm5UZXJtOjpUeXBlUGFyZW50aGVzZXNTdWJwYXR0ZXJuKQorICAgICAgICAgICAgbV9wYXR0 ZXJuLm1fc2hvdWxkRmFsbEJhY2sgPSB0cnVlOworCiAgICAgICAgIGlmIChtaW4gPT0gMCkKICAg ICAgICAgICAgIHRlcm0ucXVhbnRpZnkobWF4LCBncmVlZHkgICA/IFF1YW50aWZpZXJHcmVlZHkg OiBRdWFudGlmaWVyTm9uR3JlZWR5KTsKICAgICAgICAgZWxzZSBpZiAobWluID09IG1heCkKZGlm ZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL3lhcnIvUmVnZXhKSVQuY3BwIGIvSmF2YVNjcmlwdENv cmUveWFyci9SZWdleEpJVC5jcHAKaW5kZXggMjcxZDQ1My4uZjM3YWJiZiAxMDA2NDQKLS0tIGEv SmF2YVNjcmlwdENvcmUveWFyci9SZWdleEpJVC5jcHAKKysrIGIvSmF2YVNjcmlwdENvcmUveWFy ci9SZWdleEpJVC5jcHAKQEAgLTEwODgsMTcgKzEwODgsMTUgQEAgY2xhc3MgUmVnZXhHZW5lcmF0 b3IgOiBwcml2YXRlIE1hY3JvQXNzZW1ibGVyIHsKICAgICAgICAgICAgIGJyZWFrOwogCiAgICAg ICAgIGNhc2UgUGF0dGVyblRlcm06OlR5cGVCYWNrUmVmZXJlbmNlOgotICAgICAgICAgICAgbV9n ZW5lcmF0aW9uRmFpbGVkID0gdHJ1ZTsKKyAgICAgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgp OwogICAgICAgICAgICAgYnJlYWs7CiAKICAgICAgICAgY2FzZSBQYXR0ZXJuVGVybTo6VHlwZUZv cndhcmRSZWZlcmVuY2U6CiAgICAgICAgICAgICBicmVhazsKIAogICAgICAgICBjYXNlIFBhdHRl cm5UZXJtOjpUeXBlUGFyZW50aGVzZXNTdWJwYXR0ZXJuOgotICAgICAgICAgICAgaWYgKCh0ZXJt LnF1YW50aXR5Q291bnQgPT0gMSkgJiYgIXRlcm0ucGFyZW50aGVzZXMuaXNDb3B5KQotICAgICAg ICAgICAgICAgIGdlbmVyYXRlUGFyZW50aGVzZXNTaW5nbGUoc3RhdGUpOwotICAgICAgICAgICAg ZWxzZQotICAgICAgICAgICAgICAgIG1fZ2VuZXJhdGlvbkZhaWxlZCA9IHRydWU7CisgICAgICAg ICAgICBBU1NFUlQoKHRlcm0ucXVhbnRpdHlDb3VudCA9PSAxKSAmJiAhdGVybS5wYXJlbnRoZXNl cy5pc0NvcHkpOyAvLyBtdXN0IGZhbGxiYWNrIHRvIHBjcmUgYmVmb3JlIHRoaXMgcG9pbnQKKyAg ICAgICAgICAgIGdlbmVyYXRlUGFyZW50aGVzZXNTaW5nbGUoc3RhdGUpOwogICAgICAgICAgICAg YnJlYWs7CiAKICAgICAgICAgY2FzZSBQYXR0ZXJuVGVybTo6VHlwZVBhcmVudGhldGljYWxBc3Nl cnRpb246CkBAIC0xMzUxLDcgKzEzNDksNiBAQCBjbGFzcyBSZWdleEdlbmVyYXRvciA6IHByaXZh dGUgTWFjcm9Bc3NlbWJsZXIgewogcHVibGljOgogICAgIFJlZ2V4R2VuZXJhdG9yKFJlZ2V4UGF0 dGVybiYgcGF0dGVybikKICAgICAgICAgOiBtX3BhdHRlcm4ocGF0dGVybikKLSAgICAgICAgLCBt X2dlbmVyYXRpb25GYWlsZWQoZmFsc2UpCiAgICAgewogICAgIH0KIApAQCAtMTM4MSwxNSArMTM3 OCw5IEBAIHB1YmxpYzoKICAgICAgICAgaml0T2JqZWN0LnNldChwYXRjaEJ1ZmZlci5maW5hbGl6 ZUNvZGUoKSk7CiAgICAgfQogCi0gICAgYm9vbCBnZW5lcmF0aW9uRmFpbGVkKCkKLSAgICB7Ci0g ICAgICAgIHJldHVybiBtX2dlbmVyYXRpb25GYWlsZWQ7Ci0gICAgfQotCiBwcml2YXRlOgogICAg IFJlZ2V4UGF0dGVybiYgbV9wYXR0ZXJuOwogICAgIFZlY3RvcjxBbHRlcm5hdGl2ZUJhY2t0cmFj a1JlY29yZD4gbV9iYWNrdHJhY2tSZWNvcmRzOwotICAgIGJvb2wgbV9nZW5lcmF0aW9uRmFpbGVk OwogfTsKIAogdm9pZCBqaXRDb21waWxlUmVnZXgoSlNHbG9iYWxEYXRhKiBnbG9iYWxEYXRhLCBS ZWdleENvZGVCbG9jayYgaml0T2JqZWN0LCBjb25zdCBVU3RyaW5nJiBwYXR0ZXJuU3RyaW5nLCB1 bnNpZ25lZCYgbnVtU3VicGF0dGVybnMsIGNvbnN0IGNoYXIqJiBlcnJvciwgYm9vbCBpZ25vcmVD YXNlLCBib29sIG11bHRpbGluZSkKQEAgLTE0MDEsMTMgKzEzOTIsMTMgQEAgdm9pZCBqaXRDb21w aWxlUmVnZXgoSlNHbG9iYWxEYXRhKiBnbG9iYWxEYXRhLCBSZWdleENvZGVCbG9jayYgaml0T2Jq ZWN0LCBjb25zdAogCiAgICAgbnVtU3VicGF0dGVybnMgPSBwYXR0ZXJuLm1fbnVtU3VicGF0dGVy bnM7CiAKLSAgICBSZWdleEdlbmVyYXRvciBnZW5lcmF0b3IocGF0dGVybik7Ci0gICAgZ2VuZXJh dG9yLmNvbXBpbGUoZ2xvYmFsRGF0YSwgaml0T2JqZWN0KTsKLQotICAgIGlmIChnZW5lcmF0b3Iu Z2VuZXJhdGlvbkZhaWxlZCgpKSB7CisgICAgaWYgKHBhdHRlcm4ubV9zaG91bGRGYWxsQmFjaykg ewogICAgICAgICBKU1JlZ0V4cElnbm9yZUNhc2VPcHRpb24gaWdub3JlQ2FzZU9wdGlvbiA9IGln bm9yZUNhc2UgPyBKU1JlZ0V4cElnbm9yZUNhc2UgOiBKU1JlZ0V4cERvTm90SWdub3JlQ2FzZTsK ICAgICAgICAgSlNSZWdFeHBNdWx0aWxpbmVPcHRpb24gbXVsdGlsaW5lT3B0aW9uID0gbXVsdGls aW5lID8gSlNSZWdFeHBNdWx0aWxpbmUgOiBKU1JlZ0V4cFNpbmdsZUxpbmU7CiAgICAgICAgIGpp dE9iamVjdC5zZXRGYWxsYmFjayhqc1JlZ0V4cENvbXBpbGUocmVpbnRlcnByZXRfY2FzdDxjb25z dCBVQ2hhcio+KHBhdHRlcm5TdHJpbmcuZGF0YSgpKSwgcGF0dGVyblN0cmluZy5zaXplKCksIGln bm9yZUNhc2VPcHRpb24sIG11bHRpbGluZU9wdGlvbiwgJm51bVN1YnBhdHRlcm5zLCAmZXJyb3Ip KTsKKyAgICB9IGVsc2UgeworICAgICAgICBSZWdleEdlbmVyYXRvciBnZW5lcmF0b3IocGF0dGVy bik7CisgICAgICAgIGdlbmVyYXRvci5jb21waWxlKGdsb2JhbERhdGEsIGppdE9iamVjdCk7CiAg ICAgfQogfQogCmRpZmYgLS1naXQgYS9KYXZhU2NyaXB0Q29yZS95YXJyL1JlZ2V4SklULmggYi9K YXZhU2NyaXB0Q29yZS95YXJyL1JlZ2V4SklULmgKaW5kZXggZmQ3NjViYy4uN2Y5YzE2ZSAxMDA2 NDQKLS0tIGEvSmF2YVNjcmlwdENvcmUveWFyci9SZWdleEpJVC5oCisrKyBiL0phdmFTY3JpcHRD b3JlL3lhcnIvUmVnZXhKSVQuaApAQCAtNjYsNyArNjYsNyBAQCBwdWJsaWM6CiAgICAgSlNSZWdF eHAqIGdldEZhbGxiYWNrKCkgeyByZXR1cm4gbV9mYWxsYmFjazsgfQogICAgIHZvaWQgc2V0RmFs bGJhY2soSlNSZWdFeHAqIGZhbGxiYWNrKSB7IG1fZmFsbGJhY2sgPSBmYWxsYmFjazsgfQogCi0g ICAgYm9vbCBvcGVyYXRvciEoKSB7IHJldHVybiAhbV9yZWYubV9jb2RlLmV4ZWN1dGFibGVBZGRy ZXNzKCk7IH0KKyAgICBib29sIG9wZXJhdG9yISgpIHsgcmV0dXJuICghbV9yZWYubV9jb2RlLmV4 ZWN1dGFibGVBZGRyZXNzKCkgJiYgIW1fZmFsbGJhY2spOyB9CiAgICAgdm9pZCBzZXQoTWFjcm9B c3NlbWJsZXI6OkNvZGVSZWYgcmVmKSB7IG1fcmVmID0gcmVmOyB9CiAKICAgICBpbnQgZXhlY3V0 ZShjb25zdCBVQ2hhciogaW5wdXQsIHVuc2lnbmVkIHN0YXJ0LCB1bnNpZ25lZCBsZW5ndGgsIGlu dCogb3V0cHV0KQpkaWZmIC0tZ2l0IGEvSmF2YVNjcmlwdENvcmUveWFyci9SZWdleFBhdHRlcm4u aCBiL0phdmFTY3JpcHRDb3JlL3lhcnIvUmVnZXhQYXR0ZXJuLmgKaW5kZXggMmU4ZjQ2OC4uNjli ZWUwYyAxMDA2NDQKLS0tIGEvSmF2YVNjcmlwdENvcmUveWFyci9SZWdleFBhdHRlcm4uaAorKysg Yi9KYXZhU2NyaXB0Q29yZS95YXJyL1JlZ2V4UGF0dGVybi5oCkBAIC0yNDcsNiArMjQ3LDcgQEAg c3RydWN0IFJlZ2V4UGF0dGVybiB7CiAgICAgICAgICwgbV9tdWx0aWxpbmUobXVsdGlsaW5lKQog ICAgICAgICAsIG1fbnVtU3VicGF0dGVybnMoMCkKICAgICAgICAgLCBtX21heEJhY2tSZWZlcmVu Y2UoMCkKKyAgICAgICAgLCBtX3Nob3VsZEZhbGxCYWNrKGZhbHNlKQogICAgICAgICAsIG5ld2xp bmVDYWNoZWQoMCkKICAgICAgICAgLCBkaWdpdHNDYWNoZWQoMCkKICAgICAgICAgLCBzcGFjZXND YWNoZWQoMCkKQEAgLTI2OCw2ICsyNjksOCBAQCBzdHJ1Y3QgUmVnZXhQYXR0ZXJuIHsKICAgICAg ICAgbV9udW1TdWJwYXR0ZXJucyA9IDA7CiAgICAgICAgIG1fbWF4QmFja1JlZmVyZW5jZSA9IDA7 CiAKKyAgICAgICAgbV9zaG91bGRGYWxsQmFjayA9IGZhbHNlOworCiAgICAgICAgIG5ld2xpbmVD YWNoZWQgPSAwOwogICAgICAgICBkaWdpdHNDYWNoZWQgPSAwOwogICAgICAgICBzcGFjZXNDYWNo ZWQgPSAwOwpAQCAtMzM0LDYgKzMzNyw3IEBAIHN0cnVjdCBSZWdleFBhdHRlcm4gewogICAgIGJv b2wgbV9tdWx0aWxpbmU7CiAgICAgdW5zaWduZWQgbV9udW1TdWJwYXR0ZXJuczsKICAgICB1bnNp Z25lZCBtX21heEJhY2tSZWZlcmVuY2U7CisgICAgYm9vbCBtX3Nob3VsZEZhbGxCYWNrOwogICAg IFBhdHRlcm5EaXNqdW5jdGlvbiogbV9ib2R5OwogICAgIFZlY3RvcjxQYXR0ZXJuRGlzanVuY3Rp b24qLCA0PiBtX2Rpc2p1bmN0aW9uczsKICAgICBWZWN0b3I8Q2hhcmFjdGVyQ2xhc3MqPiBtX3Vz ZXJDaGFyYWN0ZXJDbGFzc2VzOwotLSAKMS42LjQuNAoK