37563 2010-04-14 00:17:41 -0700 new-run-webkit-tests prints out nothing when build-dumprendertree fails 2010-09-24 15:04:33 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric webkit-unassigned abarth bashi cjerdonek commit-queue dpranke oldest_to_newest 212286 0 eric 2010-04-14 00:17:41 -0700 new-run-webkit-tests prints out nothing when build-dumprendertree fails % new-run-webkit-tests Checking build ...% % echo $? 255 It's also failing to print a newline when ending, thus causing the % to print in zsh. :) We must have our python logging configured wrong somehow. 278642 1 67507 bashi 2010-09-13 18:54:20 -0700 Created attachment 67507 Patch 278643 2 67507 dpranke 2010-09-13 18:57:39 -0700 Comment on attachment 67507 Patch > diff --git a/WebKitTools/ChangeLog b/WebKitTools/ChangeLog > index 2b72256b90d79bd73b6ff47ee2268c2632cb1084..f08aae58e77c64060b673b6459da2b00a45b21d5 100644 > --- a/WebKitTools/ChangeLog > +++ b/WebKitTools/ChangeLog > @@ -1,3 +1,14 @@ > +2010-09-13 Kenichi Ishibashi <bashi@google.com> > + > + Reviewed by NOBODY (OOPS!). > + > + new-run-webkit-tests prints out nothing when build-dumprendertree fails > + https://bugs.webkit.org/show_bug.cgi?id=37563 > + > + Print error message when build-dumprendertree fails. > + > + * Scripts/webkitpy/layout_tests/port/webkit.py: > + > 2010-09-12 Dirk Pranke <dpranke@chromium.org> > > Unreviewed, build fix. > diff --git a/WebKitTools/Scripts/webkitpy/layout_tests/port/webkit.py b/WebKitTools/Scripts/webkitpy/layout_tests/port/webkit.py > index b085ceb7e68fc6bdfc25bea2aafae8ab8bc92db8..a81b0fd21696b1b311cac81b0cdf650dff2adabb 100644 > --- a/WebKitTools/Scripts/webkitpy/layout_tests/port/webkit.py > +++ b/WebKitTools/Scripts/webkitpy/layout_tests/port/webkit.py > @@ -84,10 +84,14 @@ class WebKitPort(base.Port): > return '' > > def _build_driver(self): > - return not self._executive.run_command([ > + exit_code = self._executive.run_command([ > self.script_path("build-dumprendertree"), > self.flag_from_configuration(self._options.configuration), > ], return_exit_code=True) > + if exit_code != 0: > + _log.error("Failed to build DumpRenderTree") > + return False > + return True It's probably bad that the generic code in run_webkit_tests.py isn't printing anything in this case. Can you add a _log.error('Build check failed') message at run_webkit_test.py:1420 or thereabouts as well? Otherwise the change looks good to me (although I'm not a reviewer). -- Dirk 282572 3 67507 cfleizach 2010-09-21 14:51:39 -0700 Comment on attachment 67507 Patch ditto Dirk's suggestion 284301 4 bashi 2010-09-24 02:31:52 -0700 (In reply to comment #2) Hi Dirk, Thank you for your comment! > It's probably bad that the generic code in run_webkit_tests.py isn't printing anything in this case. Can you add a _log.error('Build check failed') message at run_webkit_test.py:1420 or thereabouts as well? I've added the message in order to follow your suggestion. Patch will come soon. 284302 5 68662 bashi 2010-09-24 02:34:57 -0700 Created attachment 68662 Patch V1 284675 6 68662 dpranke 2010-09-24 13:58:50 -0700 Comment on attachment 68662 Patch V1 LGTM, but I'm not a reviewer. 284689 7 68662 eric 2010-09-24 14:16:52 -0700 Comment on attachment 68662 Patch V1 View in context: https://bugs.webkit.org/attachment.cgi?id=68662&action=review > WebKitTools/Scripts/webkitpy/layout_tests/port/webkit.py:87 > - return not self._executive.run_command([ > + exit_code = self._executive.run_command([ We don't really need to stash the exit_code in a local, but this is fine. :) 284745 8 68662 commit-queue 2010-09-24 15:04:27 -0700 Comment on attachment 68662 Patch V1 Clearing flags on attachment: 68662 Committed r68294: <http://trac.webkit.org/changeset/68294> 284746 9 commit-queue 2010-09-24 15:04:33 -0700 All reviewed patches have been landed. Closing bug. 67507 2010-09-13 18:54:20 -0700 2010-09-24 02:34:52 -0700 Patch bug-37563-20100914105418.patch text/plain 1589 bashi ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCAyYjcyMjU2YjkwZDc5YmQ3M2I2ZmY0N2VlMjI2OGMyNjMyY2IxMDg0Li5mMDhhYWU1 OGU3N2M2NDA2MGI2NzNiNjQ1OWRhMmIwMGE0NWIyMWQ1IDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAK KzIwMTAtMDktMTMgIEtlbmljaGkgSXNoaWJhc2hpICA8YmFzaGlAZ29vZ2xlLmNvbT4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBuZXctcnVuLXdlYmtp dC10ZXN0cyBwcmludHMgb3V0IG5vdGhpbmcgd2hlbiBidWlsZC1kdW1wcmVuZGVydHJlZSBmYWls cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzc1NjMK KworICAgICAgICBQcmludCBlcnJvciBtZXNzYWdlIHdoZW4gYnVpbGQtZHVtcHJlbmRlcnRyZWUg ZmFpbHMuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3dl YmtpdC5weToKKwogMjAxMC0wOS0xMiAgRGlyayBQcmFua2UgIDxkcHJhbmtlQGNocm9taXVtLm9y Zz4KIAogICAgICAgICBVbnJldmlld2VkLCBidWlsZCBmaXguCmRpZmYgLS1naXQgYS9XZWJLaXRU b29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3dlYmtpdC5weSBiL1dlYktp dFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvd2Via2l0LnB5CmluZGV4 IGIwODVjZWI3ZTY4ZmM2YmRmYzI1YmVhMmFhZmFlOGFiOGJjOTJkYjguLmE4MWIwZmQyMTY5NmIx YjMxMWNhYzgxYjBjZGY2NTBkZmYyYWRhYmIgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1Njcmlw dHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvd2Via2l0LnB5CisrKyBiL1dlYktpdFRvb2xz L1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvd2Via2l0LnB5CkBAIC04NCwxMCAr ODQsMTQgQEAgY2xhc3MgV2ViS2l0UG9ydChiYXNlLlBvcnQpOgogICAgICAgICByZXR1cm4gJycK IAogICAgIGRlZiBfYnVpbGRfZHJpdmVyKHNlbGYpOgotICAgICAgICByZXR1cm4gbm90IHNlbGYu X2V4ZWN1dGl2ZS5ydW5fY29tbWFuZChbCisgICAgICAgIGV4aXRfY29kZSA9IHNlbGYuX2V4ZWN1 dGl2ZS5ydW5fY29tbWFuZChbCiAgICAgICAgICAgICBzZWxmLnNjcmlwdF9wYXRoKCJidWlsZC1k dW1wcmVuZGVydHJlZSIpLAogICAgICAgICAgICAgc2VsZi5mbGFnX2Zyb21fY29uZmlndXJhdGlv bihzZWxmLl9vcHRpb25zLmNvbmZpZ3VyYXRpb24pLAogICAgICAgICBdLCByZXR1cm5fZXhpdF9j b2RlPVRydWUpCisgICAgICAgIGlmIGV4aXRfY29kZSAhPSAwOgorICAgICAgICAgICAgX2xvZy5l cnJvcigiRmFpbGVkIHRvIGJ1aWxkIER1bXBSZW5kZXJUcmVlIikKKyAgICAgICAgICAgIHJldHVy biBGYWxzZQorICAgICAgICByZXR1cm4gVHJ1ZQogCiAgICAgZGVmIF9jaGVja19kcml2ZXIoc2Vs Zik6CiAgICAgICAgIGRyaXZlcl9wYXRoID0gc2VsZi5fcGF0aF90b19kcml2ZXIoKQo= 68662 2010-09-24 02:34:57 -0700 2010-09-24 15:04:27 -0700 Patch V1 bug-37563-20100924183455.patch text/plain 2341 bashi ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCAzZjY3YTQ4MWE3ZjAyYmZjOTkwYThkZTVhODdmMjVmNDdjOWM2N2Y1Li45YTc5YjZi NDhjZGEyMzc1YmJhYWRhN2JkYTdlNWIyMjFlM2U5N2Q5IDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTAtMDktMjQgIEtlbmljaGkgSXNoaWJhc2hpICA8YmFzaGlAZ29vZ2xlLmNvbT4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBuZXctcnVuLXdlYmtp dC10ZXN0cyBwcmludHMgb3V0IG5vdGhpbmcgd2hlbiBidWlsZC1kdW1wcmVuZGVydHJlZSBmYWls cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzc1NjMK KworICAgICAgICBQcmludCBlcnJvciBtZXNzYWdlIHdoZW4gYnVpbGQtZHVtcHJlbmRlcnRyZWUg ZmFpbHMuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3dl YmtpdC5weToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5fd2Vi a2l0X3Rlc3RzLnB5OgorCiAyMDEwLTA5LTIzICBUb255IENoYW5nICA8dG9ueUBjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjY4MjMyLgpkaWZmIC0tZ2l0 IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC93ZWJraXQu cHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3dlYmtp dC5weQppbmRleCA3ZWM4MTVhOGVjZjBkNjBkYmRkNzE0ZDlkZmFhZmY1Y2U4Yjk0NTVmLi40NTZl YTkxYWY0MmVkNzRjYjAyNjk2MjE5OGZmMzQ4MzQ3MGFjNjdkIDEwMDY0NAotLS0gYS9XZWJLaXRU b29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3dlYmtpdC5weQorKysgYi9X ZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3dlYmtpdC5weQpA QCAtODQsMTAgKzg0LDE0IEBAIGNsYXNzIFdlYktpdFBvcnQoYmFzZS5Qb3J0KToKICAgICAgICAg cmV0dXJuICcnCiAKICAgICBkZWYgX2J1aWxkX2RyaXZlcihzZWxmKToKLSAgICAgICAgcmV0dXJu IG5vdCBzZWxmLl9leGVjdXRpdmUucnVuX2NvbW1hbmQoWworICAgICAgICBleGl0X2NvZGUgPSBz ZWxmLl9leGVjdXRpdmUucnVuX2NvbW1hbmQoWwogICAgICAgICAgICAgc2VsZi5zY3JpcHRfcGF0 aCgiYnVpbGQtZHVtcHJlbmRlcnRyZWUiKSwKICAgICAgICAgICAgIHNlbGYuZmxhZ19mcm9tX2Nv bmZpZ3VyYXRpb24oc2VsZi5fb3B0aW9ucy5jb25maWd1cmF0aW9uKSwKICAgICAgICAgXSwgcmV0 dXJuX2V4aXRfY29kZT1UcnVlKQorICAgICAgICBpZiBleGl0X2NvZGUgIT0gMDoKKyAgICAgICAg ICAgIF9sb2cuZXJyb3IoIkZhaWxlZCB0byBidWlsZCBEdW1wUmVuZGVyVHJlZSIpCisgICAgICAg ICAgICByZXR1cm4gRmFsc2UKKyAgICAgICAgcmV0dXJuIFRydWUKIAogICAgIGRlZiBfY2hlY2tf ZHJpdmVyKHNlbGYpOgogICAgICAgICBkcml2ZXJfcGF0aCA9IHNlbGYuX3BhdGhfdG9fZHJpdmVy KCkKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3Rz L3J1bl93ZWJraXRfdGVzdHMucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91 dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzLnB5CmluZGV4IDlhMGQyNGM4NjZhZTFjYjhhMjM2YzQ4 MGI1YjUzZTU1OTk5ZGQxNjUuLmU5YzZkMmNiODBkZGZiYmU3NTA4NGIzNTMzOGFhNjhjNWEzNmRl YzkgMTAwNzU1Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3Rz L3J1bl93ZWJraXRfdGVzdHMucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9s YXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0cy5weQpAQCAtMTQwMSw2ICsxNDAxLDcgQEAgZGVm IHJ1bihwb3J0LCBvcHRpb25zLCBhcmdzLCByZWd1bGFyX291dHB1dD1zeXMuc3RkZXJyLAogCiAg ICAgICAgIHByaW50ZXIucHJpbnRfdXBkYXRlKCJDaGVja2luZyBidWlsZCAuLi4iKQogICAgICAg ICBpZiBub3QgcG9ydC5jaGVja19idWlsZCh0ZXN0X3J1bm5lci5uZWVkc19odHRwKCkpOgorICAg ICAgICAgICAgX2xvZy5lcnJvcigiQnVpbGQgY2hlY2sgZmFpbGVkIikKICAgICAgICAgICAgIHJl dHVybiAtMQogCiAgICAgICAgIHJlc3VsdF9zdW1tYXJ5ID0gdGVzdF9ydW5uZXIuc2V0X3VwX3J1 bigpCg==