37542 2010-04-13 19:04:18 -0700 [WML] Duplicated patches were pushed 2010-04-15 04:51:36 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 0 gyuyoung.kim webkit-unassigned commit-queue eric zmo oldest_to_newest 212193 0 gyuyoung.kim 2010-04-13 19:04:18 -0700 Duplicated patches were pushed to same files (wml/WMLOptionElement.h, wml/WMLSelectElement.h) - Bug 36698 - There are build breaks when wml is enabled. - Bug 36648 - [WML] WML enabled build failure. I think one of them should be reverted. There are build breaks when wml enabled as below, ------------------------------------------------------------------------------------------------------ In file included from WebCore/dom/SelectElement.cpp:48: ./WebCore/wml/WMLSelectElement.h:92: error: 'virtual void WebCore::WMLSelectElement::listBoxSelectItem(int, bool, bool, bool)' cannot be overloaded ./WebCore/wml/WMLSelectElement.h:90: error: with 'virtual void WebCore::WMLSelectElement::listBoxSelectItem(int, bool, bool, bool)' In file included from WebCore/dom/OptionElement.cpp:34: ./WebCore/wml/WMLOptionElement.h:59: error: 'virtual bool WebCore::WMLOptionElement::disabled() const' cannot be overloaded ./WebCore/wml/WMLOptionElement.h:44: error: with 'virtual bool WebCore::WMLOptionElement::disabled() const' ------------------------------------------------------------------------------------------------------------- 212674 1 eric 2010-04-14 17:56:46 -0700 Feel free to post a patch. :) 212750 2 53409 gyuyoung.kim 2010-04-14 22:10:38 -0700 Created attachment 53409 Fix build break I attach a patch for this build fail. Thanks. 212753 3 53409 eric 2010-04-14 22:36:27 -0700 Comment on attachment 53409 Fix build break Are the current dummy implementations in the header the right ones? Do they need FIXMEs next to them? 212756 4 53410 gyuyoung.kim 2010-04-14 22:46:29 -0700 Created attachment 53410 Patch for wml build break I think so. I remove the dumy functions implemented in header file. 212761 5 53410 eric 2010-04-14 22:50:46 -0700 Comment on attachment 53410 Patch for wml build break OK. 212799 6 53410 commit-queue 2010-04-15 03:51:37 -0700 Comment on attachment 53410 Patch for wml build break Rejecting patch 53410 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--quiet']" exit_code: 1 Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 12683 test cases. fast/canvas/webgl/index-validation.html -> failed Exiting early after 1 failures. 5085 tests run. 85.28s total testing time 5084 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 1 test case (<1%) had stderr output Full output: http://webkit-commit-queue.appspot.com/results/1722046 212800 7 gyuyoung.kim 2010-04-15 04:14:08 -0700 Hmm, I don't know why this patch makes test fail. If you know the reason, could you tell me the reason ? 212801 8 eric 2010-04-15 04:36:49 -0700 It's not your fault, it's a flaky test. 212805 9 53410 commit-queue 2010-04-15 04:51:30 -0700 Comment on attachment 53410 Patch for wml build break Clearing flags on attachment: 53410 Committed r57639: <http://trac.webkit.org/changeset/57639> 212806 10 commit-queue 2010-04-15 04:51:36 -0700 All reviewed patches have been landed. Closing bug. 53409 2010-04-14 22:10:38 -0700 2010-04-14 22:46:29 -0700 Fix build break WMLBuildFixPatch.patch text/plain 2936 gyuyoung.kim SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NzYzMykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTAtMDQtMTQgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBz YW1zdW5nLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBEdXBsaWNhdGVkIHBhdGNoZXMgcmVsYXRlZCB0byB3bWwgd2VyZSBwdXNoZWQgdG8gdHJ1 bmsuIFNvLCBvbmUgb2YKKyAgICAgICAgdGhlIHBhdGNoZXMgc2hvdWxkIGJlIHJldmVydGVkLgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzc1NDIKKwor ICAgICAgICAqIHdtbC9XTUxPcHRpb25FbGVtZW50LmNwcDoKKyAgICAgICAgKiB3bWwvV01MT3B0 aW9uRWxlbWVudC5oOgorICAgICAgICAqIHdtbC9XTUxTZWxlY3RFbGVtZW50LmNwcDoKKyAgICAg ICAgKiB3bWwvV01MU2VsZWN0RWxlbWVudC5oOgorICAgICAgICAoV2ViQ29yZTo6V01MU2VsZWN0 RWxlbWVudDo6aW5pdGlhbGl6ZWQpOgorCiAyMDEwLTA0LTE0ICBTaW1vbiBGcmFzZXIgIDxzaW1v bi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhbiBCZXJuc3RlaW4u CkluZGV4OiBXZWJDb3JlL3dtbC9XTUxPcHRpb25FbGVtZW50LmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBX ZWJDb3JlL3dtbC9XTUxPcHRpb25FbGVtZW50LmNwcAkocmV2aXNpb24gNTc2MzEpCisrKyBXZWJD b3JlL3dtbC9XTUxPcHRpb25FbGVtZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTcwLDEyICsx NzAsNiBAQCB2b2lkIFdNTE9wdGlvbkVsZW1lbnQ6OmhhbmRsZUludHJpbnNpY0V2CiAgICAgICAg IGV2ZW50SGFuZGxlci0+dHJpZ2dlckludHJpbnNpY0V2ZW50KFdNTEludHJpbnNpY0V2ZW50T25Q aWNrKTsKIH0KIAotYm9vbCBXTUxPcHRpb25FbGVtZW50OjpkaXNhYmxlZCgpIGNvbnN0Ci17Ci0g ICAgLyogRHVtbXkgaW1wbGVtZW50YXRpb24sIGFzIGRpc2FibGVkKCkgaXMgcHVyZSB2aXJ0dWFs IGluIE9wdGlvbkVsZW1lbnQgY2xhc3MgKi8KLSAgICByZXR1cm4gZmFsc2U7Ci19Ci0KIH0KIAog I2VuZGlmCkluZGV4OiBXZWJDb3JlL3dtbC9XTUxPcHRpb25FbGVtZW50LmgKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gV2ViQ29yZS93bWwvV01MT3B0aW9uRWxlbWVudC5oCShyZXZpc2lvbiA1NzYzMSkKKysrIFdl YkNvcmUvd21sL1dNTE9wdGlvbkVsZW1lbnQuaAkod29ya2luZyBjb3B5KQpAQCAtNTYsOCArNTYs NiBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCBTdHJpbmcgdGV4dEluZGVudGVkVG9SZXNwZWN0R3Jv dXBMYWJlbCgpIGNvbnN0OwogICAgIHZpcnR1YWwgU3RyaW5nIHZhbHVlKCkgY29uc3Q7CiAKLSAg ICB2aXJ0dWFsIGJvb2wgZGlzYWJsZWQoKSBjb25zdDsKLQogcHJpdmF0ZToKICAgICB2aXJ0dWFs IFJlbmRlclN0eWxlKiBub25SZW5kZXJlclJlbmRlclN0eWxlKCkgY29uc3Q7CiAgICAgdm9pZCBo YW5kbGVJbnRyaW5zaWNFdmVudElmTmVlZGVkKCk7CkluZGV4OiBXZWJDb3JlL3dtbC9XTUxTZWxl Y3RFbGVtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3dtbC9XTUxTZWxlY3RFbGVtZW50 LmNwcAkocmV2aXNpb24gNTc2MzEpCisrKyBXZWJDb3JlL3dtbC9XTUxTZWxlY3RFbGVtZW50LmNw cAkod29ya2luZyBjb3B5KQpAQCAtNTQ1LDExICs1NDUsNiBAQCBTdHJpbmcgV01MU2VsZWN0RWxl bWVudDo6aXZhbHVlKCkgY29uc3QKICAgICByZXR1cm4gcGFyc2VWYWx1ZVN1YnN0aXR1dGluZ1Zh cmlhYmxlUmVmZXJlbmNlcyhnZXRBdHRyaWJ1dGUoaXZhbHVlQXR0cikpOwogfQogCi12b2lkIFdN TFNlbGVjdEVsZW1lbnQ6Omxpc3RCb3hTZWxlY3RJdGVtKGludCBsaXN0SW5kZXgsIGJvb2wgYWxs b3dNdWx0aXBseVNlbGVjdGlvbnMsIGJvb2wgc2hpZnQsIGJvb2wgZmlyZU9uQ2hhbmdlTm93KQot ewotICAgIC8qIER1bW15IGltcGxlbWVudGF0aW9uIGFzIGxpc3RCb3hTZWxlY3RJdGVtIGlzIHB1 cmUgdmlydHVhbCBpbiBTZWxlY3RFbGVtZW50IGNsYXNzICovCi19Ci0KIH0KIAogI2VuZGlmCklu ZGV4OiBXZWJDb3JlL3dtbC9XTUxTZWxlY3RFbGVtZW50LmgKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29y ZS93bWwvV01MU2VsZWN0RWxlbWVudC5oCShyZXZpc2lvbiA1NzYzMSkKKysrIFdlYkNvcmUvd21s L1dNTFNlbGVjdEVsZW1lbnQuaAkod29ya2luZyBjb3B5KQpAQCAtODYsOCArODYsNiBAQCBwdWJs aWM6CiAgICAgdm9pZCBzZWxlY3RJbml0aWFsT3B0aW9ucygpOwogCiAgICAgYm9vbCBpbml0aWFs aXplZCgpIGNvbnN0IHsgcmV0dXJuIG1faW5pdGlhbGl6ZWQ7IH0KLSAgICAKLSAgICB2aXJ0dWFs IHZvaWQgbGlzdEJveFNlbGVjdEl0ZW0oaW50IGxpc3RJbmRleCwgYm9vbCBhbGxvd011bHRpcGx5 U2VsZWN0aW9ucywgYm9vbCBzaGlmdCwgYm9vbCBmaXJlT25DaGFuZ2VOb3cgPSB0cnVlKTsKIAog ICAgIHZpcnR1YWwgdm9pZCBsaXN0Qm94U2VsZWN0SXRlbShpbnQgbGlzdEluZGV4LCBib29sIGFs bG93TXVsdGlwbHlTZWxlY3Rpb25zLCBib29sIHNoaWZ0LCBib29sIGZpcmVPbkNoYW5nZU5vdyA9 IHRydWUpIHsgcmV0dXJuOyB9CiBwcml2YXRlOgo= 53410 2010-04-14 22:46:29 -0700 2010-04-15 04:51:30 -0700 Patch for wml build break WMLBuildBreak.patch text/plain 1827 gyuyoung.kim SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NzYzMykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTAtMDQtMTQgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBz YW1zdW5nLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBEdXBsaWNhdGVkIHBhdGNoZXMgcmVsYXRlZCB0byB3bWwgd2VyZSBwdXNoZWQgdG8gdHJ1 bmsuIFNvLCBvbmUgb2YKKyAgICAgICAgdGhlIHBhdGNoZXMgc2hvdWxkIGJlIHJldmVydGVkLgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzc1NDIKKwor ICAgICAgICAqIHdtbC9XTUxPcHRpb25FbGVtZW50Lmg6CisgICAgICAgICogd21sL1dNTFNlbGVj dEVsZW1lbnQuaDoKKwogMjAxMC0wNC0xNCAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFw cGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYW4gQmVybnN0ZWluLgpJbmRleDogV2Vi Q29yZS93bWwvV01MT3B0aW9uRWxlbWVudC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvd21sL1dN TE9wdGlvbkVsZW1lbnQuaAkocmV2aXNpb24gNTc2MzEpCisrKyBXZWJDb3JlL3dtbC9XTUxPcHRp b25FbGVtZW50LmgJKHdvcmtpbmcgY29weSkKQEAgLTQxLDggKzQxLDYgQEAgcHVibGljOgogICAg IHZpcnR1YWwgdm9pZCBjaGlsZHJlbkNoYW5nZWQoYm9vbCBjaGFuZ2VkQnlQYXJzZXIgPSBmYWxz ZSwgTm9kZSogYmVmb3JlQ2hhbmdlID0gMCwgTm9kZSogYWZ0ZXJDaGFuZ2UgPSAwLCBpbnQgY2hp bGRDb3VudERlbHRhID0gMCk7CiAgICAgdmlydHVhbCB2b2lkIHBhcnNlTWFwcGVkQXR0cmlidXRl KE1hcHBlZEF0dHJpYnV0ZSopOwogCi0gICAgdmlydHVhbCBib29sIGRpc2FibGVkKCkgY29uc3Qg eyByZXR1cm4gZmFsc2U7IH0KLQogICAgIHZpcnR1YWwgdm9pZCBhdHRhY2goKTsKICAgICB2aXJ0 dWFsIHZvaWQgZGV0YWNoKCk7CiAgICAgdmlydHVhbCB2b2lkIHNldFJlbmRlclN0eWxlKFBhc3NS ZWZQdHI8UmVuZGVyU3R5bGU+KTsKSW5kZXg6IFdlYkNvcmUvd21sL1dNTFNlbGVjdEVsZW1lbnQu aAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3dtbC9XTUxTZWxlY3RFbGVtZW50LmgJKHJldmlzaW9u IDU3NjMxKQorKysgV2ViQ29yZS93bWwvV01MU2VsZWN0RWxlbWVudC5oCSh3b3JraW5nIGNvcHkp CkBAIC04OCw4ICs4OCw2IEBAIHB1YmxpYzoKICAgICBib29sIGluaXRpYWxpemVkKCkgY29uc3Qg eyByZXR1cm4gbV9pbml0aWFsaXplZDsgfQogICAgIAogICAgIHZpcnR1YWwgdm9pZCBsaXN0Qm94 U2VsZWN0SXRlbShpbnQgbGlzdEluZGV4LCBib29sIGFsbG93TXVsdGlwbHlTZWxlY3Rpb25zLCBi b29sIHNoaWZ0LCBib29sIGZpcmVPbkNoYW5nZU5vdyA9IHRydWUpOwotCi0gICAgdmlydHVhbCB2 b2lkIGxpc3RCb3hTZWxlY3RJdGVtKGludCBsaXN0SW5kZXgsIGJvb2wgYWxsb3dNdWx0aXBseVNl bGVjdGlvbnMsIGJvb2wgc2hpZnQsIGJvb2wgZmlyZU9uQ2hhbmdlTm93ID0gdHJ1ZSkgeyByZXR1 cm47IH0KIHByaXZhdGU6CiAgICAgdmlydHVhbCB2b2lkIGluc2VydGVkSW50b1RyZWUoYm9vbCk7 CiAK