37533 2010-04-13 17:10:44 -0700 [Chromium] UniscribeHelper::draw() should not ASSERT that ScriptTextOut always succeeds 2010-04-14 14:52:11 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 dumi dumi brettw eric oldest_to_newest 212167 0 dumi 2010-04-13 17:10:44 -0700 UniscribeHelper::draw() should not ASSERT that ScriptTextOut() always succeed. It even has logic to deal with this kind of failures. 212169 1 53302 dumi 2010-04-13 17:12:45 -0700 Created attachment 53302 patch 212181 2 brettw 2010-04-13 17:55:10 -0700 For background, we probably used to have a DCHECK here with is a debug-only assert to help catch errors. However, there are legitimate reasons this function may fail, especially in the Chrome sandbox, which is what the existing recovery code is supposed to do. 212271 3 53302 jianli 2010-04-13 23:49:14 -0700 Comment on attachment 53302 patch r=me 212504 4 dumi 2010-04-14 12:44:49 -0700 Landed as r57595. 212588 5 eric 2010-04-14 14:50:02 -0700 fast/dom/Window/HTMLFrameSetElement-window-eventListener-attributes.html has been failing consistently on SnowLeopard since this checkin: http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r57603%20(5978)/fast/dom/Window/HTMLFrameSetElement-window-eventListener-attributes-stderr.txt ASSERTION FAILED: m_wrapper || !m_jsFunction (/Volumes/Data/WebKit-BuildSlave/snowleopard-intel-leaks/build/WebCore/bindings/js/JSEventListener.h:83 JSC::JSObject* WebCore::JSEventListener::jsFunction(WebCore::ScriptExecutionContext*) const) That's the same ASSERT as bug 36779, except now its failing every time. 212592 6 eric 2010-04-14 14:52:11 -0700 Nevermind, this test is flakey and has been failing for much longer. 53302 2010-04-13 17:12:45 -0700 2010-04-13 23:49:13 -0700 patch patch text/plain 1294 dumi SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NzU1MCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTAtMDQtMTMgIER1bWl0cnUgRGFuaWxpdWMgIDxkdW1pQGNocm9t aXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBSZW1vdmUgYW4gaW5jb3JyZWN0IEFTU0VSVCBpbiBVbmlzY3JpYmVIZWxwZXI6OmRyYXcoKS4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM3NTMzCisK KyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9VbmlzY3JpYmVIZWxwZXIuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6VW5pc2NyaWJlSGVscGVyOjpkcmF3KToKKwogMjAxMC0wNC0x MyAgQ2hhbmcgU2h1ICA8Y2hhbmcuc2h1QG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBi eSBEYXJpbiBGaXNoZXIuCkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVt L1VuaXNjcmliZUhlbHBlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9jaHJvbWl1bS9VbmlzY3JpYmVIZWxwZXIuY3BwCShyZXZpc2lvbiA1NzU0OCkKKysrIFdl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vVW5pc2NyaWJlSGVscGVyLmNwcAkod29y a2luZyBjb3B5KQpAQCAtMzk4LDcgKzM5OCw2IEBAIHZvaWQgVW5pc2NyaWJlSGVscGVyOjpkcmF3 KEdyYXBoaWNzQ29udGUKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgJnNoYXBpbmcubV9hZHZhbmNlW2Zyb21HbHlwaF0sCiAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGp1c3RpZnksCiAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICZzaGFwaW5nLm1fb2Zmc2V0c1tmcm9tR2x5cGhd KTsKLSAgICAgICAgICAgICAgICAgICAgQVNTRVJUKFNfT0sgPT0gaHIpOwogICAgICAgICAgICAg ICAgICAgICB0ZXh0T3V0T2sgPSAoaHIgPT0gU19PSyk7CiAgICAgICAgICAgICAgICAgfSBlbHNl IHsKICAgICAgICAgICAgICAgICAgICAgU2tQb2ludCBvcmlnaW47Cg==