37531 2010-04-13 16:42:56 -0700 Dummy bug for testing code review tool. 2010-06-12 21:05:03 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED INVALID P2 Normal --- 1 jparent jparent eric oldest_to_newest 212151 0 jparent 2010-04-13 16:42:56 -0700 This is just a test bug for testing reitveld integration. Don't worry, I am only making one fake bug. 212152 1 53298 jparent 2010-04-13 16:43:39 -0700 Created attachment 53298 Dummy patch. 212160 2 53298 jparent 2010-04-13 16:57:22 -0700 Comment on attachment 53298 Dummy patch. testing 212612 3 53298 jparent 2010-04-14 15:22:24 -0700 Comment on attachment 53298 Dummy patch. > > > > > setTimeout(function() { > var codeViewFrame = document.getElementsByTagName('frame')[0]; > var reviewFrame = document.getElementsByTagName('frame')[1]; > var reviewDoc = reviewFrame.contentDocument; > > // Add button for showing Reitveld. > var prettyPatchButton = reviewDoc.getElementById('viewPrettyPatchButton'); > var awesomeButton = reviewDoc.createElement('input'); > awesomeButton.type = 'button'; > awesomeButton.id = 'reitveldBtn'; > awesomeButton.value = 'View in Reitveld'; > awesomeButton.onclick = navToReitveld; > prettyPatchButton.parentNode.appendChild(awesomeButton); > > function navToReitveld() { > // TODO: Get real URL here. > codeViewFrame.location = 'http://wkrietveld.appspot.com/'; > } > > function updateComments() { > // Hook into submit action, get data from reitveld. > var commentField = reviewDoc.getElementById('comment'); > var comments = > commentField.value = comments; > } > > }, 1000); 212626 4 53298 jparent 2010-04-14 15:39:25 -0700 Comment on attachment 53298 Dummy patch. foo@bar.com 213023 5 53298 jparent 2010-04-15 13:57:22 -0700 Comment on attachment 53298 Dummy patch. http://wkrietveld.appspot.com/2001/diff/1/2 File templates/patch.html (right): http://wkrietveld.appspot.com/2001/diff/1/2#newcode162 templates/patch.html:162: console.log("Publishing codereview comments failed with real uplod!") THIS IS NEW! On 2010/04/15 20:52:36, contributor wrote: > On 2010/04/15 20:50:48, contributor wrote: > > On 2010/04/15 20:41:55, contributor wrote: > > > This line is too long. > > > > Done. > > Done. 213026 6 53298 jparent 2010-04-15 14:00:41 -0700 Comment on attachment 53298 Dummy patch. http://wkrietveld.appspot.com/2001/diff/1/2 File templates/patch.html (right): http://wkrietveld.appspot.com/2001/diff/1/2#newcode162 templates/patch.html:162: console.log("Publishing codereview comments failed with real uplod!") This is awesome! On 2010/04/15 20:57:21, contributor wrote: > THIS IS NEW! > > On 2010/04/15 20:52:36, contributor wrote: > > On 2010/04/15 20:50:48, contributor wrote: > > > On 2010/04/15 20:41:55, contributor wrote: > > > > This line is too long. > > > > > > Done. > > > > Done. > > 213034 7 53473 ojan 2010-04-15 14:07:46 -0700 Created attachment 53473 Patch 213040 8 53476 ojan 2010-04-15 14:10:16 -0700 Created attachment 53476 Patch Feel free to provide comments at https://wkrietveld.appspot.com/3001 213053 9 53478 ojan 2010-04-15 14:27:06 -0700 Created attachment 53478 Patch-4001 Feel free to provide comments at https://wkrietveld.appspot.com/4001 213336 10 53478 jparent 2010-04-16 11:50:45 -0700 Comment on attachment 53478 Patch-4001 My comments from here ------------------------------------------------------------------ http://wkrietveld.appspot.com/4001/diff/1/4 File WebKitTools/Scripts/webkitpy/tool/steps/postdiff.py (right): http://wkrietveld.appspot.com/4001/diff/1/4#newcode4 WebKitTools/Scripts/webkitpy/tool/steps/postdiff.py:4: # modification, are permitted provided that the following conditions are Wot? 213341 11 53478 levin 2010-04-16 11:53:56 -0700 Comment on attachment 53478 Patch-4001 test ------------------------------------------------------------------ 213480 12 53577 ojan 2010-04-16 16:25:26 -0700 Created attachment 53577 Patch-5001 53298 2010-04-13 16:43:39 -0700 2010-04-15 14:07:39 -0700 Dummy patch. webkit-cr.js text/plain 920 jparent DQoNCg0KDQpzZXRUaW1lb3V0KGZ1bmN0aW9uKCkgew0KdmFyIGNvZGVWaWV3RnJhbWUgPSBkb2N1 bWVudC5nZXRFbGVtZW50c0J5VGFnTmFtZSgnZnJhbWUnKVswXTsNCnZhciByZXZpZXdGcmFtZSA9 IGRvY3VtZW50LmdldEVsZW1lbnRzQnlUYWdOYW1lKCdmcmFtZScpWzFdOw0KdmFyIHJldmlld0Rv YyA9IHJldmlld0ZyYW1lLmNvbnRlbnREb2N1bWVudDsNCg0KLy8gQWRkIGJ1dHRvbiBmb3Igc2hv d2luZyBSZWl0dmVsZC4NCnZhciBwcmV0dHlQYXRjaEJ1dHRvbiA9IHJldmlld0RvYy5nZXRFbGVt ZW50QnlJZCgndmlld1ByZXR0eVBhdGNoQnV0dG9uJyk7DQp2YXIgYXdlc29tZUJ1dHRvbiA9IHJl dmlld0RvYy5jcmVhdGVFbGVtZW50KCdpbnB1dCcpOw0KYXdlc29tZUJ1dHRvbi50eXBlID0gJ2J1 dHRvbic7DQphd2Vzb21lQnV0dG9uLmlkID0gJ3JlaXR2ZWxkQnRuJzsNCmF3ZXNvbWVCdXR0b24u dmFsdWUgPSAnVmlldyBpbiBSZWl0dmVsZCc7DQphd2Vzb21lQnV0dG9uLm9uY2xpY2sgPSBuYXZU b1JlaXR2ZWxkOw0KcHJldHR5UGF0Y2hCdXR0b24ucGFyZW50Tm9kZS5hcHBlbmRDaGlsZChhd2Vz b21lQnV0dG9uKTsNCg0KZnVuY3Rpb24gbmF2VG9SZWl0dmVsZCgpIHsNCiAgLy8gVE9ETzogR2V0 IHJlYWwgVVJMIGhlcmUuDQogIGNvZGVWaWV3RnJhbWUubG9jYXRpb24gPSAnaHR0cDovL3drcmll dHZlbGQuYXBwc3BvdC5jb20vJzsNCn0NCg0KZnVuY3Rpb24gdXBkYXRlQ29tbWVudHMoKSB7DQog IC8vIEhvb2sgaW50byBzdWJtaXQgYWN0aW9uLCBnZXQgZGF0YSBmcm9tIHJlaXR2ZWxkLg0KICB2 YXIgY29tbWVudEZpZWxkID0gcmV2aWV3RG9jLmdldEVsZW1lbnRCeUlkKCdjb21tZW50Jyk7DQoJ dmFyIGNvbW1lbnRzID0gDQogIGNvbW1lbnRGaWVsZC52YWx1ZSA9IGNvbW1lbnRzOw0KfQ0KDQp9 LCAxMDAwKTs= 53473 2010-04-15 14:07:46 -0700 2010-04-15 14:10:13 -0700 Patch bug-37531-20100415140744.patch text/plain 701 ojan ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA4OTMzOTdhLi5jZWU0YzI2 IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAK KzIwMTAtMDQtMTUgIE9qYW4gVmFmYWkgIDxvamFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEdW1teSBidWcgZm9yIHRlc3Rp bmcgY29kZSByZXZpZXcgdG9vbC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTM3NTMxCisKKyAgICAgICAgKiBjb25maWd1cmUuYWM6CisKIDIwMTAtMDQt MDkgIFNpbW9uIEhhdXNtYW5uICA8c2ltb24uaGF1c21hbm5Abm9raWEuY29tPgogCiAgICAgICAg IFVucmV2aWV3ZWQgY3Jhc2ggZml4LgpkaWZmIC0tZ2l0IGEvY29uZmlndXJlLmFjIGIvY29uZmln dXJlLmFjCmluZGV4IDIyYmQ1NDUuLmE5YWMzMjEgMTAwNjQ0Ci0tLSBhL2NvbmZpZ3VyZS5hYwor KysgYi9jb25maWd1cmUuYWMKQEAgLTEsNSArMSw1IEBACiBBQ19QUkVSRVEoMi41OSkKLQorZHVt bXkgY2hhbmdlCiBtNF9kZWZpbmUoW3dlYmtpdF9tYWpvcl92ZXJzaW9uXSwgWzFdKQogbTRfZGVm aW5lKFt3ZWJraXRfbWlub3JfdmVyc2lvbl0sIFsxXSkKIG00X2RlZmluZShbd2Via2l0X21pY3Jv X3ZlcnNpb25dLCBbOTBdKQo= 53476 2010-04-15 14:10:16 -0700 2010-04-15 14:27:03 -0700 Patch bug-37531-20100415141015.patch text/plain 701 ojan ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA4OTMzOTdhLi5jZWU0YzI2 IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAK KzIwMTAtMDQtMTUgIE9qYW4gVmFmYWkgIDxvamFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEdW1teSBidWcgZm9yIHRlc3Rp bmcgY29kZSByZXZpZXcgdG9vbC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTM3NTMxCisKKyAgICAgICAgKiBjb25maWd1cmUuYWM6CisKIDIwMTAtMDQt MDkgIFNpbW9uIEhhdXNtYW5uICA8c2ltb24uaGF1c21hbm5Abm9raWEuY29tPgogCiAgICAgICAg IFVucmV2aWV3ZWQgY3Jhc2ggZml4LgpkaWZmIC0tZ2l0IGEvY29uZmlndXJlLmFjIGIvY29uZmln dXJlLmFjCmluZGV4IDIyYmQ1NDUuLmE5YWMzMjEgMTAwNjQ0Ci0tLSBhL2NvbmZpZ3VyZS5hYwor KysgYi9jb25maWd1cmUuYWMKQEAgLTEsNSArMSw1IEBACiBBQ19QUkVSRVEoMi41OSkKLQorZHVt bXkgY2hhbmdlCiBtNF9kZWZpbmUoW3dlYmtpdF9tYWpvcl92ZXJzaW9uXSwgWzFdKQogbTRfZGVm aW5lKFt3ZWJraXRfbWlub3JfdmVyc2lvbl0sIFsxXSkKIG00X2RlZmluZShbd2Via2l0X21pY3Jv X3ZlcnNpb25dLCBbOTBdKQo= 53478 2010-04-15 14:27:06 -0700 2010-04-16 16:25:23 -0700 Patch-4001 bug-37531-20100415142705.patch text/plain 2141 ojan ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCAwZDUxZjhlLi5lYjEwOTE3IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDQt MTUgIE9qYW4gVmFmYWkgIDxvamFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEdW1teSBidWcgZm9yIHRlc3RpbmcgY29kZSBy ZXZpZXcgdG9vbC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTM3NTMxCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc3RlcHMvcG9zdGNv ZGVyZXZpZXcucHk6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS90b29sL3N0ZXBzL3Bvc3Rk aWZmLnB5OgorCiAyMDEwLTA0LTEzICBPamFuIFZhZmFpICA8b2phbkBjaHJvbWl1bS5vcmc+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2aWQgTGV2aW4uCmRpZmYgLS1naXQgYS9XZWJLaXRUb29s cy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc3RlcHMvcG9zdGNvZGVyZXZpZXcucHkgYi9XZWJLaXRU b29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc3RlcHMvcG9zdGNvZGVyZXZpZXcucHkKaW5kZXgg NGRhNTI4NS4uM2U3ZWQ3NiAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRw eS90b29sL3N0ZXBzL3Bvc3Rjb2RlcmV2aWV3LnB5CisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMv d2Via2l0cHkvdG9vbC9zdGVwcy9wb3N0Y29kZXJldmlldy5weQpAQCAtNDMsOCArNDMsNiBAQCBj bGFzcyBQb3N0Q29kZVJldmlldyhBYnN0cmFjdFN0ZXApOgogICAgIGRlZiBydW4oc2VsZiwgc3Rh dGUpOgogICAgICAgICBpZiBub3Qgc2VsZi5fb3B0aW9ucy5mYW5jeV9yZXZpZXc6CiAgICAgICAg ICAgICByZXR1cm4KLSAgICAgICAgaWYgbm90IHNlbGYuX29wdGlvbnMucmV2aWV3OgotICAgICAg ICAgICAgcmV0dXJuCiAgICAgICAgICMgRklYTUU6IFRoaXMgd2lsbCBhbHdheXMgYmUgTm9uZSBi ZWNhdXNlIHdlIGRvbid0IHJldHJpZXZlIHRoZSBpc3N1ZQogICAgICAgICAjICAgICAgICBudW1i ZXIgZnJvbSB0aGUgQ2hhbmdlTG9nIHlldC4KICAgICAgICAgY29kZXJldmlld19pc3N1ZSA9IHN0 YXRlLmdldCgiY29kZXJldmlld19pc3N1ZSIpCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3Jp cHRzL3dlYmtpdHB5L3Rvb2wvc3RlcHMvcG9zdGRpZmYucHkgYi9XZWJLaXRUb29scy9TY3JpcHRz L3dlYmtpdHB5L3Rvb2wvc3RlcHMvcG9zdGRpZmYucHkKaW5kZXggNWIyODM4My4uNGZmZDIzYSAx MDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL3N0ZXBzL3Bvc3Rk aWZmLnB5CisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zdGVwcy9wb3N0 ZGlmZi5weQpAQCAtNDUsNyArNDUsMTMgQEAgY2xhc3MgUG9zdERpZmYoQWJzdHJhY3RTdGVwKToK ICAgICBkZWYgcnVuKHNlbGYsIHN0YXRlKToKICAgICAgICAgZGlmZiA9IHNlbGYuY2FjaGVkX2xv b2t1cChzdGF0ZSwgImRpZmYiKQogICAgICAgICBkaWZmX2ZpbGUgPSBTdHJpbmdJTy5TdHJpbmdJ TyhkaWZmKSAjIGFkZF9wYXRjaF90b19idWcgZXhwZWN0cyBhIGZpbGUtbGlrZSBvYmplY3QKKwog ICAgICAgICBkZXNjcmlwdGlvbiA9IHNlbGYuX29wdGlvbnMuZGVzY3JpcHRpb24gb3IgIlBhdGNo IgorICAgICAgICAjIEluY2x1ZGUgY29kZXJldmlldyBpc3N1ZSBudW1iZXIgaW4gcGF0Y2ggbmFt ZS4gVGhpcyBpcyBhIGJpdCBvZiBhIGhhY2ssCisgICAgICAgICMgYnV0IGl0IG1ha2VzIGRvaW5n IHRoZSByaWV0dmVsZCBpbnRlZ3JhdGlvbiBhIGxvdCBlYXNpZXIuCisgICAgICAgIGlmICJjb2Rl cmV2aWV3X2lzc3VlIiBpbiBzdGF0ZToKKyAgICAgICAgICBkZXNjcmlwdGlvbiArPSAiLSVzIiAl IHN0YXRlWyJjb2RlcmV2aWV3X2lzc3VlIl0KKwogICAgICAgICBjb21tZW50X3RleHQgPSBOb25l CiAgICAgICAgIGNvZGVyZXZpZXdfaXNzdWUgPSBzdGF0ZS5nZXQoImNvZGVyZXZpZXdfaXNzdWUi KQogICAgICAgICBpZiBjb2RlcmV2aWV3X2lzc3VlOgo= 53577 2010-04-16 16:25:26 -0700 2010-06-12 21:04:52 -0700 Patch-5001 bug-37531-20100416162525.patch text/plain 750 ojan ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA4OTMzOTdhLi4wOGQzMmM3 IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAK KzIwMTAtMDQtMTYgIE9qYW4gVmFmYWkgIDxvamFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEdW1teSBidWcgZm9yIHRlc3Rp bmcgY29kZSByZXZpZXcgdG9vbC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTM3NTMxCisKKyAgICAgICAgKiBNYWtlZmlsZToKKwogMjAxMC0wNC0wOSAg U2ltb24gSGF1c21hbm4gIDxzaW1vbi5oYXVzbWFubkBub2tpYS5jb20+CiAKICAgICAgICAgVW5y ZXZpZXdlZCBjcmFzaCBmaXguCmRpZmYgLS1naXQgYS9NYWtlZmlsZSBiL01ha2VmaWxlCmluZGV4 IDI0YTZmMGQuLmMxOTY1YTQgMTAwNjQ0Ci0tLSBhL01ha2VmaWxlCisrKyBiL01ha2VmaWxlCkBA IC0xLDUgKzEsNSBAQAogTU9EVUxFUyA9IEphdmFTY3JpcHRDb3JlIEphdmFTY3JpcHRHbHVlIFdl YkNvcmUgV2ViS2l0IFdlYktpdFRvb2xzCi0KK2FzZGZhc2RmYXNkZgogYWxsOgogCUBmb3IgZGly IGluICQoTU9EVUxFUyk7IGRvICR7TUFLRX0gJEAgLUMgJCRkaXI7IGV4aXRfc3RhdHVzPSQkPzsg XAogCWlmIFsgJCRleGl0X3N0YXR1cyAtbmUgMCBdOyB0aGVuIGV4aXQgJCRleGl0X3N0YXR1czsg Zmk7IGRvbmUK