37528 2010-04-13 16:04:55 -0700 Add check to make sure commit-queue can never commit too short a message 2010-04-13 16:55:29 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric webkit-unassigned abarth oldest_to_newest 212132 0 eric 2010-04-13 16:04:55 -0700 Add check to make sure commit-queue can never commit too short a message 212134 1 53294 eric 2010-04-13 16:06:57 -0700 Created attachment 53294 Patch 212135 2 eric 2010-04-13 16:08:02 -0700 I'll commit this w/o review, and Adam and tell me if I'm crazy later. 212140 3 eric 2010-04-13 16:15:59 -0700 OK, I was able to reproduce this while trying to commit this. Investigating. 212155 4 53299 eric 2010-04-13 16:49:24 -0700 Created attachment 53299 Patch 212158 5 eric 2010-04-13 16:55:29 -0700 Committed r57550: <http://trac.webkit.org/changeset/57550> 53294 2010-04-13 16:06:57 -0700 2010-04-13 16:49:18 -0700 Patch bug-37528-20100413160655.patch text/plain 1591 eric ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA1ZjU1ZjQ1Li5iMGY4ZjNjIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTAtMDQt MTMgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBjaGVjayB0byBtYWtlIHN1cmUgY29tbWl0 LXF1ZXVlIGNhbiBuZXZlciBjb21taXQgdG9vIHNob3J0IGEgbWVzc2FnZQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzc1MjgKKworICAgICAgICBUaGUg Y29tbWl0LXF1ZXVlIG1hZGUgYm9ndXMgbWVzc2FnZXMgaGVyZToKKyAgICAgICAgaHR0cDovL3Ry YWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvNTc1MzIKKyAgICAgICAgaHR0cDovL3RyYWMud2Via2l0 Lm9yZy9jaGFuZ2VzZXQvNTc1MzQKKyAgICAgICAgSSB3YXMgbm90IGFibGUgdG8gcmVwcm9kdWNl IHRoZSBidWcgbG9jYWxseSwgYnV0IEknbSBhZGRpbmcKKyAgICAgICAgYW4gImFzc2VydCIgdG8g bWFrZSBzdXJlIGl0IG5ldmVyIGhhcHBlbnMgYWdhaW4uCisKKyAgICAgICAgKiBTY3JpcHRzL3dl YmtpdHB5L3Rvb2wvc3RlcHMvY29tbWl0LnB5OgorCiAyMDEwLTA0LTEzICBDc2FiYSBPc3p0cm9n b27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCBidWlsZGZpeCBh ZnRlciByNTc1MzcuCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rv b2wvc3RlcHMvY29tbWl0LnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL3N0 ZXBzL2NvbW1pdC5weQppbmRleCBiZDVjOTk4Li40YmFmN2ZhIDEwMDY0NAotLS0gYS9XZWJLaXRU b29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc3RlcHMvY29tbWl0LnB5CisrKyBiL1dlYktpdFRv b2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zdGVwcy9jb21taXQucHkKQEAgLTMyLDQgKzMyLDYg QEAgZnJvbSB3ZWJraXRweS50b29sLnN0ZXBzLmFic3RyYWN0c3RlcCBpbXBvcnQgQWJzdHJhY3RT dGVwCiBjbGFzcyBDb21taXQoQWJzdHJhY3RTdGVwKToKICAgICBkZWYgcnVuKHNlbGYsIHN0YXRl KToKICAgICAgICAgY29tbWl0X21lc3NhZ2UgPSBzZWxmLl90b29sLmNoZWNrb3V0KCkuY29tbWl0 X21lc3NhZ2VfZm9yX3RoaXNfY29tbWl0KCkKKyAgICAgICAgaWYgbGVuKGNvbW1pdF9tZXNzYWdl KSA8IDUwOgorICAgICAgICAgICAgcmFpc2UgRXhjZXB0aW9uKCJBdHRlbXB0ZWQgdG8gY29tbWl0 IHdpdGggYSBjb21taXQgbWVzc2FnZSBzaG9ydGVyIHRoYW4gNTAgY2hhcmFjdGVycy4gIEVpdGhl ciB5b3VyIHBhdGNoIGlzIG1pc3NpbmcgYSBDaGFuZ2VMb2cgb3Igd2Via2l0LXBhdGNoIG1heSBo YXZlIGEgYnVnLiIpCiAgICAgICAgIHN0YXRlWyJjb21taXRfdGV4dCJdID0gIHNlbGYuX3Rvb2wu c2NtKCkuY29tbWl0X3dpdGhfbWVzc2FnZShjb21taXRfbWVzc2FnZS5tZXNzYWdlKCkpCg== 53299 2010-04-13 16:49:24 -0700 2010-04-13 16:49:24 -0700 Patch bug-37528-20100413164922.patch text/plain 2782 eric ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA1ZjU1ZjQ1Li45MzExNDYwIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIwMTAtMDQt MTMgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFVucmV2aWV3ZWQs IGp1c3QgYWRkaW5nIGEgc2FuaXR5IGNoZWNrLgorCisgICAgICAgIEFkZCBjaGVjayB0byBtYWtl IHN1cmUgY29tbWl0LXF1ZXVlIGNhbiBuZXZlciBjb21taXQgdG9vIHNob3J0IGEgbWVzc2FnZQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzc1MjgKKwor ICAgICAgICBUaGUgY29tbWl0LXF1ZXVlIG1hZGUgYm9ndXMgbWVzc2FnZXMgaGVyZToKKyAgICAg ICAgaHR0cDovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvNTc1MzIKKyAgICAgICAgaHR0cDov L3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvNTc1MzQKKworICAgICAgICBUaGlzIHdhcyBhIHJl Z3Jlc3Npb24gY2F1c2VkIGJ5IGFkZGluZyB1bmljb2RlIHBhcnNpbmcgZm9yCisgICAgICAgIG91 ciBDaGFuZ2VMb2cgZmlsZXMuICBQb3BlbiBkb2VzIG5vdCBzZWVtIHRvIHBsYXkgbmljZSB3aXRo CisgICAgICAgIHVuaWNvZGUgc3RyaW5ncy4KKworICAgICAgICBJJ20gYWxzbyBhZGRpbmcgYW4g ImFzc2VydCIgdG8gbWFrZSBzdXJlIHNob3J0IENoYW5nZUxvZ3MgbmV2ZXIgaGFwcGVuIGFnYWlu LgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL2V4ZWN1dGl2ZS5w eToKKyAgICAgICAgIC0gQ2FzdCBpbnB1dCB0byBzdHJpbmdzIGJlZm9yZSBwYXNzaW5nIHRvIFBP cGVuCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS90b29sL3N0ZXBzL2NvbW1pdC5weToKKyAg ICAgICAgIC0gVmFsaWRhdGUgdGhhdCBjb21taXQgbWVzc2FnZXMgYXJlIG5vdCB0byBzaG9ydC4K KwogMjAxMC0wNC0xMyAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQub3JnPgogCiAg ICAgICAgIFVucmV2aWV3ZWQgYnVpbGRmaXggYWZ0ZXIgcjU3NTM3LgpkaWZmIC0tZ2l0IGEvV2Vi S2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL2V4ZWN1dGl2ZS5weSBiL1dl YktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS9leGVjdXRpdmUucHkKaW5k ZXggNGFhNmRiYy4uYjYxMjZlNCAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJr aXRweS9jb21tb24vc3lzdGVtL2V4ZWN1dGl2ZS5weQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRz L3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vZXhlY3V0aXZlLnB5CkBAIC0xNzksNyArMTc5LDExIEBA IGNsYXNzIEV4ZWN1dGl2ZShvYmplY3QpOgogICAgICAgICAgICAgc3RkaW4gPSBOb25lCiAgICAg ICAgICAgICBpZiBpbnB1dDoKICAgICAgICAgICAgICAgICBzdGRpbiA9IHN1YnByb2Nlc3MuUElQ RQotICAgICAgICAgICAgc3RyaW5nX3RvX2NvbW11bmljYXRlID0gaW5wdXQKKyAgICAgICAgICAg ICMgc3RyaW5nX3RvX2NvbW11bmljYXRlIHNlZW1zIHRvIG5lZWQgdG8gYmUgYSBzdHIgZm9yIHBy b3BlcgorICAgICAgICAgICAgIyBjb21tdW5pY2F0aW9uIHdpdGggc2hlbGwgY29tbWFuZHMuCisg ICAgICAgICAgICAjIFNlZSBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 Mzc1MjgKKyAgICAgICAgICAgICMgRm9yIGFuIGV4YW1wbGUgb2YgYSByZWdyZXNpb24gY2F1c2Vk IGJ5IHBhc3NpbmcgYSB1bmljb2RlIHN0cmluZyB0aHJvdWdoLgorICAgICAgICAgICAgc3RyaW5n X3RvX2NvbW11bmljYXRlID0gc3RyKGlucHV0KQogICAgICAgICBpZiByZXR1cm5fc3RkZXJyOgog ICAgICAgICAgICAgc3RkZXJyID0gc3VicHJvY2Vzcy5TVERPVVQKICAgICAgICAgZWxzZToKZGlm ZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zdGVwcy9jb21taXQu cHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc3RlcHMvY29tbWl0LnB5Cmlu ZGV4IGJkNWM5OTguLjI5NGI0MWUgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvdG9vbC9zdGVwcy9jb21taXQucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJr aXRweS90b29sL3N0ZXBzL2NvbW1pdC5weQpAQCAtMzIsNCArMzIsNiBAQCBmcm9tIHdlYmtpdHB5 LnRvb2wuc3RlcHMuYWJzdHJhY3RzdGVwIGltcG9ydCBBYnN0cmFjdFN0ZXAKIGNsYXNzIENvbW1p dChBYnN0cmFjdFN0ZXApOgogICAgIGRlZiBydW4oc2VsZiwgc3RhdGUpOgogICAgICAgICBjb21t aXRfbWVzc2FnZSA9IHNlbGYuX3Rvb2wuY2hlY2tvdXQoKS5jb21taXRfbWVzc2FnZV9mb3JfdGhp c19jb21taXQoKQorICAgICAgICBpZiBsZW4oY29tbWl0X21lc3NhZ2UubWVzc2FnZSgpKSA8IDUw OgorICAgICAgICAgICAgcmFpc2UgRXhjZXB0aW9uKCJBdHRlbXB0ZWQgdG8gY29tbWl0IHdpdGgg YSBjb21taXQgbWVzc2FnZSBzaG9ydGVyIHRoYW4gNTAgY2hhcmFjdGVycy4gIEVpdGhlciB5b3Vy IHBhdGNoIGlzIG1pc3NpbmcgYSBDaGFuZ2VMb2cgb3Igd2Via2l0LXBhdGNoIG1heSBoYXZlIGEg YnVnLiIpCiAgICAgICAgIHN0YXRlWyJjb21taXRfdGV4dCJdID0gIHNlbGYuX3Rvb2wuc2NtKCku Y29tbWl0X3dpdGhfbWVzc2FnZShjb21taXRfbWVzc2FnZS5tZXNzYWdlKCkpCg==