37525 2010-04-13 15:15:42 -0700 Make failure-reason more forgiving 2010-04-18 23:36:58 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric eric aroben oldest_to_newest 212107 0 eric 2010-04-13 15:15:42 -0700 Make failure-reason more forgiving 212111 1 53286 eric 2010-04-13 15:20:30 -0700 Created attachment 53286 Patch 212216 2 53286 aroben 2010-04-13 21:51:45 -0700 Comment on attachment 53286 Patch > + # FIXME: This could be made more user friendly. > + print "Failed to load layout test results start revision r%s, can't continue." % start_revision I think this would be a little clearer like this: "Failed to load layout test results; can't continue. (start revision = r%s)" > @@ -237,8 +243,10 @@ class FailureReason(AbstractDeclarativeCommand): > results_to_explain -= fixed_results > if results_to_explain: > print "Failed to explain failures: %s" % results_to_explain > + return 1 > else: > print "Explained all results for %s" % builder.name() > + return 0 Our C++ style is not to use "else" after "return". r=me 212218 3 53286 eric 2010-04-13 21:57:14 -0700 Comment on attachment 53286 Patch Oooh, good suggestions. Will do. 213857 4 eric 2010-04-18 16:29:43 -0700 Attachment 53286 was posted by a committer and has review+, assigning to Eric Seidel for commit. 213921 5 eric 2010-04-18 23:36:58 -0700 Committed r57805: <http://trac.webkit.org/changeset/57805> 53286 2010-04-13 15:20:30 -0700 2010-04-13 21:57:14 -0700 Patch bug-37525-20100413152028.patch text/plain 4623 eric ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCAzNzY3ZTllLi4wM2I5ZGIwIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTAtMDQt MTMgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1ha2UgZmFpbHVyZS1yZWFzb24gbW9yZSBmb3Jn aXZpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM3 NTI1CisKKyAgICAgICAgUmVtb3ZlZCBzZWFyY2hfbGltaXQsIHdoaWNoIHdhc24ndCB2ZXJ5IHVz ZWZ1bCBhbnl3YXkuCisgICAgICAgIEFkZGVkIGEgbG9nIGFib3V0IHRoZSBsb25nIGxvYWQgdGlt ZSBsb2FkaW5nIGZyb20gdGhlIGJ1aWxkZXJzLgorICAgICAgICBQcm9tcHQgdGhlIHVzZXIgZm9y IHdoYXQgcmV2aXNpb24gdG8gc3RhcnQgd2Fsa2luZyBmcm9tIChtYWtlcyBpdCBlYXN5IHRvIHJl c3RhcnQgdXBvbiBmYWlsdXJlKS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbW9u L25ldC9idWlsZGJvdC5weToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFu ZHMvcXVlcmllcy5weToKKwogMjAxMC0wNC0xMyAgQWRhbSBSb2JlbiAgPGFyb2JlbkBhcHBsZS5j b20+CiAKICAgICAgICAgRml4IHJ1bi13ZWJraXQtdGVzdHMgb24gV2luZG93cyB3aXRoIHNwYWNl cyBpbiB0aGUgcGF0aApkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9j b21tb24vbmV0L2J1aWxkYm90LnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21t b24vbmV0L2J1aWxkYm90LnB5CmluZGV4IDI5MjRiMTQuLmQyNzMxMmIgMTAwNjQ0Ci0tLSBhL1dl YktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL25ldC9idWlsZGJvdC5weQorKysgYi9X ZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9uZXQvYnVpbGRib3QucHkKQEAgLTEx MCw2ICsxMTAsOCBAQCBjbGFzcyBCdWlsZGVyKG9iamVjdCk6CiAgICAgICAgICAgICAjIEZJWE1F OiBUaGlzIG1ldGhvZCBpcyBob3JyaWJseSBzbG93IGR1ZSB0byB0aGUgaHVnZSBuZXR3b3JrIGxv YWQuCiAgICAgICAgICAgICAjIEZJWE1FOiBUaGlzIGlzIGEgcG9vciB3YXkgdG8gZG8gcmV2aXNp b24gLT4gYnVpbGQgbWFwcGluZy4KICAgICAgICAgICAgICMgQmV0dGVyIHdvdWxkIGJlIHRvIGFz ayBidWlsZGJvdCB0aHJvdWdoIHNvbWUgc29ydCBvZiBBUEkuCisgICAgICAgICAgICBwcmludCAi TG9hZGluZyByZXZpc2lvbi9idWlsZCBsaXN0IGZyb20gJXMuIiAlIHNlbGYucmVzdWx0c191cmwo KQorICAgICAgICAgICAgcHJpbnQgIlRoaXMgbWF5IHRha2UgYSB3aGlsZS4uLiIKICAgICAgICAg ICAgIHJlc3VsdF9maWxlcyA9IHNlbGYuX2J1aWxkYm90Ll9mZXRjaF90d2lzdGVkX2RpcmVjdG9y eV9saXN0aW5nKHNlbGYucmVzdWx0c191cmwoKSkKICAgICAgICAgZXhjZXB0IHVybGxpYjIuSFRU UEVycm9yLCBlcnJvcjoKICAgICAgICAgICAgIGlmIGVycm9yLmNvZGUgIT0gNDA0OgpkaWZmIC0t Z2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL3F1ZXJpZXMu cHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvcXVlcmllcy5w eQppbmRleCBhYmVmNDZkLi42Nzg2NDNjIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRz L3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvcXVlcmllcy5weQorKysgYi9XZWJLaXRUb29scy9TY3Jp cHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvcXVlcmllcy5weQpAQCAtMjAzLDE0ICsyMDMsMjAg QEAgY2xhc3MgRmFpbHVyZVJlYXNvbihBYnN0cmFjdERlY2xhcmF0aXZlQ29tbWFuZCk6CiAgICAg ICAgICAgICBjb21taXRfaW5mbyA9IHNlbGYudG9vbC5jaGVja291dCgpLmNvbW1pdF9pbmZvX2Zv cl9yZXZpc2lvbihyZXZpc2lvbikKICAgICAgICAgICAgIHByaW50IGNvbW1pdF9pbmZvLmJsYW1l X3N0cmluZyhzZWxmLnRvb2wuYnVncykKIAotICAgIGRlZiBfZXhwbGFpbl9mYWlsdXJlc19mb3Jf YnVpbGRlcihzZWxmLCBidWlsZGVyLCBzdGFydF9yZXZpc2lvbiwgc2VhcmNoX2xpbWl0PTEwMDAp OgorICAgIGRlZiBfZXhwbGFpbl9mYWlsdXJlc19mb3JfYnVpbGRlcihzZWxmLCBidWlsZGVyLCBz dGFydF9yZXZpc2lvbik6CiAgICAgICAgIHByaW50ICJFeGFtaW5pbmcgZmFpbHVyZXMgZm9yIFwi JXNcIiwgc3RhcnRpbmcgYXQgciVzIiAlIChidWlsZGVyLm5hbWUoKSwgc3RhcnRfcmV2aXNpb24p CiAgICAgICAgIHJldmlzaW9uX3RvX3Rlc3QgPSBzdGFydF9yZXZpc2lvbgogICAgICAgICBidWls ZCA9IGJ1aWxkZXIuYnVpbGRfZm9yX3JldmlzaW9uKHJldmlzaW9uX3RvX3Rlc3QsIGFsbG93X2Zh aWxlZF9sb29rdXBzPVRydWUpCi0gICAgICAgIHJlc3VsdHNfdG9fZXhwbGFpbiA9IHNldChidWls ZC5sYXlvdXRfdGVzdF9yZXN1bHRzKCkuZmFpbGluZ190ZXN0cygpKQorICAgICAgICBsYXlvdXRf dGVzdF9yZXN1bHRzID0gYnVpbGQubGF5b3V0X3Rlc3RfcmVzdWx0cygpCisgICAgICAgIGlmIG5v dCBsYXlvdXRfdGVzdF9yZXN1bHRzOgorICAgICAgICAgICAgIyBGSVhNRTogVGhpcyBjb3VsZCBi ZSBtYWRlIG1vcmUgdXNlciBmcmllbmRseS4KKyAgICAgICAgICAgIHByaW50ICJGYWlsZWQgdG8g bG9hZCBsYXlvdXQgdGVzdCByZXN1bHRzIHN0YXJ0IHJldmlzaW9uIHIlcywgY2FuJ3QgY29udGlu dWUuIiAlIHN0YXJ0X3JldmlzaW9uCisgICAgICAgICAgICByZXR1cm4gMQorCisgICAgICAgIHJl c3VsdHNfdG9fZXhwbGFpbiA9IHNldChsYXlvdXRfdGVzdF9yZXN1bHRzLmZhaWxpbmdfdGVzdHMo KSkKICAgICAgICAgbGFzdF9idWlsZF93aXRoX3Jlc3VsdHMgPSBidWlsZAogICAgICAgICBwcmlu dCAiU3RhcnRpbmcgYXQgJXMiICUgcmV2aXNpb25fdG9fdGVzdAotICAgICAgICB3aGlsZSByZXN1 bHRzX3RvX2V4cGxhaW4gYW5kIHJldmlzaW9uX3RvX3Rlc3QgPiBzdGFydF9yZXZpc2lvbiAtIHNl YXJjaF9saW1pdDoKKyAgICAgICAgd2hpbGUgcmVzdWx0c190b19leHBsYWluOgogICAgICAgICAg ICAgcmV2aXNpb25fdG9fdGVzdCAtPSAxCiAgICAgICAgICAgICBuZXdfYnVpbGQgPSBidWlsZGVy LmJ1aWxkX2Zvcl9yZXZpc2lvbihyZXZpc2lvbl90b190ZXN0LCBhbGxvd19mYWlsZWRfbG9va3Vw cz1UcnVlKQogICAgICAgICAgICAgaWYgbm90IG5ld19idWlsZDoKQEAgLTIzNyw4ICsyNDMsMTAg QEAgY2xhc3MgRmFpbHVyZVJlYXNvbihBYnN0cmFjdERlY2xhcmF0aXZlQ29tbWFuZCk6CiAgICAg ICAgICAgICByZXN1bHRzX3RvX2V4cGxhaW4gLT0gZml4ZWRfcmVzdWx0cwogICAgICAgICBpZiBy ZXN1bHRzX3RvX2V4cGxhaW46CiAgICAgICAgICAgICBwcmludCAiRmFpbGVkIHRvIGV4cGxhaW4g ZmFpbHVyZXM6ICVzIiAlIHJlc3VsdHNfdG9fZXhwbGFpbgorICAgICAgICAgICAgcmV0dXJuIDEK ICAgICAgICAgZWxzZToKICAgICAgICAgICAgIHByaW50ICJFeHBsYWluZWQgYWxsIHJlc3VsdHMg Zm9yICVzIiAlIGJ1aWxkZXIubmFtZSgpCisgICAgICAgICAgICByZXR1cm4gMAogCiAgICAgZGVm IF9idWlsZGVyX3RvX2V4cGxhaW4oc2VsZik6CiAgICAgICAgIGJ1aWxkZXJfc3RhdHVzZXMgPSBz ZWxmLnRvb2wuYnVpbGRib3QuYnVpbGRlcl9zdGF0dXNlcygpCkBAIC0yNTMsOCArMjYxLDEyIEBA IGNsYXNzIEZhaWx1cmVSZWFzb24oQWJzdHJhY3REZWNsYXJhdGl2ZUNvbW1hbmQpOgogICAgICAg ICAgICAgICAgIHJldHVybiAoc2VsZi50b29sLmJ1aWxkYm90LmJ1aWxkZXJfd2l0aF9uYW1lKGNo b3Nlbl9uYW1lKSwgc3RhdHVzWyJidWlsdF9yZXZpc2lvbiJdKQogCiAgICAgZGVmIGV4ZWN1dGUo c2VsZiwgb3B0aW9ucywgYXJncywgdG9vbCk6Ci0gICAgICAgIChidWlsZGVyLCBzdGFydF9yZXZp c2lvbikgPSBzZWxmLl9idWlsZGVyX3RvX2V4cGxhaW4oKQotICAgICAgICBzZWxmLl9leHBsYWlu X2ZhaWx1cmVzX2Zvcl9idWlsZGVyKGJ1aWxkZXIsIHN0YXJ0X3JldmlzaW9uPXN0YXJ0X3Jldmlz aW9uKQorICAgICAgICAoYnVpbGRlciwgbGF0ZXN0X3JldmlzaW9uKSA9IHNlbGYuX2J1aWxkZXJf dG9fZXhwbGFpbigpCisgICAgICAgIHN0YXJ0X3JldmlzaW9uID0gc2VsZi50b29sLnVzZXIucHJv bXB0KCJSZXZpc2lvbiB0byB3YWxrIGJhY2t3YXJkcyBmcm9tPyBbJXNdICIgJSBsYXRlc3RfcmV2 aXNpb24pIG9yIGxhdGVzdF9yZXZpc2lvbgorICAgICAgICBpZiBub3Qgc3RhcnRfcmV2aXNpb246 CisgICAgICAgICAgICBwcmludCAiUmV2aXNpb24gcmVxdWlyZWQuIgorICAgICAgICAgICAgcmV0 dXJuIDEKKyAgICAgICAgcmV0dXJuIHNlbGYuX2V4cGxhaW5fZmFpbHVyZXNfZm9yX2J1aWxkZXIo YnVpbGRlciwgc3RhcnRfcmV2aXNpb249aW50KHN0YXJ0X3JldmlzaW9uKSkKIAogY2xhc3MgVHJl ZVN0YXR1cyhBYnN0cmFjdERlY2xhcmF0aXZlQ29tbWFuZCk6CiAgICAgbmFtZSA9ICJ0cmVlLXN0 YXR1cyIK