37519 2010-04-13 13:57:04 -0700 Teach webkit-patch how to handle revisions missing ChangeLogs 2010-04-14 02:01:12 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric webkit-unassigned abarth aroben commit-queue oldest_to_newest 212067 0 eric 2010-04-13 13:57:04 -0700 Teach webkit-patch how to handle revisions missing ChangeLogs 212069 1 53276 eric 2010-04-13 14:00:17 -0700 Created attachment 53276 Patch 212070 2 eric 2010-04-13 14:01:34 -0700 This fixes the exception Adam Roben hit when trying to run failure-reason yesterday. 212085 3 53276 abarth 2010-04-13 14:37:57 -0700 Comment on attachment 53276 Patch good point. 212093 4 eric 2010-04-13 14:47:36 -0700 I don't really like this current handling, especially due to the copy/paste logging code. But I'm not sure CommitInfo even makes sense w/o ChangeLogs. :) 212298 5 53276 commit-queue 2010-04-14 02:01:07 -0700 Comment on attachment 53276 Patch Clearing flags on attachment: 53276 Committed r57572: <http://trac.webkit.org/changeset/57572> 212299 6 commit-queue 2010-04-14 02:01:12 -0700 All reviewed patches have been landed. Closing bug. 53276 2010-04-13 14:00:17 -0700 2010-04-14 02:01:06 -0700 Patch bug-37519-20100413140015.patch text/plain 5863 eric ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCAzNzY3ZTllLi42ZjhlY2Q4IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTAtMDQt MTMgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRlYWNoIHdlYmtpdC1wYXRjaCBob3cgdG8gaGFu ZGxlIHJldmlzaW9ucyBtaXNzaW5nIENoYW5nZUxvZ3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM3NTE5CisKKyAgICAgICAgTWFrZSBjb21taXRfaW5m b19mb3JfcmV2aXNpb24gcmV0dXJuIE5vbmUgd2hlbiByZXZpc2lvbgorICAgICAgICBpcyBtaXNz aW5nIGEgQ2hhbmdlTG9nLiAgUHJldmlvdXNseSB3ZSB3b3VsZCB0aHJvdyBhbiBhcnJheSBpbmRl eAorICAgICAgICBleGNlcHRpb24uCisgICAgICAgIFRlYWNoIGNhbGxlcnMgaG93IHRvIGhhbmRs ZSBOb25lLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tvdXQvYXBp LnB5OgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NoZWNrb3V0L2FwaV91bml0 dGVzdC5weToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvZG93bmxv YWQucHk6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL3F1ZXJpZXMu cHk6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL3NoZXJpZmZib3Qu cHk6CisKIDIwMTAtMDQtMTMgIEFkYW0gUm9iZW4gIDxhcm9iZW5AYXBwbGUuY29tPgogCiAgICAg ICAgIEZpeCBydW4td2Via2l0LXRlc3RzIG9uIFdpbmRvd3Mgd2l0aCBzcGFjZXMgaW4gdGhlIHBh dGgKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NoZWNr b3V0L2FwaS5weSBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NoZWNrb3V0 L2FwaS5weQppbmRleCA1NzQxOGRjLi5jNGUyYjY5IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9T Y3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jaGVja291dC9hcGkucHkKKysrIGIvV2ViS2l0VG9vbHMv U2NyaXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tvdXQvYXBpLnB5CkBAIC02MSw2ICs2MSw4IEBA IGNsYXNzIENoZWNrb3V0KG9iamVjdCk6CiAgICAgICAgIGNoYW5nZWxvZ19lbnRyaWVzID0gc2Vs Zi5jaGFuZ2Vsb2dfZW50cmllc19mb3JfcmV2aXNpb24ocmV2aXNpb24pCiAgICAgICAgICMgQXNz dW1lIGZvciBub3cgdGhhdCB0aGUgZmlyc3QgZW50cnkgaGFzIGV2ZXJ5dGhpbmcgd2UgbmVlZDoK ICAgICAgICAgIyBGSVhNRTogVGhpcyB3aWxsIHRocm93IGFuIGV4Y2VwdGlvbiBpZiB0aGVyZSB3 ZXJlIG5vIENoYW5nZUxvZ3MuCisgICAgICAgIGlmIG5vdCBsZW4oY2hhbmdlbG9nX2VudHJpZXMp OgorICAgICAgICAgICAgcmV0dXJuIE5vbmUKICAgICAgICAgY2hhbmdlbG9nX2VudHJ5ID0gY2hh bmdlbG9nX2VudHJpZXNbMF0KICAgICAgICAgY2hhbmdlbG9nX2RhdGEgPSB7CiAgICAgICAgICAg ICAiYnVnX2lkIjogcGFyc2VfYnVnX2lkKGNoYW5nZWxvZ19lbnRyeS5jb250ZW50cygpKSwKZGlm ZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NoZWNrb3V0L2Fw aV91bml0dGVzdC5weSBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NoZWNr b3V0L2FwaV91bml0dGVzdC5weQppbmRleCAzNTZiNjg4Li5lOTljYWVlIDEwMDY0NAotLS0gYS9X ZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jaGVja291dC9hcGlfdW5pdHRlc3Qu cHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tvdXQvYXBp X3VuaXR0ZXN0LnB5CkBAIC0xNDQsNiArMTQ0LDkgQEAgY2xhc3MgQ2hlY2tvdXRUZXN0KHVuaXR0 ZXN0LlRlc3RDYXNlKToKICAgICAgICAgc2VsZi5hc3NlcnRFcXVhbChjb21taXRpbmZvLmNvbW1p dHRlcl9lbWFpbCgpLCAiY29tbWl0dGVyQGV4YW1wbGUuY29tIikKICAgICAgICAgc2VsZi5hc3Nl cnRFcXVhbChjb21taXRpbmZvLmNvbW1pdHRlcigpLCBOb25lKQogCisgICAgICAgIGNoZWNrb3V0 LmNoYW5nZWxvZ19lbnRyaWVzX2Zvcl9yZXZpc2lvbiA9IGxhbWJkYSByZXZpc2lvbjogW10KKyAg ICAgICAgc2VsZi5hc3NlcnRFcXVhbChjaGVja291dC5jb21taXRfaW5mb19mb3JfcmV2aXNpb24o MSksIE5vbmUpCisKICAgICBkZWYgdGVzdF9idWdfaWRfZm9yX3JldmlzaW9uKHNlbGYpOgogICAg ICAgICBzY20gPSBNb2NrKCkKICAgICAgICAgc2NtLmNvbW1pdHRlcl9lbWFpbF9mb3JfcmV2aXNp b24gPSBsYW1iZGEgcmV2aXNpb246ICJjb21taXR0ZXJAZXhhbXBsZS5jb20iCmRpZmYgLS1naXQg YS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvZG93bmxvYWQucHkg Yi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvZG93bmxvYWQucHkK aW5kZXggM2FjYzY2Ni4uZDk2MGJiZSAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93 ZWJraXRweS90b29sL2NvbW1hbmRzL2Rvd25sb2FkLnB5CisrKyBiL1dlYktpdFRvb2xzL1Njcmlw dHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9kb3dubG9hZC5weQpAQCAtMjU0LDcgKzI1NCw3IEBA IGNsYXNzIEFic3RyYWN0Um9sbG91dFByZXBDb21tYW5kKEFic3RyYWN0U2VxdWVuY2VkQ29tbWFu ZCk6CiAKICAgICBkZWYgX2NvbW1pdF9pbmZvKHNlbGYsIHJldmlzaW9uKToKICAgICAgICAgY29t bWl0X2luZm8gPSBzZWxmLnRvb2wuY2hlY2tvdXQoKS5jb21taXRfaW5mb19mb3JfcmV2aXNpb24o cmV2aXNpb24pCi0gICAgICAgIGlmIGNvbW1pdF9pbmZvLmJ1Z19pZCgpOgorICAgICAgICBpZiBj b21taXRfaW5mbyBhbmQgY29tbWl0X2luZm8uYnVnX2lkKCk6CiAgICAgICAgICAgICAjIE5vdGU6 IERvbid0IHByaW50IGEgYnVnIFVSTCBoZXJlIGJlY2F1c2UgaXQgd2lsbCBjb25mdXNlIHRoZQog ICAgICAgICAgICAgIyAgICAgICBTaGVyaWZmQm90IGJlY2F1c2UgdGhlIFNoZXJpZmZCb3QganVz dCBncmVwcyB0aGUgb3V0cHV0CiAgICAgICAgICAgICAjICAgICAgIG9mIGNyZWF0ZS1yb2xsb3V0 IGZvciBidWcgVVJMcy4gIEl0IHNob3VsZCBkbyBiZXR0ZXIKZGlmZiAtLWdpdCBhL1dlYktpdFRv b2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9xdWVyaWVzLnB5IGIvV2ViS2l0VG9v bHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL3F1ZXJpZXMucHkKaW5kZXggYWJlZjQ2 ZC4uNTI3MzFlOSAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29s L2NvbW1hbmRzL3F1ZXJpZXMucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS90 b29sL2NvbW1hbmRzL3F1ZXJpZXMucHkKQEAgLTE0Miw3ICsxNDIsMTAgQEAgY2xhc3MgV2hhdEJy b2tlKEFic3RyYWN0RGVjbGFyYXRpdmVDb21tYW5kKToKICAgICAgICAgc2VsZi5fcHJpbnRfYnVp bGRlcl9saW5lKGJ1aWxkZXIubmFtZSgpLCBuYW1lX3dpZHRoLCAiRkFJTCAoYmxhbWUtbGlzdDog JXMlcykiICUgKHN1c3BlY3RfcmV2aXNpb25zLCBmaXJzdF9mYWlsdXJlX21lc3NhZ2UpKQogICAg ICAgICBmb3IgcmV2aXNpb24gaW4gc3VzcGVjdF9yZXZpc2lvbnM6CiAgICAgICAgICAgICBjb21t aXRfaW5mbyA9IHNlbGYudG9vbC5jaGVja291dCgpLmNvbW1pdF9pbmZvX2Zvcl9yZXZpc2lvbihy ZXZpc2lvbikKLSAgICAgICAgICAgIHByaW50IGNvbW1pdF9pbmZvLmJsYW1lX3N0cmluZyhzZWxm LnRvb2wuYnVncykKKyAgICAgICAgICAgIGlmIGNvbW1pdF9pbmZvOgorICAgICAgICAgICAgICAg IHByaW50IGNvbW1pdF9pbmZvLmJsYW1lX3N0cmluZyhzZWxmLnRvb2wuYnVncykKKyAgICAgICAg ICAgIGVsc2U6CisgICAgICAgICAgICAgICAgcHJpbnQgIkZBSUxFRCB0byBmZXRjaCBDb21taXRJ bmZvIGZvciByJXMsIGxpa2VseSBtaXNzaW5nIENoYW5nZUxvZyIgJSByZXZpc2lvbgogCiAgICAg ZGVmIGV4ZWN1dGUoc2VsZiwgb3B0aW9ucywgYXJncywgdG9vbCk6CiAgICAgICAgIGJ1aWxkZXJf c3RhdHVzZXMgPSB0b29sLmJ1aWxkYm90LmJ1aWxkZXJfc3RhdHVzZXMoKQpAQCAtMjAxLDcgKzIw NCwxMCBAQCBjbGFzcyBGYWlsdXJlUmVhc29uKEFic3RyYWN0RGVjbGFyYXRpdmVDb21tYW5kKToK ICAgICAgICAgcHJpbnQgIlN1c3BlY3QgcmV2aXNpb25zOiIKICAgICAgICAgZm9yIHJldmlzaW9u IGluIHN1c3BlY3RfcmV2aXNpb25zOgogICAgICAgICAgICAgY29tbWl0X2luZm8gPSBzZWxmLnRv b2wuY2hlY2tvdXQoKS5jb21taXRfaW5mb19mb3JfcmV2aXNpb24ocmV2aXNpb24pCi0gICAgICAg ICAgICBwcmludCBjb21taXRfaW5mby5ibGFtZV9zdHJpbmcoc2VsZi50b29sLmJ1Z3MpCisgICAg ICAgICAgICBpZiBjb21taXRfaW5mbzoKKyAgICAgICAgICAgICAgICBwcmludCBjb21taXRfaW5m by5ibGFtZV9zdHJpbmcoc2VsZi50b29sLmJ1Z3MpCisgICAgICAgICAgICBlbHNlOgorICAgICAg ICAgICAgICAgIHByaW50ICJGQUlMRUQgdG8gZmV0Y2ggQ29tbWl0SW5mbyBmb3IgciVzLCBsaWtl bHkgbWlzc2luZyBDaGFuZ2VMb2ciICUgcmV2aXNpb24KIAogICAgIGRlZiBfZXhwbGFpbl9mYWls dXJlc19mb3JfYnVpbGRlcihzZWxmLCBidWlsZGVyLCBzdGFydF9yZXZpc2lvbiwgc2VhcmNoX2xp bWl0PTEwMDApOgogICAgICAgICBwcmludCAiRXhhbWluaW5nIGZhaWx1cmVzIGZvciBcIiVzXCIs IHN0YXJ0aW5nIGF0IHIlcyIgJSAoYnVpbGRlci5uYW1lKCksIHN0YXJ0X3JldmlzaW9uKQpkaWZm IC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL3NoZXJp ZmZib3QucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvc2hl cmlmZmJvdC5weQppbmRleCBlNTU5ZTMwLi5lYjgwZDhmIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvc2hlcmlmZmJvdC5weQorKysgYi9XZWJL aXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvc2hlcmlmZmJvdC5weQpAQCAt ODAsNiArODAsOSBAQCBjbGFzcyBTaGVyaWZmQm90KEFic3RyYWN0UXVldWUsIFN0ZXBTZXF1ZW5j ZUVycm9ySGFuZGxlcik6CiAgICAgICAgIGZvciBzdm5fcmV2aXNpb24sIGJ1aWxkZXJzIGluIG5l d19mYWlsdXJlcy5pdGVtcygpOgogICAgICAgICAgICAgdHJ5OgogICAgICAgICAgICAgICAgIGNv bW1pdF9pbmZvID0gc2VsZi50b29sLmNoZWNrb3V0KCkuY29tbWl0X2luZm9fZm9yX3JldmlzaW9u KHN2bl9yZXZpc2lvbikKKyAgICAgICAgICAgICAgICBpZiBub3QgY29tbWl0X2luZm86CisgICAg ICAgICAgICAgICAgICAgIHByaW50ICJGQUlMRUQgdG8gZmV0Y2ggQ29tbWl0SW5mbyBmb3IgciVz LCBsaWtlbHkgbWlzc2luZyBDaGFuZ2VMb2ciICUgcmV2aXNpb24KKyAgICAgICAgICAgICAgICAg ICAgY29udGludWUKICAgICAgICAgICAgICAgICBzZWxmLl9zaGVyaWZmLnBvc3RfaXJjX3dhcm5p bmcoY29tbWl0X2luZm8sIGJ1aWxkZXJzKQogICAgICAgICAgICAgICAgIHNlbGYuX3NoZXJpZmYu cG9zdF9ibGFtZV9jb21tZW50X29uX2J1Zyhjb21taXRfaW5mbywKICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYnVpbGRlcnMsCg==